Linux Audio

Check our new training course

Loading...
v4.6
 
  1/*
  2 * PWM driver for Rockchip SoCs
  3 *
  4 * Copyright (C) 2014 Beniamino Galvani <b.galvani@gmail.com>
  5 * Copyright (C) 2014 ROCKCHIP, Inc.
  6 *
  7 * This program is free software; you can redistribute it and/or
  8 * modify it under the terms of the GNU General Public License
  9 * version 2 as published by the Free Software Foundation.
 10 */
 11
 12#include <linux/clk.h>
 13#include <linux/io.h>
 14#include <linux/module.h>
 15#include <linux/of.h>
 16#include <linux/of_device.h>
 17#include <linux/platform_device.h>
 
 18#include <linux/pwm.h>
 19#include <linux/time.h>
 20
 21#define PWM_CTRL_TIMER_EN	(1 << 0)
 22#define PWM_CTRL_OUTPUT_EN	(1 << 3)
 23
 24#define PWM_ENABLE		(1 << 0)
 25#define PWM_CONTINUOUS		(1 << 1)
 26#define PWM_DUTY_POSITIVE	(1 << 3)
 27#define PWM_DUTY_NEGATIVE	(0 << 3)
 28#define PWM_INACTIVE_NEGATIVE	(0 << 4)
 29#define PWM_INACTIVE_POSITIVE	(1 << 4)
 
 30#define PWM_OUTPUT_LEFT		(0 << 5)
 
 31#define PWM_LP_DISABLE		(0 << 8)
 32
 33struct rockchip_pwm_chip {
 34	struct pwm_chip chip;
 35	struct clk *clk;
 
 36	const struct rockchip_pwm_data *data;
 37	void __iomem *base;
 38};
 39
 40struct rockchip_pwm_regs {
 41	unsigned long duty;
 42	unsigned long period;
 43	unsigned long cntr;
 44	unsigned long ctrl;
 45};
 46
 47struct rockchip_pwm_data {
 48	struct rockchip_pwm_regs regs;
 49	unsigned int prescaler;
 50	const struct pwm_ops *ops;
 51
 52	void (*set_enable)(struct pwm_chip *chip,
 53			   struct pwm_device *pwm, bool enable);
 54};
 55
 56static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *c)
 57{
 58	return container_of(c, struct rockchip_pwm_chip, chip);
 59}
 60
 61static void rockchip_pwm_set_enable_v1(struct pwm_chip *chip,
 62				       struct pwm_device *pwm, bool enable)
 
 63{
 64	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
 65	u32 enable_conf = PWM_CTRL_OUTPUT_EN | PWM_CTRL_TIMER_EN;
 
 
 66	u32 val;
 
 67
 68	val = readl_relaxed(pc->base + pc->data->regs.ctrl);
 69
 70	if (enable)
 71		val |= enable_conf;
 72	else
 73		val &= ~enable_conf;
 74
 75	writel_relaxed(val, pc->base + pc->data->regs.ctrl);
 76}
 
 77
 78static void rockchip_pwm_set_enable_v2(struct pwm_chip *chip,
 79				       struct pwm_device *pwm, bool enable)
 80{
 81	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
 82	u32 enable_conf = PWM_OUTPUT_LEFT | PWM_LP_DISABLE | PWM_ENABLE |
 83			  PWM_CONTINUOUS;
 84	u32 val;
 85
 86	if (pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED)
 87		enable_conf |= PWM_DUTY_NEGATIVE | PWM_INACTIVE_POSITIVE;
 88	else
 89		enable_conf |= PWM_DUTY_POSITIVE | PWM_INACTIVE_NEGATIVE;
 
 
 
 90
 91	val = readl_relaxed(pc->base + pc->data->regs.ctrl);
 
 92
 93	if (enable)
 94		val |= enable_conf;
 95	else
 96		val &= ~enable_conf;
 97
 98	writel_relaxed(val, pc->base + pc->data->regs.ctrl);
 
 
 
 99}
100
101static int rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
102			       int duty_ns, int period_ns)
103{
104	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
105	unsigned long period, duty;
106	u64 clk_rate, div;
107	int ret;
108
109	clk_rate = clk_get_rate(pc->clk);
110
111	/*
112	 * Since period and duty cycle registers have a width of 32
113	 * bits, every possible input period can be obtained using the
114	 * default prescaler value for all practical clock rate values.
115	 */
116	div = clk_rate * period_ns;
117	do_div(div, pc->data->prescaler * NSEC_PER_SEC);
118	period = div;
119
120	div = clk_rate * duty_ns;
121	do_div(div, pc->data->prescaler * NSEC_PER_SEC);
122	duty = div;
123
124	ret = clk_enable(pc->clk);
125	if (ret)
126		return ret;
 
 
 
 
 
 
 
 
 
127
128	writel(period, pc->base + pc->data->regs.period);
129	writel(duty, pc->base + pc->data->regs.duty);
130	writel(0, pc->base + pc->data->regs.cntr);
131
132	clk_disable(pc->clk);
133
134	return 0;
135}
 
 
 
 
 
136
137static int rockchip_pwm_set_polarity(struct pwm_chip *chip,
138				     struct pwm_device *pwm,
139				     enum pwm_polarity polarity)
140{
141	/*
142	 * No action needed here because pwm->polarity will be set by the core
143	 * and the core will only change polarity when the PWM is not enabled.
144	 * We'll handle things in set_enable().
145	 */
 
 
146
147	return 0;
148}
149
150static int rockchip_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
 
 
151{
152	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
 
153	int ret;
 
154
155	ret = clk_enable(pc->clk);
156	if (ret)
157		return ret;
 
 
 
 
158
159	pc->data->set_enable(chip, pwm, true);
 
 
 
 
 
 
 
 
160
161	return 0;
162}
163
164static void rockchip_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 
165{
166	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
 
 
 
167
168	pc->data->set_enable(chip, pwm, false);
 
 
 
 
 
 
169
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
170	clk_disable(pc->clk);
171}
172
173static const struct pwm_ops rockchip_pwm_ops_v1 = {
174	.config = rockchip_pwm_config,
175	.enable = rockchip_pwm_enable,
176	.disable = rockchip_pwm_disable,
177	.owner = THIS_MODULE,
178};
179
180static const struct pwm_ops rockchip_pwm_ops_v2 = {
181	.config = rockchip_pwm_config,
182	.set_polarity = rockchip_pwm_set_polarity,
183	.enable = rockchip_pwm_enable,
184	.disable = rockchip_pwm_disable,
185	.owner = THIS_MODULE,
186};
187
188static const struct rockchip_pwm_data pwm_data_v1 = {
189	.regs = {
190		.duty = 0x04,
191		.period = 0x08,
192		.cntr = 0x00,
193		.ctrl = 0x0c,
194	},
195	.prescaler = 2,
196	.ops = &rockchip_pwm_ops_v1,
197	.set_enable = rockchip_pwm_set_enable_v1,
 
198};
199
200static const struct rockchip_pwm_data pwm_data_v2 = {
201	.regs = {
202		.duty = 0x08,
203		.period = 0x04,
204		.cntr = 0x00,
205		.ctrl = 0x0c,
206	},
207	.prescaler = 1,
208	.ops = &rockchip_pwm_ops_v2,
209	.set_enable = rockchip_pwm_set_enable_v2,
 
 
210};
211
212static const struct rockchip_pwm_data pwm_data_vop = {
213	.regs = {
214		.duty = 0x08,
215		.period = 0x04,
216		.cntr = 0x0c,
217		.ctrl = 0x00,
218	},
219	.prescaler = 1,
220	.ops = &rockchip_pwm_ops_v2,
221	.set_enable = rockchip_pwm_set_enable_v2,
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
222};
223
224static const struct of_device_id rockchip_pwm_dt_ids[] = {
225	{ .compatible = "rockchip,rk2928-pwm", .data = &pwm_data_v1},
226	{ .compatible = "rockchip,rk3288-pwm", .data = &pwm_data_v2},
227	{ .compatible = "rockchip,vop-pwm", .data = &pwm_data_vop},
 
228	{ /* sentinel */ }
229};
230MODULE_DEVICE_TABLE(of, rockchip_pwm_dt_ids);
231
232static int rockchip_pwm_probe(struct platform_device *pdev)
233{
234	const struct of_device_id *id;
235	struct rockchip_pwm_chip *pc;
236	struct resource *r;
237	int ret;
 
 
 
 
 
 
238
239	id = of_match_device(rockchip_pwm_dt_ids, &pdev->dev);
240	if (!id)
241		return -EINVAL;
242
243	pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
244	if (!pc)
245		return -ENOMEM;
246
247	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
248	pc->base = devm_ioremap_resource(&pdev->dev, r);
249	if (IS_ERR(pc->base))
250		return PTR_ERR(pc->base);
251
252	pc->clk = devm_clk_get(&pdev->dev, NULL);
253	if (IS_ERR(pc->clk))
254		return PTR_ERR(pc->clk);
 
 
 
 
255
256	ret = clk_prepare(pc->clk);
257	if (ret)
258		return ret;
 
 
 
259
260	platform_set_drvdata(pdev, pc);
 
261
262	pc->data = id->data;
263	pc->chip.dev = &pdev->dev;
264	pc->chip.ops = pc->data->ops;
265	pc->chip.base = -1;
266	pc->chip.npwm = 1;
267
268	if (pc->data->ops->set_polarity) {
269		pc->chip.of_xlate = of_pwm_xlate_with_flags;
270		pc->chip.of_pwm_n_cells = 3;
271	}
272
273	ret = pwmchip_add(&pc->chip);
 
 
 
 
 
 
 
 
 
274	if (ret < 0) {
275		clk_unprepare(pc->clk);
276		dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
277	}
278
 
 
 
 
 
 
 
 
 
 
 
 
 
279	return ret;
280}
281
282static int rockchip_pwm_remove(struct platform_device *pdev)
283{
284	struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev);
 
285
286	clk_unprepare(pc->clk);
287
288	return pwmchip_remove(&pc->chip);
 
289}
290
291static struct platform_driver rockchip_pwm_driver = {
292	.driver = {
293		.name = "rockchip-pwm",
294		.of_match_table = rockchip_pwm_dt_ids,
295	},
296	.probe = rockchip_pwm_probe,
297	.remove = rockchip_pwm_remove,
298};
299module_platform_driver(rockchip_pwm_driver);
300
301MODULE_AUTHOR("Beniamino Galvani <b.galvani@gmail.com>");
302MODULE_DESCRIPTION("Rockchip SoC PWM driver");
303MODULE_LICENSE("GPL v2");
v6.13.7
  1// SPDX-License-Identifier: GPL-2.0-only
  2/*
  3 * PWM driver for Rockchip SoCs
  4 *
  5 * Copyright (C) 2014 Beniamino Galvani <b.galvani@gmail.com>
  6 * Copyright (C) 2014 ROCKCHIP, Inc.
 
 
 
 
  7 */
  8
  9#include <linux/clk.h>
 10#include <linux/io.h>
 11#include <linux/module.h>
 12#include <linux/of.h>
 
 13#include <linux/platform_device.h>
 14#include <linux/property.h>
 15#include <linux/pwm.h>
 16#include <linux/time.h>
 17
 18#define PWM_CTRL_TIMER_EN	(1 << 0)
 19#define PWM_CTRL_OUTPUT_EN	(1 << 3)
 20
 21#define PWM_ENABLE		(1 << 0)
 22#define PWM_CONTINUOUS		(1 << 1)
 23#define PWM_DUTY_POSITIVE	(1 << 3)
 24#define PWM_DUTY_NEGATIVE	(0 << 3)
 25#define PWM_INACTIVE_NEGATIVE	(0 << 4)
 26#define PWM_INACTIVE_POSITIVE	(1 << 4)
 27#define PWM_POLARITY_MASK	(PWM_DUTY_POSITIVE | PWM_INACTIVE_POSITIVE)
 28#define PWM_OUTPUT_LEFT		(0 << 5)
 29#define PWM_LOCK_EN		(1 << 6)
 30#define PWM_LP_DISABLE		(0 << 8)
 31
 32struct rockchip_pwm_chip {
 
 33	struct clk *clk;
 34	struct clk *pclk;
 35	const struct rockchip_pwm_data *data;
 36	void __iomem *base;
 37};
 38
 39struct rockchip_pwm_regs {
 40	unsigned long duty;
 41	unsigned long period;
 42	unsigned long cntr;
 43	unsigned long ctrl;
 44};
 45
 46struct rockchip_pwm_data {
 47	struct rockchip_pwm_regs regs;
 48	unsigned int prescaler;
 49	bool supports_polarity;
 50	bool supports_lock;
 51	u32 enable_conf;
 
 52};
 53
 54static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *chip)
 55{
 56	return pwmchip_get_drvdata(chip);
 57}
 58
 59static int rockchip_pwm_get_state(struct pwm_chip *chip,
 60				  struct pwm_device *pwm,
 61				  struct pwm_state *state)
 62{
 63	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
 64	u32 enable_conf = pc->data->enable_conf;
 65	unsigned long clk_rate;
 66	u64 tmp;
 67	u32 val;
 68	int ret;
 69
 70	ret = clk_enable(pc->pclk);
 71	if (ret)
 72		return ret;
 
 
 
 73
 74	ret = clk_enable(pc->clk);
 75	if (ret)
 76		return ret;
 77
 78	clk_rate = clk_get_rate(pc->clk);
 
 
 
 
 
 
 79
 80	tmp = readl_relaxed(pc->base + pc->data->regs.period);
 81	tmp *= pc->data->prescaler * NSEC_PER_SEC;
 82	state->period = DIV_ROUND_CLOSEST_ULL(tmp, clk_rate);
 83
 84	tmp = readl_relaxed(pc->base + pc->data->regs.duty);
 85	tmp *= pc->data->prescaler * NSEC_PER_SEC;
 86	state->duty_cycle =  DIV_ROUND_CLOSEST_ULL(tmp, clk_rate);
 87
 88	val = readl_relaxed(pc->base + pc->data->regs.ctrl);
 89	state->enabled = (val & enable_conf) == enable_conf;
 90
 91	if (pc->data->supports_polarity && !(val & PWM_DUTY_POSITIVE))
 92		state->polarity = PWM_POLARITY_INVERSED;
 93	else
 94		state->polarity = PWM_POLARITY_NORMAL;
 95
 96	clk_disable(pc->clk);
 97	clk_disable(pc->pclk);
 98
 99	return 0;
100}
101
102static void rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
103			       const struct pwm_state *state)
104{
105	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
106	unsigned long period, duty;
107	u64 clk_rate, div;
108	u32 ctrl;
109
110	clk_rate = clk_get_rate(pc->clk);
111
112	/*
113	 * Since period and duty cycle registers have a width of 32
114	 * bits, every possible input period can be obtained using the
115	 * default prescaler value for all practical clock rate values.
116	 */
117	div = clk_rate * state->period;
118	period = DIV_ROUND_CLOSEST_ULL(div,
119				       pc->data->prescaler * NSEC_PER_SEC);
 
 
 
 
120
121	div = clk_rate * state->duty_cycle;
122	duty = DIV_ROUND_CLOSEST_ULL(div, pc->data->prescaler * NSEC_PER_SEC);
123
124	/*
125	 * Lock the period and duty of previous configuration, then
126	 * change the duty and period, that would not be effective.
127	 */
128	ctrl = readl_relaxed(pc->base + pc->data->regs.ctrl);
129	if (pc->data->supports_lock) {
130		ctrl |= PWM_LOCK_EN;
131		writel_relaxed(ctrl, pc->base + pc->data->regs.ctrl);
132	}
133
134	writel(period, pc->base + pc->data->regs.period);
135	writel(duty, pc->base + pc->data->regs.duty);
 
 
 
136
137	if (pc->data->supports_polarity) {
138		ctrl &= ~PWM_POLARITY_MASK;
139		if (state->polarity == PWM_POLARITY_INVERSED)
140			ctrl |= PWM_DUTY_NEGATIVE | PWM_INACTIVE_POSITIVE;
141		else
142			ctrl |= PWM_DUTY_POSITIVE | PWM_INACTIVE_NEGATIVE;
143	}
144
 
 
 
 
145	/*
146	 * Unlock and set polarity at the same time,
147	 * the configuration of duty, period and polarity
148	 * would be effective together at next period.
149	 */
150	if (pc->data->supports_lock)
151		ctrl &= ~PWM_LOCK_EN;
152
153	writel(ctrl, pc->base + pc->data->regs.ctrl);
154}
155
156static int rockchip_pwm_enable(struct pwm_chip *chip,
157			       struct pwm_device *pwm,
158			       bool enable)
159{
160	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
161	u32 enable_conf = pc->data->enable_conf;
162	int ret;
163	u32 val;
164
165	if (enable) {
166		ret = clk_enable(pc->clk);
167		if (ret)
168			return ret;
169	}
170
171	val = readl_relaxed(pc->base + pc->data->regs.ctrl);
172
173	if (enable)
174		val |= enable_conf;
175	else
176		val &= ~enable_conf;
177
178	writel_relaxed(val, pc->base + pc->data->regs.ctrl);
179
180	if (!enable)
181		clk_disable(pc->clk);
182
183	return 0;
184}
185
186static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
187			      const struct pwm_state *state)
188{
189	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
190	struct pwm_state curstate;
191	bool enabled;
192	int ret = 0;
193
194	ret = clk_enable(pc->pclk);
195	if (ret)
196		return ret;
197
198	ret = clk_enable(pc->clk);
199	if (ret)
200		return ret;
201
202	pwm_get_state(pwm, &curstate);
203	enabled = curstate.enabled;
204
205	if (state->polarity != curstate.polarity && enabled &&
206	    !pc->data->supports_lock) {
207		ret = rockchip_pwm_enable(chip, pwm, false);
208		if (ret)
209			goto out;
210		enabled = false;
211	}
212
213	rockchip_pwm_config(chip, pwm, state);
214	if (state->enabled != enabled) {
215		ret = rockchip_pwm_enable(chip, pwm, state->enabled);
216		if (ret)
217			goto out;
218	}
219
220out:
221	clk_disable(pc->clk);
222	clk_disable(pc->pclk);
223
224	return ret;
225}
 
 
 
 
226
227static const struct pwm_ops rockchip_pwm_ops = {
228	.get_state = rockchip_pwm_get_state,
229	.apply = rockchip_pwm_apply,
 
 
 
230};
231
232static const struct rockchip_pwm_data pwm_data_v1 = {
233	.regs = {
234		.duty = 0x04,
235		.period = 0x08,
236		.cntr = 0x00,
237		.ctrl = 0x0c,
238	},
239	.prescaler = 2,
240	.supports_polarity = false,
241	.supports_lock = false,
242	.enable_conf = PWM_CTRL_OUTPUT_EN | PWM_CTRL_TIMER_EN,
243};
244
245static const struct rockchip_pwm_data pwm_data_v2 = {
246	.regs = {
247		.duty = 0x08,
248		.period = 0x04,
249		.cntr = 0x00,
250		.ctrl = 0x0c,
251	},
252	.prescaler = 1,
253	.supports_polarity = true,
254	.supports_lock = false,
255	.enable_conf = PWM_OUTPUT_LEFT | PWM_LP_DISABLE | PWM_ENABLE |
256		       PWM_CONTINUOUS,
257};
258
259static const struct rockchip_pwm_data pwm_data_vop = {
260	.regs = {
261		.duty = 0x08,
262		.period = 0x04,
263		.cntr = 0x0c,
264		.ctrl = 0x00,
265	},
266	.prescaler = 1,
267	.supports_polarity = true,
268	.supports_lock = false,
269	.enable_conf = PWM_OUTPUT_LEFT | PWM_LP_DISABLE | PWM_ENABLE |
270		       PWM_CONTINUOUS,
271};
272
273static const struct rockchip_pwm_data pwm_data_v3 = {
274	.regs = {
275		.duty = 0x08,
276		.period = 0x04,
277		.cntr = 0x00,
278		.ctrl = 0x0c,
279	},
280	.prescaler = 1,
281	.supports_polarity = true,
282	.supports_lock = true,
283	.enable_conf = PWM_OUTPUT_LEFT | PWM_LP_DISABLE | PWM_ENABLE |
284		       PWM_CONTINUOUS,
285};
286
287static const struct of_device_id rockchip_pwm_dt_ids[] = {
288	{ .compatible = "rockchip,rk2928-pwm", .data = &pwm_data_v1},
289	{ .compatible = "rockchip,rk3288-pwm", .data = &pwm_data_v2},
290	{ .compatible = "rockchip,vop-pwm", .data = &pwm_data_vop},
291	{ .compatible = "rockchip,rk3328-pwm", .data = &pwm_data_v3},
292	{ /* sentinel */ }
293};
294MODULE_DEVICE_TABLE(of, rockchip_pwm_dt_ids);
295
296static int rockchip_pwm_probe(struct platform_device *pdev)
297{
298	struct pwm_chip *chip;
299	struct rockchip_pwm_chip *pc;
300	u32 enable_conf, ctrl;
301	bool enabled;
302	int ret, count;
303
304	chip = devm_pwmchip_alloc(&pdev->dev, 1, sizeof(*pc));
305	if (IS_ERR(chip))
306		return PTR_ERR(chip);
307	pc = to_rockchip_pwm_chip(chip);
308
309	pc->base = devm_platform_ioremap_resource(pdev, 0);
 
 
 
 
 
 
 
 
 
310	if (IS_ERR(pc->base))
311		return PTR_ERR(pc->base);
312
313	pc->clk = devm_clk_get(&pdev->dev, "pwm");
314	if (IS_ERR(pc->clk)) {
315		pc->clk = devm_clk_get(&pdev->dev, NULL);
316		if (IS_ERR(pc->clk))
317			return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
318					     "Can't get PWM clk\n");
319	}
320
321	count = of_count_phandle_with_args(pdev->dev.of_node,
322					   "clocks", "#clock-cells");
323	if (count == 2)
324		pc->pclk = devm_clk_get(&pdev->dev, "pclk");
325	else
326		pc->pclk = pc->clk;
327
328	if (IS_ERR(pc->pclk))
329		return dev_err_probe(&pdev->dev, PTR_ERR(pc->pclk), "Can't get APB clk\n");
330
331	ret = clk_prepare_enable(pc->clk);
332	if (ret)
333		return dev_err_probe(&pdev->dev, ret, "Can't prepare enable PWM clk\n");
334
335	ret = clk_prepare_enable(pc->pclk);
336	if (ret) {
337		dev_err_probe(&pdev->dev, ret, "Can't prepare enable APB clk\n");
338		goto err_clk;
 
339	}
340
341	platform_set_drvdata(pdev, chip);
342
343	pc->data = device_get_match_data(&pdev->dev);
344	chip->ops = &rockchip_pwm_ops;
345
346	enable_conf = pc->data->enable_conf;
347	ctrl = readl_relaxed(pc->base + pc->data->regs.ctrl);
348	enabled = (ctrl & enable_conf) == enable_conf;
349
350	ret = pwmchip_add(chip);
351	if (ret < 0) {
352		dev_err_probe(&pdev->dev, ret, "pwmchip_add() failed\n");
353		goto err_pclk;
354	}
355
356	/* Keep the PWM clk enabled if the PWM appears to be up and running. */
357	if (!enabled)
358		clk_disable(pc->clk);
359
360	clk_disable(pc->pclk);
361
362	return 0;
363
364err_pclk:
365	clk_disable_unprepare(pc->pclk);
366err_clk:
367	clk_disable_unprepare(pc->clk);
368
369	return ret;
370}
371
372static void rockchip_pwm_remove(struct platform_device *pdev)
373{
374	struct pwm_chip *chip = platform_get_drvdata(pdev);
375	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
376
377	pwmchip_remove(chip);
378
379	clk_unprepare(pc->pclk);
380	clk_unprepare(pc->clk);
381}
382
383static struct platform_driver rockchip_pwm_driver = {
384	.driver = {
385		.name = "rockchip-pwm",
386		.of_match_table = rockchip_pwm_dt_ids,
387	},
388	.probe = rockchip_pwm_probe,
389	.remove = rockchip_pwm_remove,
390};
391module_platform_driver(rockchip_pwm_driver);
392
393MODULE_AUTHOR("Beniamino Galvani <b.galvani@gmail.com>");
394MODULE_DESCRIPTION("Rockchip SoC PWM driver");
395MODULE_LICENSE("GPL v2");