Loading...
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2013 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 */
6
7#include <linux/file.h>
8#include <linux/sync_file.h>
9#include <linux/uaccess.h>
10
11#include <drm/drm_drv.h>
12#include <drm/drm_file.h>
13#include <drm/drm_syncobj.h>
14
15#include "msm_drv.h"
16#include "msm_gpu.h"
17#include "msm_gem.h"
18#include "msm_gpu_trace.h"
19
20/* For userspace errors, use DRM_UT_DRIVER.. so that userspace can enable
21 * error msgs for debugging, but we don't spam dmesg by default
22 */
23#define SUBMIT_ERROR(submit, fmt, ...) \
24 DRM_DEV_DEBUG_DRIVER((submit)->dev->dev, fmt, ##__VA_ARGS__)
25
26/*
27 * Cmdstream submission:
28 */
29
30static struct msm_gem_submit *submit_create(struct drm_device *dev,
31 struct msm_gpu *gpu,
32 struct msm_gpu_submitqueue *queue, uint32_t nr_bos,
33 uint32_t nr_cmds)
34{
35 static atomic_t ident = ATOMIC_INIT(0);
36 struct msm_gem_submit *submit;
37 uint64_t sz;
38 int ret;
39
40 sz = struct_size(submit, bos, nr_bos) +
41 ((u64)nr_cmds * sizeof(submit->cmd[0]));
42
43 if (sz > SIZE_MAX)
44 return ERR_PTR(-ENOMEM);
45
46 submit = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN);
47 if (!submit)
48 return ERR_PTR(-ENOMEM);
49
50 submit->hw_fence = msm_fence_alloc();
51 if (IS_ERR(submit->hw_fence)) {
52 ret = PTR_ERR(submit->hw_fence);
53 kfree(submit);
54 return ERR_PTR(ret);
55 }
56
57 ret = drm_sched_job_init(&submit->base, queue->entity, 1, queue);
58 if (ret) {
59 kfree(submit->hw_fence);
60 kfree(submit);
61 return ERR_PTR(ret);
62 }
63
64 kref_init(&submit->ref);
65 submit->dev = dev;
66 submit->aspace = queue->ctx->aspace;
67 submit->gpu = gpu;
68 submit->cmd = (void *)&submit->bos[nr_bos];
69 submit->queue = queue;
70 submit->pid = get_pid(task_pid(current));
71 submit->ring = gpu->rb[queue->ring_nr];
72 submit->fault_dumped = false;
73
74 /* Get a unique identifier for the submission for logging purposes */
75 submit->ident = atomic_inc_return(&ident) - 1;
76
77 INIT_LIST_HEAD(&submit->node);
78
79 return submit;
80}
81
82void __msm_gem_submit_destroy(struct kref *kref)
83{
84 struct msm_gem_submit *submit =
85 container_of(kref, struct msm_gem_submit, ref);
86 unsigned i;
87
88 if (submit->fence_id) {
89 spin_lock(&submit->queue->idr_lock);
90 idr_remove(&submit->queue->fence_idr, submit->fence_id);
91 spin_unlock(&submit->queue->idr_lock);
92 }
93
94 dma_fence_put(submit->user_fence);
95
96 /*
97 * If the submit is freed before msm_job_run(), then hw_fence is
98 * just some pre-allocated memory, not a reference counted fence.
99 * Once the job runs and the hw_fence is initialized, it will
100 * have a refcount of at least one, since the submit holds a ref
101 * to the hw_fence.
102 */
103 if (kref_read(&submit->hw_fence->refcount) == 0) {
104 kfree(submit->hw_fence);
105 } else {
106 dma_fence_put(submit->hw_fence);
107 }
108
109 put_pid(submit->pid);
110 msm_submitqueue_put(submit->queue);
111
112 for (i = 0; i < submit->nr_cmds; i++)
113 kfree(submit->cmd[i].relocs);
114
115 kfree(submit);
116}
117
118static int submit_lookup_objects(struct msm_gem_submit *submit,
119 struct drm_msm_gem_submit *args, struct drm_file *file)
120{
121 unsigned i;
122 int ret = 0;
123
124 for (i = 0; i < args->nr_bos; i++) {
125 struct drm_msm_gem_submit_bo submit_bo;
126 void __user *userptr =
127 u64_to_user_ptr(args->bos + (i * sizeof(submit_bo)));
128
129 /* make sure we don't have garbage flags, in case we hit
130 * error path before flags is initialized:
131 */
132 submit->bos[i].flags = 0;
133
134 if (copy_from_user(&submit_bo, userptr, sizeof(submit_bo))) {
135 ret = -EFAULT;
136 i = 0;
137 goto out;
138 }
139
140/* at least one of READ and/or WRITE flags should be set: */
141#define MANDATORY_FLAGS (MSM_SUBMIT_BO_READ | MSM_SUBMIT_BO_WRITE)
142
143 if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
144 !(submit_bo.flags & MANDATORY_FLAGS)) {
145 SUBMIT_ERROR(submit, "invalid flags: %x\n", submit_bo.flags);
146 ret = -EINVAL;
147 i = 0;
148 goto out;
149 }
150
151 submit->bos[i].handle = submit_bo.handle;
152 submit->bos[i].flags = submit_bo.flags;
153 }
154
155 spin_lock(&file->table_lock);
156
157 for (i = 0; i < args->nr_bos; i++) {
158 struct drm_gem_object *obj;
159
160 /* normally use drm_gem_object_lookup(), but for bulk lookup
161 * all under single table_lock just hit object_idr directly:
162 */
163 obj = idr_find(&file->object_idr, submit->bos[i].handle);
164 if (!obj) {
165 SUBMIT_ERROR(submit, "invalid handle %u at index %u\n", submit->bos[i].handle, i);
166 ret = -EINVAL;
167 goto out_unlock;
168 }
169
170 drm_gem_object_get(obj);
171
172 submit->bos[i].obj = obj;
173 }
174
175out_unlock:
176 spin_unlock(&file->table_lock);
177
178out:
179 submit->nr_bos = i;
180
181 return ret;
182}
183
184static int submit_lookup_cmds(struct msm_gem_submit *submit,
185 struct drm_msm_gem_submit *args, struct drm_file *file)
186{
187 unsigned i;
188 size_t sz;
189 int ret = 0;
190
191 for (i = 0; i < args->nr_cmds; i++) {
192 struct drm_msm_gem_submit_cmd submit_cmd;
193 void __user *userptr =
194 u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd)));
195
196 ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd));
197 if (ret) {
198 ret = -EFAULT;
199 goto out;
200 }
201
202 /* validate input from userspace: */
203 switch (submit_cmd.type) {
204 case MSM_SUBMIT_CMD_BUF:
205 case MSM_SUBMIT_CMD_IB_TARGET_BUF:
206 case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
207 break;
208 default:
209 SUBMIT_ERROR(submit, "invalid type: %08x\n", submit_cmd.type);
210 return -EINVAL;
211 }
212
213 if (submit_cmd.size % 4) {
214 SUBMIT_ERROR(submit, "non-aligned cmdstream buffer size: %u\n",
215 submit_cmd.size);
216 ret = -EINVAL;
217 goto out;
218 }
219
220 submit->cmd[i].type = submit_cmd.type;
221 submit->cmd[i].size = submit_cmd.size / 4;
222 submit->cmd[i].offset = submit_cmd.submit_offset / 4;
223 submit->cmd[i].idx = submit_cmd.submit_idx;
224 submit->cmd[i].nr_relocs = submit_cmd.nr_relocs;
225
226 userptr = u64_to_user_ptr(submit_cmd.relocs);
227
228 sz = array_size(submit_cmd.nr_relocs,
229 sizeof(struct drm_msm_gem_submit_reloc));
230 /* check for overflow: */
231 if (sz == SIZE_MAX) {
232 ret = -ENOMEM;
233 goto out;
234 }
235 submit->cmd[i].relocs = kmalloc(sz, GFP_KERNEL | __GFP_NOWARN);
236 if (!submit->cmd[i].relocs) {
237 ret = -ENOMEM;
238 goto out;
239 }
240 ret = copy_from_user(submit->cmd[i].relocs, userptr, sz);
241 if (ret) {
242 ret = -EFAULT;
243 goto out;
244 }
245 }
246
247out:
248 return ret;
249}
250
251/* This is where we make sure all the bo's are reserved and pin'd: */
252static int submit_lock_objects(struct msm_gem_submit *submit)
253{
254 int ret;
255
256 drm_exec_init(&submit->exec, DRM_EXEC_INTERRUPTIBLE_WAIT, submit->nr_bos);
257
258 drm_exec_until_all_locked (&submit->exec) {
259 for (unsigned i = 0; i < submit->nr_bos; i++) {
260 struct drm_gem_object *obj = submit->bos[i].obj;
261 ret = drm_exec_prepare_obj(&submit->exec, obj, 1);
262 drm_exec_retry_on_contention(&submit->exec);
263 if (ret)
264 goto error;
265 }
266 }
267
268 return 0;
269
270error:
271 return ret;
272}
273
274static int submit_fence_sync(struct msm_gem_submit *submit)
275{
276 int i, ret = 0;
277
278 for (i = 0; i < submit->nr_bos; i++) {
279 struct drm_gem_object *obj = submit->bos[i].obj;
280 bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE;
281
282 /* Otherwise userspace can ask for implicit sync to be
283 * disabled on specific buffers. This is useful for internal
284 * usermode driver managed buffers, suballocation, etc.
285 */
286 if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT)
287 continue;
288
289 ret = drm_sched_job_add_implicit_dependencies(&submit->base,
290 obj,
291 write);
292 if (ret)
293 break;
294 }
295
296 return ret;
297}
298
299static int submit_pin_objects(struct msm_gem_submit *submit)
300{
301 struct msm_drm_private *priv = submit->dev->dev_private;
302 int i, ret = 0;
303
304 for (i = 0; i < submit->nr_bos; i++) {
305 struct drm_gem_object *obj = submit->bos[i].obj;
306 struct msm_gem_vma *vma;
307
308 /* if locking succeeded, pin bo: */
309 vma = msm_gem_get_vma_locked(obj, submit->aspace);
310 if (IS_ERR(vma)) {
311 ret = PTR_ERR(vma);
312 break;
313 }
314
315 ret = msm_gem_pin_vma_locked(obj, vma);
316 if (ret)
317 break;
318
319 submit->bos[i].iova = vma->iova;
320 }
321
322 /*
323 * A second loop while holding the LRU lock (a) avoids acquiring/dropping
324 * the LRU lock for each individual bo, while (b) avoiding holding the
325 * LRU lock while calling msm_gem_pin_vma_locked() (which could trigger
326 * get_pages() which could trigger reclaim.. and if we held the LRU lock
327 * could trigger deadlock with the shrinker).
328 */
329 mutex_lock(&priv->lru.lock);
330 for (i = 0; i < submit->nr_bos; i++) {
331 msm_gem_pin_obj_locked(submit->bos[i].obj);
332 }
333 mutex_unlock(&priv->lru.lock);
334
335 submit->bos_pinned = true;
336
337 return ret;
338}
339
340static void submit_unpin_objects(struct msm_gem_submit *submit)
341{
342 if (!submit->bos_pinned)
343 return;
344
345 for (int i = 0; i < submit->nr_bos; i++) {
346 struct drm_gem_object *obj = submit->bos[i].obj;
347
348 msm_gem_unpin_locked(obj);
349 }
350
351 submit->bos_pinned = false;
352}
353
354static void submit_attach_object_fences(struct msm_gem_submit *submit)
355{
356 int i;
357
358 for (i = 0; i < submit->nr_bos; i++) {
359 struct drm_gem_object *obj = submit->bos[i].obj;
360
361 if (submit->bos[i].flags & MSM_SUBMIT_BO_WRITE)
362 dma_resv_add_fence(obj->resv, submit->user_fence,
363 DMA_RESV_USAGE_WRITE);
364 else if (submit->bos[i].flags & MSM_SUBMIT_BO_READ)
365 dma_resv_add_fence(obj->resv, submit->user_fence,
366 DMA_RESV_USAGE_READ);
367 }
368}
369
370static int submit_bo(struct msm_gem_submit *submit, uint32_t idx,
371 struct drm_gem_object **obj, uint64_t *iova)
372{
373 if (idx >= submit->nr_bos) {
374 SUBMIT_ERROR(submit, "invalid buffer index: %u (out of %u)\n",
375 idx, submit->nr_bos);
376 return -EINVAL;
377 }
378
379 if (obj)
380 *obj = submit->bos[idx].obj;
381 if (iova)
382 *iova = submit->bos[idx].iova;
383
384 return 0;
385}
386
387/* process the reloc's and patch up the cmdstream as needed: */
388static int submit_reloc(struct msm_gem_submit *submit, struct drm_gem_object *obj,
389 uint32_t offset, uint32_t nr_relocs, struct drm_msm_gem_submit_reloc *relocs)
390{
391 uint32_t i, last_offset = 0;
392 uint32_t *ptr;
393 int ret = 0;
394
395 if (offset % 4) {
396 SUBMIT_ERROR(submit, "non-aligned cmdstream buffer: %u\n", offset);
397 return -EINVAL;
398 }
399
400 /* For now, just map the entire thing. Eventually we probably
401 * to do it page-by-page, w/ kmap() if not vmap()d..
402 */
403 ptr = msm_gem_get_vaddr_locked(obj);
404
405 if (IS_ERR(ptr)) {
406 ret = PTR_ERR(ptr);
407 DBG("failed to map: %d", ret);
408 return ret;
409 }
410
411 for (i = 0; i < nr_relocs; i++) {
412 struct drm_msm_gem_submit_reloc submit_reloc = relocs[i];
413 uint32_t off;
414 uint64_t iova;
415
416 if (submit_reloc.submit_offset % 4) {
417 SUBMIT_ERROR(submit, "non-aligned reloc offset: %u\n",
418 submit_reloc.submit_offset);
419 ret = -EINVAL;
420 goto out;
421 }
422
423 /* offset in dwords: */
424 off = submit_reloc.submit_offset / 4;
425
426 if ((off >= (obj->size / 4)) ||
427 (off < last_offset)) {
428 SUBMIT_ERROR(submit, "invalid offset %u at reloc %u\n", off, i);
429 ret = -EINVAL;
430 goto out;
431 }
432
433 ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova);
434 if (ret)
435 goto out;
436
437 iova += submit_reloc.reloc_offset;
438
439 if (submit_reloc.shift < 0)
440 iova >>= -submit_reloc.shift;
441 else
442 iova <<= submit_reloc.shift;
443
444 ptr[off] = iova | submit_reloc.or;
445
446 last_offset = off;
447 }
448
449out:
450 msm_gem_put_vaddr_locked(obj);
451
452 return ret;
453}
454
455/* Cleanup submit at end of ioctl. In the error case, this also drops
456 * references, unpins, and drops active refcnt. In the non-error case,
457 * this is done when the submit is retired.
458 */
459static void submit_cleanup(struct msm_gem_submit *submit, bool error)
460{
461 if (error) {
462 submit_unpin_objects(submit);
463 /* job wasn't enqueued to scheduler, so early retirement: */
464 msm_submit_retire(submit);
465 }
466
467 if (submit->exec.objects)
468 drm_exec_fini(&submit->exec);
469}
470
471void msm_submit_retire(struct msm_gem_submit *submit)
472{
473 int i;
474
475 for (i = 0; i < submit->nr_bos; i++) {
476 struct drm_gem_object *obj = submit->bos[i].obj;
477
478 drm_gem_object_put(obj);
479 }
480}
481
482struct msm_submit_post_dep {
483 struct drm_syncobj *syncobj;
484 uint64_t point;
485 struct dma_fence_chain *chain;
486};
487
488static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit,
489 struct drm_file *file,
490 uint64_t in_syncobjs_addr,
491 uint32_t nr_in_syncobjs,
492 size_t syncobj_stride)
493{
494 struct drm_syncobj **syncobjs = NULL;
495 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
496 int ret = 0;
497 uint32_t i, j;
498
499 syncobjs = kcalloc(nr_in_syncobjs, sizeof(*syncobjs),
500 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
501 if (!syncobjs)
502 return ERR_PTR(-ENOMEM);
503
504 for (i = 0; i < nr_in_syncobjs; ++i) {
505 uint64_t address = in_syncobjs_addr + i * syncobj_stride;
506
507 if (copy_from_user(&syncobj_desc,
508 u64_to_user_ptr(address),
509 min(syncobj_stride, sizeof(syncobj_desc)))) {
510 ret = -EFAULT;
511 break;
512 }
513
514 if (syncobj_desc.point &&
515 !drm_core_check_feature(submit->dev, DRIVER_SYNCOBJ_TIMELINE)) {
516 ret = -EOPNOTSUPP;
517 break;
518 }
519
520 if (syncobj_desc.flags & ~MSM_SUBMIT_SYNCOBJ_FLAGS) {
521 ret = -EINVAL;
522 break;
523 }
524
525 ret = drm_sched_job_add_syncobj_dependency(&submit->base, file,
526 syncobj_desc.handle, syncobj_desc.point);
527 if (ret)
528 break;
529
530 if (syncobj_desc.flags & MSM_SUBMIT_SYNCOBJ_RESET) {
531 syncobjs[i] =
532 drm_syncobj_find(file, syncobj_desc.handle);
533 if (!syncobjs[i]) {
534 ret = -EINVAL;
535 break;
536 }
537 }
538 }
539
540 if (ret) {
541 for (j = 0; j <= i; ++j) {
542 if (syncobjs[j])
543 drm_syncobj_put(syncobjs[j]);
544 }
545 kfree(syncobjs);
546 return ERR_PTR(ret);
547 }
548 return syncobjs;
549}
550
551static void msm_reset_syncobjs(struct drm_syncobj **syncobjs,
552 uint32_t nr_syncobjs)
553{
554 uint32_t i;
555
556 for (i = 0; syncobjs && i < nr_syncobjs; ++i) {
557 if (syncobjs[i])
558 drm_syncobj_replace_fence(syncobjs[i], NULL);
559 }
560}
561
562static struct msm_submit_post_dep *msm_parse_post_deps(struct drm_device *dev,
563 struct drm_file *file,
564 uint64_t syncobjs_addr,
565 uint32_t nr_syncobjs,
566 size_t syncobj_stride)
567{
568 struct msm_submit_post_dep *post_deps;
569 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
570 int ret = 0;
571 uint32_t i, j;
572
573 post_deps = kcalloc(nr_syncobjs, sizeof(*post_deps),
574 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
575 if (!post_deps)
576 return ERR_PTR(-ENOMEM);
577
578 for (i = 0; i < nr_syncobjs; ++i) {
579 uint64_t address = syncobjs_addr + i * syncobj_stride;
580
581 if (copy_from_user(&syncobj_desc,
582 u64_to_user_ptr(address),
583 min(syncobj_stride, sizeof(syncobj_desc)))) {
584 ret = -EFAULT;
585 break;
586 }
587
588 post_deps[i].point = syncobj_desc.point;
589
590 if (syncobj_desc.flags) {
591 ret = -EINVAL;
592 break;
593 }
594
595 if (syncobj_desc.point) {
596 if (!drm_core_check_feature(dev,
597 DRIVER_SYNCOBJ_TIMELINE)) {
598 ret = -EOPNOTSUPP;
599 break;
600 }
601
602 post_deps[i].chain = dma_fence_chain_alloc();
603 if (!post_deps[i].chain) {
604 ret = -ENOMEM;
605 break;
606 }
607 }
608
609 post_deps[i].syncobj =
610 drm_syncobj_find(file, syncobj_desc.handle);
611 if (!post_deps[i].syncobj) {
612 ret = -EINVAL;
613 break;
614 }
615 }
616
617 if (ret) {
618 for (j = 0; j <= i; ++j) {
619 dma_fence_chain_free(post_deps[j].chain);
620 if (post_deps[j].syncobj)
621 drm_syncobj_put(post_deps[j].syncobj);
622 }
623
624 kfree(post_deps);
625 return ERR_PTR(ret);
626 }
627
628 return post_deps;
629}
630
631static void msm_process_post_deps(struct msm_submit_post_dep *post_deps,
632 uint32_t count, struct dma_fence *fence)
633{
634 uint32_t i;
635
636 for (i = 0; post_deps && i < count; ++i) {
637 if (post_deps[i].chain) {
638 drm_syncobj_add_point(post_deps[i].syncobj,
639 post_deps[i].chain,
640 fence, post_deps[i].point);
641 post_deps[i].chain = NULL;
642 } else {
643 drm_syncobj_replace_fence(post_deps[i].syncobj,
644 fence);
645 }
646 }
647}
648
649int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
650 struct drm_file *file)
651{
652 struct msm_drm_private *priv = dev->dev_private;
653 struct drm_msm_gem_submit *args = data;
654 struct msm_file_private *ctx = file->driver_priv;
655 struct msm_gem_submit *submit = NULL;
656 struct msm_gpu *gpu = priv->gpu;
657 struct msm_gpu_submitqueue *queue;
658 struct msm_ringbuffer *ring;
659 struct msm_submit_post_dep *post_deps = NULL;
660 struct drm_syncobj **syncobjs_to_reset = NULL;
661 int out_fence_fd = -1;
662 unsigned i;
663 int ret;
664
665 if (!gpu)
666 return -ENXIO;
667
668 if (args->pad)
669 return -EINVAL;
670
671 if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) {
672 DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n");
673 return -EPERM;
674 }
675
676 /* for now, we just have 3d pipe.. eventually this would need to
677 * be more clever to dispatch to appropriate gpu module:
678 */
679 if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
680 return -EINVAL;
681
682 if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
683 return -EINVAL;
684
685 if (args->flags & MSM_SUBMIT_SUDO) {
686 if (!IS_ENABLED(CONFIG_DRM_MSM_GPU_SUDO) ||
687 !capable(CAP_SYS_RAWIO))
688 return -EINVAL;
689 }
690
691 queue = msm_submitqueue_get(ctx, args->queueid);
692 if (!queue)
693 return -ENOENT;
694
695 ring = gpu->rb[queue->ring_nr];
696
697 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
698 out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
699 if (out_fence_fd < 0) {
700 ret = out_fence_fd;
701 goto out_post_unlock;
702 }
703 }
704
705 submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds);
706 if (IS_ERR(submit)) {
707 ret = PTR_ERR(submit);
708 goto out_post_unlock;
709 }
710
711 trace_msm_gpu_submit(pid_nr(submit->pid), ring->id, submit->ident,
712 args->nr_bos, args->nr_cmds);
713
714 ret = mutex_lock_interruptible(&queue->lock);
715 if (ret)
716 goto out_post_unlock;
717
718 if (args->flags & MSM_SUBMIT_SUDO)
719 submit->in_rb = true;
720
721 if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
722 struct dma_fence *in_fence;
723
724 in_fence = sync_file_get_fence(args->fence_fd);
725
726 if (!in_fence) {
727 ret = -EINVAL;
728 goto out_unlock;
729 }
730
731 ret = drm_sched_job_add_dependency(&submit->base, in_fence);
732 if (ret)
733 goto out_unlock;
734 }
735
736 if (args->flags & MSM_SUBMIT_SYNCOBJ_IN) {
737 syncobjs_to_reset = msm_parse_deps(submit, file,
738 args->in_syncobjs,
739 args->nr_in_syncobjs,
740 args->syncobj_stride);
741 if (IS_ERR(syncobjs_to_reset)) {
742 ret = PTR_ERR(syncobjs_to_reset);
743 goto out_unlock;
744 }
745 }
746
747 if (args->flags & MSM_SUBMIT_SYNCOBJ_OUT) {
748 post_deps = msm_parse_post_deps(dev, file,
749 args->out_syncobjs,
750 args->nr_out_syncobjs,
751 args->syncobj_stride);
752 if (IS_ERR(post_deps)) {
753 ret = PTR_ERR(post_deps);
754 goto out_unlock;
755 }
756 }
757
758 ret = submit_lookup_objects(submit, args, file);
759 if (ret)
760 goto out;
761
762 ret = submit_lookup_cmds(submit, args, file);
763 if (ret)
764 goto out;
765
766 /* copy_*_user while holding a ww ticket upsets lockdep */
767 ret = submit_lock_objects(submit);
768 if (ret)
769 goto out;
770
771 if (!(args->flags & MSM_SUBMIT_NO_IMPLICIT)) {
772 ret = submit_fence_sync(submit);
773 if (ret)
774 goto out;
775 }
776
777 ret = submit_pin_objects(submit);
778 if (ret)
779 goto out;
780
781 for (i = 0; i < args->nr_cmds; i++) {
782 struct drm_gem_object *obj;
783 uint64_t iova;
784
785 ret = submit_bo(submit, submit->cmd[i].idx, &obj, &iova);
786 if (ret)
787 goto out;
788
789 if (!submit->cmd[i].size ||
790 ((submit->cmd[i].size + submit->cmd[i].offset) >
791 obj->size / 4)) {
792 SUBMIT_ERROR(submit, "invalid cmdstream size: %u\n", submit->cmd[i].size * 4);
793 ret = -EINVAL;
794 goto out;
795 }
796
797 submit->cmd[i].iova = iova + (submit->cmd[i].offset * 4);
798
799 if (likely(!submit->cmd[i].nr_relocs))
800 continue;
801
802 if (!gpu->allow_relocs) {
803 SUBMIT_ERROR(submit, "relocs not allowed\n");
804 ret = -EINVAL;
805 goto out;
806 }
807
808 ret = submit_reloc(submit, obj, submit->cmd[i].offset * 4,
809 submit->cmd[i].nr_relocs, submit->cmd[i].relocs);
810 if (ret)
811 goto out;
812 }
813
814 submit->nr_cmds = i;
815
816 idr_preload(GFP_KERNEL);
817
818 spin_lock(&queue->idr_lock);
819
820 /*
821 * If using userspace provided seqno fence, validate that the id
822 * is available before arming sched job. Since access to fence_idr
823 * is serialized on the queue lock, the slot should be still avail
824 * after the job is armed
825 */
826 if ((args->flags & MSM_SUBMIT_FENCE_SN_IN) &&
827 (!args->fence || idr_find(&queue->fence_idr, args->fence))) {
828 spin_unlock(&queue->idr_lock);
829 idr_preload_end();
830 ret = -EINVAL;
831 goto out;
832 }
833
834 drm_sched_job_arm(&submit->base);
835
836 submit->user_fence = dma_fence_get(&submit->base.s_fence->finished);
837
838 if (args->flags & MSM_SUBMIT_FENCE_SN_IN) {
839 /*
840 * Userspace has assigned the seqno fence that it wants
841 * us to use. It is an error to pick a fence sequence
842 * number that is not available.
843 */
844 submit->fence_id = args->fence;
845 ret = idr_alloc_u32(&queue->fence_idr, submit->user_fence,
846 &submit->fence_id, submit->fence_id,
847 GFP_NOWAIT);
848 /*
849 * We've already validated that the fence_id slot is valid,
850 * so if idr_alloc_u32 failed, it is a kernel bug
851 */
852 WARN_ON(ret);
853 } else {
854 /*
855 * Allocate an id which can be used by WAIT_FENCE ioctl to map
856 * back to the underlying fence.
857 */
858 submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
859 submit->user_fence, 1,
860 INT_MAX, GFP_NOWAIT);
861 }
862
863 spin_unlock(&queue->idr_lock);
864 idr_preload_end();
865
866 if (submit->fence_id < 0) {
867 ret = submit->fence_id;
868 submit->fence_id = 0;
869 }
870
871 if (ret == 0 && args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
872 struct sync_file *sync_file = sync_file_create(submit->user_fence);
873 if (!sync_file) {
874 ret = -ENOMEM;
875 } else {
876 fd_install(out_fence_fd, sync_file->file);
877 args->fence_fd = out_fence_fd;
878 }
879 }
880
881 if (ret)
882 goto out;
883
884 submit_attach_object_fences(submit);
885
886 /* The scheduler owns a ref now: */
887 msm_gem_submit_get(submit);
888
889 msm_rd_dump_submit(priv->rd, submit, NULL);
890
891 drm_sched_entity_push_job(&submit->base);
892
893 args->fence = submit->fence_id;
894 queue->last_fence = submit->fence_id;
895
896 msm_reset_syncobjs(syncobjs_to_reset, args->nr_in_syncobjs);
897 msm_process_post_deps(post_deps, args->nr_out_syncobjs,
898 submit->user_fence);
899
900
901out:
902 submit_cleanup(submit, !!ret);
903out_unlock:
904 mutex_unlock(&queue->lock);
905out_post_unlock:
906 if (ret && (out_fence_fd >= 0))
907 put_unused_fd(out_fence_fd);
908
909 if (!IS_ERR_OR_NULL(submit)) {
910 msm_gem_submit_put(submit);
911 } else {
912 /*
913 * If the submit hasn't yet taken ownership of the queue
914 * then we need to drop the reference ourself:
915 */
916 msm_submitqueue_put(queue);
917 }
918 if (!IS_ERR_OR_NULL(post_deps)) {
919 for (i = 0; i < args->nr_out_syncobjs; ++i) {
920 kfree(post_deps[i].chain);
921 drm_syncobj_put(post_deps[i].syncobj);
922 }
923 kfree(post_deps);
924 }
925
926 if (!IS_ERR_OR_NULL(syncobjs_to_reset)) {
927 for (i = 0; i < args->nr_in_syncobjs; ++i) {
928 if (syncobjs_to_reset[i])
929 drm_syncobj_put(syncobjs_to_reset[i]);
930 }
931 kfree(syncobjs_to_reset);
932 }
933
934 return ret;
935}
1/*
2 * Copyright (C) 2013 Red Hat
3 * Author: Rob Clark <robdclark@gmail.com>
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 *
9 * This program is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
12 * more details.
13 *
14 * You should have received a copy of the GNU General Public License along with
15 * this program. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18#include <linux/sync_file.h>
19
20#include "msm_drv.h"
21#include "msm_gpu.h"
22#include "msm_gem.h"
23
24/*
25 * Cmdstream submission:
26 */
27
28/* make sure these don't conflict w/ MSM_SUBMIT_BO_x */
29#define BO_VALID 0x8000 /* is current addr in cmdstream correct/valid? */
30#define BO_LOCKED 0x4000
31#define BO_PINNED 0x2000
32
33static struct msm_gem_submit *submit_create(struct drm_device *dev,
34 struct msm_gpu *gpu, int nr_bos, int nr_cmds)
35{
36 struct msm_gem_submit *submit;
37 int sz = sizeof(*submit) + (nr_bos * sizeof(submit->bos[0])) +
38 (nr_cmds * sizeof(*submit->cmd));
39
40 submit = kmalloc(sz, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
41 if (!submit)
42 return NULL;
43
44 submit->dev = dev;
45 submit->gpu = gpu;
46 submit->fence = NULL;
47 submit->pid = get_pid(task_pid(current));
48 submit->cmd = (void *)&submit->bos[nr_bos];
49
50 /* initially, until copy_from_user() and bo lookup succeeds: */
51 submit->nr_bos = 0;
52 submit->nr_cmds = 0;
53
54 INIT_LIST_HEAD(&submit->node);
55 INIT_LIST_HEAD(&submit->bo_list);
56 ww_acquire_init(&submit->ticket, &reservation_ww_class);
57
58 return submit;
59}
60
61void msm_gem_submit_free(struct msm_gem_submit *submit)
62{
63 dma_fence_put(submit->fence);
64 list_del(&submit->node);
65 put_pid(submit->pid);
66 kfree(submit);
67}
68
69static inline unsigned long __must_check
70copy_from_user_inatomic(void *to, const void __user *from, unsigned long n)
71{
72 if (access_ok(VERIFY_READ, from, n))
73 return __copy_from_user_inatomic(to, from, n);
74 return -EFAULT;
75}
76
77static int submit_lookup_objects(struct msm_gem_submit *submit,
78 struct drm_msm_gem_submit *args, struct drm_file *file)
79{
80 unsigned i;
81 int ret = 0;
82
83 spin_lock(&file->table_lock);
84 pagefault_disable();
85
86 for (i = 0; i < args->nr_bos; i++) {
87 struct drm_msm_gem_submit_bo submit_bo;
88 struct drm_gem_object *obj;
89 struct msm_gem_object *msm_obj;
90 void __user *userptr =
91 u64_to_user_ptr(args->bos + (i * sizeof(submit_bo)));
92
93 /* make sure we don't have garbage flags, in case we hit
94 * error path before flags is initialized:
95 */
96 submit->bos[i].flags = 0;
97
98 ret = copy_from_user_inatomic(&submit_bo, userptr, sizeof(submit_bo));
99 if (unlikely(ret)) {
100 pagefault_enable();
101 spin_unlock(&file->table_lock);
102 ret = copy_from_user(&submit_bo, userptr, sizeof(submit_bo));
103 if (ret)
104 goto out;
105 spin_lock(&file->table_lock);
106 pagefault_disable();
107 }
108
109 if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
110 !(submit_bo.flags & MSM_SUBMIT_BO_FLAGS)) {
111 DRM_ERROR("invalid flags: %x\n", submit_bo.flags);
112 ret = -EINVAL;
113 goto out_unlock;
114 }
115
116 submit->bos[i].flags = submit_bo.flags;
117 /* in validate_objects() we figure out if this is true: */
118 submit->bos[i].iova = submit_bo.presumed;
119
120 /* normally use drm_gem_object_lookup(), but for bulk lookup
121 * all under single table_lock just hit object_idr directly:
122 */
123 obj = idr_find(&file->object_idr, submit_bo.handle);
124 if (!obj) {
125 DRM_ERROR("invalid handle %u at index %u\n", submit_bo.handle, i);
126 ret = -EINVAL;
127 goto out_unlock;
128 }
129
130 msm_obj = to_msm_bo(obj);
131
132 if (!list_empty(&msm_obj->submit_entry)) {
133 DRM_ERROR("handle %u at index %u already on submit list\n",
134 submit_bo.handle, i);
135 ret = -EINVAL;
136 goto out_unlock;
137 }
138
139 drm_gem_object_reference(obj);
140
141 submit->bos[i].obj = msm_obj;
142
143 list_add_tail(&msm_obj->submit_entry, &submit->bo_list);
144 }
145
146out_unlock:
147 pagefault_enable();
148 spin_unlock(&file->table_lock);
149
150out:
151 submit->nr_bos = i;
152
153 return ret;
154}
155
156static void submit_unlock_unpin_bo(struct msm_gem_submit *submit, int i)
157{
158 struct msm_gem_object *msm_obj = submit->bos[i].obj;
159
160 if (submit->bos[i].flags & BO_PINNED)
161 msm_gem_put_iova(&msm_obj->base, submit->gpu->id);
162
163 if (submit->bos[i].flags & BO_LOCKED)
164 ww_mutex_unlock(&msm_obj->resv->lock);
165
166 if (!(submit->bos[i].flags & BO_VALID))
167 submit->bos[i].iova = 0;
168
169 submit->bos[i].flags &= ~(BO_LOCKED | BO_PINNED);
170}
171
172/* This is where we make sure all the bo's are reserved and pin'd: */
173static int submit_lock_objects(struct msm_gem_submit *submit)
174{
175 int contended, slow_locked = -1, i, ret = 0;
176
177retry:
178 for (i = 0; i < submit->nr_bos; i++) {
179 struct msm_gem_object *msm_obj = submit->bos[i].obj;
180
181 if (slow_locked == i)
182 slow_locked = -1;
183
184 contended = i;
185
186 if (!(submit->bos[i].flags & BO_LOCKED)) {
187 ret = ww_mutex_lock_interruptible(&msm_obj->resv->lock,
188 &submit->ticket);
189 if (ret)
190 goto fail;
191 submit->bos[i].flags |= BO_LOCKED;
192 }
193 }
194
195 ww_acquire_done(&submit->ticket);
196
197 return 0;
198
199fail:
200 for (; i >= 0; i--)
201 submit_unlock_unpin_bo(submit, i);
202
203 if (slow_locked > 0)
204 submit_unlock_unpin_bo(submit, slow_locked);
205
206 if (ret == -EDEADLK) {
207 struct msm_gem_object *msm_obj = submit->bos[contended].obj;
208 /* we lost out in a seqno race, lock and retry.. */
209 ret = ww_mutex_lock_slow_interruptible(&msm_obj->resv->lock,
210 &submit->ticket);
211 if (!ret) {
212 submit->bos[contended].flags |= BO_LOCKED;
213 slow_locked = contended;
214 goto retry;
215 }
216 }
217
218 return ret;
219}
220
221static int submit_fence_sync(struct msm_gem_submit *submit)
222{
223 int i, ret = 0;
224
225 for (i = 0; i < submit->nr_bos; i++) {
226 struct msm_gem_object *msm_obj = submit->bos[i].obj;
227 bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE;
228
229 ret = msm_gem_sync_object(&msm_obj->base, submit->gpu->fctx, write);
230 if (ret)
231 break;
232 }
233
234 return ret;
235}
236
237static int submit_pin_objects(struct msm_gem_submit *submit)
238{
239 int i, ret = 0;
240
241 submit->valid = true;
242
243 for (i = 0; i < submit->nr_bos; i++) {
244 struct msm_gem_object *msm_obj = submit->bos[i].obj;
245 uint64_t iova;
246
247 /* if locking succeeded, pin bo: */
248 ret = msm_gem_get_iova_locked(&msm_obj->base,
249 submit->gpu->id, &iova);
250
251 if (ret)
252 break;
253
254 submit->bos[i].flags |= BO_PINNED;
255
256 if (iova == submit->bos[i].iova) {
257 submit->bos[i].flags |= BO_VALID;
258 } else {
259 submit->bos[i].iova = iova;
260 /* iova changed, so address in cmdstream is not valid: */
261 submit->bos[i].flags &= ~BO_VALID;
262 submit->valid = false;
263 }
264 }
265
266 return ret;
267}
268
269static int submit_bo(struct msm_gem_submit *submit, uint32_t idx,
270 struct msm_gem_object **obj, uint64_t *iova, bool *valid)
271{
272 if (idx >= submit->nr_bos) {
273 DRM_ERROR("invalid buffer index: %u (out of %u)\n",
274 idx, submit->nr_bos);
275 return -EINVAL;
276 }
277
278 if (obj)
279 *obj = submit->bos[idx].obj;
280 if (iova)
281 *iova = submit->bos[idx].iova;
282 if (valid)
283 *valid = !!(submit->bos[idx].flags & BO_VALID);
284
285 return 0;
286}
287
288/* process the reloc's and patch up the cmdstream as needed: */
289static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obj,
290 uint32_t offset, uint32_t nr_relocs, uint64_t relocs)
291{
292 uint32_t i, last_offset = 0;
293 uint32_t *ptr;
294 int ret = 0;
295
296 if (offset % 4) {
297 DRM_ERROR("non-aligned cmdstream buffer: %u\n", offset);
298 return -EINVAL;
299 }
300
301 /* For now, just map the entire thing. Eventually we probably
302 * to do it page-by-page, w/ kmap() if not vmap()d..
303 */
304 ptr = msm_gem_get_vaddr_locked(&obj->base);
305
306 if (IS_ERR(ptr)) {
307 ret = PTR_ERR(ptr);
308 DBG("failed to map: %d", ret);
309 return ret;
310 }
311
312 for (i = 0; i < nr_relocs; i++) {
313 struct drm_msm_gem_submit_reloc submit_reloc;
314 void __user *userptr =
315 u64_to_user_ptr(relocs + (i * sizeof(submit_reloc)));
316 uint32_t off;
317 uint64_t iova;
318 bool valid;
319
320 ret = copy_from_user(&submit_reloc, userptr, sizeof(submit_reloc));
321 if (ret)
322 goto out;
323
324 if (submit_reloc.submit_offset % 4) {
325 DRM_ERROR("non-aligned reloc offset: %u\n",
326 submit_reloc.submit_offset);
327 ret = -EINVAL;
328 goto out;
329 }
330
331 /* offset in dwords: */
332 off = submit_reloc.submit_offset / 4;
333
334 if ((off >= (obj->base.size / 4)) ||
335 (off < last_offset)) {
336 DRM_ERROR("invalid offset %u at reloc %u\n", off, i);
337 ret = -EINVAL;
338 goto out;
339 }
340
341 ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova, &valid);
342 if (ret)
343 goto out;
344
345 if (valid)
346 continue;
347
348 iova += submit_reloc.reloc_offset;
349
350 if (submit_reloc.shift < 0)
351 iova >>= -submit_reloc.shift;
352 else
353 iova <<= submit_reloc.shift;
354
355 ptr[off] = iova | submit_reloc.or;
356
357 last_offset = off;
358 }
359
360out:
361 msm_gem_put_vaddr_locked(&obj->base);
362
363 return ret;
364}
365
366static void submit_cleanup(struct msm_gem_submit *submit)
367{
368 unsigned i;
369
370 for (i = 0; i < submit->nr_bos; i++) {
371 struct msm_gem_object *msm_obj = submit->bos[i].obj;
372 submit_unlock_unpin_bo(submit, i);
373 list_del_init(&msm_obj->submit_entry);
374 drm_gem_object_unreference(&msm_obj->base);
375 }
376
377 ww_acquire_fini(&submit->ticket);
378}
379
380int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
381 struct drm_file *file)
382{
383 struct msm_drm_private *priv = dev->dev_private;
384 struct drm_msm_gem_submit *args = data;
385 struct msm_file_private *ctx = file->driver_priv;
386 struct msm_gem_submit *submit;
387 struct msm_gpu *gpu = priv->gpu;
388 struct dma_fence *in_fence = NULL;
389 struct sync_file *sync_file = NULL;
390 int out_fence_fd = -1;
391 unsigned i;
392 int ret;
393
394 if (!gpu)
395 return -ENXIO;
396
397 /* for now, we just have 3d pipe.. eventually this would need to
398 * be more clever to dispatch to appropriate gpu module:
399 */
400 if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
401 return -EINVAL;
402
403 if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
404 return -EINVAL;
405
406 ret = mutex_lock_interruptible(&dev->struct_mutex);
407 if (ret)
408 return ret;
409
410 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
411 out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
412 if (out_fence_fd < 0) {
413 ret = out_fence_fd;
414 goto out_unlock;
415 }
416 }
417 priv->struct_mutex_task = current;
418
419 submit = submit_create(dev, gpu, args->nr_bos, args->nr_cmds);
420 if (!submit) {
421 ret = -ENOMEM;
422 goto out_unlock;
423 }
424
425 ret = submit_lookup_objects(submit, args, file);
426 if (ret)
427 goto out;
428
429 ret = submit_lock_objects(submit);
430 if (ret)
431 goto out;
432
433 if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
434 in_fence = sync_file_get_fence(args->fence_fd);
435
436 if (!in_fence) {
437 ret = -EINVAL;
438 goto out;
439 }
440
441 /* TODO if we get an array-fence due to userspace merging multiple
442 * fences, we need a way to determine if all the backing fences
443 * are from our own context..
444 */
445
446 if (in_fence->context != gpu->fctx->context) {
447 ret = dma_fence_wait(in_fence, true);
448 if (ret)
449 goto out;
450 }
451
452 }
453
454 if (!(args->fence & MSM_SUBMIT_NO_IMPLICIT)) {
455 ret = submit_fence_sync(submit);
456 if (ret)
457 goto out;
458 }
459
460 ret = submit_pin_objects(submit);
461 if (ret)
462 goto out;
463
464 for (i = 0; i < args->nr_cmds; i++) {
465 struct drm_msm_gem_submit_cmd submit_cmd;
466 void __user *userptr =
467 u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd)));
468 struct msm_gem_object *msm_obj;
469 uint64_t iova;
470
471 ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd));
472 if (ret) {
473 ret = -EFAULT;
474 goto out;
475 }
476
477 /* validate input from userspace: */
478 switch (submit_cmd.type) {
479 case MSM_SUBMIT_CMD_BUF:
480 case MSM_SUBMIT_CMD_IB_TARGET_BUF:
481 case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
482 break;
483 default:
484 DRM_ERROR("invalid type: %08x\n", submit_cmd.type);
485 ret = -EINVAL;
486 goto out;
487 }
488
489 ret = submit_bo(submit, submit_cmd.submit_idx,
490 &msm_obj, &iova, NULL);
491 if (ret)
492 goto out;
493
494 if (submit_cmd.size % 4) {
495 DRM_ERROR("non-aligned cmdstream buffer size: %u\n",
496 submit_cmd.size);
497 ret = -EINVAL;
498 goto out;
499 }
500
501 if ((submit_cmd.size + submit_cmd.submit_offset) >=
502 msm_obj->base.size) {
503 DRM_ERROR("invalid cmdstream size: %u\n", submit_cmd.size);
504 ret = -EINVAL;
505 goto out;
506 }
507
508 submit->cmd[i].type = submit_cmd.type;
509 submit->cmd[i].size = submit_cmd.size / 4;
510 submit->cmd[i].iova = iova + submit_cmd.submit_offset;
511 submit->cmd[i].idx = submit_cmd.submit_idx;
512
513 if (submit->valid)
514 continue;
515
516 ret = submit_reloc(submit, msm_obj, submit_cmd.submit_offset,
517 submit_cmd.nr_relocs, submit_cmd.relocs);
518 if (ret)
519 goto out;
520 }
521
522 submit->nr_cmds = i;
523
524 submit->fence = msm_fence_alloc(gpu->fctx);
525 if (IS_ERR(submit->fence)) {
526 ret = PTR_ERR(submit->fence);
527 submit->fence = NULL;
528 goto out;
529 }
530
531 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
532 sync_file = sync_file_create(submit->fence);
533 if (!sync_file) {
534 ret = -ENOMEM;
535 goto out;
536 }
537 }
538
539 msm_gpu_submit(gpu, submit, ctx);
540
541 args->fence = submit->fence->seqno;
542
543 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
544 fd_install(out_fence_fd, sync_file->file);
545 args->fence_fd = out_fence_fd;
546 }
547
548out:
549 if (in_fence)
550 dma_fence_put(in_fence);
551 submit_cleanup(submit);
552 if (ret)
553 msm_gem_submit_free(submit);
554out_unlock:
555 if (ret && (out_fence_fd >= 0))
556 put_unused_fd(out_fence_fd);
557 priv->struct_mutex_task = NULL;
558 mutex_unlock(&dev->struct_mutex);
559 return ret;
560}