Linux Audio

Check our new training course

Loading...
v6.8
  1// SPDX-License-Identifier: GPL-2.0-or-later
  2/* NXP PCF50633 Power Management Unit (PMU) driver
  3 *
  4 * (C) 2006-2008 by Openmoko, Inc.
  5 * Author: Harald Welte <laforge@openmoko.org>
  6 * 	   Balaji Rao <balajirrao@openmoko.org>
  7 * All rights reserved.
 
 
 
 
 
 
  8 */
  9
 10#include <linux/i2c.h>
 11#include <linux/interrupt.h>
 12#include <linux/kernel.h>
 13#include <linux/mutex.h>
 14#include <linux/export.h>
 15#include <linux/slab.h>
 16
 17#include <linux/mfd/pcf50633/core.h>
 18#include <linux/mfd/pcf50633/mbc.h>
 19
 20int pcf50633_register_irq(struct pcf50633 *pcf, int irq,
 21			void (*handler) (int, void *), void *data)
 22{
 23	if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler)
 24		return -EINVAL;
 25
 26	if (WARN_ON(pcf->irq_handler[irq].handler))
 27		return -EBUSY;
 28
 29	mutex_lock(&pcf->lock);
 30	pcf->irq_handler[irq].handler = handler;
 31	pcf->irq_handler[irq].data = data;
 32	mutex_unlock(&pcf->lock);
 33
 34	return 0;
 35}
 36EXPORT_SYMBOL_GPL(pcf50633_register_irq);
 37
 38int pcf50633_free_irq(struct pcf50633 *pcf, int irq)
 39{
 40	if (irq < 0 || irq >= PCF50633_NUM_IRQ)
 41		return -EINVAL;
 42
 43	mutex_lock(&pcf->lock);
 44	pcf->irq_handler[irq].handler = NULL;
 45	mutex_unlock(&pcf->lock);
 46
 47	return 0;
 48}
 49EXPORT_SYMBOL_GPL(pcf50633_free_irq);
 50
 51static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask)
 52{
 53	u8 reg, bit;
 54	int idx;
 55
 56	idx = irq >> 3;
 57	reg = PCF50633_REG_INT1M + idx;
 58	bit = 1 << (irq & 0x07);
 59
 60	pcf50633_reg_set_bit_mask(pcf, reg, bit, mask ? bit : 0);
 61
 62	mutex_lock(&pcf->lock);
 63
 64	if (mask)
 65		pcf->mask_regs[idx] |= bit;
 66	else
 67		pcf->mask_regs[idx] &= ~bit;
 68
 69	mutex_unlock(&pcf->lock);
 70
 71	return 0;
 72}
 73
 74int pcf50633_irq_mask(struct pcf50633 *pcf, int irq)
 75{
 76	dev_dbg(pcf->dev, "Masking IRQ %d\n", irq);
 77
 78	return __pcf50633_irq_mask_set(pcf, irq, 1);
 79}
 80EXPORT_SYMBOL_GPL(pcf50633_irq_mask);
 81
 82int pcf50633_irq_unmask(struct pcf50633 *pcf, int irq)
 83{
 84	dev_dbg(pcf->dev, "Unmasking IRQ %d\n", irq);
 85
 86	return __pcf50633_irq_mask_set(pcf, irq, 0);
 87}
 88EXPORT_SYMBOL_GPL(pcf50633_irq_unmask);
 89
 90int pcf50633_irq_mask_get(struct pcf50633 *pcf, int irq)
 91{
 92	u8 reg, bits;
 93
 94	reg =  irq >> 3;
 95	bits = 1 << (irq & 0x07);
 96
 97	return pcf->mask_regs[reg] & bits;
 98}
 99EXPORT_SYMBOL_GPL(pcf50633_irq_mask_get);
100
101static void pcf50633_irq_call_handler(struct pcf50633 *pcf, int irq)
102{
103	if (pcf->irq_handler[irq].handler)
104		pcf->irq_handler[irq].handler(irq, pcf->irq_handler[irq].data);
105}
106
107/* Maximum amount of time ONKEY is held before emergency action is taken */
108#define PCF50633_ONKEY1S_TIMEOUT 8
109
110static irqreturn_t pcf50633_irq(int irq, void *data)
111{
112	struct pcf50633 *pcf = data;
113	int ret, i, j;
114	u8 pcf_int[5], chgstat;
115
116	/* Read the 5 INT regs in one transaction */
117	ret = pcf50633_read_block(pcf, PCF50633_REG_INT1,
118						ARRAY_SIZE(pcf_int), pcf_int);
119	if (ret != ARRAY_SIZE(pcf_int)) {
120		dev_err(pcf->dev, "Error reading INT registers\n");
121
122		/*
123		 * If this doesn't ACK the interrupt to the chip, we'll be
124		 * called once again as we're level triggered.
125		 */
126		goto out;
127	}
128
129	/* defeat 8s death from lowsys on A5 */
130	pcf50633_reg_write(pcf, PCF50633_REG_OOCSHDWN,  0x04);
131
132	/* We immediately read the usb and adapter status. We thus make sure
133	 * only of USBINS/USBREM IRQ handlers are called */
134	if (pcf_int[0] & (PCF50633_INT1_USBINS | PCF50633_INT1_USBREM)) {
135		chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
136		if (chgstat & (0x3 << 4))
137			pcf_int[0] &= ~PCF50633_INT1_USBREM;
138		else
139			pcf_int[0] &= ~PCF50633_INT1_USBINS;
140	}
141
142	/* Make sure only one of ADPINS or ADPREM is set */
143	if (pcf_int[0] & (PCF50633_INT1_ADPINS | PCF50633_INT1_ADPREM)) {
144		chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
145		if (chgstat & (0x3 << 4))
146			pcf_int[0] &= ~PCF50633_INT1_ADPREM;
147		else
148			pcf_int[0] &= ~PCF50633_INT1_ADPINS;
149	}
150
151	dev_dbg(pcf->dev, "INT1=0x%02x INT2=0x%02x INT3=0x%02x "
152			"INT4=0x%02x INT5=0x%02x\n", pcf_int[0],
153			pcf_int[1], pcf_int[2], pcf_int[3], pcf_int[4]);
154
155	/* Some revisions of the chip don't have a 8s standby mode on
156	 * ONKEY1S press. We try to manually do it in such cases. */
157	if ((pcf_int[0] & PCF50633_INT1_SECOND) && pcf->onkey1s_held) {
158		dev_info(pcf->dev, "ONKEY1S held for %d secs\n",
159							pcf->onkey1s_held);
160		if (pcf->onkey1s_held++ == PCF50633_ONKEY1S_TIMEOUT)
161			if (pcf->pdata->force_shutdown)
162				pcf->pdata->force_shutdown(pcf);
163	}
164
165	if (pcf_int[2] & PCF50633_INT3_ONKEY1S) {
166		dev_info(pcf->dev, "ONKEY1S held\n");
167		pcf->onkey1s_held = 1 ;
168
169		/* Unmask IRQ_SECOND */
170		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M,
171						PCF50633_INT1_SECOND);
172
173		/* Unmask IRQ_ONKEYR */
174		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT2M,
175						PCF50633_INT2_ONKEYR);
176	}
177
178	if ((pcf_int[1] & PCF50633_INT2_ONKEYR) && pcf->onkey1s_held) {
179		pcf->onkey1s_held = 0;
180
181		/* Mask SECOND and ONKEYR interrupts */
182		if (pcf->mask_regs[0] & PCF50633_INT1_SECOND)
183			pcf50633_reg_set_bit_mask(pcf,
184					PCF50633_REG_INT1M,
185					PCF50633_INT1_SECOND,
186					PCF50633_INT1_SECOND);
187
188		if (pcf->mask_regs[1] & PCF50633_INT2_ONKEYR)
189			pcf50633_reg_set_bit_mask(pcf,
190					PCF50633_REG_INT2M,
191					PCF50633_INT2_ONKEYR,
192					PCF50633_INT2_ONKEYR);
193	}
194
195	/* Have we just resumed ? */
196	if (pcf->is_suspended) {
197		pcf->is_suspended = 0;
198
199		/* Set the resume reason filtering out non resumers */
200		for (i = 0; i < ARRAY_SIZE(pcf_int); i++)
201			pcf->resume_reason[i] = pcf_int[i] &
202						pcf->pdata->resumers[i];
203
204		/* Make sure we don't pass on any ONKEY events to
205		 * userspace now */
206		pcf_int[1] &= ~(PCF50633_INT2_ONKEYR | PCF50633_INT2_ONKEYF);
207	}
208
209	for (i = 0; i < ARRAY_SIZE(pcf_int); i++) {
210		/* Unset masked interrupts */
211		pcf_int[i] &= ~pcf->mask_regs[i];
212
213		for (j = 0; j < 8 ; j++)
214			if (pcf_int[i] & (1 << j))
215				pcf50633_irq_call_handler(pcf, (i * 8) + j);
216	}
217
218out:
219	return IRQ_HANDLED;
220}
221
222static int pcf50633_suspend(struct device *dev)
 
 
223{
224	struct i2c_client *client = to_i2c_client(dev);
225	struct pcf50633 *pcf = i2c_get_clientdata(client);
226	int ret;
227	int i;
228	u8 res[5];
229
230
231	/* Make sure our interrupt handlers are not called
232	 * henceforth */
233	disable_irq(pcf->irq);
234
235	/* Save the masks */
236	ret = pcf50633_read_block(pcf, PCF50633_REG_INT1M,
237				ARRAY_SIZE(pcf->suspend_irq_masks),
238					pcf->suspend_irq_masks);
239	if (ret < 0) {
240		dev_err(pcf->dev, "error saving irq masks\n");
241		goto out;
242	}
243
244	/* Write wakeup irq masks */
245	for (i = 0; i < ARRAY_SIZE(res); i++)
246		res[i] = ~pcf->pdata->resumers[i];
247
248	ret = pcf50633_write_block(pcf, PCF50633_REG_INT1M,
249					ARRAY_SIZE(res), &res[0]);
250	if (ret < 0) {
251		dev_err(pcf->dev, "error writing wakeup irq masks\n");
252		goto out;
253	}
254
255	pcf->is_suspended = 1;
256
257out:
258	return ret;
259}
260
261static int pcf50633_resume(struct device *dev)
262{
263	struct i2c_client *client = to_i2c_client(dev);
264	struct pcf50633 *pcf = i2c_get_clientdata(client);
265	int ret;
266
267	/* Write the saved mask registers */
268	ret = pcf50633_write_block(pcf, PCF50633_REG_INT1M,
269				ARRAY_SIZE(pcf->suspend_irq_masks),
270					pcf->suspend_irq_masks);
271	if (ret < 0)
272		dev_err(pcf->dev, "Error restoring saved suspend masks\n");
273
274	enable_irq(pcf->irq);
275
276	return ret;
277}
278
279EXPORT_GPL_SIMPLE_DEV_PM_OPS(pcf50633_pm, pcf50633_suspend, pcf50633_resume);
280
281int pcf50633_irq_init(struct pcf50633 *pcf, int irq)
282{
283	int ret;
284
285	pcf->irq = irq;
286
287	/* Enable all interrupts except RTC SECOND */
288	pcf->mask_regs[0] = 0x80;
289	pcf50633_reg_write(pcf, PCF50633_REG_INT1M, pcf->mask_regs[0]);
290	pcf50633_reg_write(pcf, PCF50633_REG_INT2M, 0x00);
291	pcf50633_reg_write(pcf, PCF50633_REG_INT3M, 0x00);
292	pcf50633_reg_write(pcf, PCF50633_REG_INT4M, 0x00);
293	pcf50633_reg_write(pcf, PCF50633_REG_INT5M, 0x00);
294
295	ret = request_threaded_irq(irq, NULL, pcf50633_irq,
296					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
297					"pcf50633", pcf);
298
299	if (ret)
300		dev_err(pcf->dev, "Failed to request IRQ %d\n", ret);
301
302	if (enable_irq_wake(irq) < 0)
303		dev_err(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
304			"in this hardware revision", irq);
305
306	return ret;
307}
308
309void pcf50633_irq_free(struct pcf50633 *pcf)
310{
311	free_irq(pcf->irq, pcf);
312}
v3.15
 
  1/* NXP PCF50633 Power Management Unit (PMU) driver
  2 *
  3 * (C) 2006-2008 by Openmoko, Inc.
  4 * Author: Harald Welte <laforge@openmoko.org>
  5 * 	   Balaji Rao <balajirrao@openmoko.org>
  6 * All rights reserved.
  7 *
  8 *  This program is free software; you can redistribute  it and/or modify it
  9 *  under  the terms of  the GNU General  Public License as published by the
 10 *  Free Software Foundation;  either version 2 of the  License, or (at your
 11 *  option) any later version.
 12 *
 13 */
 14
 
 15#include <linux/interrupt.h>
 16#include <linux/kernel.h>
 17#include <linux/mutex.h>
 18#include <linux/export.h>
 19#include <linux/slab.h>
 20
 21#include <linux/mfd/pcf50633/core.h>
 22#include <linux/mfd/pcf50633/mbc.h>
 23
 24int pcf50633_register_irq(struct pcf50633 *pcf, int irq,
 25			void (*handler) (int, void *), void *data)
 26{
 27	if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler)
 28		return -EINVAL;
 29
 30	if (WARN_ON(pcf->irq_handler[irq].handler))
 31		return -EBUSY;
 32
 33	mutex_lock(&pcf->lock);
 34	pcf->irq_handler[irq].handler = handler;
 35	pcf->irq_handler[irq].data = data;
 36	mutex_unlock(&pcf->lock);
 37
 38	return 0;
 39}
 40EXPORT_SYMBOL_GPL(pcf50633_register_irq);
 41
 42int pcf50633_free_irq(struct pcf50633 *pcf, int irq)
 43{
 44	if (irq < 0 || irq >= PCF50633_NUM_IRQ)
 45		return -EINVAL;
 46
 47	mutex_lock(&pcf->lock);
 48	pcf->irq_handler[irq].handler = NULL;
 49	mutex_unlock(&pcf->lock);
 50
 51	return 0;
 52}
 53EXPORT_SYMBOL_GPL(pcf50633_free_irq);
 54
 55static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask)
 56{
 57	u8 reg, bit;
 58	int ret = 0, idx;
 59
 60	idx = irq >> 3;
 61	reg = PCF50633_REG_INT1M + idx;
 62	bit = 1 << (irq & 0x07);
 63
 64	pcf50633_reg_set_bit_mask(pcf, reg, bit, mask ? bit : 0);
 65
 66	mutex_lock(&pcf->lock);
 67
 68	if (mask)
 69		pcf->mask_regs[idx] |= bit;
 70	else
 71		pcf->mask_regs[idx] &= ~bit;
 72
 73	mutex_unlock(&pcf->lock);
 74
 75	return ret;
 76}
 77
 78int pcf50633_irq_mask(struct pcf50633 *pcf, int irq)
 79{
 80	dev_dbg(pcf->dev, "Masking IRQ %d\n", irq);
 81
 82	return __pcf50633_irq_mask_set(pcf, irq, 1);
 83}
 84EXPORT_SYMBOL_GPL(pcf50633_irq_mask);
 85
 86int pcf50633_irq_unmask(struct pcf50633 *pcf, int irq)
 87{
 88	dev_dbg(pcf->dev, "Unmasking IRQ %d\n", irq);
 89
 90	return __pcf50633_irq_mask_set(pcf, irq, 0);
 91}
 92EXPORT_SYMBOL_GPL(pcf50633_irq_unmask);
 93
 94int pcf50633_irq_mask_get(struct pcf50633 *pcf, int irq)
 95{
 96	u8 reg, bits;
 97
 98	reg =  irq >> 3;
 99	bits = 1 << (irq & 0x07);
100
101	return pcf->mask_regs[reg] & bits;
102}
103EXPORT_SYMBOL_GPL(pcf50633_irq_mask_get);
104
105static void pcf50633_irq_call_handler(struct pcf50633 *pcf, int irq)
106{
107	if (pcf->irq_handler[irq].handler)
108		pcf->irq_handler[irq].handler(irq, pcf->irq_handler[irq].data);
109}
110
111/* Maximum amount of time ONKEY is held before emergency action is taken */
112#define PCF50633_ONKEY1S_TIMEOUT 8
113
114static irqreturn_t pcf50633_irq(int irq, void *data)
115{
116	struct pcf50633 *pcf = data;
117	int ret, i, j;
118	u8 pcf_int[5], chgstat;
119
120	/* Read the 5 INT regs in one transaction */
121	ret = pcf50633_read_block(pcf, PCF50633_REG_INT1,
122						ARRAY_SIZE(pcf_int), pcf_int);
123	if (ret != ARRAY_SIZE(pcf_int)) {
124		dev_err(pcf->dev, "Error reading INT registers\n");
125
126		/*
127		 * If this doesn't ACK the interrupt to the chip, we'll be
128		 * called once again as we're level triggered.
129		 */
130		goto out;
131	}
132
133	/* defeat 8s death from lowsys on A5 */
134	pcf50633_reg_write(pcf, PCF50633_REG_OOCSHDWN,  0x04);
135
136	/* We immediately read the usb and adapter status. We thus make sure
137	 * only of USBINS/USBREM IRQ handlers are called */
138	if (pcf_int[0] & (PCF50633_INT1_USBINS | PCF50633_INT1_USBREM)) {
139		chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
140		if (chgstat & (0x3 << 4))
141			pcf_int[0] &= ~PCF50633_INT1_USBREM;
142		else
143			pcf_int[0] &= ~PCF50633_INT1_USBINS;
144	}
145
146	/* Make sure only one of ADPINS or ADPREM is set */
147	if (pcf_int[0] & (PCF50633_INT1_ADPINS | PCF50633_INT1_ADPREM)) {
148		chgstat = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
149		if (chgstat & (0x3 << 4))
150			pcf_int[0] &= ~PCF50633_INT1_ADPREM;
151		else
152			pcf_int[0] &= ~PCF50633_INT1_ADPINS;
153	}
154
155	dev_dbg(pcf->dev, "INT1=0x%02x INT2=0x%02x INT3=0x%02x "
156			"INT4=0x%02x INT5=0x%02x\n", pcf_int[0],
157			pcf_int[1], pcf_int[2], pcf_int[3], pcf_int[4]);
158
159	/* Some revisions of the chip don't have a 8s standby mode on
160	 * ONKEY1S press. We try to manually do it in such cases. */
161	if ((pcf_int[0] & PCF50633_INT1_SECOND) && pcf->onkey1s_held) {
162		dev_info(pcf->dev, "ONKEY1S held for %d secs\n",
163							pcf->onkey1s_held);
164		if (pcf->onkey1s_held++ == PCF50633_ONKEY1S_TIMEOUT)
165			if (pcf->pdata->force_shutdown)
166				pcf->pdata->force_shutdown(pcf);
167	}
168
169	if (pcf_int[2] & PCF50633_INT3_ONKEY1S) {
170		dev_info(pcf->dev, "ONKEY1S held\n");
171		pcf->onkey1s_held = 1 ;
172
173		/* Unmask IRQ_SECOND */
174		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M,
175						PCF50633_INT1_SECOND);
176
177		/* Unmask IRQ_ONKEYR */
178		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT2M,
179						PCF50633_INT2_ONKEYR);
180	}
181
182	if ((pcf_int[1] & PCF50633_INT2_ONKEYR) && pcf->onkey1s_held) {
183		pcf->onkey1s_held = 0;
184
185		/* Mask SECOND and ONKEYR interrupts */
186		if (pcf->mask_regs[0] & PCF50633_INT1_SECOND)
187			pcf50633_reg_set_bit_mask(pcf,
188					PCF50633_REG_INT1M,
189					PCF50633_INT1_SECOND,
190					PCF50633_INT1_SECOND);
191
192		if (pcf->mask_regs[1] & PCF50633_INT2_ONKEYR)
193			pcf50633_reg_set_bit_mask(pcf,
194					PCF50633_REG_INT2M,
195					PCF50633_INT2_ONKEYR,
196					PCF50633_INT2_ONKEYR);
197	}
198
199	/* Have we just resumed ? */
200	if (pcf->is_suspended) {
201		pcf->is_suspended = 0;
202
203		/* Set the resume reason filtering out non resumers */
204		for (i = 0; i < ARRAY_SIZE(pcf_int); i++)
205			pcf->resume_reason[i] = pcf_int[i] &
206						pcf->pdata->resumers[i];
207
208		/* Make sure we don't pass on any ONKEY events to
209		 * userspace now */
210		pcf_int[1] &= ~(PCF50633_INT2_ONKEYR | PCF50633_INT2_ONKEYF);
211	}
212
213	for (i = 0; i < ARRAY_SIZE(pcf_int); i++) {
214		/* Unset masked interrupts */
215		pcf_int[i] &= ~pcf->mask_regs[i];
216
217		for (j = 0; j < 8 ; j++)
218			if (pcf_int[i] & (1 << j))
219				pcf50633_irq_call_handler(pcf, (i * 8) + j);
220	}
221
222out:
223	return IRQ_HANDLED;
224}
225
226#ifdef CONFIG_PM
227
228int pcf50633_irq_suspend(struct pcf50633 *pcf)
229{
 
 
230	int ret;
231	int i;
232	u8 res[5];
233
234
235	/* Make sure our interrupt handlers are not called
236	 * henceforth */
237	disable_irq(pcf->irq);
238
239	/* Save the masks */
240	ret = pcf50633_read_block(pcf, PCF50633_REG_INT1M,
241				ARRAY_SIZE(pcf->suspend_irq_masks),
242					pcf->suspend_irq_masks);
243	if (ret < 0) {
244		dev_err(pcf->dev, "error saving irq masks\n");
245		goto out;
246	}
247
248	/* Write wakeup irq masks */
249	for (i = 0; i < ARRAY_SIZE(res); i++)
250		res[i] = ~pcf->pdata->resumers[i];
251
252	ret = pcf50633_write_block(pcf, PCF50633_REG_INT1M,
253					ARRAY_SIZE(res), &res[0]);
254	if (ret < 0) {
255		dev_err(pcf->dev, "error writing wakeup irq masks\n");
256		goto out;
257	}
258
259	pcf->is_suspended = 1;
260
261out:
262	return ret;
263}
264
265int pcf50633_irq_resume(struct pcf50633 *pcf)
266{
 
 
267	int ret;
268
269	/* Write the saved mask registers */
270	ret = pcf50633_write_block(pcf, PCF50633_REG_INT1M,
271				ARRAY_SIZE(pcf->suspend_irq_masks),
272					pcf->suspend_irq_masks);
273	if (ret < 0)
274		dev_err(pcf->dev, "Error restoring saved suspend masks\n");
275
276	enable_irq(pcf->irq);
277
278	return ret;
279}
280
281#endif
282
283int pcf50633_irq_init(struct pcf50633 *pcf, int irq)
284{
285	int ret;
286
287	pcf->irq = irq;
288
289	/* Enable all interrupts except RTC SECOND */
290	pcf->mask_regs[0] = 0x80;
291	pcf50633_reg_write(pcf, PCF50633_REG_INT1M, pcf->mask_regs[0]);
292	pcf50633_reg_write(pcf, PCF50633_REG_INT2M, 0x00);
293	pcf50633_reg_write(pcf, PCF50633_REG_INT3M, 0x00);
294	pcf50633_reg_write(pcf, PCF50633_REG_INT4M, 0x00);
295	pcf50633_reg_write(pcf, PCF50633_REG_INT5M, 0x00);
296
297	ret = request_threaded_irq(irq, NULL, pcf50633_irq,
298					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
299					"pcf50633", pcf);
300
301	if (ret)
302		dev_err(pcf->dev, "Failed to request IRQ %d\n", ret);
303
304	if (enable_irq_wake(irq) < 0)
305		dev_err(pcf->dev, "IRQ %u cannot be enabled as wake-up source"
306			"in this hardware revision", irq);
307
308	return ret;
309}
310
311void pcf50633_irq_free(struct pcf50633 *pcf)
312{
313	free_irq(pcf->irq, pcf);
314}