Loading...
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2013 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 */
6
7#include <linux/file.h>
8#include <linux/sync_file.h>
9#include <linux/uaccess.h>
10
11#include <drm/drm_drv.h>
12#include <drm/drm_file.h>
13#include <drm/drm_syncobj.h>
14
15#include "msm_drv.h"
16#include "msm_gpu.h"
17#include "msm_gem.h"
18#include "msm_gpu_trace.h"
19
20/* For userspace errors, use DRM_UT_DRIVER.. so that userspace can enable
21 * error msgs for debugging, but we don't spam dmesg by default
22 */
23#define SUBMIT_ERROR(submit, fmt, ...) \
24 DRM_DEV_DEBUG_DRIVER((submit)->dev->dev, fmt, ##__VA_ARGS__)
25
26/*
27 * Cmdstream submission:
28 */
29
30static struct msm_gem_submit *submit_create(struct drm_device *dev,
31 struct msm_gpu *gpu,
32 struct msm_gpu_submitqueue *queue, uint32_t nr_bos,
33 uint32_t nr_cmds)
34{
35 static atomic_t ident = ATOMIC_INIT(0);
36 struct msm_gem_submit *submit;
37 uint64_t sz;
38 int ret;
39
40 sz = struct_size(submit, bos, nr_bos) +
41 ((u64)nr_cmds * sizeof(submit->cmd[0]));
42
43 if (sz > SIZE_MAX)
44 return ERR_PTR(-ENOMEM);
45
46 submit = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN);
47 if (!submit)
48 return ERR_PTR(-ENOMEM);
49
50 submit->hw_fence = msm_fence_alloc();
51 if (IS_ERR(submit->hw_fence)) {
52 ret = PTR_ERR(submit->hw_fence);
53 kfree(submit);
54 return ERR_PTR(ret);
55 }
56
57 ret = drm_sched_job_init(&submit->base, queue->entity, 1, queue);
58 if (ret) {
59 kfree(submit->hw_fence);
60 kfree(submit);
61 return ERR_PTR(ret);
62 }
63
64 kref_init(&submit->ref);
65 submit->dev = dev;
66 submit->aspace = queue->ctx->aspace;
67 submit->gpu = gpu;
68 submit->cmd = (void *)&submit->bos[nr_bos];
69 submit->queue = queue;
70 submit->pid = get_pid(task_pid(current));
71 submit->ring = gpu->rb[queue->ring_nr];
72 submit->fault_dumped = false;
73
74 /* Get a unique identifier for the submission for logging purposes */
75 submit->ident = atomic_inc_return(&ident) - 1;
76
77 INIT_LIST_HEAD(&submit->node);
78
79 return submit;
80}
81
82void __msm_gem_submit_destroy(struct kref *kref)
83{
84 struct msm_gem_submit *submit =
85 container_of(kref, struct msm_gem_submit, ref);
86 unsigned i;
87
88 if (submit->fence_id) {
89 spin_lock(&submit->queue->idr_lock);
90 idr_remove(&submit->queue->fence_idr, submit->fence_id);
91 spin_unlock(&submit->queue->idr_lock);
92 }
93
94 dma_fence_put(submit->user_fence);
95
96 /*
97 * If the submit is freed before msm_job_run(), then hw_fence is
98 * just some pre-allocated memory, not a reference counted fence.
99 * Once the job runs and the hw_fence is initialized, it will
100 * have a refcount of at least one, since the submit holds a ref
101 * to the hw_fence.
102 */
103 if (kref_read(&submit->hw_fence->refcount) == 0) {
104 kfree(submit->hw_fence);
105 } else {
106 dma_fence_put(submit->hw_fence);
107 }
108
109 put_pid(submit->pid);
110 msm_submitqueue_put(submit->queue);
111
112 for (i = 0; i < submit->nr_cmds; i++)
113 kfree(submit->cmd[i].relocs);
114
115 kfree(submit);
116}
117
118static int submit_lookup_objects(struct msm_gem_submit *submit,
119 struct drm_msm_gem_submit *args, struct drm_file *file)
120{
121 unsigned i;
122 int ret = 0;
123
124 for (i = 0; i < args->nr_bos; i++) {
125 struct drm_msm_gem_submit_bo submit_bo;
126 void __user *userptr =
127 u64_to_user_ptr(args->bos + (i * sizeof(submit_bo)));
128
129 /* make sure we don't have garbage flags, in case we hit
130 * error path before flags is initialized:
131 */
132 submit->bos[i].flags = 0;
133
134 if (copy_from_user(&submit_bo, userptr, sizeof(submit_bo))) {
135 ret = -EFAULT;
136 i = 0;
137 goto out;
138 }
139
140/* at least one of READ and/or WRITE flags should be set: */
141#define MANDATORY_FLAGS (MSM_SUBMIT_BO_READ | MSM_SUBMIT_BO_WRITE)
142
143 if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
144 !(submit_bo.flags & MANDATORY_FLAGS)) {
145 SUBMIT_ERROR(submit, "invalid flags: %x\n", submit_bo.flags);
146 ret = -EINVAL;
147 i = 0;
148 goto out;
149 }
150
151 submit->bos[i].handle = submit_bo.handle;
152 submit->bos[i].flags = submit_bo.flags;
153 }
154
155 spin_lock(&file->table_lock);
156
157 for (i = 0; i < args->nr_bos; i++) {
158 struct drm_gem_object *obj;
159
160 /* normally use drm_gem_object_lookup(), but for bulk lookup
161 * all under single table_lock just hit object_idr directly:
162 */
163 obj = idr_find(&file->object_idr, submit->bos[i].handle);
164 if (!obj) {
165 SUBMIT_ERROR(submit, "invalid handle %u at index %u\n", submit->bos[i].handle, i);
166 ret = -EINVAL;
167 goto out_unlock;
168 }
169
170 drm_gem_object_get(obj);
171
172 submit->bos[i].obj = obj;
173 }
174
175out_unlock:
176 spin_unlock(&file->table_lock);
177
178out:
179 submit->nr_bos = i;
180
181 return ret;
182}
183
184static int submit_lookup_cmds(struct msm_gem_submit *submit,
185 struct drm_msm_gem_submit *args, struct drm_file *file)
186{
187 unsigned i;
188 size_t sz;
189 int ret = 0;
190
191 for (i = 0; i < args->nr_cmds; i++) {
192 struct drm_msm_gem_submit_cmd submit_cmd;
193 void __user *userptr =
194 u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd)));
195
196 ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd));
197 if (ret) {
198 ret = -EFAULT;
199 goto out;
200 }
201
202 /* validate input from userspace: */
203 switch (submit_cmd.type) {
204 case MSM_SUBMIT_CMD_BUF:
205 case MSM_SUBMIT_CMD_IB_TARGET_BUF:
206 case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
207 break;
208 default:
209 SUBMIT_ERROR(submit, "invalid type: %08x\n", submit_cmd.type);
210 return -EINVAL;
211 }
212
213 if (submit_cmd.size % 4) {
214 SUBMIT_ERROR(submit, "non-aligned cmdstream buffer size: %u\n",
215 submit_cmd.size);
216 ret = -EINVAL;
217 goto out;
218 }
219
220 submit->cmd[i].type = submit_cmd.type;
221 submit->cmd[i].size = submit_cmd.size / 4;
222 submit->cmd[i].offset = submit_cmd.submit_offset / 4;
223 submit->cmd[i].idx = submit_cmd.submit_idx;
224 submit->cmd[i].nr_relocs = submit_cmd.nr_relocs;
225
226 userptr = u64_to_user_ptr(submit_cmd.relocs);
227
228 sz = array_size(submit_cmd.nr_relocs,
229 sizeof(struct drm_msm_gem_submit_reloc));
230 /* check for overflow: */
231 if (sz == SIZE_MAX) {
232 ret = -ENOMEM;
233 goto out;
234 }
235 submit->cmd[i].relocs = kmalloc(sz, GFP_KERNEL | __GFP_NOWARN);
236 if (!submit->cmd[i].relocs) {
237 ret = -ENOMEM;
238 goto out;
239 }
240 ret = copy_from_user(submit->cmd[i].relocs, userptr, sz);
241 if (ret) {
242 ret = -EFAULT;
243 goto out;
244 }
245 }
246
247out:
248 return ret;
249}
250
251/* This is where we make sure all the bo's are reserved and pin'd: */
252static int submit_lock_objects(struct msm_gem_submit *submit)
253{
254 int ret;
255
256 drm_exec_init(&submit->exec, DRM_EXEC_INTERRUPTIBLE_WAIT, submit->nr_bos);
257
258 drm_exec_until_all_locked (&submit->exec) {
259 for (unsigned i = 0; i < submit->nr_bos; i++) {
260 struct drm_gem_object *obj = submit->bos[i].obj;
261 ret = drm_exec_prepare_obj(&submit->exec, obj, 1);
262 drm_exec_retry_on_contention(&submit->exec);
263 if (ret)
264 goto error;
265 }
266 }
267
268 return 0;
269
270error:
271 return ret;
272}
273
274static int submit_fence_sync(struct msm_gem_submit *submit)
275{
276 int i, ret = 0;
277
278 for (i = 0; i < submit->nr_bos; i++) {
279 struct drm_gem_object *obj = submit->bos[i].obj;
280 bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE;
281
282 /* Otherwise userspace can ask for implicit sync to be
283 * disabled on specific buffers. This is useful for internal
284 * usermode driver managed buffers, suballocation, etc.
285 */
286 if (submit->bos[i].flags & MSM_SUBMIT_BO_NO_IMPLICIT)
287 continue;
288
289 ret = drm_sched_job_add_implicit_dependencies(&submit->base,
290 obj,
291 write);
292 if (ret)
293 break;
294 }
295
296 return ret;
297}
298
299static int submit_pin_objects(struct msm_gem_submit *submit)
300{
301 struct msm_drm_private *priv = submit->dev->dev_private;
302 int i, ret = 0;
303
304 for (i = 0; i < submit->nr_bos; i++) {
305 struct drm_gem_object *obj = submit->bos[i].obj;
306 struct msm_gem_vma *vma;
307
308 /* if locking succeeded, pin bo: */
309 vma = msm_gem_get_vma_locked(obj, submit->aspace);
310 if (IS_ERR(vma)) {
311 ret = PTR_ERR(vma);
312 break;
313 }
314
315 ret = msm_gem_pin_vma_locked(obj, vma);
316 if (ret)
317 break;
318
319 submit->bos[i].iova = vma->iova;
320 }
321
322 /*
323 * A second loop while holding the LRU lock (a) avoids acquiring/dropping
324 * the LRU lock for each individual bo, while (b) avoiding holding the
325 * LRU lock while calling msm_gem_pin_vma_locked() (which could trigger
326 * get_pages() which could trigger reclaim.. and if we held the LRU lock
327 * could trigger deadlock with the shrinker).
328 */
329 mutex_lock(&priv->lru.lock);
330 for (i = 0; i < submit->nr_bos; i++) {
331 msm_gem_pin_obj_locked(submit->bos[i].obj);
332 }
333 mutex_unlock(&priv->lru.lock);
334
335 submit->bos_pinned = true;
336
337 return ret;
338}
339
340static void submit_unpin_objects(struct msm_gem_submit *submit)
341{
342 if (!submit->bos_pinned)
343 return;
344
345 for (int i = 0; i < submit->nr_bos; i++) {
346 struct drm_gem_object *obj = submit->bos[i].obj;
347
348 msm_gem_unpin_locked(obj);
349 }
350
351 submit->bos_pinned = false;
352}
353
354static void submit_attach_object_fences(struct msm_gem_submit *submit)
355{
356 int i;
357
358 for (i = 0; i < submit->nr_bos; i++) {
359 struct drm_gem_object *obj = submit->bos[i].obj;
360
361 if (submit->bos[i].flags & MSM_SUBMIT_BO_WRITE)
362 dma_resv_add_fence(obj->resv, submit->user_fence,
363 DMA_RESV_USAGE_WRITE);
364 else if (submit->bos[i].flags & MSM_SUBMIT_BO_READ)
365 dma_resv_add_fence(obj->resv, submit->user_fence,
366 DMA_RESV_USAGE_READ);
367 }
368}
369
370static int submit_bo(struct msm_gem_submit *submit, uint32_t idx,
371 struct drm_gem_object **obj, uint64_t *iova)
372{
373 if (idx >= submit->nr_bos) {
374 SUBMIT_ERROR(submit, "invalid buffer index: %u (out of %u)\n",
375 idx, submit->nr_bos);
376 return -EINVAL;
377 }
378
379 if (obj)
380 *obj = submit->bos[idx].obj;
381 if (iova)
382 *iova = submit->bos[idx].iova;
383
384 return 0;
385}
386
387/* process the reloc's and patch up the cmdstream as needed: */
388static int submit_reloc(struct msm_gem_submit *submit, struct drm_gem_object *obj,
389 uint32_t offset, uint32_t nr_relocs, struct drm_msm_gem_submit_reloc *relocs)
390{
391 uint32_t i, last_offset = 0;
392 uint32_t *ptr;
393 int ret = 0;
394
395 if (offset % 4) {
396 SUBMIT_ERROR(submit, "non-aligned cmdstream buffer: %u\n", offset);
397 return -EINVAL;
398 }
399
400 /* For now, just map the entire thing. Eventually we probably
401 * to do it page-by-page, w/ kmap() if not vmap()d..
402 */
403 ptr = msm_gem_get_vaddr_locked(obj);
404
405 if (IS_ERR(ptr)) {
406 ret = PTR_ERR(ptr);
407 DBG("failed to map: %d", ret);
408 return ret;
409 }
410
411 for (i = 0; i < nr_relocs; i++) {
412 struct drm_msm_gem_submit_reloc submit_reloc = relocs[i];
413 uint32_t off;
414 uint64_t iova;
415
416 if (submit_reloc.submit_offset % 4) {
417 SUBMIT_ERROR(submit, "non-aligned reloc offset: %u\n",
418 submit_reloc.submit_offset);
419 ret = -EINVAL;
420 goto out;
421 }
422
423 /* offset in dwords: */
424 off = submit_reloc.submit_offset / 4;
425
426 if ((off >= (obj->size / 4)) ||
427 (off < last_offset)) {
428 SUBMIT_ERROR(submit, "invalid offset %u at reloc %u\n", off, i);
429 ret = -EINVAL;
430 goto out;
431 }
432
433 ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova);
434 if (ret)
435 goto out;
436
437 iova += submit_reloc.reloc_offset;
438
439 if (submit_reloc.shift < 0)
440 iova >>= -submit_reloc.shift;
441 else
442 iova <<= submit_reloc.shift;
443
444 ptr[off] = iova | submit_reloc.or;
445
446 last_offset = off;
447 }
448
449out:
450 msm_gem_put_vaddr_locked(obj);
451
452 return ret;
453}
454
455/* Cleanup submit at end of ioctl. In the error case, this also drops
456 * references, unpins, and drops active refcnt. In the non-error case,
457 * this is done when the submit is retired.
458 */
459static void submit_cleanup(struct msm_gem_submit *submit, bool error)
460{
461 if (error) {
462 submit_unpin_objects(submit);
463 /* job wasn't enqueued to scheduler, so early retirement: */
464 msm_submit_retire(submit);
465 }
466
467 if (submit->exec.objects)
468 drm_exec_fini(&submit->exec);
469}
470
471void msm_submit_retire(struct msm_gem_submit *submit)
472{
473 int i;
474
475 for (i = 0; i < submit->nr_bos; i++) {
476 struct drm_gem_object *obj = submit->bos[i].obj;
477
478 drm_gem_object_put(obj);
479 }
480}
481
482struct msm_submit_post_dep {
483 struct drm_syncobj *syncobj;
484 uint64_t point;
485 struct dma_fence_chain *chain;
486};
487
488static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit,
489 struct drm_file *file,
490 uint64_t in_syncobjs_addr,
491 uint32_t nr_in_syncobjs,
492 size_t syncobj_stride)
493{
494 struct drm_syncobj **syncobjs = NULL;
495 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
496 int ret = 0;
497 uint32_t i, j;
498
499 syncobjs = kcalloc(nr_in_syncobjs, sizeof(*syncobjs),
500 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
501 if (!syncobjs)
502 return ERR_PTR(-ENOMEM);
503
504 for (i = 0; i < nr_in_syncobjs; ++i) {
505 uint64_t address = in_syncobjs_addr + i * syncobj_stride;
506
507 if (copy_from_user(&syncobj_desc,
508 u64_to_user_ptr(address),
509 min(syncobj_stride, sizeof(syncobj_desc)))) {
510 ret = -EFAULT;
511 break;
512 }
513
514 if (syncobj_desc.point &&
515 !drm_core_check_feature(submit->dev, DRIVER_SYNCOBJ_TIMELINE)) {
516 ret = -EOPNOTSUPP;
517 break;
518 }
519
520 if (syncobj_desc.flags & ~MSM_SUBMIT_SYNCOBJ_FLAGS) {
521 ret = -EINVAL;
522 break;
523 }
524
525 ret = drm_sched_job_add_syncobj_dependency(&submit->base, file,
526 syncobj_desc.handle, syncobj_desc.point);
527 if (ret)
528 break;
529
530 if (syncobj_desc.flags & MSM_SUBMIT_SYNCOBJ_RESET) {
531 syncobjs[i] =
532 drm_syncobj_find(file, syncobj_desc.handle);
533 if (!syncobjs[i]) {
534 ret = -EINVAL;
535 break;
536 }
537 }
538 }
539
540 if (ret) {
541 for (j = 0; j <= i; ++j) {
542 if (syncobjs[j])
543 drm_syncobj_put(syncobjs[j]);
544 }
545 kfree(syncobjs);
546 return ERR_PTR(ret);
547 }
548 return syncobjs;
549}
550
551static void msm_reset_syncobjs(struct drm_syncobj **syncobjs,
552 uint32_t nr_syncobjs)
553{
554 uint32_t i;
555
556 for (i = 0; syncobjs && i < nr_syncobjs; ++i) {
557 if (syncobjs[i])
558 drm_syncobj_replace_fence(syncobjs[i], NULL);
559 }
560}
561
562static struct msm_submit_post_dep *msm_parse_post_deps(struct drm_device *dev,
563 struct drm_file *file,
564 uint64_t syncobjs_addr,
565 uint32_t nr_syncobjs,
566 size_t syncobj_stride)
567{
568 struct msm_submit_post_dep *post_deps;
569 struct drm_msm_gem_submit_syncobj syncobj_desc = {0};
570 int ret = 0;
571 uint32_t i, j;
572
573 post_deps = kcalloc(nr_syncobjs, sizeof(*post_deps),
574 GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
575 if (!post_deps)
576 return ERR_PTR(-ENOMEM);
577
578 for (i = 0; i < nr_syncobjs; ++i) {
579 uint64_t address = syncobjs_addr + i * syncobj_stride;
580
581 if (copy_from_user(&syncobj_desc,
582 u64_to_user_ptr(address),
583 min(syncobj_stride, sizeof(syncobj_desc)))) {
584 ret = -EFAULT;
585 break;
586 }
587
588 post_deps[i].point = syncobj_desc.point;
589
590 if (syncobj_desc.flags) {
591 ret = -EINVAL;
592 break;
593 }
594
595 if (syncobj_desc.point) {
596 if (!drm_core_check_feature(dev,
597 DRIVER_SYNCOBJ_TIMELINE)) {
598 ret = -EOPNOTSUPP;
599 break;
600 }
601
602 post_deps[i].chain = dma_fence_chain_alloc();
603 if (!post_deps[i].chain) {
604 ret = -ENOMEM;
605 break;
606 }
607 }
608
609 post_deps[i].syncobj =
610 drm_syncobj_find(file, syncobj_desc.handle);
611 if (!post_deps[i].syncobj) {
612 ret = -EINVAL;
613 break;
614 }
615 }
616
617 if (ret) {
618 for (j = 0; j <= i; ++j) {
619 dma_fence_chain_free(post_deps[j].chain);
620 if (post_deps[j].syncobj)
621 drm_syncobj_put(post_deps[j].syncobj);
622 }
623
624 kfree(post_deps);
625 return ERR_PTR(ret);
626 }
627
628 return post_deps;
629}
630
631static void msm_process_post_deps(struct msm_submit_post_dep *post_deps,
632 uint32_t count, struct dma_fence *fence)
633{
634 uint32_t i;
635
636 for (i = 0; post_deps && i < count; ++i) {
637 if (post_deps[i].chain) {
638 drm_syncobj_add_point(post_deps[i].syncobj,
639 post_deps[i].chain,
640 fence, post_deps[i].point);
641 post_deps[i].chain = NULL;
642 } else {
643 drm_syncobj_replace_fence(post_deps[i].syncobj,
644 fence);
645 }
646 }
647}
648
649int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
650 struct drm_file *file)
651{
652 struct msm_drm_private *priv = dev->dev_private;
653 struct drm_msm_gem_submit *args = data;
654 struct msm_file_private *ctx = file->driver_priv;
655 struct msm_gem_submit *submit = NULL;
656 struct msm_gpu *gpu = priv->gpu;
657 struct msm_gpu_submitqueue *queue;
658 struct msm_ringbuffer *ring;
659 struct msm_submit_post_dep *post_deps = NULL;
660 struct drm_syncobj **syncobjs_to_reset = NULL;
661 int out_fence_fd = -1;
662 unsigned i;
663 int ret;
664
665 if (!gpu)
666 return -ENXIO;
667
668 if (args->pad)
669 return -EINVAL;
670
671 if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) {
672 DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n");
673 return -EPERM;
674 }
675
676 /* for now, we just have 3d pipe.. eventually this would need to
677 * be more clever to dispatch to appropriate gpu module:
678 */
679 if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
680 return -EINVAL;
681
682 if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
683 return -EINVAL;
684
685 if (args->flags & MSM_SUBMIT_SUDO) {
686 if (!IS_ENABLED(CONFIG_DRM_MSM_GPU_SUDO) ||
687 !capable(CAP_SYS_RAWIO))
688 return -EINVAL;
689 }
690
691 queue = msm_submitqueue_get(ctx, args->queueid);
692 if (!queue)
693 return -ENOENT;
694
695 ring = gpu->rb[queue->ring_nr];
696
697 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
698 out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
699 if (out_fence_fd < 0) {
700 ret = out_fence_fd;
701 goto out_post_unlock;
702 }
703 }
704
705 submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds);
706 if (IS_ERR(submit)) {
707 ret = PTR_ERR(submit);
708 goto out_post_unlock;
709 }
710
711 trace_msm_gpu_submit(pid_nr(submit->pid), ring->id, submit->ident,
712 args->nr_bos, args->nr_cmds);
713
714 ret = mutex_lock_interruptible(&queue->lock);
715 if (ret)
716 goto out_post_unlock;
717
718 if (args->flags & MSM_SUBMIT_SUDO)
719 submit->in_rb = true;
720
721 if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
722 struct dma_fence *in_fence;
723
724 in_fence = sync_file_get_fence(args->fence_fd);
725
726 if (!in_fence) {
727 ret = -EINVAL;
728 goto out_unlock;
729 }
730
731 ret = drm_sched_job_add_dependency(&submit->base, in_fence);
732 if (ret)
733 goto out_unlock;
734 }
735
736 if (args->flags & MSM_SUBMIT_SYNCOBJ_IN) {
737 syncobjs_to_reset = msm_parse_deps(submit, file,
738 args->in_syncobjs,
739 args->nr_in_syncobjs,
740 args->syncobj_stride);
741 if (IS_ERR(syncobjs_to_reset)) {
742 ret = PTR_ERR(syncobjs_to_reset);
743 goto out_unlock;
744 }
745 }
746
747 if (args->flags & MSM_SUBMIT_SYNCOBJ_OUT) {
748 post_deps = msm_parse_post_deps(dev, file,
749 args->out_syncobjs,
750 args->nr_out_syncobjs,
751 args->syncobj_stride);
752 if (IS_ERR(post_deps)) {
753 ret = PTR_ERR(post_deps);
754 goto out_unlock;
755 }
756 }
757
758 ret = submit_lookup_objects(submit, args, file);
759 if (ret)
760 goto out;
761
762 ret = submit_lookup_cmds(submit, args, file);
763 if (ret)
764 goto out;
765
766 /* copy_*_user while holding a ww ticket upsets lockdep */
767 ret = submit_lock_objects(submit);
768 if (ret)
769 goto out;
770
771 if (!(args->flags & MSM_SUBMIT_NO_IMPLICIT)) {
772 ret = submit_fence_sync(submit);
773 if (ret)
774 goto out;
775 }
776
777 ret = submit_pin_objects(submit);
778 if (ret)
779 goto out;
780
781 for (i = 0; i < args->nr_cmds; i++) {
782 struct drm_gem_object *obj;
783 uint64_t iova;
784
785 ret = submit_bo(submit, submit->cmd[i].idx, &obj, &iova);
786 if (ret)
787 goto out;
788
789 if (!submit->cmd[i].size ||
790 (size_add(submit->cmd[i].size, submit->cmd[i].offset) > obj->size / 4)) {
791 SUBMIT_ERROR(submit, "invalid cmdstream size: %u\n", submit->cmd[i].size * 4);
792 ret = -EINVAL;
793 goto out;
794 }
795
796 submit->cmd[i].iova = iova + (submit->cmd[i].offset * 4);
797
798 if (likely(!submit->cmd[i].nr_relocs))
799 continue;
800
801 if (!gpu->allow_relocs) {
802 SUBMIT_ERROR(submit, "relocs not allowed\n");
803 ret = -EINVAL;
804 goto out;
805 }
806
807 ret = submit_reloc(submit, obj, submit->cmd[i].offset * 4,
808 submit->cmd[i].nr_relocs, submit->cmd[i].relocs);
809 if (ret)
810 goto out;
811 }
812
813 submit->nr_cmds = i;
814
815 idr_preload(GFP_KERNEL);
816
817 spin_lock(&queue->idr_lock);
818
819 /*
820 * If using userspace provided seqno fence, validate that the id
821 * is available before arming sched job. Since access to fence_idr
822 * is serialized on the queue lock, the slot should be still avail
823 * after the job is armed
824 */
825 if ((args->flags & MSM_SUBMIT_FENCE_SN_IN) &&
826 (!args->fence || idr_find(&queue->fence_idr, args->fence))) {
827 spin_unlock(&queue->idr_lock);
828 idr_preload_end();
829 ret = -EINVAL;
830 goto out;
831 }
832
833 drm_sched_job_arm(&submit->base);
834
835 submit->user_fence = dma_fence_get(&submit->base.s_fence->finished);
836
837 if (args->flags & MSM_SUBMIT_FENCE_SN_IN) {
838 /*
839 * Userspace has assigned the seqno fence that it wants
840 * us to use. It is an error to pick a fence sequence
841 * number that is not available.
842 */
843 submit->fence_id = args->fence;
844 ret = idr_alloc_u32(&queue->fence_idr, submit->user_fence,
845 &submit->fence_id, submit->fence_id,
846 GFP_NOWAIT);
847 /*
848 * We've already validated that the fence_id slot is valid,
849 * so if idr_alloc_u32 failed, it is a kernel bug
850 */
851 WARN_ON(ret);
852 } else {
853 /*
854 * Allocate an id which can be used by WAIT_FENCE ioctl to map
855 * back to the underlying fence.
856 */
857 submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
858 submit->user_fence, 1,
859 INT_MAX, GFP_NOWAIT);
860 }
861
862 spin_unlock(&queue->idr_lock);
863 idr_preload_end();
864
865 if (submit->fence_id < 0) {
866 ret = submit->fence_id;
867 submit->fence_id = 0;
868 }
869
870 if (ret == 0 && args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
871 struct sync_file *sync_file = sync_file_create(submit->user_fence);
872 if (!sync_file) {
873 ret = -ENOMEM;
874 } else {
875 fd_install(out_fence_fd, sync_file->file);
876 args->fence_fd = out_fence_fd;
877 }
878 }
879
880 if (ret)
881 goto out;
882
883 submit_attach_object_fences(submit);
884
885 /* The scheduler owns a ref now: */
886 msm_gem_submit_get(submit);
887
888 msm_rd_dump_submit(priv->rd, submit, NULL);
889
890 drm_sched_entity_push_job(&submit->base);
891
892 args->fence = submit->fence_id;
893 queue->last_fence = submit->fence_id;
894
895 msm_reset_syncobjs(syncobjs_to_reset, args->nr_in_syncobjs);
896 msm_process_post_deps(post_deps, args->nr_out_syncobjs,
897 submit->user_fence);
898
899
900out:
901 submit_cleanup(submit, !!ret);
902out_unlock:
903 mutex_unlock(&queue->lock);
904out_post_unlock:
905 if (ret && (out_fence_fd >= 0))
906 put_unused_fd(out_fence_fd);
907
908 if (!IS_ERR_OR_NULL(submit)) {
909 msm_gem_submit_put(submit);
910 } else {
911 /*
912 * If the submit hasn't yet taken ownership of the queue
913 * then we need to drop the reference ourself:
914 */
915 msm_submitqueue_put(queue);
916 }
917 if (!IS_ERR_OR_NULL(post_deps)) {
918 for (i = 0; i < args->nr_out_syncobjs; ++i) {
919 kfree(post_deps[i].chain);
920 drm_syncobj_put(post_deps[i].syncobj);
921 }
922 kfree(post_deps);
923 }
924
925 if (!IS_ERR_OR_NULL(syncobjs_to_reset)) {
926 for (i = 0; i < args->nr_in_syncobjs; ++i) {
927 if (syncobjs_to_reset[i])
928 drm_syncobj_put(syncobjs_to_reset[i]);
929 }
930 kfree(syncobjs_to_reset);
931 }
932
933 return ret;
934}
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2013 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 */
6
7#include <linux/file.h>
8#include <linux/sync_file.h>
9#include <linux/uaccess.h>
10
11#include <drm/drm_file.h>
12
13#include "msm_drv.h"
14#include "msm_gpu.h"
15#include "msm_gem.h"
16#include "msm_gpu_trace.h"
17
18/*
19 * Cmdstream submission:
20 */
21
22/* make sure these don't conflict w/ MSM_SUBMIT_BO_x */
23#define BO_VALID 0x8000 /* is current addr in cmdstream correct/valid? */
24#define BO_LOCKED 0x4000
25#define BO_PINNED 0x2000
26
27static struct msm_gem_submit *submit_create(struct drm_device *dev,
28 struct msm_gpu *gpu, struct msm_gem_address_space *aspace,
29 struct msm_gpu_submitqueue *queue, uint32_t nr_bos,
30 uint32_t nr_cmds)
31{
32 struct msm_gem_submit *submit;
33 uint64_t sz = struct_size(submit, bos, nr_bos) +
34 ((u64)nr_cmds * sizeof(submit->cmd[0]));
35
36 if (sz > SIZE_MAX)
37 return NULL;
38
39 submit = kmalloc(sz, GFP_KERNEL | __GFP_NOWARN | __GFP_NORETRY);
40 if (!submit)
41 return NULL;
42
43 submit->dev = dev;
44 submit->aspace = aspace;
45 submit->gpu = gpu;
46 submit->fence = NULL;
47 submit->cmd = (void *)&submit->bos[nr_bos];
48 submit->queue = queue;
49 submit->ring = gpu->rb[queue->prio];
50
51 /* initially, until copy_from_user() and bo lookup succeeds: */
52 submit->nr_bos = 0;
53 submit->nr_cmds = 0;
54
55 INIT_LIST_HEAD(&submit->node);
56 INIT_LIST_HEAD(&submit->bo_list);
57 ww_acquire_init(&submit->ticket, &reservation_ww_class);
58
59 return submit;
60}
61
62void msm_gem_submit_free(struct msm_gem_submit *submit)
63{
64 dma_fence_put(submit->fence);
65 list_del(&submit->node);
66 put_pid(submit->pid);
67 msm_submitqueue_put(submit->queue);
68
69 kfree(submit);
70}
71
72static int submit_lookup_objects(struct msm_gem_submit *submit,
73 struct drm_msm_gem_submit *args, struct drm_file *file)
74{
75 unsigned i;
76 int ret = 0;
77
78 for (i = 0; i < args->nr_bos; i++) {
79 struct drm_msm_gem_submit_bo submit_bo;
80 void __user *userptr =
81 u64_to_user_ptr(args->bos + (i * sizeof(submit_bo)));
82
83 /* make sure we don't have garbage flags, in case we hit
84 * error path before flags is initialized:
85 */
86 submit->bos[i].flags = 0;
87
88 if (copy_from_user(&submit_bo, userptr, sizeof(submit_bo))) {
89 ret = -EFAULT;
90 i = 0;
91 goto out;
92 }
93
94/* at least one of READ and/or WRITE flags should be set: */
95#define MANDATORY_FLAGS (MSM_SUBMIT_BO_READ | MSM_SUBMIT_BO_WRITE)
96
97 if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) ||
98 !(submit_bo.flags & MANDATORY_FLAGS)) {
99 DRM_ERROR("invalid flags: %x\n", submit_bo.flags);
100 ret = -EINVAL;
101 i = 0;
102 goto out;
103 }
104
105 submit->bos[i].handle = submit_bo.handle;
106 submit->bos[i].flags = submit_bo.flags;
107 /* in validate_objects() we figure out if this is true: */
108 submit->bos[i].iova = submit_bo.presumed;
109 }
110
111 spin_lock(&file->table_lock);
112
113 for (i = 0; i < args->nr_bos; i++) {
114 struct drm_gem_object *obj;
115 struct msm_gem_object *msm_obj;
116
117 /* normally use drm_gem_object_lookup(), but for bulk lookup
118 * all under single table_lock just hit object_idr directly:
119 */
120 obj = idr_find(&file->object_idr, submit->bos[i].handle);
121 if (!obj) {
122 DRM_ERROR("invalid handle %u at index %u\n", submit->bos[i].handle, i);
123 ret = -EINVAL;
124 goto out_unlock;
125 }
126
127 msm_obj = to_msm_bo(obj);
128
129 if (!list_empty(&msm_obj->submit_entry)) {
130 DRM_ERROR("handle %u at index %u already on submit list\n",
131 submit->bos[i].handle, i);
132 ret = -EINVAL;
133 goto out_unlock;
134 }
135
136 drm_gem_object_get(obj);
137
138 submit->bos[i].obj = msm_obj;
139
140 list_add_tail(&msm_obj->submit_entry, &submit->bo_list);
141 }
142
143out_unlock:
144 spin_unlock(&file->table_lock);
145
146out:
147 submit->nr_bos = i;
148
149 return ret;
150}
151
152static void submit_unlock_unpin_bo(struct msm_gem_submit *submit,
153 int i, bool backoff)
154{
155 struct msm_gem_object *msm_obj = submit->bos[i].obj;
156
157 if (submit->bos[i].flags & BO_PINNED)
158 msm_gem_unpin_iova(&msm_obj->base, submit->aspace);
159
160 if (submit->bos[i].flags & BO_LOCKED)
161 ww_mutex_unlock(&msm_obj->base.resv->lock);
162
163 if (backoff && !(submit->bos[i].flags & BO_VALID))
164 submit->bos[i].iova = 0;
165
166 submit->bos[i].flags &= ~(BO_LOCKED | BO_PINNED);
167}
168
169/* This is where we make sure all the bo's are reserved and pin'd: */
170static int submit_lock_objects(struct msm_gem_submit *submit)
171{
172 int contended, slow_locked = -1, i, ret = 0;
173
174retry:
175 for (i = 0; i < submit->nr_bos; i++) {
176 struct msm_gem_object *msm_obj = submit->bos[i].obj;
177
178 if (slow_locked == i)
179 slow_locked = -1;
180
181 contended = i;
182
183 if (!(submit->bos[i].flags & BO_LOCKED)) {
184 ret = ww_mutex_lock_interruptible(&msm_obj->base.resv->lock,
185 &submit->ticket);
186 if (ret)
187 goto fail;
188 submit->bos[i].flags |= BO_LOCKED;
189 }
190 }
191
192 ww_acquire_done(&submit->ticket);
193
194 return 0;
195
196fail:
197 for (; i >= 0; i--)
198 submit_unlock_unpin_bo(submit, i, true);
199
200 if (slow_locked > 0)
201 submit_unlock_unpin_bo(submit, slow_locked, true);
202
203 if (ret == -EDEADLK) {
204 struct msm_gem_object *msm_obj = submit->bos[contended].obj;
205 /* we lost out in a seqno race, lock and retry.. */
206 ret = ww_mutex_lock_slow_interruptible(&msm_obj->base.resv->lock,
207 &submit->ticket);
208 if (!ret) {
209 submit->bos[contended].flags |= BO_LOCKED;
210 slow_locked = contended;
211 goto retry;
212 }
213 }
214
215 return ret;
216}
217
218static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit)
219{
220 int i, ret = 0;
221
222 for (i = 0; i < submit->nr_bos; i++) {
223 struct msm_gem_object *msm_obj = submit->bos[i].obj;
224 bool write = submit->bos[i].flags & MSM_SUBMIT_BO_WRITE;
225
226 if (!write) {
227 /* NOTE: _reserve_shared() must happen before
228 * _add_shared_fence(), which makes this a slightly
229 * strange place to call it. OTOH this is a
230 * convenient can-fail point to hook it in.
231 */
232 ret = dma_resv_reserve_shared(msm_obj->base.resv,
233 1);
234 if (ret)
235 return ret;
236 }
237
238 if (no_implicit)
239 continue;
240
241 ret = msm_gem_sync_object(&msm_obj->base, submit->ring->fctx,
242 write);
243 if (ret)
244 break;
245 }
246
247 return ret;
248}
249
250static int submit_pin_objects(struct msm_gem_submit *submit)
251{
252 int i, ret = 0;
253
254 submit->valid = true;
255
256 for (i = 0; i < submit->nr_bos; i++) {
257 struct msm_gem_object *msm_obj = submit->bos[i].obj;
258 uint64_t iova;
259
260 /* if locking succeeded, pin bo: */
261 ret = msm_gem_get_and_pin_iova(&msm_obj->base,
262 submit->aspace, &iova);
263
264 if (ret)
265 break;
266
267 submit->bos[i].flags |= BO_PINNED;
268
269 if (iova == submit->bos[i].iova) {
270 submit->bos[i].flags |= BO_VALID;
271 } else {
272 submit->bos[i].iova = iova;
273 /* iova changed, so address in cmdstream is not valid: */
274 submit->bos[i].flags &= ~BO_VALID;
275 submit->valid = false;
276 }
277 }
278
279 return ret;
280}
281
282static int submit_bo(struct msm_gem_submit *submit, uint32_t idx,
283 struct msm_gem_object **obj, uint64_t *iova, bool *valid)
284{
285 if (idx >= submit->nr_bos) {
286 DRM_ERROR("invalid buffer index: %u (out of %u)\n",
287 idx, submit->nr_bos);
288 return -EINVAL;
289 }
290
291 if (obj)
292 *obj = submit->bos[idx].obj;
293 if (iova)
294 *iova = submit->bos[idx].iova;
295 if (valid)
296 *valid = !!(submit->bos[idx].flags & BO_VALID);
297
298 return 0;
299}
300
301/* process the reloc's and patch up the cmdstream as needed: */
302static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obj,
303 uint32_t offset, uint32_t nr_relocs, uint64_t relocs)
304{
305 uint32_t i, last_offset = 0;
306 uint32_t *ptr;
307 int ret = 0;
308
309 if (!nr_relocs)
310 return 0;
311
312 if (offset % 4) {
313 DRM_ERROR("non-aligned cmdstream buffer: %u\n", offset);
314 return -EINVAL;
315 }
316
317 /* For now, just map the entire thing. Eventually we probably
318 * to do it page-by-page, w/ kmap() if not vmap()d..
319 */
320 ptr = msm_gem_get_vaddr(&obj->base);
321
322 if (IS_ERR(ptr)) {
323 ret = PTR_ERR(ptr);
324 DBG("failed to map: %d", ret);
325 return ret;
326 }
327
328 for (i = 0; i < nr_relocs; i++) {
329 struct drm_msm_gem_submit_reloc submit_reloc;
330 void __user *userptr =
331 u64_to_user_ptr(relocs + (i * sizeof(submit_reloc)));
332 uint32_t off;
333 uint64_t iova;
334 bool valid;
335
336 if (copy_from_user(&submit_reloc, userptr, sizeof(submit_reloc))) {
337 ret = -EFAULT;
338 goto out;
339 }
340
341 if (submit_reloc.submit_offset % 4) {
342 DRM_ERROR("non-aligned reloc offset: %u\n",
343 submit_reloc.submit_offset);
344 ret = -EINVAL;
345 goto out;
346 }
347
348 /* offset in dwords: */
349 off = submit_reloc.submit_offset / 4;
350
351 if ((off >= (obj->base.size / 4)) ||
352 (off < last_offset)) {
353 DRM_ERROR("invalid offset %u at reloc %u\n", off, i);
354 ret = -EINVAL;
355 goto out;
356 }
357
358 ret = submit_bo(submit, submit_reloc.reloc_idx, NULL, &iova, &valid);
359 if (ret)
360 goto out;
361
362 if (valid)
363 continue;
364
365 iova += submit_reloc.reloc_offset;
366
367 if (submit_reloc.shift < 0)
368 iova >>= -submit_reloc.shift;
369 else
370 iova <<= submit_reloc.shift;
371
372 ptr[off] = iova | submit_reloc.or;
373
374 last_offset = off;
375 }
376
377out:
378 msm_gem_put_vaddr(&obj->base);
379
380 return ret;
381}
382
383static void submit_cleanup(struct msm_gem_submit *submit)
384{
385 unsigned i;
386
387 for (i = 0; i < submit->nr_bos; i++) {
388 struct msm_gem_object *msm_obj = submit->bos[i].obj;
389 submit_unlock_unpin_bo(submit, i, false);
390 list_del_init(&msm_obj->submit_entry);
391 drm_gem_object_put(&msm_obj->base);
392 }
393
394 ww_acquire_fini(&submit->ticket);
395}
396
397int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
398 struct drm_file *file)
399{
400 static atomic_t ident = ATOMIC_INIT(0);
401 struct msm_drm_private *priv = dev->dev_private;
402 struct drm_msm_gem_submit *args = data;
403 struct msm_file_private *ctx = file->driver_priv;
404 struct msm_gem_submit *submit;
405 struct msm_gpu *gpu = priv->gpu;
406 struct sync_file *sync_file = NULL;
407 struct msm_gpu_submitqueue *queue;
408 struct msm_ringbuffer *ring;
409 int out_fence_fd = -1;
410 struct pid *pid = get_pid(task_pid(current));
411 unsigned i;
412 int ret, submitid;
413 if (!gpu)
414 return -ENXIO;
415
416 /* for now, we just have 3d pipe.. eventually this would need to
417 * be more clever to dispatch to appropriate gpu module:
418 */
419 if (MSM_PIPE_ID(args->flags) != MSM_PIPE_3D0)
420 return -EINVAL;
421
422 if (MSM_PIPE_FLAGS(args->flags) & ~MSM_SUBMIT_FLAGS)
423 return -EINVAL;
424
425 if (args->flags & MSM_SUBMIT_SUDO) {
426 if (!IS_ENABLED(CONFIG_DRM_MSM_GPU_SUDO) ||
427 !capable(CAP_SYS_RAWIO))
428 return -EINVAL;
429 }
430
431 queue = msm_submitqueue_get(ctx, args->queueid);
432 if (!queue)
433 return -ENOENT;
434
435 /* Get a unique identifier for the submission for logging purposes */
436 submitid = atomic_inc_return(&ident) - 1;
437
438 ring = gpu->rb[queue->prio];
439 trace_msm_gpu_submit(pid_nr(pid), ring->id, submitid,
440 args->nr_bos, args->nr_cmds);
441
442 if (args->flags & MSM_SUBMIT_FENCE_FD_IN) {
443 struct dma_fence *in_fence;
444
445 in_fence = sync_file_get_fence(args->fence_fd);
446
447 if (!in_fence)
448 return -EINVAL;
449
450 /*
451 * Wait if the fence is from a foreign context, or if the fence
452 * array contains any fence from a foreign context.
453 */
454 ret = 0;
455 if (!dma_fence_match_context(in_fence, ring->fctx->context))
456 ret = dma_fence_wait(in_fence, true);
457
458 dma_fence_put(in_fence);
459 if (ret)
460 return ret;
461 }
462
463 ret = mutex_lock_interruptible(&dev->struct_mutex);
464 if (ret)
465 return ret;
466
467 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
468 out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
469 if (out_fence_fd < 0) {
470 ret = out_fence_fd;
471 goto out_unlock;
472 }
473 }
474
475 submit = submit_create(dev, gpu, ctx->aspace, queue, args->nr_bos,
476 args->nr_cmds);
477 if (!submit) {
478 ret = -ENOMEM;
479 goto out_unlock;
480 }
481
482 submit->pid = pid;
483 submit->ident = submitid;
484
485 if (args->flags & MSM_SUBMIT_SUDO)
486 submit->in_rb = true;
487
488 ret = submit_lookup_objects(submit, args, file);
489 if (ret)
490 goto out;
491
492 ret = submit_lock_objects(submit);
493 if (ret)
494 goto out;
495
496 ret = submit_fence_sync(submit, !!(args->flags & MSM_SUBMIT_NO_IMPLICIT));
497 if (ret)
498 goto out;
499
500 ret = submit_pin_objects(submit);
501 if (ret)
502 goto out;
503
504 for (i = 0; i < args->nr_cmds; i++) {
505 struct drm_msm_gem_submit_cmd submit_cmd;
506 void __user *userptr =
507 u64_to_user_ptr(args->cmds + (i * sizeof(submit_cmd)));
508 struct msm_gem_object *msm_obj;
509 uint64_t iova;
510
511 ret = copy_from_user(&submit_cmd, userptr, sizeof(submit_cmd));
512 if (ret) {
513 ret = -EFAULT;
514 goto out;
515 }
516
517 /* validate input from userspace: */
518 switch (submit_cmd.type) {
519 case MSM_SUBMIT_CMD_BUF:
520 case MSM_SUBMIT_CMD_IB_TARGET_BUF:
521 case MSM_SUBMIT_CMD_CTX_RESTORE_BUF:
522 break;
523 default:
524 DRM_ERROR("invalid type: %08x\n", submit_cmd.type);
525 ret = -EINVAL;
526 goto out;
527 }
528
529 ret = submit_bo(submit, submit_cmd.submit_idx,
530 &msm_obj, &iova, NULL);
531 if (ret)
532 goto out;
533
534 if (submit_cmd.size % 4) {
535 DRM_ERROR("non-aligned cmdstream buffer size: %u\n",
536 submit_cmd.size);
537 ret = -EINVAL;
538 goto out;
539 }
540
541 if (!submit_cmd.size ||
542 ((submit_cmd.size + submit_cmd.submit_offset) >
543 msm_obj->base.size)) {
544 DRM_ERROR("invalid cmdstream size: %u\n", submit_cmd.size);
545 ret = -EINVAL;
546 goto out;
547 }
548
549 submit->cmd[i].type = submit_cmd.type;
550 submit->cmd[i].size = submit_cmd.size / 4;
551 submit->cmd[i].iova = iova + submit_cmd.submit_offset;
552 submit->cmd[i].idx = submit_cmd.submit_idx;
553
554 if (submit->valid)
555 continue;
556
557 ret = submit_reloc(submit, msm_obj, submit_cmd.submit_offset,
558 submit_cmd.nr_relocs, submit_cmd.relocs);
559 if (ret)
560 goto out;
561 }
562
563 submit->nr_cmds = i;
564
565 submit->fence = msm_fence_alloc(ring->fctx);
566 if (IS_ERR(submit->fence)) {
567 ret = PTR_ERR(submit->fence);
568 submit->fence = NULL;
569 goto out;
570 }
571
572 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
573 sync_file = sync_file_create(submit->fence);
574 if (!sync_file) {
575 ret = -ENOMEM;
576 goto out;
577 }
578 }
579
580 msm_gpu_submit(gpu, submit, ctx);
581
582 args->fence = submit->fence->seqno;
583
584 if (args->flags & MSM_SUBMIT_FENCE_FD_OUT) {
585 fd_install(out_fence_fd, sync_file->file);
586 args->fence_fd = out_fence_fd;
587 }
588
589out:
590 submit_cleanup(submit);
591 if (ret)
592 msm_gem_submit_free(submit);
593out_unlock:
594 if (ret && (out_fence_fd >= 0))
595 put_unused_fd(out_fence_fd);
596 mutex_unlock(&dev->struct_mutex);
597 return ret;
598}