Loading...
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2014 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 */
6
7#include <drm/drm_atomic_uapi.h>
8#include <drm/drm_vblank.h>
9
10#include "msm_atomic_trace.h"
11#include "msm_drv.h"
12#include "msm_gem.h"
13#include "msm_kms.h"
14
15/*
16 * Helpers to control vblanks while we flush.. basically just to ensure
17 * that vblank accounting is switched on, so we get valid seqn/timestamp
18 * on pageflip events (if requested)
19 */
20
21static void vblank_get(struct msm_kms *kms, unsigned crtc_mask)
22{
23 struct drm_crtc *crtc;
24
25 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
26 if (!crtc->state->active)
27 continue;
28 drm_crtc_vblank_get(crtc);
29 }
30}
31
32static void vblank_put(struct msm_kms *kms, unsigned crtc_mask)
33{
34 struct drm_crtc *crtc;
35
36 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
37 if (!crtc->state->active)
38 continue;
39 drm_crtc_vblank_put(crtc);
40 }
41}
42
43static void lock_crtcs(struct msm_kms *kms, unsigned int crtc_mask)
44{
45 int crtc_index;
46 struct drm_crtc *crtc;
47
48 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
49 crtc_index = drm_crtc_index(crtc);
50 mutex_lock_nested(&kms->commit_lock[crtc_index], crtc_index);
51 }
52}
53
54static void unlock_crtcs(struct msm_kms *kms, unsigned int crtc_mask)
55{
56 struct drm_crtc *crtc;
57
58 for_each_crtc_mask_reverse(kms->dev, crtc, crtc_mask)
59 mutex_unlock(&kms->commit_lock[drm_crtc_index(crtc)]);
60}
61
62static void msm_atomic_async_commit(struct msm_kms *kms, int crtc_idx)
63{
64 unsigned crtc_mask = BIT(crtc_idx);
65
66 trace_msm_atomic_async_commit_start(crtc_mask);
67
68 lock_crtcs(kms, crtc_mask);
69
70 if (!(kms->pending_crtc_mask & crtc_mask)) {
71 unlock_crtcs(kms, crtc_mask);
72 goto out;
73 }
74
75 kms->pending_crtc_mask &= ~crtc_mask;
76
77 kms->funcs->enable_commit(kms);
78
79 vblank_get(kms, crtc_mask);
80
81 /*
82 * Flush hardware updates:
83 */
84 trace_msm_atomic_flush_commit(crtc_mask);
85 kms->funcs->flush_commit(kms, crtc_mask);
86
87 /*
88 * Wait for flush to complete:
89 */
90 trace_msm_atomic_wait_flush_start(crtc_mask);
91 kms->funcs->wait_flush(kms, crtc_mask);
92 trace_msm_atomic_wait_flush_finish(crtc_mask);
93
94 vblank_put(kms, crtc_mask);
95
96 kms->funcs->complete_commit(kms, crtc_mask);
97 unlock_crtcs(kms, crtc_mask);
98 kms->funcs->disable_commit(kms);
99
100out:
101 trace_msm_atomic_async_commit_finish(crtc_mask);
102}
103
104static void msm_atomic_pending_work(struct kthread_work *work)
105{
106 struct msm_pending_timer *timer = container_of(work,
107 struct msm_pending_timer, work.work);
108
109 msm_atomic_async_commit(timer->kms, timer->crtc_idx);
110}
111
112int msm_atomic_init_pending_timer(struct msm_pending_timer *timer,
113 struct msm_kms *kms, int crtc_idx)
114{
115 timer->kms = kms;
116 timer->crtc_idx = crtc_idx;
117
118 timer->worker = kthread_create_worker(0, "atomic-worker-%d", crtc_idx);
119 if (IS_ERR(timer->worker)) {
120 int ret = PTR_ERR(timer->worker);
121 timer->worker = NULL;
122 return ret;
123 }
124 sched_set_fifo(timer->worker->task);
125
126 msm_hrtimer_work_init(&timer->work, timer->worker,
127 msm_atomic_pending_work,
128 CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
129
130 return 0;
131}
132
133void msm_atomic_destroy_pending_timer(struct msm_pending_timer *timer)
134{
135 if (timer->worker)
136 kthread_destroy_worker(timer->worker);
137}
138
139static bool can_do_async(struct drm_atomic_state *state,
140 struct drm_crtc **async_crtc)
141{
142 struct drm_connector_state *connector_state;
143 struct drm_connector *connector;
144 struct drm_crtc_state *crtc_state;
145 struct drm_crtc *crtc;
146 int i, num_crtcs = 0;
147
148 if (!(state->legacy_cursor_update || state->async_update))
149 return false;
150
151 /* any connector change, means slow path: */
152 for_each_new_connector_in_state(state, connector, connector_state, i)
153 return false;
154
155 for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
156 if (drm_atomic_crtc_needs_modeset(crtc_state))
157 return false;
158 if (!crtc_state->active)
159 return false;
160 if (++num_crtcs > 1)
161 return false;
162 *async_crtc = crtc;
163 }
164
165 return true;
166}
167
168/* Get bitmask of crtcs that will need to be flushed. The bitmask
169 * can be used with for_each_crtc_mask() iterator, to iterate
170 * effected crtcs without needing to preserve the atomic state.
171 */
172static unsigned get_crtc_mask(struct drm_atomic_state *state)
173{
174 struct drm_crtc_state *crtc_state;
175 struct drm_crtc *crtc;
176 unsigned i, mask = 0;
177
178 for_each_new_crtc_in_state(state, crtc, crtc_state, i)
179 mask |= drm_crtc_mask(crtc);
180
181 return mask;
182}
183
184int msm_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
185{
186 struct drm_crtc_state *old_crtc_state, *new_crtc_state;
187 struct drm_crtc *crtc;
188 int i;
189
190 for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state,
191 new_crtc_state, i) {
192 if ((old_crtc_state->ctm && !new_crtc_state->ctm) ||
193 (!old_crtc_state->ctm && new_crtc_state->ctm)) {
194 new_crtc_state->mode_changed = true;
195 state->allow_modeset = true;
196 }
197 }
198
199 return drm_atomic_helper_check(dev, state);
200}
201
202void msm_atomic_commit_tail(struct drm_atomic_state *state)
203{
204 struct drm_device *dev = state->dev;
205 struct msm_drm_private *priv = dev->dev_private;
206 struct msm_kms *kms = priv->kms;
207 struct drm_crtc *async_crtc = NULL;
208 unsigned crtc_mask = get_crtc_mask(state);
209 bool async = can_do_async(state, &async_crtc);
210
211 trace_msm_atomic_commit_tail_start(async, crtc_mask);
212
213 kms->funcs->enable_commit(kms);
214
215 /*
216 * Ensure any previous (potentially async) commit has
217 * completed:
218 */
219 lock_crtcs(kms, crtc_mask);
220 trace_msm_atomic_wait_flush_start(crtc_mask);
221 kms->funcs->wait_flush(kms, crtc_mask);
222 trace_msm_atomic_wait_flush_finish(crtc_mask);
223
224 /*
225 * Now that there is no in-progress flush, prepare the
226 * current update:
227 */
228 if (kms->funcs->prepare_commit)
229 kms->funcs->prepare_commit(kms, state);
230
231 /*
232 * Push atomic updates down to hardware:
233 */
234 drm_atomic_helper_commit_modeset_disables(dev, state);
235 drm_atomic_helper_commit_planes(dev, state, 0);
236 drm_atomic_helper_commit_modeset_enables(dev, state);
237
238 if (async) {
239 struct msm_pending_timer *timer =
240 &kms->pending_timers[drm_crtc_index(async_crtc)];
241
242 /* async updates are limited to single-crtc updates: */
243 WARN_ON(crtc_mask != drm_crtc_mask(async_crtc));
244
245 /*
246 * Start timer if we don't already have an update pending
247 * on this crtc:
248 */
249 if (!(kms->pending_crtc_mask & crtc_mask)) {
250 ktime_t vsync_time, wakeup_time;
251
252 kms->pending_crtc_mask |= crtc_mask;
253
254 if (drm_crtc_next_vblank_start(async_crtc, &vsync_time))
255 goto fallback;
256
257 wakeup_time = ktime_sub(vsync_time, ms_to_ktime(1));
258
259 msm_hrtimer_queue_work(&timer->work, wakeup_time,
260 HRTIMER_MODE_ABS);
261 }
262
263 kms->funcs->disable_commit(kms);
264 unlock_crtcs(kms, crtc_mask);
265 /*
266 * At this point, from drm core's perspective, we
267 * are done with the atomic update, so we can just
268 * go ahead and signal that it is done:
269 */
270 drm_atomic_helper_commit_hw_done(state);
271 drm_atomic_helper_cleanup_planes(dev, state);
272
273 trace_msm_atomic_commit_tail_finish(async, crtc_mask);
274
275 return;
276 }
277
278fallback:
279 /*
280 * If there is any async flush pending on updated crtcs, fold
281 * them into the current flush.
282 */
283 kms->pending_crtc_mask &= ~crtc_mask;
284
285 vblank_get(kms, crtc_mask);
286
287 /*
288 * Flush hardware updates:
289 */
290 trace_msm_atomic_flush_commit(crtc_mask);
291 kms->funcs->flush_commit(kms, crtc_mask);
292 unlock_crtcs(kms, crtc_mask);
293 /*
294 * Wait for flush to complete:
295 */
296 trace_msm_atomic_wait_flush_start(crtc_mask);
297 kms->funcs->wait_flush(kms, crtc_mask);
298 trace_msm_atomic_wait_flush_finish(crtc_mask);
299
300 vblank_put(kms, crtc_mask);
301
302 lock_crtcs(kms, crtc_mask);
303 kms->funcs->complete_commit(kms, crtc_mask);
304 unlock_crtcs(kms, crtc_mask);
305 kms->funcs->disable_commit(kms);
306
307 drm_atomic_helper_commit_hw_done(state);
308 drm_atomic_helper_cleanup_planes(dev, state);
309
310 trace_msm_atomic_commit_tail_finish(async, crtc_mask);
311}
1/*
2 * Copyright (C) 2014 Red Hat
3 * Author: Rob Clark <robdclark@gmail.com>
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 *
9 * This program is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
12 * more details.
13 *
14 * You should have received a copy of the GNU General Public License along with
15 * this program. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18#include "msm_drv.h"
19#include "msm_kms.h"
20#include "msm_gem.h"
21#include "msm_fence.h"
22
23struct msm_commit {
24 struct drm_device *dev;
25 struct drm_atomic_state *state;
26 struct work_struct work;
27 uint32_t crtc_mask;
28};
29
30static void commit_worker(struct work_struct *work);
31
32/* block until specified crtcs are no longer pending update, and
33 * atomically mark them as pending update
34 */
35static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
36{
37 int ret;
38
39 spin_lock(&priv->pending_crtcs_event.lock);
40 ret = wait_event_interruptible_locked(priv->pending_crtcs_event,
41 !(priv->pending_crtcs & crtc_mask));
42 if (ret == 0) {
43 DBG("start: %08x", crtc_mask);
44 priv->pending_crtcs |= crtc_mask;
45 }
46 spin_unlock(&priv->pending_crtcs_event.lock);
47
48 return ret;
49}
50
51/* clear specified crtcs (no longer pending update)
52 */
53static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
54{
55 spin_lock(&priv->pending_crtcs_event.lock);
56 DBG("end: %08x", crtc_mask);
57 priv->pending_crtcs &= ~crtc_mask;
58 wake_up_all_locked(&priv->pending_crtcs_event);
59 spin_unlock(&priv->pending_crtcs_event.lock);
60}
61
62static struct msm_commit *commit_init(struct drm_atomic_state *state)
63{
64 struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL);
65
66 if (!c)
67 return NULL;
68
69 c->dev = state->dev;
70 c->state = state;
71
72 INIT_WORK(&c->work, commit_worker);
73
74 return c;
75}
76
77static void commit_destroy(struct msm_commit *c)
78{
79 end_atomic(c->dev->dev_private, c->crtc_mask);
80 kfree(c);
81}
82
83static void msm_atomic_wait_for_commit_done(struct drm_device *dev,
84 struct drm_atomic_state *old_state)
85{
86 struct drm_crtc *crtc;
87 struct drm_crtc_state *crtc_state;
88 struct msm_drm_private *priv = old_state->dev->dev_private;
89 struct msm_kms *kms = priv->kms;
90 int i;
91
92 for_each_crtc_in_state(old_state, crtc, crtc_state, i) {
93 if (!crtc->state->enable)
94 continue;
95
96 /* Legacy cursor ioctls are completely unsynced, and userspace
97 * relies on that (by doing tons of cursor updates). */
98 if (old_state->legacy_cursor_update)
99 continue;
100
101 kms->funcs->wait_for_crtc_commit_done(kms, crtc);
102 }
103}
104
105/* The (potentially) asynchronous part of the commit. At this point
106 * nothing can fail short of armageddon.
107 */
108static void complete_commit(struct msm_commit *c, bool async)
109{
110 struct drm_atomic_state *state = c->state;
111 struct drm_device *dev = state->dev;
112 struct msm_drm_private *priv = dev->dev_private;
113 struct msm_kms *kms = priv->kms;
114
115 drm_atomic_helper_wait_for_fences(dev, state, false);
116
117 kms->funcs->prepare_commit(kms, state);
118
119 drm_atomic_helper_commit_modeset_disables(dev, state);
120
121 drm_atomic_helper_commit_planes(dev, state, 0);
122
123 drm_atomic_helper_commit_modeset_enables(dev, state);
124
125 /* NOTE: _wait_for_vblanks() only waits for vblank on
126 * enabled CRTCs. So we end up faulting when disabling
127 * due to (potentially) unref'ing the outgoing fb's
128 * before the vblank when the disable has latched.
129 *
130 * But if it did wait on disabled (or newly disabled)
131 * CRTCs, that would be racy (ie. we could have missed
132 * the irq. We need some way to poll for pipe shut
133 * down. Or just live with occasionally hitting the
134 * timeout in the CRTC disable path (which really should
135 * not be critical path)
136 */
137
138 msm_atomic_wait_for_commit_done(dev, state);
139
140 drm_atomic_helper_cleanup_planes(dev, state);
141
142 kms->funcs->complete_commit(kms, state);
143
144 drm_atomic_state_put(state);
145
146 commit_destroy(c);
147}
148
149static void commit_worker(struct work_struct *work)
150{
151 complete_commit(container_of(work, struct msm_commit, work), true);
152}
153
154int msm_atomic_check(struct drm_device *dev,
155 struct drm_atomic_state *state)
156{
157 int ret;
158
159 /*
160 * msm ->atomic_check can update ->mode_changed for pixel format
161 * changes, hence must be run before we check the modeset changes.
162 */
163 ret = drm_atomic_helper_check_planes(dev, state);
164 if (ret)
165 return ret;
166
167 ret = drm_atomic_helper_check_modeset(dev, state);
168 if (ret)
169 return ret;
170
171 return ret;
172}
173
174/**
175 * drm_atomic_helper_commit - commit validated state object
176 * @dev: DRM device
177 * @state: the driver state object
178 * @nonblock: nonblocking commit
179 *
180 * This function commits a with drm_atomic_helper_check() pre-validated state
181 * object. This can still fail when e.g. the framebuffer reservation fails.
182 *
183 * RETURNS
184 * Zero for success or -errno.
185 */
186int msm_atomic_commit(struct drm_device *dev,
187 struct drm_atomic_state *state, bool nonblock)
188{
189 struct msm_drm_private *priv = dev->dev_private;
190 struct msm_commit *c;
191 struct drm_crtc *crtc;
192 struct drm_crtc_state *crtc_state;
193 struct drm_plane *plane;
194 struct drm_plane_state *plane_state;
195 int i, ret;
196
197 ret = drm_atomic_helper_prepare_planes(dev, state);
198 if (ret)
199 return ret;
200
201 c = commit_init(state);
202 if (!c) {
203 ret = -ENOMEM;
204 goto error;
205 }
206
207 /*
208 * Figure out what crtcs we have:
209 */
210 for_each_crtc_in_state(state, crtc, crtc_state, i)
211 c->crtc_mask |= drm_crtc_mask(crtc);
212
213 /*
214 * Figure out what fence to wait for:
215 */
216 for_each_plane_in_state(state, plane, plane_state, i) {
217 if ((plane->state->fb != plane_state->fb) && plane_state->fb) {
218 struct drm_gem_object *obj = msm_framebuffer_bo(plane_state->fb, 0);
219 struct msm_gem_object *msm_obj = to_msm_bo(obj);
220 struct dma_fence *fence = reservation_object_get_excl_rcu(msm_obj->resv);
221
222 drm_atomic_set_fence_for_plane(plane_state, fence);
223 }
224 }
225
226 /*
227 * Wait for pending updates on any of the same crtc's and then
228 * mark our set of crtc's as busy:
229 */
230 ret = start_atomic(dev->dev_private, c->crtc_mask);
231 if (ret) {
232 kfree(c);
233 goto error;
234 }
235
236 /*
237 * This is the point of no return - everything below never fails except
238 * when the hw goes bonghits. Which means we can commit the new state on
239 * the software side now.
240 */
241
242 drm_atomic_helper_swap_state(state, true);
243
244 /* swap driver private state while still holding state_lock */
245 if (to_kms_state(state)->state)
246 priv->kms->funcs->swap_state(priv->kms, state);
247
248 /*
249 * Everything below can be run asynchronously without the need to grab
250 * any modeset locks at all under one conditions: It must be guaranteed
251 * that the asynchronous work has either been cancelled (if the driver
252 * supports it, which at least requires that the framebuffers get
253 * cleaned up with drm_atomic_helper_cleanup_planes()) or completed
254 * before the new state gets committed on the software side with
255 * drm_atomic_helper_swap_state().
256 *
257 * This scheme allows new atomic state updates to be prepared and
258 * checked in parallel to the asynchronous completion of the previous
259 * update. Which is important since compositors need to figure out the
260 * composition of the next frame right after having submitted the
261 * current layout.
262 */
263
264 drm_atomic_state_get(state);
265 if (nonblock) {
266 queue_work(priv->atomic_wq, &c->work);
267 return 0;
268 }
269
270 complete_commit(c, false);
271
272 return 0;
273
274error:
275 drm_atomic_helper_cleanup_planes(dev, state);
276 return ret;
277}
278
279struct drm_atomic_state *msm_atomic_state_alloc(struct drm_device *dev)
280{
281 struct msm_kms_state *state = kzalloc(sizeof(*state), GFP_KERNEL);
282
283 if (!state || drm_atomic_state_init(dev, &state->base) < 0) {
284 kfree(state);
285 return NULL;
286 }
287
288 return &state->base;
289}
290
291void msm_atomic_state_clear(struct drm_atomic_state *s)
292{
293 struct msm_kms_state *state = to_kms_state(s);
294 drm_atomic_state_default_clear(&state->base);
295 kfree(state->state);
296 state->state = NULL;
297}
298
299void msm_atomic_state_free(struct drm_atomic_state *state)
300{
301 kfree(to_kms_state(state)->state);
302 drm_atomic_state_default_release(state);
303 kfree(state);
304}