Linux Audio

Check our new training course

Loading...
Note: File does not exist in v4.6.
  1// SPDX-License-Identifier: GPL-2.0-only
  2/*
  3 * Copyright (C) 2016 Broadcom
  4 */
  5
  6/**
  7 * DOC: VC4 SDTV module
  8 *
  9 * The VEC encoder generates PAL or NTSC composite video output.
 10 *
 11 * TV mode selection is done by an atomic property on the encoder,
 12 * because a drm_mode_modeinfo is insufficient to distinguish between
 13 * PAL and PAL-M or NTSC and NTSC-J.
 14 */
 15
 16#include <drm/drm_atomic_helper.h>
 17#include <drm/drm_drv.h>
 18#include <drm/drm_edid.h>
 19#include <drm/drm_panel.h>
 20#include <drm/drm_probe_helper.h>
 21#include <drm/drm_simple_kms_helper.h>
 22#include <linux/clk.h>
 23#include <linux/component.h>
 24#include <linux/of_graph.h>
 25#include <linux/of_platform.h>
 26#include <linux/pm_runtime.h>
 27
 28#include "vc4_drv.h"
 29#include "vc4_regs.h"
 30
 31/* WSE Registers */
 32#define VEC_WSE_RESET			0xc0
 33
 34#define VEC_WSE_CONTROL			0xc4
 35#define VEC_WSE_WSS_ENABLE		BIT(7)
 36
 37#define VEC_WSE_WSS_DATA		0xc8
 38#define VEC_WSE_VPS_DATA1		0xcc
 39#define VEC_WSE_VPS_CONTROL		0xd0
 40
 41/* VEC Registers */
 42#define VEC_REVID			0x100
 43
 44#define VEC_CONFIG0			0x104
 45#define VEC_CONFIG0_YDEL_MASK		GENMASK(28, 26)
 46#define VEC_CONFIG0_YDEL(x)		((x) << 26)
 47#define VEC_CONFIG0_CDEL_MASK		GENMASK(25, 24)
 48#define VEC_CONFIG0_CDEL(x)		((x) << 24)
 49#define VEC_CONFIG0_PBPR_FIL		BIT(18)
 50#define VEC_CONFIG0_CHROMA_GAIN_MASK	GENMASK(17, 16)
 51#define VEC_CONFIG0_CHROMA_GAIN_UNITY	(0 << 16)
 52#define VEC_CONFIG0_CHROMA_GAIN_1_32	(1 << 16)
 53#define VEC_CONFIG0_CHROMA_GAIN_1_16	(2 << 16)
 54#define VEC_CONFIG0_CHROMA_GAIN_1_8	(3 << 16)
 55#define VEC_CONFIG0_CBURST_GAIN_MASK	GENMASK(14, 13)
 56#define VEC_CONFIG0_CBURST_GAIN_UNITY	(0 << 13)
 57#define VEC_CONFIG0_CBURST_GAIN_1_128	(1 << 13)
 58#define VEC_CONFIG0_CBURST_GAIN_1_64	(2 << 13)
 59#define VEC_CONFIG0_CBURST_GAIN_1_32	(3 << 13)
 60#define VEC_CONFIG0_CHRBW1		BIT(11)
 61#define VEC_CONFIG0_CHRBW0		BIT(10)
 62#define VEC_CONFIG0_SYNCDIS		BIT(9)
 63#define VEC_CONFIG0_BURDIS		BIT(8)
 64#define VEC_CONFIG0_CHRDIS		BIT(7)
 65#define VEC_CONFIG0_PDEN		BIT(6)
 66#define VEC_CONFIG0_YCDELAY		BIT(4)
 67#define VEC_CONFIG0_RAMPEN		BIT(2)
 68#define VEC_CONFIG0_YCDIS		BIT(2)
 69#define VEC_CONFIG0_STD_MASK		GENMASK(1, 0)
 70#define VEC_CONFIG0_NTSC_STD		0
 71#define VEC_CONFIG0_PAL_BDGHI_STD	1
 72#define VEC_CONFIG0_PAL_M_STD		2
 73#define VEC_CONFIG0_PAL_N_STD		3
 74
 75#define VEC_SCHPH			0x108
 76#define VEC_SOFT_RESET			0x10c
 77#define VEC_CLMP0_START			0x144
 78#define VEC_CLMP0_END			0x148
 79#define VEC_FREQ3_2			0x180
 80#define VEC_FREQ1_0			0x184
 81
 82#define VEC_CONFIG1			0x188
 83#define VEC_CONFIG_VEC_RESYNC_OFF	BIT(18)
 84#define VEC_CONFIG_RGB219		BIT(17)
 85#define VEC_CONFIG_CBAR_EN		BIT(16)
 86#define VEC_CONFIG_TC_OBB		BIT(15)
 87#define VEC_CONFIG1_OUTPUT_MODE_MASK	GENMASK(12, 10)
 88#define VEC_CONFIG1_C_Y_CVBS		(0 << 10)
 89#define VEC_CONFIG1_CVBS_Y_C		(1 << 10)
 90#define VEC_CONFIG1_PR_Y_PB		(2 << 10)
 91#define VEC_CONFIG1_RGB			(4 << 10)
 92#define VEC_CONFIG1_Y_C_CVBS		(5 << 10)
 93#define VEC_CONFIG1_C_CVBS_Y		(6 << 10)
 94#define VEC_CONFIG1_C_CVBS_CVBS		(7 << 10)
 95#define VEC_CONFIG1_DIS_CHR		BIT(9)
 96#define VEC_CONFIG1_DIS_LUMA		BIT(8)
 97#define VEC_CONFIG1_YCBCR_IN		BIT(6)
 98#define VEC_CONFIG1_DITHER_TYPE_LFSR	0
 99#define VEC_CONFIG1_DITHER_TYPE_COUNTER	BIT(5)
100#define VEC_CONFIG1_DITHER_EN		BIT(4)
101#define VEC_CONFIG1_CYDELAY		BIT(3)
102#define VEC_CONFIG1_LUMADIS		BIT(2)
103#define VEC_CONFIG1_COMPDIS		BIT(1)
104#define VEC_CONFIG1_CUSTOM_FREQ		BIT(0)
105
106#define VEC_CONFIG2			0x18c
107#define VEC_CONFIG2_PROG_SCAN		BIT(15)
108#define VEC_CONFIG2_SYNC_ADJ_MASK	GENMASK(14, 12)
109#define VEC_CONFIG2_SYNC_ADJ(x)		(((x) / 2) << 12)
110#define VEC_CONFIG2_PBPR_EN		BIT(10)
111#define VEC_CONFIG2_UV_DIG_DIS		BIT(6)
112#define VEC_CONFIG2_RGB_DIG_DIS		BIT(5)
113#define VEC_CONFIG2_TMUX_MASK		GENMASK(3, 2)
114#define VEC_CONFIG2_TMUX_DRIVE0		(0 << 2)
115#define VEC_CONFIG2_TMUX_RG_COMP	(1 << 2)
116#define VEC_CONFIG2_TMUX_UV_YC		(2 << 2)
117#define VEC_CONFIG2_TMUX_SYNC_YC	(3 << 2)
118
119#define VEC_INTERRUPT_CONTROL		0x190
120#define VEC_INTERRUPT_STATUS		0x194
121#define VEC_FCW_SECAM_B			0x198
122#define VEC_SECAM_GAIN_VAL		0x19c
123
124#define VEC_CONFIG3			0x1a0
125#define VEC_CONFIG3_HORIZ_LEN_STD	(0 << 0)
126#define VEC_CONFIG3_HORIZ_LEN_MPEG1_SIF	(1 << 0)
127#define VEC_CONFIG3_SHAPE_NON_LINEAR	BIT(1)
128
129#define VEC_STATUS0			0x200
130#define VEC_MASK0			0x204
131
132#define VEC_CFG				0x208
133#define VEC_CFG_SG_MODE_MASK		GENMASK(6, 5)
134#define VEC_CFG_SG_MODE(x)		((x) << 5)
135#define VEC_CFG_SG_EN			BIT(4)
136#define VEC_CFG_VEC_EN			BIT(3)
137#define VEC_CFG_MB_EN			BIT(2)
138#define VEC_CFG_ENABLE			BIT(1)
139#define VEC_CFG_TB_EN			BIT(0)
140
141#define VEC_DAC_TEST			0x20c
142
143#define VEC_DAC_CONFIG			0x210
144#define VEC_DAC_CONFIG_LDO_BIAS_CTRL(x)	((x) << 24)
145#define VEC_DAC_CONFIG_DRIVER_CTRL(x)	((x) << 16)
146#define VEC_DAC_CONFIG_DAC_CTRL(x)	(x)
147
148#define VEC_DAC_MISC			0x214
149#define VEC_DAC_MISC_VCD_CTRL_MASK	GENMASK(31, 16)
150#define VEC_DAC_MISC_VCD_CTRL(x)	((x) << 16)
151#define VEC_DAC_MISC_VID_ACT		BIT(8)
152#define VEC_DAC_MISC_VCD_PWRDN		BIT(6)
153#define VEC_DAC_MISC_BIAS_PWRDN		BIT(5)
154#define VEC_DAC_MISC_DAC_PWRDN		BIT(2)
155#define VEC_DAC_MISC_LDO_PWRDN		BIT(1)
156#define VEC_DAC_MISC_DAC_RST_N		BIT(0)
157
158
159struct vc4_vec_variant {
160	u32 dac_config;
161};
162
163/* General VEC hardware state. */
164struct vc4_vec {
165	struct vc4_encoder encoder;
166	struct drm_connector connector;
167
168	struct platform_device *pdev;
169	const struct vc4_vec_variant *variant;
170
171	void __iomem *regs;
172
173	struct clk *clock;
174
175	struct debugfs_regset32 regset;
176};
177
178#define VEC_READ(offset) readl(vec->regs + (offset))
179#define VEC_WRITE(offset, val) writel(val, vec->regs + (offset))
180
181static inline struct vc4_vec *
182encoder_to_vc4_vec(struct drm_encoder *encoder)
183{
184	return container_of(encoder, struct vc4_vec, encoder.base);
185}
186
187enum vc4_vec_tv_mode_id {
188	VC4_VEC_TV_MODE_NTSC,
189	VC4_VEC_TV_MODE_NTSC_J,
190	VC4_VEC_TV_MODE_PAL,
191	VC4_VEC_TV_MODE_PAL_M,
192};
193
194struct vc4_vec_tv_mode {
195	const struct drm_display_mode *mode;
196	u32 config0;
197	u32 config1;
198	u32 custom_freq;
199};
200
201static const struct debugfs_reg32 vec_regs[] = {
202	VC4_REG32(VEC_WSE_CONTROL),
203	VC4_REG32(VEC_WSE_WSS_DATA),
204	VC4_REG32(VEC_WSE_VPS_DATA1),
205	VC4_REG32(VEC_WSE_VPS_CONTROL),
206	VC4_REG32(VEC_REVID),
207	VC4_REG32(VEC_CONFIG0),
208	VC4_REG32(VEC_SCHPH),
209	VC4_REG32(VEC_CLMP0_START),
210	VC4_REG32(VEC_CLMP0_END),
211	VC4_REG32(VEC_FREQ3_2),
212	VC4_REG32(VEC_FREQ1_0),
213	VC4_REG32(VEC_CONFIG1),
214	VC4_REG32(VEC_CONFIG2),
215	VC4_REG32(VEC_INTERRUPT_CONTROL),
216	VC4_REG32(VEC_INTERRUPT_STATUS),
217	VC4_REG32(VEC_FCW_SECAM_B),
218	VC4_REG32(VEC_SECAM_GAIN_VAL),
219	VC4_REG32(VEC_CONFIG3),
220	VC4_REG32(VEC_STATUS0),
221	VC4_REG32(VEC_MASK0),
222	VC4_REG32(VEC_CFG),
223	VC4_REG32(VEC_DAC_TEST),
224	VC4_REG32(VEC_DAC_CONFIG),
225	VC4_REG32(VEC_DAC_MISC),
226};
227
228static const struct drm_display_mode ntsc_mode = {
229	DRM_MODE("720x480", DRM_MODE_TYPE_DRIVER, 13500,
230		 720, 720 + 14, 720 + 14 + 64, 720 + 14 + 64 + 60, 0,
231		 480, 480 + 7, 480 + 7 + 6, 525, 0,
232		 DRM_MODE_FLAG_INTERLACE)
233};
234
235static const struct drm_display_mode pal_mode = {
236	DRM_MODE("720x576", DRM_MODE_TYPE_DRIVER, 13500,
237		 720, 720 + 20, 720 + 20 + 64, 720 + 20 + 64 + 60, 0,
238		 576, 576 + 4, 576 + 4 + 6, 625, 0,
239		 DRM_MODE_FLAG_INTERLACE)
240};
241
242static const struct vc4_vec_tv_mode vc4_vec_tv_modes[] = {
243	[VC4_VEC_TV_MODE_NTSC] = {
244		.mode = &ntsc_mode,
245		.config0 = VEC_CONFIG0_NTSC_STD | VEC_CONFIG0_PDEN,
246		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
247	},
248	[VC4_VEC_TV_MODE_NTSC_J] = {
249		.mode = &ntsc_mode,
250		.config0 = VEC_CONFIG0_NTSC_STD,
251		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
252	},
253	[VC4_VEC_TV_MODE_PAL] = {
254		.mode = &pal_mode,
255		.config0 = VEC_CONFIG0_PAL_BDGHI_STD,
256		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
257	},
258	[VC4_VEC_TV_MODE_PAL_M] = {
259		.mode = &ntsc_mode,
260		.config0 = VEC_CONFIG0_PAL_M_STD,
261		.config1 = VEC_CONFIG1_C_CVBS_CVBS,
262	},
263};
264
265static enum drm_connector_status
266vc4_vec_connector_detect(struct drm_connector *connector, bool force)
267{
268	return connector_status_unknown;
269}
270
271static int vc4_vec_connector_get_modes(struct drm_connector *connector)
272{
273	struct drm_connector_state *state = connector->state;
274	struct drm_display_mode *mode;
275
276	mode = drm_mode_duplicate(connector->dev,
277				  vc4_vec_tv_modes[state->tv.mode].mode);
278	if (!mode) {
279		DRM_ERROR("Failed to create a new display mode\n");
280		return -ENOMEM;
281	}
282
283	drm_mode_probed_add(connector, mode);
284
285	return 1;
286}
287
288static const struct drm_connector_funcs vc4_vec_connector_funcs = {
289	.detect = vc4_vec_connector_detect,
290	.fill_modes = drm_helper_probe_single_connector_modes,
291	.reset = drm_atomic_helper_connector_reset,
292	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
293	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
294};
295
296static const struct drm_connector_helper_funcs vc4_vec_connector_helper_funcs = {
297	.get_modes = vc4_vec_connector_get_modes,
298};
299
300static int vc4_vec_connector_init(struct drm_device *dev, struct vc4_vec *vec)
301{
302	struct drm_connector *connector = &vec->connector;
303	int ret;
304
305	connector->interlace_allowed = true;
306
307	ret = drmm_connector_init(dev, connector, &vc4_vec_connector_funcs,
308				 DRM_MODE_CONNECTOR_Composite, NULL);
309	if (ret)
310		return ret;
311
312	drm_connector_helper_add(connector, &vc4_vec_connector_helper_funcs);
313
314	drm_object_attach_property(&connector->base,
315				   dev->mode_config.tv_mode_property,
316				   VC4_VEC_TV_MODE_NTSC);
317
318	drm_connector_attach_encoder(connector, &vec->encoder.base);
319
320	return 0;
321}
322
323static void vc4_vec_encoder_disable(struct drm_encoder *encoder,
324				    struct drm_atomic_state *state)
325{
326	struct drm_device *drm = encoder->dev;
327	struct vc4_vec *vec = encoder_to_vc4_vec(encoder);
328	int idx, ret;
329
330	if (!drm_dev_enter(drm, &idx))
331		return;
332
333	VEC_WRITE(VEC_CFG, 0);
334	VEC_WRITE(VEC_DAC_MISC,
335		  VEC_DAC_MISC_VCD_PWRDN |
336		  VEC_DAC_MISC_BIAS_PWRDN |
337		  VEC_DAC_MISC_DAC_PWRDN |
338		  VEC_DAC_MISC_LDO_PWRDN);
339
340	clk_disable_unprepare(vec->clock);
341
342	ret = pm_runtime_put(&vec->pdev->dev);
343	if (ret < 0) {
344		DRM_ERROR("Failed to release power domain: %d\n", ret);
345		goto err_dev_exit;
346	}
347
348	drm_dev_exit(idx);
349	return;
350
351err_dev_exit:
352	drm_dev_exit(idx);
353}
354
355static void vc4_vec_encoder_enable(struct drm_encoder *encoder,
356				   struct drm_atomic_state *state)
357{
358	struct drm_device *drm = encoder->dev;
359	struct vc4_vec *vec = encoder_to_vc4_vec(encoder);
360	struct drm_connector *connector = &vec->connector;
361	struct drm_connector_state *conn_state =
362		drm_atomic_get_new_connector_state(state, connector);
363	const struct vc4_vec_tv_mode *tv_mode =
364		&vc4_vec_tv_modes[conn_state->tv.mode];
365	int idx, ret;
366
367	if (!drm_dev_enter(drm, &idx))
368		return;
369
370	ret = pm_runtime_get_sync(&vec->pdev->dev);
371	if (ret < 0) {
372		DRM_ERROR("Failed to retain power domain: %d\n", ret);
373		goto err_dev_exit;
374	}
375
376	/*
377	 * We need to set the clock rate each time we enable the encoder
378	 * because there's a chance we share the same parent with the HDMI
379	 * clock, and both drivers are requesting different rates.
380	 * The good news is, these 2 encoders cannot be enabled at the same
381	 * time, thus preventing incompatible rate requests.
382	 */
383	ret = clk_set_rate(vec->clock, 108000000);
384	if (ret) {
385		DRM_ERROR("Failed to set clock rate: %d\n", ret);
386		goto err_put_runtime_pm;
387	}
388
389	ret = clk_prepare_enable(vec->clock);
390	if (ret) {
391		DRM_ERROR("Failed to turn on core clock: %d\n", ret);
392		goto err_put_runtime_pm;
393	}
394
395	/* Reset the different blocks */
396	VEC_WRITE(VEC_WSE_RESET, 1);
397	VEC_WRITE(VEC_SOFT_RESET, 1);
398
399	/* Disable the CGSM-A and WSE blocks */
400	VEC_WRITE(VEC_WSE_CONTROL, 0);
401
402	/* Write config common to all modes. */
403
404	/*
405	 * Color subcarrier phase: phase = 360 * SCHPH / 256.
406	 * 0x28 <=> 39.375 deg.
407	 */
408	VEC_WRITE(VEC_SCHPH, 0x28);
409
410	/*
411	 * Reset to default values.
412	 */
413	VEC_WRITE(VEC_CLMP0_START, 0xac);
414	VEC_WRITE(VEC_CLMP0_END, 0xec);
415	VEC_WRITE(VEC_CONFIG2,
416		  VEC_CONFIG2_UV_DIG_DIS | VEC_CONFIG2_RGB_DIG_DIS);
417	VEC_WRITE(VEC_CONFIG3, VEC_CONFIG3_HORIZ_LEN_STD);
418	VEC_WRITE(VEC_DAC_CONFIG, vec->variant->dac_config);
419
420	/* Mask all interrupts. */
421	VEC_WRITE(VEC_MASK0, 0);
422
423	VEC_WRITE(VEC_CONFIG0, tv_mode->config0);
424	VEC_WRITE(VEC_CONFIG1, tv_mode->config1);
425
426	if (tv_mode->custom_freq) {
427		VEC_WRITE(VEC_FREQ3_2,
428			  (tv_mode->custom_freq >> 16) & 0xffff);
429		VEC_WRITE(VEC_FREQ1_0,
430			  tv_mode->custom_freq & 0xffff);
431	}
432
433	VEC_WRITE(VEC_DAC_MISC,
434		  VEC_DAC_MISC_VID_ACT | VEC_DAC_MISC_DAC_RST_N);
435	VEC_WRITE(VEC_CFG, VEC_CFG_VEC_EN);
436
437	drm_dev_exit(idx);
438	return;
439
440err_put_runtime_pm:
441	pm_runtime_put(&vec->pdev->dev);
442err_dev_exit:
443	drm_dev_exit(idx);
444}
445
446static int vc4_vec_encoder_atomic_check(struct drm_encoder *encoder,
447					struct drm_crtc_state *crtc_state,
448					struct drm_connector_state *conn_state)
449{
450	const struct vc4_vec_tv_mode *vec_mode;
451
452	vec_mode = &vc4_vec_tv_modes[conn_state->tv.mode];
453
454	if (conn_state->crtc &&
455	    !drm_mode_equal(vec_mode->mode, &crtc_state->adjusted_mode))
456		return -EINVAL;
457
458	return 0;
459}
460
461static const struct drm_encoder_helper_funcs vc4_vec_encoder_helper_funcs = {
462	.atomic_check = vc4_vec_encoder_atomic_check,
463	.atomic_disable = vc4_vec_encoder_disable,
464	.atomic_enable = vc4_vec_encoder_enable,
465};
466
467static int vc4_vec_late_register(struct drm_encoder *encoder)
468{
469	struct drm_device *drm = encoder->dev;
470	struct vc4_vec *vec = encoder_to_vc4_vec(encoder);
471	int ret;
472
473	ret = vc4_debugfs_add_regset32(drm->primary, "vec_regs",
474				       &vec->regset);
475	if (ret)
476		return ret;
477
478	return 0;
479}
480
481static const struct drm_encoder_funcs vc4_vec_encoder_funcs = {
482	.late_register = vc4_vec_late_register,
483};
484
485static const struct vc4_vec_variant bcm2835_vec_variant = {
486	.dac_config = VEC_DAC_CONFIG_DAC_CTRL(0xc) |
487		      VEC_DAC_CONFIG_DRIVER_CTRL(0xc) |
488		      VEC_DAC_CONFIG_LDO_BIAS_CTRL(0x46)
489};
490
491static const struct vc4_vec_variant bcm2711_vec_variant = {
492	.dac_config = VEC_DAC_CONFIG_DAC_CTRL(0x0) |
493		      VEC_DAC_CONFIG_DRIVER_CTRL(0x80) |
494		      VEC_DAC_CONFIG_LDO_BIAS_CTRL(0x61)
495};
496
497static const struct of_device_id vc4_vec_dt_match[] = {
498	{ .compatible = "brcm,bcm2835-vec", .data = &bcm2835_vec_variant },
499	{ .compatible = "brcm,bcm2711-vec", .data = &bcm2711_vec_variant },
500	{ /* sentinel */ },
501};
502
503static const char * const tv_mode_names[] = {
504	[VC4_VEC_TV_MODE_NTSC] = "NTSC",
505	[VC4_VEC_TV_MODE_NTSC_J] = "NTSC-J",
506	[VC4_VEC_TV_MODE_PAL] = "PAL",
507	[VC4_VEC_TV_MODE_PAL_M] = "PAL-M",
508};
509
510static int vc4_vec_bind(struct device *dev, struct device *master, void *data)
511{
512	struct platform_device *pdev = to_platform_device(dev);
513	struct drm_device *drm = dev_get_drvdata(master);
514	struct vc4_vec *vec;
515	int ret;
516
517	ret = drm_mode_create_tv_properties(drm, ARRAY_SIZE(tv_mode_names),
518					    tv_mode_names);
519	if (ret)
520		return ret;
521
522	vec = drmm_kzalloc(drm, sizeof(*vec), GFP_KERNEL);
523	if (!vec)
524		return -ENOMEM;
525
526	vec->encoder.type = VC4_ENCODER_TYPE_VEC;
527	vec->pdev = pdev;
528	vec->variant = (const struct vc4_vec_variant *)
529		of_device_get_match_data(dev);
530	vec->regs = vc4_ioremap_regs(pdev, 0);
531	if (IS_ERR(vec->regs))
532		return PTR_ERR(vec->regs);
533	vec->regset.base = vec->regs;
534	vec->regset.regs = vec_regs;
535	vec->regset.nregs = ARRAY_SIZE(vec_regs);
536
537	vec->clock = devm_clk_get(dev, NULL);
538	if (IS_ERR(vec->clock)) {
539		ret = PTR_ERR(vec->clock);
540		if (ret != -EPROBE_DEFER)
541			DRM_ERROR("Failed to get clock: %d\n", ret);
542		return ret;
543	}
544
545	ret = devm_pm_runtime_enable(dev);
546	if (ret)
547		return ret;
548
549	ret = drmm_encoder_init(drm, &vec->encoder.base,
550				&vc4_vec_encoder_funcs,
551				DRM_MODE_ENCODER_TVDAC,
552				NULL);
553	if (ret)
554		return ret;
555
556	drm_encoder_helper_add(&vec->encoder.base, &vc4_vec_encoder_helper_funcs);
557
558	ret = vc4_vec_connector_init(drm, vec);
559	if (ret)
560		return ret;
561
562	dev_set_drvdata(dev, vec);
563
564	return 0;
565}
566
567static const struct component_ops vc4_vec_ops = {
568	.bind   = vc4_vec_bind,
569};
570
571static int vc4_vec_dev_probe(struct platform_device *pdev)
572{
573	return component_add(&pdev->dev, &vc4_vec_ops);
574}
575
576static int vc4_vec_dev_remove(struct platform_device *pdev)
577{
578	component_del(&pdev->dev, &vc4_vec_ops);
579	return 0;
580}
581
582struct platform_driver vc4_vec_driver = {
583	.probe = vc4_vec_dev_probe,
584	.remove = vc4_vec_dev_remove,
585	.driver = {
586		.name = "vc4_vec",
587		.of_match_table = vc4_vec_dt_match,
588	},
589};