Loading...
1/*
2 * i.MX drm driver - Television Encoder (TVEv2)
3 *
4 * Copyright (C) 2013 Philipp Zabel, Pengutronix
5 *
6 * This program is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU General Public License
8 * as published by the Free Software Foundation; either version 2
9 * of the License, or (at your option) any later version.
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 */
15
16#include <linux/clk.h>
17#include <linux/clk-provider.h>
18#include <linux/component.h>
19#include <linux/module.h>
20#include <linux/i2c.h>
21#include <linux/regmap.h>
22#include <linux/regulator/consumer.h>
23#include <linux/spinlock.h>
24#include <linux/videodev2.h>
25#include <drm/drmP.h>
26#include <drm/drm_fb_helper.h>
27#include <drm/drm_crtc_helper.h>
28#include <video/imx-ipu-v3.h>
29
30#include "imx-drm.h"
31
32#define TVE_COM_CONF_REG 0x00
33#define TVE_TVDAC0_CONT_REG 0x28
34#define TVE_TVDAC1_CONT_REG 0x2c
35#define TVE_TVDAC2_CONT_REG 0x30
36#define TVE_CD_CONT_REG 0x34
37#define TVE_INT_CONT_REG 0x64
38#define TVE_STAT_REG 0x68
39#define TVE_TST_MODE_REG 0x6c
40#define TVE_MV_CONT_REG 0xdc
41
42/* TVE_COM_CONF_REG */
43#define TVE_SYNC_CH_2_EN BIT(22)
44#define TVE_SYNC_CH_1_EN BIT(21)
45#define TVE_SYNC_CH_0_EN BIT(20)
46#define TVE_TV_OUT_MODE_MASK (0x7 << 12)
47#define TVE_TV_OUT_DISABLE (0x0 << 12)
48#define TVE_TV_OUT_CVBS_0 (0x1 << 12)
49#define TVE_TV_OUT_CVBS_2 (0x2 << 12)
50#define TVE_TV_OUT_CVBS_0_2 (0x3 << 12)
51#define TVE_TV_OUT_SVIDEO_0_1 (0x4 << 12)
52#define TVE_TV_OUT_SVIDEO_0_1_CVBS2_2 (0x5 << 12)
53#define TVE_TV_OUT_YPBPR (0x6 << 12)
54#define TVE_TV_OUT_RGB (0x7 << 12)
55#define TVE_TV_STAND_MASK (0xf << 8)
56#define TVE_TV_STAND_HD_1080P30 (0xc << 8)
57#define TVE_P2I_CONV_EN BIT(7)
58#define TVE_INP_VIDEO_FORM BIT(6)
59#define TVE_INP_YCBCR_422 (0x0 << 6)
60#define TVE_INP_YCBCR_444 (0x1 << 6)
61#define TVE_DATA_SOURCE_MASK (0x3 << 4)
62#define TVE_DATA_SOURCE_BUS1 (0x0 << 4)
63#define TVE_DATA_SOURCE_BUS2 (0x1 << 4)
64#define TVE_DATA_SOURCE_EXT (0x2 << 4)
65#define TVE_DATA_SOURCE_TESTGEN (0x3 << 4)
66#define TVE_IPU_CLK_EN_OFS 3
67#define TVE_IPU_CLK_EN BIT(3)
68#define TVE_DAC_SAMP_RATE_OFS 1
69#define TVE_DAC_SAMP_RATE_WIDTH 2
70#define TVE_DAC_SAMP_RATE_MASK (0x3 << 1)
71#define TVE_DAC_FULL_RATE (0x0 << 1)
72#define TVE_DAC_DIV2_RATE (0x1 << 1)
73#define TVE_DAC_DIV4_RATE (0x2 << 1)
74#define TVE_EN BIT(0)
75
76/* TVE_TVDACx_CONT_REG */
77#define TVE_TVDAC_GAIN_MASK (0x3f << 0)
78
79/* TVE_CD_CONT_REG */
80#define TVE_CD_CH_2_SM_EN BIT(22)
81#define TVE_CD_CH_1_SM_EN BIT(21)
82#define TVE_CD_CH_0_SM_EN BIT(20)
83#define TVE_CD_CH_2_LM_EN BIT(18)
84#define TVE_CD_CH_1_LM_EN BIT(17)
85#define TVE_CD_CH_0_LM_EN BIT(16)
86#define TVE_CD_CH_2_REF_LVL BIT(10)
87#define TVE_CD_CH_1_REF_LVL BIT(9)
88#define TVE_CD_CH_0_REF_LVL BIT(8)
89#define TVE_CD_EN BIT(0)
90
91/* TVE_INT_CONT_REG */
92#define TVE_FRAME_END_IEN BIT(13)
93#define TVE_CD_MON_END_IEN BIT(2)
94#define TVE_CD_SM_IEN BIT(1)
95#define TVE_CD_LM_IEN BIT(0)
96
97/* TVE_TST_MODE_REG */
98#define TVE_TVDAC_TEST_MODE_MASK (0x7 << 0)
99
100#define con_to_tve(x) container_of(x, struct imx_tve, connector)
101#define enc_to_tve(x) container_of(x, struct imx_tve, encoder)
102
103enum {
104 TVE_MODE_TVOUT,
105 TVE_MODE_VGA,
106};
107
108struct imx_tve {
109 struct drm_connector connector;
110 struct drm_encoder encoder;
111 struct device *dev;
112 spinlock_t lock; /* register lock */
113 bool enabled;
114 int mode;
115
116 struct regmap *regmap;
117 struct regulator *dac_reg;
118 struct i2c_adapter *ddc;
119 struct clk *clk;
120 struct clk *di_sel_clk;
121 struct clk_hw clk_hw_di;
122 struct clk *di_clk;
123 int vsync_pin;
124 int hsync_pin;
125};
126
127static void tve_lock(void *__tve)
128__acquires(&tve->lock)
129{
130 struct imx_tve *tve = __tve;
131
132 spin_lock(&tve->lock);
133}
134
135static void tve_unlock(void *__tve)
136__releases(&tve->lock)
137{
138 struct imx_tve *tve = __tve;
139
140 spin_unlock(&tve->lock);
141}
142
143static void tve_enable(struct imx_tve *tve)
144{
145 int ret;
146
147 if (!tve->enabled) {
148 tve->enabled = true;
149 clk_prepare_enable(tve->clk);
150 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
151 TVE_IPU_CLK_EN | TVE_EN,
152 TVE_IPU_CLK_EN | TVE_EN);
153 }
154
155 /* clear interrupt status register */
156 regmap_write(tve->regmap, TVE_STAT_REG, 0xffffffff);
157
158 /* cable detection irq disabled in VGA mode, enabled in TVOUT mode */
159 if (tve->mode == TVE_MODE_VGA)
160 regmap_write(tve->regmap, TVE_INT_CONT_REG, 0);
161 else
162 regmap_write(tve->regmap, TVE_INT_CONT_REG,
163 TVE_CD_SM_IEN |
164 TVE_CD_LM_IEN |
165 TVE_CD_MON_END_IEN);
166}
167
168static void tve_disable(struct imx_tve *tve)
169{
170 int ret;
171
172 if (tve->enabled) {
173 tve->enabled = false;
174 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
175 TVE_IPU_CLK_EN | TVE_EN, 0);
176 clk_disable_unprepare(tve->clk);
177 }
178}
179
180static int tve_setup_tvout(struct imx_tve *tve)
181{
182 return -ENOTSUPP;
183}
184
185static int tve_setup_vga(struct imx_tve *tve)
186{
187 unsigned int mask;
188 unsigned int val;
189 int ret;
190
191 /* set gain to (1 + 10/128) to provide 0.7V peak-to-peak amplitude */
192 ret = regmap_update_bits(tve->regmap, TVE_TVDAC0_CONT_REG,
193 TVE_TVDAC_GAIN_MASK, 0x0a);
194 if (ret)
195 return ret;
196
197 ret = regmap_update_bits(tve->regmap, TVE_TVDAC1_CONT_REG,
198 TVE_TVDAC_GAIN_MASK, 0x0a);
199 if (ret)
200 return ret;
201
202 ret = regmap_update_bits(tve->regmap, TVE_TVDAC2_CONT_REG,
203 TVE_TVDAC_GAIN_MASK, 0x0a);
204 if (ret)
205 return ret;
206
207 /* set configuration register */
208 mask = TVE_DATA_SOURCE_MASK | TVE_INP_VIDEO_FORM;
209 val = TVE_DATA_SOURCE_BUS2 | TVE_INP_YCBCR_444;
210 mask |= TVE_TV_STAND_MASK | TVE_P2I_CONV_EN;
211 val |= TVE_TV_STAND_HD_1080P30 | 0;
212 mask |= TVE_TV_OUT_MODE_MASK | TVE_SYNC_CH_0_EN;
213 val |= TVE_TV_OUT_RGB | TVE_SYNC_CH_0_EN;
214 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG, mask, val);
215 if (ret)
216 return ret;
217
218 /* set test mode (as documented) */
219 return regmap_update_bits(tve->regmap, TVE_TST_MODE_REG,
220 TVE_TVDAC_TEST_MODE_MASK, 1);
221}
222
223static enum drm_connector_status imx_tve_connector_detect(
224 struct drm_connector *connector, bool force)
225{
226 return connector_status_connected;
227}
228
229static int imx_tve_connector_get_modes(struct drm_connector *connector)
230{
231 struct imx_tve *tve = con_to_tve(connector);
232 struct edid *edid;
233 int ret = 0;
234
235 if (!tve->ddc)
236 return 0;
237
238 edid = drm_get_edid(connector, tve->ddc);
239 if (edid) {
240 drm_mode_connector_update_edid_property(connector, edid);
241 ret = drm_add_edid_modes(connector, edid);
242 kfree(edid);
243 }
244
245 return ret;
246}
247
248static int imx_tve_connector_mode_valid(struct drm_connector *connector,
249 struct drm_display_mode *mode)
250{
251 struct imx_tve *tve = con_to_tve(connector);
252 unsigned long rate;
253
254 /* pixel clock with 2x oversampling */
255 rate = clk_round_rate(tve->clk, 2000UL * mode->clock) / 2000;
256 if (rate == mode->clock)
257 return MODE_OK;
258
259 /* pixel clock without oversampling */
260 rate = clk_round_rate(tve->clk, 1000UL * mode->clock) / 1000;
261 if (rate == mode->clock)
262 return MODE_OK;
263
264 dev_warn(tve->dev, "ignoring mode %dx%d\n",
265 mode->hdisplay, mode->vdisplay);
266
267 return MODE_BAD;
268}
269
270static struct drm_encoder *imx_tve_connector_best_encoder(
271 struct drm_connector *connector)
272{
273 struct imx_tve *tve = con_to_tve(connector);
274
275 return &tve->encoder;
276}
277
278static void imx_tve_encoder_dpms(struct drm_encoder *encoder, int mode)
279{
280 struct imx_tve *tve = enc_to_tve(encoder);
281 int ret;
282
283 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
284 TVE_TV_OUT_MODE_MASK, TVE_TV_OUT_DISABLE);
285 if (ret < 0)
286 dev_err(tve->dev, "failed to disable TVOUT: %d\n", ret);
287}
288
289static void imx_tve_encoder_prepare(struct drm_encoder *encoder)
290{
291 struct imx_tve *tve = enc_to_tve(encoder);
292
293 tve_disable(tve);
294
295 switch (tve->mode) {
296 case TVE_MODE_VGA:
297 imx_drm_set_bus_format_pins(encoder, MEDIA_BUS_FMT_GBR888_1X24,
298 tve->hsync_pin, tve->vsync_pin);
299 break;
300 case TVE_MODE_TVOUT:
301 imx_drm_set_bus_format(encoder, MEDIA_BUS_FMT_YUV8_1X24);
302 break;
303 }
304}
305
306static void imx_tve_encoder_mode_set(struct drm_encoder *encoder,
307 struct drm_display_mode *orig_mode,
308 struct drm_display_mode *mode)
309{
310 struct imx_tve *tve = enc_to_tve(encoder);
311 unsigned long rounded_rate;
312 unsigned long rate;
313 int div = 1;
314 int ret;
315
316 /*
317 * FIXME
318 * we should try 4k * mode->clock first,
319 * and enable 4x oversampling for lower resolutions
320 */
321 rate = 2000UL * mode->clock;
322 clk_set_rate(tve->clk, rate);
323 rounded_rate = clk_get_rate(tve->clk);
324 if (rounded_rate >= rate)
325 div = 2;
326 clk_set_rate(tve->di_clk, rounded_rate / div);
327
328 ret = clk_set_parent(tve->di_sel_clk, tve->di_clk);
329 if (ret < 0) {
330 dev_err(tve->dev, "failed to set di_sel parent to tve_di: %d\n",
331 ret);
332 }
333
334 if (tve->mode == TVE_MODE_VGA)
335 ret = tve_setup_vga(tve);
336 else
337 ret = tve_setup_tvout(tve);
338 if (ret)
339 dev_err(tve->dev, "failed to set configuration: %d\n", ret);
340}
341
342static void imx_tve_encoder_commit(struct drm_encoder *encoder)
343{
344 struct imx_tve *tve = enc_to_tve(encoder);
345
346 tve_enable(tve);
347}
348
349static void imx_tve_encoder_disable(struct drm_encoder *encoder)
350{
351 struct imx_tve *tve = enc_to_tve(encoder);
352
353 tve_disable(tve);
354}
355
356static const struct drm_connector_funcs imx_tve_connector_funcs = {
357 .dpms = drm_helper_connector_dpms,
358 .fill_modes = drm_helper_probe_single_connector_modes,
359 .detect = imx_tve_connector_detect,
360 .destroy = imx_drm_connector_destroy,
361};
362
363static const struct drm_connector_helper_funcs imx_tve_connector_helper_funcs = {
364 .get_modes = imx_tve_connector_get_modes,
365 .best_encoder = imx_tve_connector_best_encoder,
366 .mode_valid = imx_tve_connector_mode_valid,
367};
368
369static const struct drm_encoder_funcs imx_tve_encoder_funcs = {
370 .destroy = imx_drm_encoder_destroy,
371};
372
373static const struct drm_encoder_helper_funcs imx_tve_encoder_helper_funcs = {
374 .dpms = imx_tve_encoder_dpms,
375 .prepare = imx_tve_encoder_prepare,
376 .mode_set = imx_tve_encoder_mode_set,
377 .commit = imx_tve_encoder_commit,
378 .disable = imx_tve_encoder_disable,
379};
380
381static irqreturn_t imx_tve_irq_handler(int irq, void *data)
382{
383 struct imx_tve *tve = data;
384 unsigned int val;
385
386 regmap_read(tve->regmap, TVE_STAT_REG, &val);
387
388 /* clear interrupt status register */
389 regmap_write(tve->regmap, TVE_STAT_REG, 0xffffffff);
390
391 return IRQ_HANDLED;
392}
393
394static unsigned long clk_tve_di_recalc_rate(struct clk_hw *hw,
395 unsigned long parent_rate)
396{
397 struct imx_tve *tve = container_of(hw, struct imx_tve, clk_hw_di);
398 unsigned int val;
399 int ret;
400
401 ret = regmap_read(tve->regmap, TVE_COM_CONF_REG, &val);
402 if (ret < 0)
403 return 0;
404
405 switch (val & TVE_DAC_SAMP_RATE_MASK) {
406 case TVE_DAC_DIV4_RATE:
407 return parent_rate / 4;
408 case TVE_DAC_DIV2_RATE:
409 return parent_rate / 2;
410 case TVE_DAC_FULL_RATE:
411 default:
412 return parent_rate;
413 }
414
415 return 0;
416}
417
418static long clk_tve_di_round_rate(struct clk_hw *hw, unsigned long rate,
419 unsigned long *prate)
420{
421 unsigned long div;
422
423 div = *prate / rate;
424 if (div >= 4)
425 return *prate / 4;
426 else if (div >= 2)
427 return *prate / 2;
428 return *prate;
429}
430
431static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate,
432 unsigned long parent_rate)
433{
434 struct imx_tve *tve = container_of(hw, struct imx_tve, clk_hw_di);
435 unsigned long div;
436 u32 val;
437 int ret;
438
439 div = parent_rate / rate;
440 if (div >= 4)
441 val = TVE_DAC_DIV4_RATE;
442 else if (div >= 2)
443 val = TVE_DAC_DIV2_RATE;
444 else
445 val = TVE_DAC_FULL_RATE;
446
447 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
448 TVE_DAC_SAMP_RATE_MASK, val);
449
450 if (ret < 0) {
451 dev_err(tve->dev, "failed to set divider: %d\n", ret);
452 return ret;
453 }
454
455 return 0;
456}
457
458static struct clk_ops clk_tve_di_ops = {
459 .round_rate = clk_tve_di_round_rate,
460 .set_rate = clk_tve_di_set_rate,
461 .recalc_rate = clk_tve_di_recalc_rate,
462};
463
464static int tve_clk_init(struct imx_tve *tve, void __iomem *base)
465{
466 const char *tve_di_parent[1];
467 struct clk_init_data init = {
468 .name = "tve_di",
469 .ops = &clk_tve_di_ops,
470 .num_parents = 1,
471 .flags = 0,
472 };
473
474 tve_di_parent[0] = __clk_get_name(tve->clk);
475 init.parent_names = (const char **)&tve_di_parent;
476
477 tve->clk_hw_di.init = &init;
478 tve->di_clk = clk_register(tve->dev, &tve->clk_hw_di);
479 if (IS_ERR(tve->di_clk)) {
480 dev_err(tve->dev, "failed to register TVE output clock: %ld\n",
481 PTR_ERR(tve->di_clk));
482 return PTR_ERR(tve->di_clk);
483 }
484
485 return 0;
486}
487
488static int imx_tve_register(struct drm_device *drm, struct imx_tve *tve)
489{
490 int encoder_type;
491 int ret;
492
493 encoder_type = tve->mode == TVE_MODE_VGA ?
494 DRM_MODE_ENCODER_DAC : DRM_MODE_ENCODER_TVDAC;
495
496 ret = imx_drm_encoder_parse_of(drm, &tve->encoder,
497 tve->dev->of_node);
498 if (ret)
499 return ret;
500
501 drm_encoder_helper_add(&tve->encoder, &imx_tve_encoder_helper_funcs);
502 drm_encoder_init(drm, &tve->encoder, &imx_tve_encoder_funcs,
503 encoder_type, NULL);
504
505 drm_connector_helper_add(&tve->connector,
506 &imx_tve_connector_helper_funcs);
507 drm_connector_init(drm, &tve->connector, &imx_tve_connector_funcs,
508 DRM_MODE_CONNECTOR_VGA);
509
510 drm_mode_connector_attach_encoder(&tve->connector, &tve->encoder);
511
512 return 0;
513}
514
515static bool imx_tve_readable_reg(struct device *dev, unsigned int reg)
516{
517 return (reg % 4 == 0) && (reg <= 0xdc);
518}
519
520static struct regmap_config tve_regmap_config = {
521 .reg_bits = 32,
522 .val_bits = 32,
523 .reg_stride = 4,
524
525 .readable_reg = imx_tve_readable_reg,
526
527 .lock = tve_lock,
528 .unlock = tve_unlock,
529
530 .max_register = 0xdc,
531};
532
533static const char * const imx_tve_modes[] = {
534 [TVE_MODE_TVOUT] = "tvout",
535 [TVE_MODE_VGA] = "vga",
536};
537
538static const int of_get_tve_mode(struct device_node *np)
539{
540 const char *bm;
541 int ret, i;
542
543 ret = of_property_read_string(np, "fsl,tve-mode", &bm);
544 if (ret < 0)
545 return ret;
546
547 for (i = 0; i < ARRAY_SIZE(imx_tve_modes); i++)
548 if (!strcasecmp(bm, imx_tve_modes[i]))
549 return i;
550
551 return -EINVAL;
552}
553
554static int imx_tve_bind(struct device *dev, struct device *master, void *data)
555{
556 struct platform_device *pdev = to_platform_device(dev);
557 struct drm_device *drm = data;
558 struct device_node *np = dev->of_node;
559 struct device_node *ddc_node;
560 struct imx_tve *tve;
561 struct resource *res;
562 void __iomem *base;
563 unsigned int val;
564 int irq;
565 int ret;
566
567 tve = devm_kzalloc(dev, sizeof(*tve), GFP_KERNEL);
568 if (!tve)
569 return -ENOMEM;
570
571 tve->dev = dev;
572 spin_lock_init(&tve->lock);
573
574 ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
575 if (ddc_node) {
576 tve->ddc = of_find_i2c_adapter_by_node(ddc_node);
577 of_node_put(ddc_node);
578 }
579
580 tve->mode = of_get_tve_mode(np);
581 if (tve->mode != TVE_MODE_VGA) {
582 dev_err(dev, "only VGA mode supported, currently\n");
583 return -EINVAL;
584 }
585
586 if (tve->mode == TVE_MODE_VGA) {
587 ret = of_property_read_u32(np, "fsl,hsync-pin",
588 &tve->hsync_pin);
589
590 if (ret < 0) {
591 dev_err(dev, "failed to get vsync pin\n");
592 return ret;
593 }
594
595 ret |= of_property_read_u32(np, "fsl,vsync-pin",
596 &tve->vsync_pin);
597
598 if (ret < 0) {
599 dev_err(dev, "failed to get vsync pin\n");
600 return ret;
601 }
602 }
603
604 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
605 base = devm_ioremap_resource(dev, res);
606 if (IS_ERR(base))
607 return PTR_ERR(base);
608
609 tve_regmap_config.lock_arg = tve;
610 tve->regmap = devm_regmap_init_mmio_clk(dev, "tve", base,
611 &tve_regmap_config);
612 if (IS_ERR(tve->regmap)) {
613 dev_err(dev, "failed to init regmap: %ld\n",
614 PTR_ERR(tve->regmap));
615 return PTR_ERR(tve->regmap);
616 }
617
618 irq = platform_get_irq(pdev, 0);
619 if (irq < 0) {
620 dev_err(dev, "failed to get irq\n");
621 return irq;
622 }
623
624 ret = devm_request_threaded_irq(dev, irq, NULL,
625 imx_tve_irq_handler, IRQF_ONESHOT,
626 "imx-tve", tve);
627 if (ret < 0) {
628 dev_err(dev, "failed to request irq: %d\n", ret);
629 return ret;
630 }
631
632 tve->dac_reg = devm_regulator_get(dev, "dac");
633 if (!IS_ERR(tve->dac_reg)) {
634 regulator_set_voltage(tve->dac_reg, 2750000, 2750000);
635 ret = regulator_enable(tve->dac_reg);
636 if (ret)
637 return ret;
638 }
639
640 tve->clk = devm_clk_get(dev, "tve");
641 if (IS_ERR(tve->clk)) {
642 dev_err(dev, "failed to get high speed tve clock: %ld\n",
643 PTR_ERR(tve->clk));
644 return PTR_ERR(tve->clk);
645 }
646
647 /* this is the IPU DI clock input selector, can be parented to tve_di */
648 tve->di_sel_clk = devm_clk_get(dev, "di_sel");
649 if (IS_ERR(tve->di_sel_clk)) {
650 dev_err(dev, "failed to get ipu di mux clock: %ld\n",
651 PTR_ERR(tve->di_sel_clk));
652 return PTR_ERR(tve->di_sel_clk);
653 }
654
655 ret = tve_clk_init(tve, base);
656 if (ret < 0)
657 return ret;
658
659 ret = regmap_read(tve->regmap, TVE_COM_CONF_REG, &val);
660 if (ret < 0) {
661 dev_err(dev, "failed to read configuration register: %d\n",
662 ret);
663 return ret;
664 }
665 if (val != 0x00100000) {
666 dev_err(dev, "configuration register default value indicates this is not a TVEv2\n");
667 return -ENODEV;
668 }
669
670 /* disable cable detection for VGA mode */
671 ret = regmap_write(tve->regmap, TVE_CD_CONT_REG, 0);
672 if (ret)
673 return ret;
674
675 ret = imx_tve_register(drm, tve);
676 if (ret)
677 return ret;
678
679 dev_set_drvdata(dev, tve);
680
681 return 0;
682}
683
684static void imx_tve_unbind(struct device *dev, struct device *master,
685 void *data)
686{
687 struct imx_tve *tve = dev_get_drvdata(dev);
688
689 tve->connector.funcs->destroy(&tve->connector);
690 tve->encoder.funcs->destroy(&tve->encoder);
691
692 if (!IS_ERR(tve->dac_reg))
693 regulator_disable(tve->dac_reg);
694}
695
696static const struct component_ops imx_tve_ops = {
697 .bind = imx_tve_bind,
698 .unbind = imx_tve_unbind,
699};
700
701static int imx_tve_probe(struct platform_device *pdev)
702{
703 return component_add(&pdev->dev, &imx_tve_ops);
704}
705
706static int imx_tve_remove(struct platform_device *pdev)
707{
708 component_del(&pdev->dev, &imx_tve_ops);
709 return 0;
710}
711
712static const struct of_device_id imx_tve_dt_ids[] = {
713 { .compatible = "fsl,imx53-tve", },
714 { /* sentinel */ }
715};
716MODULE_DEVICE_TABLE(of, imx_tve_dt_ids);
717
718static struct platform_driver imx_tve_driver = {
719 .probe = imx_tve_probe,
720 .remove = imx_tve_remove,
721 .driver = {
722 .of_match_table = imx_tve_dt_ids,
723 .name = "imx-tve",
724 },
725};
726
727module_platform_driver(imx_tve_driver);
728
729MODULE_DESCRIPTION("i.MX Television Encoder driver");
730MODULE_AUTHOR("Philipp Zabel, Pengutronix");
731MODULE_LICENSE("GPL");
732MODULE_ALIAS("platform:imx-tve");
1// SPDX-License-Identifier: GPL-2.0+
2/*
3 * i.MX drm driver - Television Encoder (TVEv2)
4 *
5 * Copyright (C) 2013 Philipp Zabel, Pengutronix
6 */
7
8#include <linux/clk-provider.h>
9#include <linux/clk.h>
10#include <linux/component.h>
11#include <linux/i2c.h>
12#include <linux/module.h>
13#include <linux/platform_device.h>
14#include <linux/regmap.h>
15#include <linux/regulator/consumer.h>
16#include <linux/videodev2.h>
17
18#include <video/imx-ipu-v3.h>
19
20#include <drm/drm_atomic_helper.h>
21#include <drm/drm_edid.h>
22#include <drm/drm_managed.h>
23#include <drm/drm_probe_helper.h>
24#include <drm/drm_simple_kms_helper.h>
25
26#include "imx-drm.h"
27
28#define TVE_COM_CONF_REG 0x00
29#define TVE_TVDAC0_CONT_REG 0x28
30#define TVE_TVDAC1_CONT_REG 0x2c
31#define TVE_TVDAC2_CONT_REG 0x30
32#define TVE_CD_CONT_REG 0x34
33#define TVE_INT_CONT_REG 0x64
34#define TVE_STAT_REG 0x68
35#define TVE_TST_MODE_REG 0x6c
36#define TVE_MV_CONT_REG 0xdc
37
38/* TVE_COM_CONF_REG */
39#define TVE_SYNC_CH_2_EN BIT(22)
40#define TVE_SYNC_CH_1_EN BIT(21)
41#define TVE_SYNC_CH_0_EN BIT(20)
42#define TVE_TV_OUT_MODE_MASK (0x7 << 12)
43#define TVE_TV_OUT_DISABLE (0x0 << 12)
44#define TVE_TV_OUT_CVBS_0 (0x1 << 12)
45#define TVE_TV_OUT_CVBS_2 (0x2 << 12)
46#define TVE_TV_OUT_CVBS_0_2 (0x3 << 12)
47#define TVE_TV_OUT_SVIDEO_0_1 (0x4 << 12)
48#define TVE_TV_OUT_SVIDEO_0_1_CVBS2_2 (0x5 << 12)
49#define TVE_TV_OUT_YPBPR (0x6 << 12)
50#define TVE_TV_OUT_RGB (0x7 << 12)
51#define TVE_TV_STAND_MASK (0xf << 8)
52#define TVE_TV_STAND_HD_1080P30 (0xc << 8)
53#define TVE_P2I_CONV_EN BIT(7)
54#define TVE_INP_VIDEO_FORM BIT(6)
55#define TVE_INP_YCBCR_422 (0x0 << 6)
56#define TVE_INP_YCBCR_444 (0x1 << 6)
57#define TVE_DATA_SOURCE_MASK (0x3 << 4)
58#define TVE_DATA_SOURCE_BUS1 (0x0 << 4)
59#define TVE_DATA_SOURCE_BUS2 (0x1 << 4)
60#define TVE_DATA_SOURCE_EXT (0x2 << 4)
61#define TVE_DATA_SOURCE_TESTGEN (0x3 << 4)
62#define TVE_IPU_CLK_EN_OFS 3
63#define TVE_IPU_CLK_EN BIT(3)
64#define TVE_DAC_SAMP_RATE_OFS 1
65#define TVE_DAC_SAMP_RATE_WIDTH 2
66#define TVE_DAC_SAMP_RATE_MASK (0x3 << 1)
67#define TVE_DAC_FULL_RATE (0x0 << 1)
68#define TVE_DAC_DIV2_RATE (0x1 << 1)
69#define TVE_DAC_DIV4_RATE (0x2 << 1)
70#define TVE_EN BIT(0)
71
72/* TVE_TVDACx_CONT_REG */
73#define TVE_TVDAC_GAIN_MASK (0x3f << 0)
74
75/* TVE_CD_CONT_REG */
76#define TVE_CD_CH_2_SM_EN BIT(22)
77#define TVE_CD_CH_1_SM_EN BIT(21)
78#define TVE_CD_CH_0_SM_EN BIT(20)
79#define TVE_CD_CH_2_LM_EN BIT(18)
80#define TVE_CD_CH_1_LM_EN BIT(17)
81#define TVE_CD_CH_0_LM_EN BIT(16)
82#define TVE_CD_CH_2_REF_LVL BIT(10)
83#define TVE_CD_CH_1_REF_LVL BIT(9)
84#define TVE_CD_CH_0_REF_LVL BIT(8)
85#define TVE_CD_EN BIT(0)
86
87/* TVE_INT_CONT_REG */
88#define TVE_FRAME_END_IEN BIT(13)
89#define TVE_CD_MON_END_IEN BIT(2)
90#define TVE_CD_SM_IEN BIT(1)
91#define TVE_CD_LM_IEN BIT(0)
92
93/* TVE_TST_MODE_REG */
94#define TVE_TVDAC_TEST_MODE_MASK (0x7 << 0)
95
96#define IMX_TVE_DAC_VOLTAGE 2750000
97
98enum {
99 TVE_MODE_TVOUT,
100 TVE_MODE_VGA,
101};
102
103struct imx_tve_encoder {
104 struct drm_connector connector;
105 struct drm_encoder encoder;
106 struct imx_tve *tve;
107};
108
109struct imx_tve {
110 struct device *dev;
111 int mode;
112 int di_hsync_pin;
113 int di_vsync_pin;
114
115 struct regmap *regmap;
116 struct regulator *dac_reg;
117 struct i2c_adapter *ddc;
118 struct clk *clk;
119 struct clk *di_sel_clk;
120 struct clk_hw clk_hw_di;
121 struct clk *di_clk;
122};
123
124static inline struct imx_tve *con_to_tve(struct drm_connector *c)
125{
126 return container_of(c, struct imx_tve_encoder, connector)->tve;
127}
128
129static inline struct imx_tve *enc_to_tve(struct drm_encoder *e)
130{
131 return container_of(e, struct imx_tve_encoder, encoder)->tve;
132}
133
134static void tve_enable(struct imx_tve *tve)
135{
136 clk_prepare_enable(tve->clk);
137 regmap_update_bits(tve->regmap, TVE_COM_CONF_REG, TVE_EN, TVE_EN);
138
139 /* clear interrupt status register */
140 regmap_write(tve->regmap, TVE_STAT_REG, 0xffffffff);
141
142 /* cable detection irq disabled in VGA mode, enabled in TVOUT mode */
143 if (tve->mode == TVE_MODE_VGA)
144 regmap_write(tve->regmap, TVE_INT_CONT_REG, 0);
145 else
146 regmap_write(tve->regmap, TVE_INT_CONT_REG,
147 TVE_CD_SM_IEN |
148 TVE_CD_LM_IEN |
149 TVE_CD_MON_END_IEN);
150}
151
152static void tve_disable(struct imx_tve *tve)
153{
154 regmap_update_bits(tve->regmap, TVE_COM_CONF_REG, TVE_EN, 0);
155 clk_disable_unprepare(tve->clk);
156}
157
158static int tve_setup_tvout(struct imx_tve *tve)
159{
160 return -ENOTSUPP;
161}
162
163static int tve_setup_vga(struct imx_tve *tve)
164{
165 unsigned int mask;
166 unsigned int val;
167 int ret;
168
169 /* set gain to (1 + 10/128) to provide 0.7V peak-to-peak amplitude */
170 ret = regmap_update_bits(tve->regmap, TVE_TVDAC0_CONT_REG,
171 TVE_TVDAC_GAIN_MASK, 0x0a);
172 if (ret)
173 return ret;
174
175 ret = regmap_update_bits(tve->regmap, TVE_TVDAC1_CONT_REG,
176 TVE_TVDAC_GAIN_MASK, 0x0a);
177 if (ret)
178 return ret;
179
180 ret = regmap_update_bits(tve->regmap, TVE_TVDAC2_CONT_REG,
181 TVE_TVDAC_GAIN_MASK, 0x0a);
182 if (ret)
183 return ret;
184
185 /* set configuration register */
186 mask = TVE_DATA_SOURCE_MASK | TVE_INP_VIDEO_FORM;
187 val = TVE_DATA_SOURCE_BUS2 | TVE_INP_YCBCR_444;
188 mask |= TVE_TV_STAND_MASK | TVE_P2I_CONV_EN;
189 val |= TVE_TV_STAND_HD_1080P30 | 0;
190 mask |= TVE_TV_OUT_MODE_MASK | TVE_SYNC_CH_0_EN;
191 val |= TVE_TV_OUT_RGB | TVE_SYNC_CH_0_EN;
192 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG, mask, val);
193 if (ret)
194 return ret;
195
196 /* set test mode (as documented) */
197 return regmap_update_bits(tve->regmap, TVE_TST_MODE_REG,
198 TVE_TVDAC_TEST_MODE_MASK, 1);
199}
200
201static int imx_tve_connector_get_modes(struct drm_connector *connector)
202{
203 struct imx_tve *tve = con_to_tve(connector);
204 struct edid *edid;
205 int ret = 0;
206
207 if (!tve->ddc)
208 return 0;
209
210 edid = drm_get_edid(connector, tve->ddc);
211 if (edid) {
212 drm_connector_update_edid_property(connector, edid);
213 ret = drm_add_edid_modes(connector, edid);
214 kfree(edid);
215 }
216
217 return ret;
218}
219
220static enum drm_mode_status
221imx_tve_connector_mode_valid(struct drm_connector *connector,
222 struct drm_display_mode *mode)
223{
224 struct imx_tve *tve = con_to_tve(connector);
225 unsigned long rate;
226
227 /* pixel clock with 2x oversampling */
228 rate = clk_round_rate(tve->clk, 2000UL * mode->clock) / 2000;
229 if (rate == mode->clock)
230 return MODE_OK;
231
232 /* pixel clock without oversampling */
233 rate = clk_round_rate(tve->clk, 1000UL * mode->clock) / 1000;
234 if (rate == mode->clock)
235 return MODE_OK;
236
237 dev_warn(tve->dev, "ignoring mode %dx%d\n",
238 mode->hdisplay, mode->vdisplay);
239
240 return MODE_BAD;
241}
242
243static void imx_tve_encoder_mode_set(struct drm_encoder *encoder,
244 struct drm_display_mode *orig_mode,
245 struct drm_display_mode *mode)
246{
247 struct imx_tve *tve = enc_to_tve(encoder);
248 unsigned long rounded_rate;
249 unsigned long rate;
250 int div = 1;
251 int ret;
252
253 /*
254 * FIXME
255 * we should try 4k * mode->clock first,
256 * and enable 4x oversampling for lower resolutions
257 */
258 rate = 2000UL * mode->clock;
259 clk_set_rate(tve->clk, rate);
260 rounded_rate = clk_get_rate(tve->clk);
261 if (rounded_rate >= rate)
262 div = 2;
263 clk_set_rate(tve->di_clk, rounded_rate / div);
264
265 ret = clk_set_parent(tve->di_sel_clk, tve->di_clk);
266 if (ret < 0) {
267 dev_err(tve->dev, "failed to set di_sel parent to tve_di: %d\n",
268 ret);
269 }
270
271 regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
272 TVE_IPU_CLK_EN, TVE_IPU_CLK_EN);
273
274 if (tve->mode == TVE_MODE_VGA)
275 ret = tve_setup_vga(tve);
276 else
277 ret = tve_setup_tvout(tve);
278 if (ret)
279 dev_err(tve->dev, "failed to set configuration: %d\n", ret);
280}
281
282static void imx_tve_encoder_enable(struct drm_encoder *encoder)
283{
284 struct imx_tve *tve = enc_to_tve(encoder);
285
286 tve_enable(tve);
287}
288
289static void imx_tve_encoder_disable(struct drm_encoder *encoder)
290{
291 struct imx_tve *tve = enc_to_tve(encoder);
292
293 tve_disable(tve);
294}
295
296static int imx_tve_atomic_check(struct drm_encoder *encoder,
297 struct drm_crtc_state *crtc_state,
298 struct drm_connector_state *conn_state)
299{
300 struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state);
301 struct imx_tve *tve = enc_to_tve(encoder);
302
303 imx_crtc_state->bus_format = MEDIA_BUS_FMT_GBR888_1X24;
304 imx_crtc_state->di_hsync_pin = tve->di_hsync_pin;
305 imx_crtc_state->di_vsync_pin = tve->di_vsync_pin;
306
307 return 0;
308}
309
310static const struct drm_connector_funcs imx_tve_connector_funcs = {
311 .fill_modes = drm_helper_probe_single_connector_modes,
312 .destroy = imx_drm_connector_destroy,
313 .reset = drm_atomic_helper_connector_reset,
314 .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
315 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
316};
317
318static const struct drm_connector_helper_funcs imx_tve_connector_helper_funcs = {
319 .get_modes = imx_tve_connector_get_modes,
320 .mode_valid = imx_tve_connector_mode_valid,
321};
322
323static const struct drm_encoder_helper_funcs imx_tve_encoder_helper_funcs = {
324 .mode_set = imx_tve_encoder_mode_set,
325 .enable = imx_tve_encoder_enable,
326 .disable = imx_tve_encoder_disable,
327 .atomic_check = imx_tve_atomic_check,
328};
329
330static irqreturn_t imx_tve_irq_handler(int irq, void *data)
331{
332 struct imx_tve *tve = data;
333 unsigned int val;
334
335 regmap_read(tve->regmap, TVE_STAT_REG, &val);
336
337 /* clear interrupt status register */
338 regmap_write(tve->regmap, TVE_STAT_REG, 0xffffffff);
339
340 return IRQ_HANDLED;
341}
342
343static unsigned long clk_tve_di_recalc_rate(struct clk_hw *hw,
344 unsigned long parent_rate)
345{
346 struct imx_tve *tve = container_of(hw, struct imx_tve, clk_hw_di);
347 unsigned int val;
348 int ret;
349
350 ret = regmap_read(tve->regmap, TVE_COM_CONF_REG, &val);
351 if (ret < 0)
352 return 0;
353
354 switch (val & TVE_DAC_SAMP_RATE_MASK) {
355 case TVE_DAC_DIV4_RATE:
356 return parent_rate / 4;
357 case TVE_DAC_DIV2_RATE:
358 return parent_rate / 2;
359 case TVE_DAC_FULL_RATE:
360 default:
361 return parent_rate;
362 }
363
364 return 0;
365}
366
367static long clk_tve_di_round_rate(struct clk_hw *hw, unsigned long rate,
368 unsigned long *prate)
369{
370 unsigned long div;
371
372 div = *prate / rate;
373 if (div >= 4)
374 return *prate / 4;
375 else if (div >= 2)
376 return *prate / 2;
377 return *prate;
378}
379
380static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate,
381 unsigned long parent_rate)
382{
383 struct imx_tve *tve = container_of(hw, struct imx_tve, clk_hw_di);
384 unsigned long div;
385 u32 val;
386 int ret;
387
388 div = parent_rate / rate;
389 if (div >= 4)
390 val = TVE_DAC_DIV4_RATE;
391 else if (div >= 2)
392 val = TVE_DAC_DIV2_RATE;
393 else
394 val = TVE_DAC_FULL_RATE;
395
396 ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
397 TVE_DAC_SAMP_RATE_MASK, val);
398
399 if (ret < 0) {
400 dev_err(tve->dev, "failed to set divider: %d\n", ret);
401 return ret;
402 }
403
404 return 0;
405}
406
407static const struct clk_ops clk_tve_di_ops = {
408 .round_rate = clk_tve_di_round_rate,
409 .set_rate = clk_tve_di_set_rate,
410 .recalc_rate = clk_tve_di_recalc_rate,
411};
412
413static int tve_clk_init(struct imx_tve *tve, void __iomem *base)
414{
415 const char *tve_di_parent[1];
416 struct clk_init_data init = {
417 .name = "tve_di",
418 .ops = &clk_tve_di_ops,
419 .num_parents = 1,
420 .flags = 0,
421 };
422
423 tve_di_parent[0] = __clk_get_name(tve->clk);
424 init.parent_names = (const char **)&tve_di_parent;
425
426 tve->clk_hw_di.init = &init;
427 tve->di_clk = devm_clk_register(tve->dev, &tve->clk_hw_di);
428 if (IS_ERR(tve->di_clk)) {
429 dev_err(tve->dev, "failed to register TVE output clock: %ld\n",
430 PTR_ERR(tve->di_clk));
431 return PTR_ERR(tve->di_clk);
432 }
433
434 return 0;
435}
436
437static void imx_tve_disable_regulator(void *data)
438{
439 struct imx_tve *tve = data;
440
441 regulator_disable(tve->dac_reg);
442}
443
444static bool imx_tve_readable_reg(struct device *dev, unsigned int reg)
445{
446 return (reg % 4 == 0) && (reg <= 0xdc);
447}
448
449static struct regmap_config tve_regmap_config = {
450 .reg_bits = 32,
451 .val_bits = 32,
452 .reg_stride = 4,
453
454 .readable_reg = imx_tve_readable_reg,
455
456 .fast_io = true,
457
458 .max_register = 0xdc,
459};
460
461static const char * const imx_tve_modes[] = {
462 [TVE_MODE_TVOUT] = "tvout",
463 [TVE_MODE_VGA] = "vga",
464};
465
466static int of_get_tve_mode(struct device_node *np)
467{
468 const char *bm;
469 int ret, i;
470
471 ret = of_property_read_string(np, "fsl,tve-mode", &bm);
472 if (ret < 0)
473 return ret;
474
475 for (i = 0; i < ARRAY_SIZE(imx_tve_modes); i++)
476 if (!strcasecmp(bm, imx_tve_modes[i]))
477 return i;
478
479 return -EINVAL;
480}
481
482static int imx_tve_bind(struct device *dev, struct device *master, void *data)
483{
484 struct drm_device *drm = data;
485 struct imx_tve *tve = dev_get_drvdata(dev);
486 struct imx_tve_encoder *tvee;
487 struct drm_encoder *encoder;
488 struct drm_connector *connector;
489 int encoder_type;
490 int ret;
491
492 encoder_type = tve->mode == TVE_MODE_VGA ?
493 DRM_MODE_ENCODER_DAC : DRM_MODE_ENCODER_TVDAC;
494
495 tvee = drmm_simple_encoder_alloc(drm, struct imx_tve_encoder, encoder,
496 encoder_type);
497 if (IS_ERR(tvee))
498 return PTR_ERR(tvee);
499
500 tvee->tve = tve;
501 encoder = &tvee->encoder;
502 connector = &tvee->connector;
503
504 ret = imx_drm_encoder_parse_of(drm, encoder, tve->dev->of_node);
505 if (ret)
506 return ret;
507
508 drm_encoder_helper_add(encoder, &imx_tve_encoder_helper_funcs);
509
510 drm_connector_helper_add(connector, &imx_tve_connector_helper_funcs);
511 ret = drm_connector_init_with_ddc(drm, connector,
512 &imx_tve_connector_funcs,
513 DRM_MODE_CONNECTOR_VGA, tve->ddc);
514 if (ret)
515 return ret;
516
517 return drm_connector_attach_encoder(connector, encoder);
518}
519
520static const struct component_ops imx_tve_ops = {
521 .bind = imx_tve_bind,
522};
523
524static int imx_tve_probe(struct platform_device *pdev)
525{
526 struct device *dev = &pdev->dev;
527 struct device_node *np = dev->of_node;
528 struct device_node *ddc_node;
529 struct imx_tve *tve;
530 void __iomem *base;
531 unsigned int val;
532 int irq;
533 int ret;
534
535 tve = devm_kzalloc(dev, sizeof(*tve), GFP_KERNEL);
536 if (!tve)
537 return -ENOMEM;
538
539 tve->dev = dev;
540
541 ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
542 if (ddc_node) {
543 tve->ddc = of_find_i2c_adapter_by_node(ddc_node);
544 of_node_put(ddc_node);
545 }
546
547 tve->mode = of_get_tve_mode(np);
548 if (tve->mode != TVE_MODE_VGA) {
549 dev_err(dev, "only VGA mode supported, currently\n");
550 return -EINVAL;
551 }
552
553 if (tve->mode == TVE_MODE_VGA) {
554 ret = of_property_read_u32(np, "fsl,hsync-pin",
555 &tve->di_hsync_pin);
556
557 if (ret < 0) {
558 dev_err(dev, "failed to get hsync pin\n");
559 return ret;
560 }
561
562 ret = of_property_read_u32(np, "fsl,vsync-pin",
563 &tve->di_vsync_pin);
564
565 if (ret < 0) {
566 dev_err(dev, "failed to get vsync pin\n");
567 return ret;
568 }
569 }
570
571 base = devm_platform_ioremap_resource(pdev, 0);
572 if (IS_ERR(base))
573 return PTR_ERR(base);
574
575 tve_regmap_config.lock_arg = tve;
576 tve->regmap = devm_regmap_init_mmio_clk(dev, "tve", base,
577 &tve_regmap_config);
578 if (IS_ERR(tve->regmap)) {
579 dev_err(dev, "failed to init regmap: %ld\n",
580 PTR_ERR(tve->regmap));
581 return PTR_ERR(tve->regmap);
582 }
583
584 irq = platform_get_irq(pdev, 0);
585 if (irq < 0)
586 return irq;
587
588 ret = devm_request_threaded_irq(dev, irq, NULL,
589 imx_tve_irq_handler, IRQF_ONESHOT,
590 "imx-tve", tve);
591 if (ret < 0) {
592 dev_err(dev, "failed to request irq: %d\n", ret);
593 return ret;
594 }
595
596 tve->dac_reg = devm_regulator_get(dev, "dac");
597 if (!IS_ERR(tve->dac_reg)) {
598 if (regulator_get_voltage(tve->dac_reg) != IMX_TVE_DAC_VOLTAGE)
599 dev_warn(dev, "dac voltage is not %d uV\n", IMX_TVE_DAC_VOLTAGE);
600 ret = regulator_enable(tve->dac_reg);
601 if (ret)
602 return ret;
603 ret = devm_add_action_or_reset(dev, imx_tve_disable_regulator, tve);
604 if (ret)
605 return ret;
606 }
607
608 tve->clk = devm_clk_get(dev, "tve");
609 if (IS_ERR(tve->clk)) {
610 dev_err(dev, "failed to get high speed tve clock: %ld\n",
611 PTR_ERR(tve->clk));
612 return PTR_ERR(tve->clk);
613 }
614
615 /* this is the IPU DI clock input selector, can be parented to tve_di */
616 tve->di_sel_clk = devm_clk_get(dev, "di_sel");
617 if (IS_ERR(tve->di_sel_clk)) {
618 dev_err(dev, "failed to get ipu di mux clock: %ld\n",
619 PTR_ERR(tve->di_sel_clk));
620 return PTR_ERR(tve->di_sel_clk);
621 }
622
623 ret = tve_clk_init(tve, base);
624 if (ret < 0)
625 return ret;
626
627 ret = regmap_read(tve->regmap, TVE_COM_CONF_REG, &val);
628 if (ret < 0) {
629 dev_err(dev, "failed to read configuration register: %d\n",
630 ret);
631 return ret;
632 }
633 if (val != 0x00100000) {
634 dev_err(dev, "configuration register default value indicates this is not a TVEv2\n");
635 return -ENODEV;
636 }
637
638 /* disable cable detection for VGA mode */
639 ret = regmap_write(tve->regmap, TVE_CD_CONT_REG, 0);
640 if (ret)
641 return ret;
642
643 platform_set_drvdata(pdev, tve);
644
645 return component_add(dev, &imx_tve_ops);
646}
647
648static int imx_tve_remove(struct platform_device *pdev)
649{
650 component_del(&pdev->dev, &imx_tve_ops);
651 return 0;
652}
653
654static const struct of_device_id imx_tve_dt_ids[] = {
655 { .compatible = "fsl,imx53-tve", },
656 { /* sentinel */ }
657};
658MODULE_DEVICE_TABLE(of, imx_tve_dt_ids);
659
660static struct platform_driver imx_tve_driver = {
661 .probe = imx_tve_probe,
662 .remove = imx_tve_remove,
663 .driver = {
664 .of_match_table = imx_tve_dt_ids,
665 .name = "imx-tve",
666 },
667};
668
669module_platform_driver(imx_tve_driver);
670
671MODULE_DESCRIPTION("i.MX Television Encoder driver");
672MODULE_AUTHOR("Philipp Zabel, Pengutronix");
673MODULE_LICENSE("GPL");
674MODULE_ALIAS("platform:imx-tve");