Loading...
1/*
2 * Copyright (C) 2012 Russell King
3 * Rewritten from the dovefb driver, and Armada510 manuals.
4 *
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 2 as
7 * published by the Free Software Foundation.
8 */
9#include <drm/drmP.h>
10#include <drm/drm_plane_helper.h>
11#include "armada_crtc.h"
12#include "armada_drm.h"
13#include "armada_fb.h"
14#include "armada_gem.h"
15#include "armada_hw.h"
16#include <drm/armada_drm.h>
17#include "armada_ioctlP.h"
18
19struct armada_ovl_plane_properties {
20 uint32_t colorkey_yr;
21 uint32_t colorkey_ug;
22 uint32_t colorkey_vb;
23#define K2R(val) (((val) >> 0) & 0xff)
24#define K2G(val) (((val) >> 8) & 0xff)
25#define K2B(val) (((val) >> 16) & 0xff)
26 int16_t brightness;
27 uint16_t contrast;
28 uint16_t saturation;
29 uint32_t colorkey_mode;
30};
31
32struct armada_ovl_plane {
33 struct armada_plane base;
34 struct drm_framebuffer *old_fb;
35 uint32_t src_hw;
36 uint32_t dst_hw;
37 uint32_t dst_yx;
38 uint32_t ctrl0;
39 struct {
40 struct armada_plane_work work;
41 struct armada_regs regs[13];
42 } vbl;
43 struct armada_ovl_plane_properties prop;
44};
45#define drm_to_armada_ovl_plane(p) \
46 container_of(p, struct armada_ovl_plane, base.base)
47
48
49static void
50armada_ovl_update_attr(struct armada_ovl_plane_properties *prop,
51 struct armada_crtc *dcrtc)
52{
53 writel_relaxed(prop->colorkey_yr, dcrtc->base + LCD_SPU_COLORKEY_Y);
54 writel_relaxed(prop->colorkey_ug, dcrtc->base + LCD_SPU_COLORKEY_U);
55 writel_relaxed(prop->colorkey_vb, dcrtc->base + LCD_SPU_COLORKEY_V);
56
57 writel_relaxed(prop->brightness << 16 | prop->contrast,
58 dcrtc->base + LCD_SPU_CONTRAST);
59 /* Docs say 15:0, but it seems to actually be 31:16 on Armada 510 */
60 writel_relaxed(prop->saturation << 16,
61 dcrtc->base + LCD_SPU_SATURATION);
62 writel_relaxed(0x00002000, dcrtc->base + LCD_SPU_CBSH_HUE);
63
64 spin_lock_irq(&dcrtc->irq_lock);
65 armada_updatel(prop->colorkey_mode | CFG_ALPHAM_GRA,
66 CFG_CKMODE_MASK | CFG_ALPHAM_MASK | CFG_ALPHA_MASK,
67 dcrtc->base + LCD_SPU_DMA_CTRL1);
68
69 armada_updatel(ADV_GRACOLORKEY, 0, dcrtc->base + LCD_SPU_ADV_REG);
70 spin_unlock_irq(&dcrtc->irq_lock);
71}
72
73static void armada_ovl_retire_fb(struct armada_ovl_plane *dplane,
74 struct drm_framebuffer *fb)
75{
76 struct drm_framebuffer *old_fb;
77
78 old_fb = xchg(&dplane->old_fb, fb);
79
80 if (old_fb)
81 armada_drm_queue_unref_work(dplane->base.base.dev, old_fb);
82}
83
84/* === Plane support === */
85static void armada_ovl_plane_work(struct armada_crtc *dcrtc,
86 struct armada_plane *plane, struct armada_plane_work *work)
87{
88 struct armada_ovl_plane *dplane = container_of(plane, struct armada_ovl_plane, base);
89
90 armada_drm_crtc_update_regs(dcrtc, dplane->vbl.regs);
91 armada_ovl_retire_fb(dplane, NULL);
92}
93
94static int
95armada_ovl_plane_update(struct drm_plane *plane, struct drm_crtc *crtc,
96 struct drm_framebuffer *fb,
97 int crtc_x, int crtc_y, unsigned crtc_w, unsigned crtc_h,
98 uint32_t src_x, uint32_t src_y, uint32_t src_w, uint32_t src_h)
99{
100 struct armada_ovl_plane *dplane = drm_to_armada_ovl_plane(plane);
101 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
102 struct drm_rect src = {
103 .x1 = src_x,
104 .y1 = src_y,
105 .x2 = src_x + src_w,
106 .y2 = src_y + src_h,
107 };
108 struct drm_rect dest = {
109 .x1 = crtc_x,
110 .y1 = crtc_y,
111 .x2 = crtc_x + crtc_w,
112 .y2 = crtc_y + crtc_h,
113 };
114 const struct drm_rect clip = {
115 .x2 = crtc->mode.hdisplay,
116 .y2 = crtc->mode.vdisplay,
117 };
118 uint32_t val, ctrl0;
119 unsigned idx = 0;
120 bool visible;
121 int ret;
122
123 ret = drm_plane_helper_check_update(plane, crtc, fb, &src, &dest, &clip,
124 0, INT_MAX, true, false, &visible);
125 if (ret)
126 return ret;
127
128 ctrl0 = CFG_DMA_FMT(drm_fb_to_armada_fb(fb)->fmt) |
129 CFG_DMA_MOD(drm_fb_to_armada_fb(fb)->mod) |
130 CFG_CBSH_ENA | CFG_DMA_HSMOOTH | CFG_DMA_ENA;
131
132 /* Does the position/size result in nothing to display? */
133 if (!visible)
134 ctrl0 &= ~CFG_DMA_ENA;
135
136 if (!dcrtc->plane) {
137 dcrtc->plane = plane;
138 armada_ovl_update_attr(&dplane->prop, dcrtc);
139 }
140
141 /* FIXME: overlay on an interlaced display */
142 /* Just updating the position/size? */
143 if (plane->fb == fb && dplane->ctrl0 == ctrl0) {
144 val = (drm_rect_height(&src) & 0xffff0000) |
145 drm_rect_width(&src) >> 16;
146 dplane->src_hw = val;
147 writel_relaxed(val, dcrtc->base + LCD_SPU_DMA_HPXL_VLN);
148
149 val = drm_rect_height(&dest) << 16 | drm_rect_width(&dest);
150 dplane->dst_hw = val;
151 writel_relaxed(val, dcrtc->base + LCD_SPU_DZM_HPXL_VLN);
152
153 val = dest.y1 << 16 | dest.x1;
154 dplane->dst_yx = val;
155 writel_relaxed(val, dcrtc->base + LCD_SPU_DMA_OVSA_HPXL_VLN);
156
157 return 0;
158 } else if (~dplane->ctrl0 & ctrl0 & CFG_DMA_ENA) {
159 /* Power up the Y/U/V FIFOs on ENA 0->1 transitions */
160 armada_updatel(0, CFG_PDWN16x66 | CFG_PDWN32x66,
161 dcrtc->base + LCD_SPU_SRAM_PARA1);
162 }
163
164 if (armada_drm_plane_work_wait(&dplane->base, HZ / 25) == 0)
165 armada_drm_plane_work_cancel(dcrtc, &dplane->base);
166
167 if (plane->fb != fb) {
168 struct armada_gem_object *obj = drm_fb_obj(fb);
169 uint32_t addr[3], pixel_format;
170 int i, num_planes, hsub;
171
172 /*
173 * Take a reference on the new framebuffer - we want to
174 * hold on to it while the hardware is displaying it.
175 */
176 drm_framebuffer_reference(fb);
177
178 if (plane->fb)
179 armada_ovl_retire_fb(dplane, plane->fb);
180
181 src_y = src.y1 >> 16;
182 src_x = src.x1 >> 16;
183
184 pixel_format = fb->pixel_format;
185 hsub = drm_format_horz_chroma_subsampling(pixel_format);
186 num_planes = drm_format_num_planes(pixel_format);
187
188 /*
189 * Annoyingly, shifting a YUYV-format image by one pixel
190 * causes the U/V planes to toggle. Toggle the UV swap.
191 * (Unfortunately, this causes momentary colour flickering.)
192 */
193 if (src_x & (hsub - 1) && num_planes == 1)
194 ctrl0 ^= CFG_DMA_MOD(CFG_SWAPUV);
195
196 for (i = 0; i < num_planes; i++)
197 addr[i] = obj->dev_addr + fb->offsets[i] +
198 src_y * fb->pitches[i] +
199 src_x * drm_format_plane_cpp(pixel_format, i);
200 for (; i < ARRAY_SIZE(addr); i++)
201 addr[i] = 0;
202
203 armada_reg_queue_set(dplane->vbl.regs, idx, addr[0],
204 LCD_SPU_DMA_START_ADDR_Y0);
205 armada_reg_queue_set(dplane->vbl.regs, idx, addr[1],
206 LCD_SPU_DMA_START_ADDR_U0);
207 armada_reg_queue_set(dplane->vbl.regs, idx, addr[2],
208 LCD_SPU_DMA_START_ADDR_V0);
209 armada_reg_queue_set(dplane->vbl.regs, idx, addr[0],
210 LCD_SPU_DMA_START_ADDR_Y1);
211 armada_reg_queue_set(dplane->vbl.regs, idx, addr[1],
212 LCD_SPU_DMA_START_ADDR_U1);
213 armada_reg_queue_set(dplane->vbl.regs, idx, addr[2],
214 LCD_SPU_DMA_START_ADDR_V1);
215
216 val = fb->pitches[0] << 16 | fb->pitches[0];
217 armada_reg_queue_set(dplane->vbl.regs, idx, val,
218 LCD_SPU_DMA_PITCH_YC);
219 val = fb->pitches[1] << 16 | fb->pitches[2];
220 armada_reg_queue_set(dplane->vbl.regs, idx, val,
221 LCD_SPU_DMA_PITCH_UV);
222 }
223
224 val = (drm_rect_height(&src) & 0xffff0000) | drm_rect_width(&src) >> 16;
225 if (dplane->src_hw != val) {
226 dplane->src_hw = val;
227 armada_reg_queue_set(dplane->vbl.regs, idx, val,
228 LCD_SPU_DMA_HPXL_VLN);
229 }
230
231 val = drm_rect_height(&dest) << 16 | drm_rect_width(&dest);
232 if (dplane->dst_hw != val) {
233 dplane->dst_hw = val;
234 armada_reg_queue_set(dplane->vbl.regs, idx, val,
235 LCD_SPU_DZM_HPXL_VLN);
236 }
237
238 val = dest.y1 << 16 | dest.x1;
239 if (dplane->dst_yx != val) {
240 dplane->dst_yx = val;
241 armada_reg_queue_set(dplane->vbl.regs, idx, val,
242 LCD_SPU_DMA_OVSA_HPXL_VLN);
243 }
244
245 if (dplane->ctrl0 != ctrl0) {
246 dplane->ctrl0 = ctrl0;
247 armada_reg_queue_mod(dplane->vbl.regs, idx, ctrl0,
248 CFG_CBSH_ENA | CFG_DMAFORMAT | CFG_DMA_FTOGGLE |
249 CFG_DMA_HSMOOTH | CFG_DMA_TSTMODE |
250 CFG_DMA_MOD(CFG_SWAPRB | CFG_SWAPUV | CFG_SWAPYU |
251 CFG_YUV2RGB) | CFG_DMA_ENA,
252 LCD_SPU_DMA_CTRL0);
253 }
254 if (idx) {
255 armada_reg_queue_end(dplane->vbl.regs, idx);
256 armada_drm_plane_work_queue(dcrtc, &dplane->base,
257 &dplane->vbl.work);
258 }
259 return 0;
260}
261
262static int armada_ovl_plane_disable(struct drm_plane *plane)
263{
264 struct armada_ovl_plane *dplane = drm_to_armada_ovl_plane(plane);
265 struct drm_framebuffer *fb;
266 struct armada_crtc *dcrtc;
267
268 if (!dplane->base.base.crtc)
269 return 0;
270
271 dcrtc = drm_to_armada_crtc(dplane->base.base.crtc);
272
273 armada_drm_plane_work_cancel(dcrtc, &dplane->base);
274 armada_drm_crtc_plane_disable(dcrtc, plane);
275
276 dcrtc->plane = NULL;
277 dplane->ctrl0 = 0;
278
279 fb = xchg(&dplane->old_fb, NULL);
280 if (fb)
281 drm_framebuffer_unreference(fb);
282
283 return 0;
284}
285
286static void armada_ovl_plane_destroy(struct drm_plane *plane)
287{
288 struct armada_ovl_plane *dplane = drm_to_armada_ovl_plane(plane);
289
290 drm_plane_cleanup(plane);
291
292 kfree(dplane);
293}
294
295static int armada_ovl_plane_set_property(struct drm_plane *plane,
296 struct drm_property *property, uint64_t val)
297{
298 struct armada_private *priv = plane->dev->dev_private;
299 struct armada_ovl_plane *dplane = drm_to_armada_ovl_plane(plane);
300 bool update_attr = false;
301
302 if (property == priv->colorkey_prop) {
303#define CCC(v) ((v) << 24 | (v) << 16 | (v) << 8)
304 dplane->prop.colorkey_yr = CCC(K2R(val));
305 dplane->prop.colorkey_ug = CCC(K2G(val));
306 dplane->prop.colorkey_vb = CCC(K2B(val));
307#undef CCC
308 update_attr = true;
309 } else if (property == priv->colorkey_min_prop) {
310 dplane->prop.colorkey_yr &= ~0x00ff0000;
311 dplane->prop.colorkey_yr |= K2R(val) << 16;
312 dplane->prop.colorkey_ug &= ~0x00ff0000;
313 dplane->prop.colorkey_ug |= K2G(val) << 16;
314 dplane->prop.colorkey_vb &= ~0x00ff0000;
315 dplane->prop.colorkey_vb |= K2B(val) << 16;
316 update_attr = true;
317 } else if (property == priv->colorkey_max_prop) {
318 dplane->prop.colorkey_yr &= ~0xff000000;
319 dplane->prop.colorkey_yr |= K2R(val) << 24;
320 dplane->prop.colorkey_ug &= ~0xff000000;
321 dplane->prop.colorkey_ug |= K2G(val) << 24;
322 dplane->prop.colorkey_vb &= ~0xff000000;
323 dplane->prop.colorkey_vb |= K2B(val) << 24;
324 update_attr = true;
325 } else if (property == priv->colorkey_val_prop) {
326 dplane->prop.colorkey_yr &= ~0x0000ff00;
327 dplane->prop.colorkey_yr |= K2R(val) << 8;
328 dplane->prop.colorkey_ug &= ~0x0000ff00;
329 dplane->prop.colorkey_ug |= K2G(val) << 8;
330 dplane->prop.colorkey_vb &= ~0x0000ff00;
331 dplane->prop.colorkey_vb |= K2B(val) << 8;
332 update_attr = true;
333 } else if (property == priv->colorkey_alpha_prop) {
334 dplane->prop.colorkey_yr &= ~0x000000ff;
335 dplane->prop.colorkey_yr |= K2R(val);
336 dplane->prop.colorkey_ug &= ~0x000000ff;
337 dplane->prop.colorkey_ug |= K2G(val);
338 dplane->prop.colorkey_vb &= ~0x000000ff;
339 dplane->prop.colorkey_vb |= K2B(val);
340 update_attr = true;
341 } else if (property == priv->colorkey_mode_prop) {
342 dplane->prop.colorkey_mode &= ~CFG_CKMODE_MASK;
343 dplane->prop.colorkey_mode |= CFG_CKMODE(val);
344 update_attr = true;
345 } else if (property == priv->brightness_prop) {
346 dplane->prop.brightness = val - 256;
347 update_attr = true;
348 } else if (property == priv->contrast_prop) {
349 dplane->prop.contrast = val;
350 update_attr = true;
351 } else if (property == priv->saturation_prop) {
352 dplane->prop.saturation = val;
353 update_attr = true;
354 }
355
356 if (update_attr && dplane->base.base.crtc)
357 armada_ovl_update_attr(&dplane->prop,
358 drm_to_armada_crtc(dplane->base.base.crtc));
359
360 return 0;
361}
362
363static const struct drm_plane_funcs armada_ovl_plane_funcs = {
364 .update_plane = armada_ovl_plane_update,
365 .disable_plane = armada_ovl_plane_disable,
366 .destroy = armada_ovl_plane_destroy,
367 .set_property = armada_ovl_plane_set_property,
368};
369
370static const uint32_t armada_ovl_formats[] = {
371 DRM_FORMAT_UYVY,
372 DRM_FORMAT_YUYV,
373 DRM_FORMAT_YUV420,
374 DRM_FORMAT_YVU420,
375 DRM_FORMAT_YUV422,
376 DRM_FORMAT_YVU422,
377 DRM_FORMAT_VYUY,
378 DRM_FORMAT_YVYU,
379 DRM_FORMAT_ARGB8888,
380 DRM_FORMAT_ABGR8888,
381 DRM_FORMAT_XRGB8888,
382 DRM_FORMAT_XBGR8888,
383 DRM_FORMAT_RGB888,
384 DRM_FORMAT_BGR888,
385 DRM_FORMAT_ARGB1555,
386 DRM_FORMAT_ABGR1555,
387 DRM_FORMAT_RGB565,
388 DRM_FORMAT_BGR565,
389};
390
391static struct drm_prop_enum_list armada_drm_colorkey_enum_list[] = {
392 { CKMODE_DISABLE, "disabled" },
393 { CKMODE_Y, "Y component" },
394 { CKMODE_U, "U component" },
395 { CKMODE_V, "V component" },
396 { CKMODE_RGB, "RGB" },
397 { CKMODE_R, "R component" },
398 { CKMODE_G, "G component" },
399 { CKMODE_B, "B component" },
400};
401
402static int armada_overlay_create_properties(struct drm_device *dev)
403{
404 struct armada_private *priv = dev->dev_private;
405
406 if (priv->colorkey_prop)
407 return 0;
408
409 priv->colorkey_prop = drm_property_create_range(dev, 0,
410 "colorkey", 0, 0xffffff);
411 priv->colorkey_min_prop = drm_property_create_range(dev, 0,
412 "colorkey_min", 0, 0xffffff);
413 priv->colorkey_max_prop = drm_property_create_range(dev, 0,
414 "colorkey_max", 0, 0xffffff);
415 priv->colorkey_val_prop = drm_property_create_range(dev, 0,
416 "colorkey_val", 0, 0xffffff);
417 priv->colorkey_alpha_prop = drm_property_create_range(dev, 0,
418 "colorkey_alpha", 0, 0xffffff);
419 priv->colorkey_mode_prop = drm_property_create_enum(dev, 0,
420 "colorkey_mode",
421 armada_drm_colorkey_enum_list,
422 ARRAY_SIZE(armada_drm_colorkey_enum_list));
423 priv->brightness_prop = drm_property_create_range(dev, 0,
424 "brightness", 0, 256 + 255);
425 priv->contrast_prop = drm_property_create_range(dev, 0,
426 "contrast", 0, 0x7fff);
427 priv->saturation_prop = drm_property_create_range(dev, 0,
428 "saturation", 0, 0x7fff);
429
430 if (!priv->colorkey_prop)
431 return -ENOMEM;
432
433 return 0;
434}
435
436int armada_overlay_plane_create(struct drm_device *dev, unsigned long crtcs)
437{
438 struct armada_private *priv = dev->dev_private;
439 struct drm_mode_object *mobj;
440 struct armada_ovl_plane *dplane;
441 int ret;
442
443 ret = armada_overlay_create_properties(dev);
444 if (ret)
445 return ret;
446
447 dplane = kzalloc(sizeof(*dplane), GFP_KERNEL);
448 if (!dplane)
449 return -ENOMEM;
450
451 ret = armada_drm_plane_init(&dplane->base);
452 if (ret) {
453 kfree(dplane);
454 return ret;
455 }
456
457 dplane->vbl.work.fn = armada_ovl_plane_work;
458
459 ret = drm_universal_plane_init(dev, &dplane->base.base, crtcs,
460 &armada_ovl_plane_funcs,
461 armada_ovl_formats,
462 ARRAY_SIZE(armada_ovl_formats),
463 DRM_PLANE_TYPE_OVERLAY, NULL);
464 if (ret) {
465 kfree(dplane);
466 return ret;
467 }
468
469 dplane->prop.colorkey_yr = 0xfefefe00;
470 dplane->prop.colorkey_ug = 0x01010100;
471 dplane->prop.colorkey_vb = 0x01010100;
472 dplane->prop.colorkey_mode = CFG_CKMODE(CKMODE_RGB);
473 dplane->prop.brightness = 0;
474 dplane->prop.contrast = 0x4000;
475 dplane->prop.saturation = 0x4000;
476
477 mobj = &dplane->base.base.base;
478 drm_object_attach_property(mobj, priv->colorkey_prop,
479 0x0101fe);
480 drm_object_attach_property(mobj, priv->colorkey_min_prop,
481 0x0101fe);
482 drm_object_attach_property(mobj, priv->colorkey_max_prop,
483 0x0101fe);
484 drm_object_attach_property(mobj, priv->colorkey_val_prop,
485 0x0101fe);
486 drm_object_attach_property(mobj, priv->colorkey_alpha_prop,
487 0x000000);
488 drm_object_attach_property(mobj, priv->colorkey_mode_prop,
489 CKMODE_RGB);
490 drm_object_attach_property(mobj, priv->brightness_prop, 256);
491 drm_object_attach_property(mobj, priv->contrast_prop,
492 dplane->prop.contrast);
493 drm_object_attach_property(mobj, priv->saturation_prop,
494 dplane->prop.saturation);
495
496 return 0;
497}
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2012 Russell King
4 * Rewritten from the dovefb driver, and Armada510 manuals.
5 */
6
7#include <drm/armada_drm.h>
8#include <drm/drm_atomic.h>
9#include <drm/drm_atomic_helper.h>
10#include <drm/drm_atomic_uapi.h>
11#include <drm/drm_fourcc.h>
12#include <drm/drm_plane_helper.h>
13
14#include "armada_crtc.h"
15#include "armada_drm.h"
16#include "armada_fb.h"
17#include "armada_gem.h"
18#include "armada_hw.h"
19#include "armada_ioctlP.h"
20#include "armada_plane.h"
21#include "armada_trace.h"
22
23#define DEFAULT_BRIGHTNESS 0
24#define DEFAULT_CONTRAST 0x4000
25#define DEFAULT_SATURATION 0x4000
26#define DEFAULT_ENCODING DRM_COLOR_YCBCR_BT601
27
28struct armada_overlay_state {
29 struct armada_plane_state base;
30 u32 colorkey_yr;
31 u32 colorkey_ug;
32 u32 colorkey_vb;
33 u32 colorkey_mode;
34 u32 colorkey_enable;
35 s16 brightness;
36 u16 contrast;
37 u16 saturation;
38};
39#define drm_to_overlay_state(s) \
40 container_of(s, struct armada_overlay_state, base.base)
41
42static inline u32 armada_spu_contrast(struct drm_plane_state *state)
43{
44 return drm_to_overlay_state(state)->brightness << 16 |
45 drm_to_overlay_state(state)->contrast;
46}
47
48static inline u32 armada_spu_saturation(struct drm_plane_state *state)
49{
50 /* Docs say 15:0, but it seems to actually be 31:16 on Armada 510 */
51 return drm_to_overlay_state(state)->saturation << 16;
52}
53
54static inline u32 armada_csc(struct drm_plane_state *state)
55{
56 /*
57 * The CFG_CSC_RGB_* settings control the output of the colour space
58 * converter, setting the range of output values it produces. Since
59 * we will be blending with the full-range graphics, we need to
60 * produce full-range RGB output from the conversion.
61 */
62 return CFG_CSC_RGB_COMPUTER |
63 (state->color_encoding == DRM_COLOR_YCBCR_BT709 ?
64 CFG_CSC_YUV_CCIR709 : CFG_CSC_YUV_CCIR601);
65}
66
67/* === Plane support === */
68static void armada_drm_overlay_plane_atomic_update(struct drm_plane *plane,
69 struct drm_atomic_state *state)
70{
71 struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
72 plane);
73 struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
74 plane);
75 struct armada_crtc *dcrtc;
76 struct armada_regs *regs;
77 unsigned int idx;
78 u32 cfg, cfg_mask, val;
79
80 DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
81
82 if (!new_state->fb || WARN_ON(!new_state->crtc))
83 return;
84
85 DRM_DEBUG_KMS("[PLANE:%d:%s] is on [CRTC:%d:%s] with [FB:%d] visible %u->%u\n",
86 plane->base.id, plane->name,
87 new_state->crtc->base.id, new_state->crtc->name,
88 new_state->fb->base.id,
89 old_state->visible, new_state->visible);
90
91 dcrtc = drm_to_armada_crtc(new_state->crtc);
92 regs = dcrtc->regs + dcrtc->regs_idx;
93
94 idx = 0;
95 if (!old_state->visible && new_state->visible)
96 armada_reg_queue_mod(regs, idx,
97 0, CFG_PDWN16x66 | CFG_PDWN32x66,
98 LCD_SPU_SRAM_PARA1);
99 val = armada_src_hw(new_state);
100 if (armada_src_hw(old_state) != val)
101 armada_reg_queue_set(regs, idx, val, LCD_SPU_DMA_HPXL_VLN);
102 val = armada_dst_yx(new_state);
103 if (armada_dst_yx(old_state) != val)
104 armada_reg_queue_set(regs, idx, val, LCD_SPU_DMA_OVSA_HPXL_VLN);
105 val = armada_dst_hw(new_state);
106 if (armada_dst_hw(old_state) != val)
107 armada_reg_queue_set(regs, idx, val, LCD_SPU_DZM_HPXL_VLN);
108 /* FIXME: overlay on an interlaced display */
109 if (old_state->src.x1 != new_state->src.x1 ||
110 old_state->src.y1 != new_state->src.y1 ||
111 old_state->fb != new_state->fb ||
112 new_state->crtc->state->mode_changed) {
113 const struct drm_format_info *format;
114 u16 src_x;
115
116 armada_reg_queue_set(regs, idx, armada_addr(new_state, 0, 0),
117 LCD_SPU_DMA_START_ADDR_Y0);
118 armada_reg_queue_set(regs, idx, armada_addr(new_state, 0, 1),
119 LCD_SPU_DMA_START_ADDR_U0);
120 armada_reg_queue_set(regs, idx, armada_addr(new_state, 0, 2),
121 LCD_SPU_DMA_START_ADDR_V0);
122 armada_reg_queue_set(regs, idx, armada_addr(new_state, 1, 0),
123 LCD_SPU_DMA_START_ADDR_Y1);
124 armada_reg_queue_set(regs, idx, armada_addr(new_state, 1, 1),
125 LCD_SPU_DMA_START_ADDR_U1);
126 armada_reg_queue_set(regs, idx, armada_addr(new_state, 1, 2),
127 LCD_SPU_DMA_START_ADDR_V1);
128
129 val = armada_pitch(new_state, 0) << 16 | armada_pitch(new_state,
130 0);
131 armada_reg_queue_set(regs, idx, val, LCD_SPU_DMA_PITCH_YC);
132 val = armada_pitch(new_state, 1) << 16 | armada_pitch(new_state,
133 2);
134 armada_reg_queue_set(regs, idx, val, LCD_SPU_DMA_PITCH_UV);
135
136 cfg = CFG_DMA_FMT(drm_fb_to_armada_fb(new_state->fb)->fmt) |
137 CFG_DMA_MOD(drm_fb_to_armada_fb(new_state->fb)->mod) |
138 CFG_CBSH_ENA;
139 if (new_state->visible)
140 cfg |= CFG_DMA_ENA;
141
142 /*
143 * Shifting a YUV packed format image by one pixel causes the
144 * U/V planes to swap. Compensate for it by also toggling
145 * the UV swap.
146 */
147 format = new_state->fb->format;
148 src_x = new_state->src.x1 >> 16;
149 if (format->num_planes == 1 && src_x & (format->hsub - 1))
150 cfg ^= CFG_DMA_MOD(CFG_SWAPUV);
151 if (to_armada_plane_state(new_state)->interlace)
152 cfg |= CFG_DMA_FTOGGLE;
153 cfg_mask = CFG_CBSH_ENA | CFG_DMAFORMAT |
154 CFG_DMA_MOD(CFG_SWAPRB | CFG_SWAPUV |
155 CFG_SWAPYU | CFG_YUV2RGB) |
156 CFG_DMA_FTOGGLE | CFG_DMA_TSTMODE |
157 CFG_DMA_ENA;
158 } else if (old_state->visible != new_state->visible) {
159 cfg = new_state->visible ? CFG_DMA_ENA : 0;
160 cfg_mask = CFG_DMA_ENA;
161 } else {
162 cfg = cfg_mask = 0;
163 }
164 if (drm_rect_width(&old_state->src) != drm_rect_width(&new_state->src) ||
165 drm_rect_width(&old_state->dst) != drm_rect_width(&new_state->dst)) {
166 cfg_mask |= CFG_DMA_HSMOOTH;
167 if (drm_rect_width(&new_state->src) >> 16 !=
168 drm_rect_width(&new_state->dst))
169 cfg |= CFG_DMA_HSMOOTH;
170 }
171
172 if (cfg_mask)
173 armada_reg_queue_mod(regs, idx, cfg, cfg_mask,
174 LCD_SPU_DMA_CTRL0);
175
176 val = armada_spu_contrast(new_state);
177 if ((!old_state->visible && new_state->visible) ||
178 armada_spu_contrast(old_state) != val)
179 armada_reg_queue_set(regs, idx, val, LCD_SPU_CONTRAST);
180 val = armada_spu_saturation(new_state);
181 if ((!old_state->visible && new_state->visible) ||
182 armada_spu_saturation(old_state) != val)
183 armada_reg_queue_set(regs, idx, val, LCD_SPU_SATURATION);
184 if (!old_state->visible && new_state->visible)
185 armada_reg_queue_set(regs, idx, 0x00002000, LCD_SPU_CBSH_HUE);
186 val = armada_csc(new_state);
187 if ((!old_state->visible && new_state->visible) ||
188 armada_csc(old_state) != val)
189 armada_reg_queue_mod(regs, idx, val, CFG_CSC_MASK,
190 LCD_SPU_IOPAD_CONTROL);
191 val = drm_to_overlay_state(new_state)->colorkey_yr;
192 if ((!old_state->visible && new_state->visible) ||
193 drm_to_overlay_state(old_state)->colorkey_yr != val)
194 armada_reg_queue_set(regs, idx, val, LCD_SPU_COLORKEY_Y);
195 val = drm_to_overlay_state(new_state)->colorkey_ug;
196 if ((!old_state->visible && new_state->visible) ||
197 drm_to_overlay_state(old_state)->colorkey_ug != val)
198 armada_reg_queue_set(regs, idx, val, LCD_SPU_COLORKEY_U);
199 val = drm_to_overlay_state(new_state)->colorkey_vb;
200 if ((!old_state->visible && new_state->visible) ||
201 drm_to_overlay_state(old_state)->colorkey_vb != val)
202 armada_reg_queue_set(regs, idx, val, LCD_SPU_COLORKEY_V);
203 val = drm_to_overlay_state(new_state)->colorkey_mode;
204 if ((!old_state->visible && new_state->visible) ||
205 drm_to_overlay_state(old_state)->colorkey_mode != val)
206 armada_reg_queue_mod(regs, idx, val, CFG_CKMODE_MASK |
207 CFG_ALPHAM_MASK | CFG_ALPHA_MASK,
208 LCD_SPU_DMA_CTRL1);
209 val = drm_to_overlay_state(new_state)->colorkey_enable;
210 if (((!old_state->visible && new_state->visible) ||
211 drm_to_overlay_state(old_state)->colorkey_enable != val) &&
212 dcrtc->variant->has_spu_adv_reg)
213 armada_reg_queue_mod(regs, idx, val, ADV_GRACOLORKEY |
214 ADV_VIDCOLORKEY, LCD_SPU_ADV_REG);
215
216 dcrtc->regs_idx += idx;
217}
218
219static void armada_drm_overlay_plane_atomic_disable(struct drm_plane *plane,
220 struct drm_atomic_state *state)
221{
222 struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
223 plane);
224 struct armada_crtc *dcrtc;
225 struct armada_regs *regs;
226 unsigned int idx = 0;
227
228 DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
229
230 if (!old_state->crtc)
231 return;
232
233 DRM_DEBUG_KMS("[PLANE:%d:%s] was on [CRTC:%d:%s] with [FB:%d]\n",
234 plane->base.id, plane->name,
235 old_state->crtc->base.id, old_state->crtc->name,
236 old_state->fb->base.id);
237
238 dcrtc = drm_to_armada_crtc(old_state->crtc);
239 regs = dcrtc->regs + dcrtc->regs_idx;
240
241 /* Disable plane and power down the YUV FIFOs */
242 armada_reg_queue_mod(regs, idx, 0, CFG_DMA_ENA, LCD_SPU_DMA_CTRL0);
243 armada_reg_queue_mod(regs, idx, CFG_PDWN16x66 | CFG_PDWN32x66, 0,
244 LCD_SPU_SRAM_PARA1);
245
246 dcrtc->regs_idx += idx;
247}
248
249static const struct drm_plane_helper_funcs armada_overlay_plane_helper_funcs = {
250 .atomic_check = armada_drm_plane_atomic_check,
251 .atomic_update = armada_drm_overlay_plane_atomic_update,
252 .atomic_disable = armada_drm_overlay_plane_atomic_disable,
253};
254
255static int
256armada_overlay_plane_update(struct drm_plane *plane, struct drm_crtc *crtc,
257 struct drm_framebuffer *fb,
258 int crtc_x, int crtc_y, unsigned crtc_w, unsigned crtc_h,
259 uint32_t src_x, uint32_t src_y, uint32_t src_w, uint32_t src_h,
260 struct drm_modeset_acquire_ctx *ctx)
261{
262 struct drm_atomic_state *state;
263 struct drm_plane_state *plane_state;
264 int ret = 0;
265
266 trace_armada_ovl_plane_update(plane, crtc, fb,
267 crtc_x, crtc_y, crtc_w, crtc_h,
268 src_x, src_y, src_w, src_h);
269
270 state = drm_atomic_state_alloc(plane->dev);
271 if (!state)
272 return -ENOMEM;
273
274 state->acquire_ctx = ctx;
275 plane_state = drm_atomic_get_plane_state(state, plane);
276 if (IS_ERR(plane_state)) {
277 ret = PTR_ERR(plane_state);
278 goto fail;
279 }
280
281 ret = drm_atomic_set_crtc_for_plane(plane_state, crtc);
282 if (ret != 0)
283 goto fail;
284
285 drm_atomic_set_fb_for_plane(plane_state, fb);
286 plane_state->crtc_x = crtc_x;
287 plane_state->crtc_y = crtc_y;
288 plane_state->crtc_h = crtc_h;
289 plane_state->crtc_w = crtc_w;
290 plane_state->src_x = src_x;
291 plane_state->src_y = src_y;
292 plane_state->src_h = src_h;
293 plane_state->src_w = src_w;
294
295 ret = drm_atomic_nonblocking_commit(state);
296fail:
297 drm_atomic_state_put(state);
298 return ret;
299}
300
301static void armada_overlay_reset(struct drm_plane *plane)
302{
303 struct armada_overlay_state *state;
304
305 if (plane->state)
306 __drm_atomic_helper_plane_destroy_state(plane->state);
307 kfree(plane->state);
308 plane->state = NULL;
309
310 state = kzalloc(sizeof(*state), GFP_KERNEL);
311 if (state) {
312 state->colorkey_yr = 0xfefefe00;
313 state->colorkey_ug = 0x01010100;
314 state->colorkey_vb = 0x01010100;
315 state->colorkey_mode = CFG_CKMODE(CKMODE_RGB) |
316 CFG_ALPHAM_GRA | CFG_ALPHA(0);
317 state->colorkey_enable = ADV_GRACOLORKEY;
318 state->brightness = DEFAULT_BRIGHTNESS;
319 state->contrast = DEFAULT_CONTRAST;
320 state->saturation = DEFAULT_SATURATION;
321 __drm_atomic_helper_plane_reset(plane, &state->base.base);
322 state->base.base.color_encoding = DEFAULT_ENCODING;
323 state->base.base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE;
324 }
325}
326
327static struct drm_plane_state *
328armada_overlay_duplicate_state(struct drm_plane *plane)
329{
330 struct armada_overlay_state *state;
331
332 if (WARN_ON(!plane->state))
333 return NULL;
334
335 state = kmemdup(plane->state, sizeof(*state), GFP_KERNEL);
336 if (state)
337 __drm_atomic_helper_plane_duplicate_state(plane,
338 &state->base.base);
339 return &state->base.base;
340}
341
342static int armada_overlay_set_property(struct drm_plane *plane,
343 struct drm_plane_state *state, struct drm_property *property,
344 uint64_t val)
345{
346 struct armada_private *priv = drm_to_armada_dev(plane->dev);
347
348#define K2R(val) (((val) >> 0) & 0xff)
349#define K2G(val) (((val) >> 8) & 0xff)
350#define K2B(val) (((val) >> 16) & 0xff)
351 if (property == priv->colorkey_prop) {
352#define CCC(v) ((v) << 24 | (v) << 16 | (v) << 8)
353 drm_to_overlay_state(state)->colorkey_yr = CCC(K2R(val));
354 drm_to_overlay_state(state)->colorkey_ug = CCC(K2G(val));
355 drm_to_overlay_state(state)->colorkey_vb = CCC(K2B(val));
356#undef CCC
357 } else if (property == priv->colorkey_min_prop) {
358 drm_to_overlay_state(state)->colorkey_yr &= ~0x00ff0000;
359 drm_to_overlay_state(state)->colorkey_yr |= K2R(val) << 16;
360 drm_to_overlay_state(state)->colorkey_ug &= ~0x00ff0000;
361 drm_to_overlay_state(state)->colorkey_ug |= K2G(val) << 16;
362 drm_to_overlay_state(state)->colorkey_vb &= ~0x00ff0000;
363 drm_to_overlay_state(state)->colorkey_vb |= K2B(val) << 16;
364 } else if (property == priv->colorkey_max_prop) {
365 drm_to_overlay_state(state)->colorkey_yr &= ~0xff000000;
366 drm_to_overlay_state(state)->colorkey_yr |= K2R(val) << 24;
367 drm_to_overlay_state(state)->colorkey_ug &= ~0xff000000;
368 drm_to_overlay_state(state)->colorkey_ug |= K2G(val) << 24;
369 drm_to_overlay_state(state)->colorkey_vb &= ~0xff000000;
370 drm_to_overlay_state(state)->colorkey_vb |= K2B(val) << 24;
371 } else if (property == priv->colorkey_val_prop) {
372 drm_to_overlay_state(state)->colorkey_yr &= ~0x0000ff00;
373 drm_to_overlay_state(state)->colorkey_yr |= K2R(val) << 8;
374 drm_to_overlay_state(state)->colorkey_ug &= ~0x0000ff00;
375 drm_to_overlay_state(state)->colorkey_ug |= K2G(val) << 8;
376 drm_to_overlay_state(state)->colorkey_vb &= ~0x0000ff00;
377 drm_to_overlay_state(state)->colorkey_vb |= K2B(val) << 8;
378 } else if (property == priv->colorkey_alpha_prop) {
379 drm_to_overlay_state(state)->colorkey_yr &= ~0x000000ff;
380 drm_to_overlay_state(state)->colorkey_yr |= K2R(val);
381 drm_to_overlay_state(state)->colorkey_ug &= ~0x000000ff;
382 drm_to_overlay_state(state)->colorkey_ug |= K2G(val);
383 drm_to_overlay_state(state)->colorkey_vb &= ~0x000000ff;
384 drm_to_overlay_state(state)->colorkey_vb |= K2B(val);
385 } else if (property == priv->colorkey_mode_prop) {
386 if (val == CKMODE_DISABLE) {
387 drm_to_overlay_state(state)->colorkey_mode =
388 CFG_CKMODE(CKMODE_DISABLE) |
389 CFG_ALPHAM_CFG | CFG_ALPHA(255);
390 drm_to_overlay_state(state)->colorkey_enable = 0;
391 } else {
392 drm_to_overlay_state(state)->colorkey_mode =
393 CFG_CKMODE(val) |
394 CFG_ALPHAM_GRA | CFG_ALPHA(0);
395 drm_to_overlay_state(state)->colorkey_enable =
396 ADV_GRACOLORKEY;
397 }
398 } else if (property == priv->brightness_prop) {
399 drm_to_overlay_state(state)->brightness = val - 256;
400 } else if (property == priv->contrast_prop) {
401 drm_to_overlay_state(state)->contrast = val;
402 } else if (property == priv->saturation_prop) {
403 drm_to_overlay_state(state)->saturation = val;
404 } else {
405 return -EINVAL;
406 }
407 return 0;
408}
409
410static int armada_overlay_get_property(struct drm_plane *plane,
411 const struct drm_plane_state *state, struct drm_property *property,
412 uint64_t *val)
413{
414 struct armada_private *priv = drm_to_armada_dev(plane->dev);
415
416#define C2K(c,s) (((c) >> (s)) & 0xff)
417#define R2BGR(r,g,b,s) (C2K(r,s) << 0 | C2K(g,s) << 8 | C2K(b,s) << 16)
418 if (property == priv->colorkey_prop) {
419 /* Do best-efforts here for this property */
420 *val = R2BGR(drm_to_overlay_state(state)->colorkey_yr,
421 drm_to_overlay_state(state)->colorkey_ug,
422 drm_to_overlay_state(state)->colorkey_vb, 16);
423 /* If min != max, or min != val, error out */
424 if (*val != R2BGR(drm_to_overlay_state(state)->colorkey_yr,
425 drm_to_overlay_state(state)->colorkey_ug,
426 drm_to_overlay_state(state)->colorkey_vb, 24) ||
427 *val != R2BGR(drm_to_overlay_state(state)->colorkey_yr,
428 drm_to_overlay_state(state)->colorkey_ug,
429 drm_to_overlay_state(state)->colorkey_vb, 8))
430 return -EINVAL;
431 } else if (property == priv->colorkey_min_prop) {
432 *val = R2BGR(drm_to_overlay_state(state)->colorkey_yr,
433 drm_to_overlay_state(state)->colorkey_ug,
434 drm_to_overlay_state(state)->colorkey_vb, 16);
435 } else if (property == priv->colorkey_max_prop) {
436 *val = R2BGR(drm_to_overlay_state(state)->colorkey_yr,
437 drm_to_overlay_state(state)->colorkey_ug,
438 drm_to_overlay_state(state)->colorkey_vb, 24);
439 } else if (property == priv->colorkey_val_prop) {
440 *val = R2BGR(drm_to_overlay_state(state)->colorkey_yr,
441 drm_to_overlay_state(state)->colorkey_ug,
442 drm_to_overlay_state(state)->colorkey_vb, 8);
443 } else if (property == priv->colorkey_alpha_prop) {
444 *val = R2BGR(drm_to_overlay_state(state)->colorkey_yr,
445 drm_to_overlay_state(state)->colorkey_ug,
446 drm_to_overlay_state(state)->colorkey_vb, 0);
447 } else if (property == priv->colorkey_mode_prop) {
448 *val = (drm_to_overlay_state(state)->colorkey_mode &
449 CFG_CKMODE_MASK) >> ffs(CFG_CKMODE_MASK);
450 } else if (property == priv->brightness_prop) {
451 *val = drm_to_overlay_state(state)->brightness + 256;
452 } else if (property == priv->contrast_prop) {
453 *val = drm_to_overlay_state(state)->contrast;
454 } else if (property == priv->saturation_prop) {
455 *val = drm_to_overlay_state(state)->saturation;
456 } else {
457 return -EINVAL;
458 }
459 return 0;
460}
461
462static const struct drm_plane_funcs armada_ovl_plane_funcs = {
463 .update_plane = armada_overlay_plane_update,
464 .disable_plane = drm_atomic_helper_disable_plane,
465 .destroy = drm_plane_helper_destroy,
466 .reset = armada_overlay_reset,
467 .atomic_duplicate_state = armada_overlay_duplicate_state,
468 .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
469 .atomic_set_property = armada_overlay_set_property,
470 .atomic_get_property = armada_overlay_get_property,
471};
472
473static const uint32_t armada_ovl_formats[] = {
474 DRM_FORMAT_UYVY,
475 DRM_FORMAT_YUYV,
476 DRM_FORMAT_YUV420,
477 DRM_FORMAT_YVU420,
478 DRM_FORMAT_YUV422,
479 DRM_FORMAT_YVU422,
480 DRM_FORMAT_VYUY,
481 DRM_FORMAT_YVYU,
482 DRM_FORMAT_ARGB8888,
483 DRM_FORMAT_ABGR8888,
484 DRM_FORMAT_XRGB8888,
485 DRM_FORMAT_XBGR8888,
486 DRM_FORMAT_RGB888,
487 DRM_FORMAT_BGR888,
488 DRM_FORMAT_ARGB1555,
489 DRM_FORMAT_ABGR1555,
490 DRM_FORMAT_RGB565,
491 DRM_FORMAT_BGR565,
492};
493
494static const struct drm_prop_enum_list armada_drm_colorkey_enum_list[] = {
495 { CKMODE_DISABLE, "disabled" },
496 { CKMODE_Y, "Y component" },
497 { CKMODE_U, "U component" },
498 { CKMODE_V, "V component" },
499 { CKMODE_RGB, "RGB" },
500 { CKMODE_R, "R component" },
501 { CKMODE_G, "G component" },
502 { CKMODE_B, "B component" },
503};
504
505static int armada_overlay_create_properties(struct drm_device *dev)
506{
507 struct armada_private *priv = drm_to_armada_dev(dev);
508
509 if (priv->colorkey_prop)
510 return 0;
511
512 priv->colorkey_prop = drm_property_create_range(dev, 0,
513 "colorkey", 0, 0xffffff);
514 priv->colorkey_min_prop = drm_property_create_range(dev, 0,
515 "colorkey_min", 0, 0xffffff);
516 priv->colorkey_max_prop = drm_property_create_range(dev, 0,
517 "colorkey_max", 0, 0xffffff);
518 priv->colorkey_val_prop = drm_property_create_range(dev, 0,
519 "colorkey_val", 0, 0xffffff);
520 priv->colorkey_alpha_prop = drm_property_create_range(dev, 0,
521 "colorkey_alpha", 0, 0xffffff);
522 priv->colorkey_mode_prop = drm_property_create_enum(dev, 0,
523 "colorkey_mode",
524 armada_drm_colorkey_enum_list,
525 ARRAY_SIZE(armada_drm_colorkey_enum_list));
526 priv->brightness_prop = drm_property_create_range(dev, 0,
527 "brightness", 0, 256 + 255);
528 priv->contrast_prop = drm_property_create_range(dev, 0,
529 "contrast", 0, 0x7fff);
530 priv->saturation_prop = drm_property_create_range(dev, 0,
531 "saturation", 0, 0x7fff);
532
533 if (!priv->colorkey_prop)
534 return -ENOMEM;
535
536 return 0;
537}
538
539int armada_overlay_plane_create(struct drm_device *dev, unsigned long crtcs)
540{
541 struct armada_private *priv = drm_to_armada_dev(dev);
542 struct drm_mode_object *mobj;
543 struct drm_plane *overlay;
544 int ret;
545
546 ret = armada_overlay_create_properties(dev);
547 if (ret)
548 return ret;
549
550 overlay = kzalloc(sizeof(*overlay), GFP_KERNEL);
551 if (!overlay)
552 return -ENOMEM;
553
554 drm_plane_helper_add(overlay, &armada_overlay_plane_helper_funcs);
555
556 ret = drm_universal_plane_init(dev, overlay, crtcs,
557 &armada_ovl_plane_funcs,
558 armada_ovl_formats,
559 ARRAY_SIZE(armada_ovl_formats),
560 NULL,
561 DRM_PLANE_TYPE_OVERLAY, NULL);
562 if (ret) {
563 kfree(overlay);
564 return ret;
565 }
566
567 mobj = &overlay->base;
568 drm_object_attach_property(mobj, priv->colorkey_prop,
569 0x0101fe);
570 drm_object_attach_property(mobj, priv->colorkey_min_prop,
571 0x0101fe);
572 drm_object_attach_property(mobj, priv->colorkey_max_prop,
573 0x0101fe);
574 drm_object_attach_property(mobj, priv->colorkey_val_prop,
575 0x0101fe);
576 drm_object_attach_property(mobj, priv->colorkey_alpha_prop,
577 0x000000);
578 drm_object_attach_property(mobj, priv->colorkey_mode_prop,
579 CKMODE_RGB);
580 drm_object_attach_property(mobj, priv->brightness_prop,
581 256 + DEFAULT_BRIGHTNESS);
582 drm_object_attach_property(mobj, priv->contrast_prop,
583 DEFAULT_CONTRAST);
584 drm_object_attach_property(mobj, priv->saturation_prop,
585 DEFAULT_SATURATION);
586
587 ret = drm_plane_create_color_properties(overlay,
588 BIT(DRM_COLOR_YCBCR_BT601) |
589 BIT(DRM_COLOR_YCBCR_BT709),
590 BIT(DRM_COLOR_YCBCR_LIMITED_RANGE),
591 DEFAULT_ENCODING,
592 DRM_COLOR_YCBCR_LIMITED_RANGE);
593
594 return ret;
595}