Loading...
1/*
2 * Copyright (C) 2014 Red Hat
3 * Author: Rob Clark <robdclark@gmail.com>
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 *
9 * This program is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
12 * more details.
13 *
14 * You should have received a copy of the GNU General Public License along with
15 * this program. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18#include "msm_drv.h"
19#include "msm_kms.h"
20#include "msm_gem.h"
21
22struct msm_commit {
23 struct drm_device *dev;
24 struct drm_atomic_state *state;
25 uint32_t fence;
26 struct msm_fence_cb fence_cb;
27 uint32_t crtc_mask;
28};
29
30static void fence_cb(struct msm_fence_cb *cb);
31
32/* block until specified crtcs are no longer pending update, and
33 * atomically mark them as pending update
34 */
35static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
36{
37 int ret;
38
39 spin_lock(&priv->pending_crtcs_event.lock);
40 ret = wait_event_interruptible_locked(priv->pending_crtcs_event,
41 !(priv->pending_crtcs & crtc_mask));
42 if (ret == 0) {
43 DBG("start: %08x", crtc_mask);
44 priv->pending_crtcs |= crtc_mask;
45 }
46 spin_unlock(&priv->pending_crtcs_event.lock);
47
48 return ret;
49}
50
51/* clear specified crtcs (no longer pending update)
52 */
53static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
54{
55 spin_lock(&priv->pending_crtcs_event.lock);
56 DBG("end: %08x", crtc_mask);
57 priv->pending_crtcs &= ~crtc_mask;
58 wake_up_all_locked(&priv->pending_crtcs_event);
59 spin_unlock(&priv->pending_crtcs_event.lock);
60}
61
62static struct msm_commit *commit_init(struct drm_atomic_state *state)
63{
64 struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL);
65
66 if (!c)
67 return NULL;
68
69 c->dev = state->dev;
70 c->state = state;
71
72 /* TODO we might need a way to indicate to run the cb on a
73 * different wq so wait_for_vblanks() doesn't block retiring
74 * bo's..
75 */
76 INIT_FENCE_CB(&c->fence_cb, fence_cb);
77
78 return c;
79}
80
81static void commit_destroy(struct msm_commit *c)
82{
83 end_atomic(c->dev->dev_private, c->crtc_mask);
84 kfree(c);
85}
86
87static void msm_atomic_wait_for_commit_done(struct drm_device *dev,
88 struct drm_atomic_state *old_state)
89{
90 struct drm_crtc *crtc;
91 struct msm_drm_private *priv = old_state->dev->dev_private;
92 struct msm_kms *kms = priv->kms;
93 int ncrtcs = old_state->dev->mode_config.num_crtc;
94 int i;
95
96 for (i = 0; i < ncrtcs; i++) {
97 crtc = old_state->crtcs[i];
98
99 if (!crtc)
100 continue;
101
102 if (!crtc->state->enable)
103 continue;
104
105 /* Legacy cursor ioctls are completely unsynced, and userspace
106 * relies on that (by doing tons of cursor updates). */
107 if (old_state->legacy_cursor_update)
108 continue;
109
110 kms->funcs->wait_for_crtc_commit_done(kms, crtc);
111 }
112}
113
114/* The (potentially) asynchronous part of the commit. At this point
115 * nothing can fail short of armageddon.
116 */
117static void complete_commit(struct msm_commit *c)
118{
119 struct drm_atomic_state *state = c->state;
120 struct drm_device *dev = state->dev;
121 struct msm_drm_private *priv = dev->dev_private;
122 struct msm_kms *kms = priv->kms;
123
124 kms->funcs->prepare_commit(kms, state);
125
126 drm_atomic_helper_commit_modeset_disables(dev, state);
127
128 drm_atomic_helper_commit_planes(dev, state, false);
129
130 drm_atomic_helper_commit_modeset_enables(dev, state);
131
132 /* NOTE: _wait_for_vblanks() only waits for vblank on
133 * enabled CRTCs. So we end up faulting when disabling
134 * due to (potentially) unref'ing the outgoing fb's
135 * before the vblank when the disable has latched.
136 *
137 * But if it did wait on disabled (or newly disabled)
138 * CRTCs, that would be racy (ie. we could have missed
139 * the irq. We need some way to poll for pipe shut
140 * down. Or just live with occasionally hitting the
141 * timeout in the CRTC disable path (which really should
142 * not be critical path)
143 */
144
145 msm_atomic_wait_for_commit_done(dev, state);
146
147 drm_atomic_helper_cleanup_planes(dev, state);
148
149 kms->funcs->complete_commit(kms, state);
150
151 drm_atomic_state_free(state);
152
153 commit_destroy(c);
154}
155
156static void fence_cb(struct msm_fence_cb *cb)
157{
158 struct msm_commit *c =
159 container_of(cb, struct msm_commit, fence_cb);
160 complete_commit(c);
161}
162
163static void add_fb(struct msm_commit *c, struct drm_framebuffer *fb)
164{
165 struct drm_gem_object *obj = msm_framebuffer_bo(fb, 0);
166 c->fence = max(c->fence, msm_gem_fence(to_msm_bo(obj), MSM_PREP_READ));
167}
168
169int msm_atomic_check(struct drm_device *dev,
170 struct drm_atomic_state *state)
171{
172 int ret;
173
174 /*
175 * msm ->atomic_check can update ->mode_changed for pixel format
176 * changes, hence must be run before we check the modeset changes.
177 */
178 ret = drm_atomic_helper_check_planes(dev, state);
179 if (ret)
180 return ret;
181
182 ret = drm_atomic_helper_check_modeset(dev, state);
183 if (ret)
184 return ret;
185
186 return ret;
187}
188
189/**
190 * drm_atomic_helper_commit - commit validated state object
191 * @dev: DRM device
192 * @state: the driver state object
193 * @async: asynchronous commit
194 *
195 * This function commits a with drm_atomic_helper_check() pre-validated state
196 * object. This can still fail when e.g. the framebuffer reservation fails. For
197 * now this doesn't implement asynchronous commits.
198 *
199 * RETURNS
200 * Zero for success or -errno.
201 */
202int msm_atomic_commit(struct drm_device *dev,
203 struct drm_atomic_state *state, bool async)
204{
205 int nplanes = dev->mode_config.num_total_plane;
206 int ncrtcs = dev->mode_config.num_crtc;
207 ktime_t timeout;
208 struct msm_commit *c;
209 int i, ret;
210
211 ret = drm_atomic_helper_prepare_planes(dev, state);
212 if (ret)
213 return ret;
214
215 c = commit_init(state);
216 if (!c) {
217 ret = -ENOMEM;
218 goto error;
219 }
220
221 /*
222 * Figure out what crtcs we have:
223 */
224 for (i = 0; i < ncrtcs; i++) {
225 struct drm_crtc *crtc = state->crtcs[i];
226 if (!crtc)
227 continue;
228 c->crtc_mask |= (1 << drm_crtc_index(crtc));
229 }
230
231 /*
232 * Figure out what fence to wait for:
233 */
234 for (i = 0; i < nplanes; i++) {
235 struct drm_plane *plane = state->planes[i];
236 struct drm_plane_state *new_state = state->plane_states[i];
237
238 if (!plane)
239 continue;
240
241 if ((plane->state->fb != new_state->fb) && new_state->fb)
242 add_fb(c, new_state->fb);
243 }
244
245 /*
246 * Wait for pending updates on any of the same crtc's and then
247 * mark our set of crtc's as busy:
248 */
249 ret = start_atomic(dev->dev_private, c->crtc_mask);
250 if (ret) {
251 kfree(c);
252 goto error;
253 }
254
255 /*
256 * This is the point of no return - everything below never fails except
257 * when the hw goes bonghits. Which means we can commit the new state on
258 * the software side now.
259 */
260
261 drm_atomic_helper_swap_state(dev, state);
262
263 /*
264 * Everything below can be run asynchronously without the need to grab
265 * any modeset locks at all under one conditions: It must be guaranteed
266 * that the asynchronous work has either been cancelled (if the driver
267 * supports it, which at least requires that the framebuffers get
268 * cleaned up with drm_atomic_helper_cleanup_planes()) or completed
269 * before the new state gets committed on the software side with
270 * drm_atomic_helper_swap_state().
271 *
272 * This scheme allows new atomic state updates to be prepared and
273 * checked in parallel to the asynchronous completion of the previous
274 * update. Which is important since compositors need to figure out the
275 * composition of the next frame right after having submitted the
276 * current layout.
277 */
278
279 if (async) {
280 msm_queue_fence_cb(dev, &c->fence_cb, c->fence);
281 return 0;
282 }
283
284 timeout = ktime_add_ms(ktime_get(), 1000);
285
286 /* uninterruptible wait */
287 msm_wait_fence(dev, c->fence, &timeout, false);
288
289 complete_commit(c);
290
291 return 0;
292
293error:
294 drm_atomic_helper_cleanup_planes(dev, state);
295 return ret;
296}
1// SPDX-License-Identifier: GPL-2.0-only
2/*
3 * Copyright (C) 2014 Red Hat
4 * Author: Rob Clark <robdclark@gmail.com>
5 */
6
7#include <drm/drm_atomic_uapi.h>
8#include <drm/drm_gem_atomic_helper.h>
9#include <drm/drm_vblank.h>
10
11#include "msm_atomic_trace.h"
12#include "msm_drv.h"
13#include "msm_gem.h"
14#include "msm_kms.h"
15
16int msm_atomic_prepare_fb(struct drm_plane *plane,
17 struct drm_plane_state *new_state)
18{
19 struct msm_drm_private *priv = plane->dev->dev_private;
20 struct msm_kms *kms = priv->kms;
21
22 if (!new_state->fb)
23 return 0;
24
25 drm_gem_plane_helper_prepare_fb(plane, new_state);
26
27 return msm_framebuffer_prepare(new_state->fb, kms->aspace);
28}
29
30/*
31 * Helpers to control vblanks while we flush.. basically just to ensure
32 * that vblank accounting is switched on, so we get valid seqn/timestamp
33 * on pageflip events (if requested)
34 */
35
36static void vblank_get(struct msm_kms *kms, unsigned crtc_mask)
37{
38 struct drm_crtc *crtc;
39
40 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
41 if (!crtc->state->active)
42 continue;
43 drm_crtc_vblank_get(crtc);
44 }
45}
46
47static void vblank_put(struct msm_kms *kms, unsigned crtc_mask)
48{
49 struct drm_crtc *crtc;
50
51 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
52 if (!crtc->state->active)
53 continue;
54 drm_crtc_vblank_put(crtc);
55 }
56}
57
58static void lock_crtcs(struct msm_kms *kms, unsigned int crtc_mask)
59{
60 int crtc_index;
61 struct drm_crtc *crtc;
62
63 for_each_crtc_mask(kms->dev, crtc, crtc_mask) {
64 crtc_index = drm_crtc_index(crtc);
65 mutex_lock_nested(&kms->commit_lock[crtc_index], crtc_index);
66 }
67}
68
69static void unlock_crtcs(struct msm_kms *kms, unsigned int crtc_mask)
70{
71 struct drm_crtc *crtc;
72
73 for_each_crtc_mask_reverse(kms->dev, crtc, crtc_mask)
74 mutex_unlock(&kms->commit_lock[drm_crtc_index(crtc)]);
75}
76
77static void msm_atomic_async_commit(struct msm_kms *kms, int crtc_idx)
78{
79 unsigned crtc_mask = BIT(crtc_idx);
80
81 trace_msm_atomic_async_commit_start(crtc_mask);
82
83 lock_crtcs(kms, crtc_mask);
84
85 if (!(kms->pending_crtc_mask & crtc_mask)) {
86 unlock_crtcs(kms, crtc_mask);
87 goto out;
88 }
89
90 kms->pending_crtc_mask &= ~crtc_mask;
91
92 kms->funcs->enable_commit(kms);
93
94 vblank_get(kms, crtc_mask);
95
96 /*
97 * Flush hardware updates:
98 */
99 trace_msm_atomic_flush_commit(crtc_mask);
100 kms->funcs->flush_commit(kms, crtc_mask);
101
102 /*
103 * Wait for flush to complete:
104 */
105 trace_msm_atomic_wait_flush_start(crtc_mask);
106 kms->funcs->wait_flush(kms, crtc_mask);
107 trace_msm_atomic_wait_flush_finish(crtc_mask);
108
109 vblank_put(kms, crtc_mask);
110
111 kms->funcs->complete_commit(kms, crtc_mask);
112 unlock_crtcs(kms, crtc_mask);
113 kms->funcs->disable_commit(kms);
114
115out:
116 trace_msm_atomic_async_commit_finish(crtc_mask);
117}
118
119static enum hrtimer_restart msm_atomic_pending_timer(struct hrtimer *t)
120{
121 struct msm_pending_timer *timer = container_of(t,
122 struct msm_pending_timer, timer);
123
124 kthread_queue_work(timer->worker, &timer->work);
125
126 return HRTIMER_NORESTART;
127}
128
129static void msm_atomic_pending_work(struct kthread_work *work)
130{
131 struct msm_pending_timer *timer = container_of(work,
132 struct msm_pending_timer, work);
133
134 msm_atomic_async_commit(timer->kms, timer->crtc_idx);
135}
136
137int msm_atomic_init_pending_timer(struct msm_pending_timer *timer,
138 struct msm_kms *kms, int crtc_idx)
139{
140 timer->kms = kms;
141 timer->crtc_idx = crtc_idx;
142 hrtimer_init(&timer->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
143 timer->timer.function = msm_atomic_pending_timer;
144
145 timer->worker = kthread_create_worker(0, "atomic-worker-%d", crtc_idx);
146 if (IS_ERR(timer->worker)) {
147 int ret = PTR_ERR(timer->worker);
148 timer->worker = NULL;
149 return ret;
150 }
151 sched_set_fifo(timer->worker->task);
152 kthread_init_work(&timer->work, msm_atomic_pending_work);
153
154 return 0;
155}
156
157void msm_atomic_destroy_pending_timer(struct msm_pending_timer *timer)
158{
159 if (timer->worker)
160 kthread_destroy_worker(timer->worker);
161}
162
163static bool can_do_async(struct drm_atomic_state *state,
164 struct drm_crtc **async_crtc)
165{
166 struct drm_connector_state *connector_state;
167 struct drm_connector *connector;
168 struct drm_crtc_state *crtc_state;
169 struct drm_crtc *crtc;
170 int i, num_crtcs = 0;
171
172 if (!(state->legacy_cursor_update || state->async_update))
173 return false;
174
175 /* any connector change, means slow path: */
176 for_each_new_connector_in_state(state, connector, connector_state, i)
177 return false;
178
179 for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
180 if (drm_atomic_crtc_needs_modeset(crtc_state))
181 return false;
182 if (++num_crtcs > 1)
183 return false;
184 *async_crtc = crtc;
185 }
186
187 return true;
188}
189
190/* Get bitmask of crtcs that will need to be flushed. The bitmask
191 * can be used with for_each_crtc_mask() iterator, to iterate
192 * effected crtcs without needing to preserve the atomic state.
193 */
194static unsigned get_crtc_mask(struct drm_atomic_state *state)
195{
196 struct drm_crtc_state *crtc_state;
197 struct drm_crtc *crtc;
198 unsigned i, mask = 0;
199
200 for_each_new_crtc_in_state(state, crtc, crtc_state, i)
201 mask |= drm_crtc_mask(crtc);
202
203 return mask;
204}
205
206void msm_atomic_commit_tail(struct drm_atomic_state *state)
207{
208 struct drm_device *dev = state->dev;
209 struct msm_drm_private *priv = dev->dev_private;
210 struct msm_kms *kms = priv->kms;
211 struct drm_crtc *async_crtc = NULL;
212 unsigned crtc_mask = get_crtc_mask(state);
213 bool async = kms->funcs->vsync_time &&
214 can_do_async(state, &async_crtc);
215
216 trace_msm_atomic_commit_tail_start(async, crtc_mask);
217
218 kms->funcs->enable_commit(kms);
219
220 /*
221 * Ensure any previous (potentially async) commit has
222 * completed:
223 */
224 lock_crtcs(kms, crtc_mask);
225 trace_msm_atomic_wait_flush_start(crtc_mask);
226 kms->funcs->wait_flush(kms, crtc_mask);
227 trace_msm_atomic_wait_flush_finish(crtc_mask);
228
229 /*
230 * Now that there is no in-progress flush, prepare the
231 * current update:
232 */
233 kms->funcs->prepare_commit(kms, state);
234
235 /*
236 * Push atomic updates down to hardware:
237 */
238 drm_atomic_helper_commit_modeset_disables(dev, state);
239 drm_atomic_helper_commit_planes(dev, state, 0);
240 drm_atomic_helper_commit_modeset_enables(dev, state);
241
242 if (async) {
243 struct msm_pending_timer *timer =
244 &kms->pending_timers[drm_crtc_index(async_crtc)];
245
246 /* async updates are limited to single-crtc updates: */
247 WARN_ON(crtc_mask != drm_crtc_mask(async_crtc));
248
249 /*
250 * Start timer if we don't already have an update pending
251 * on this crtc:
252 */
253 if (!(kms->pending_crtc_mask & crtc_mask)) {
254 ktime_t vsync_time, wakeup_time;
255
256 kms->pending_crtc_mask |= crtc_mask;
257
258 vsync_time = kms->funcs->vsync_time(kms, async_crtc);
259 wakeup_time = ktime_sub(vsync_time, ms_to_ktime(1));
260
261 hrtimer_start(&timer->timer, wakeup_time,
262 HRTIMER_MODE_ABS);
263 }
264
265 kms->funcs->disable_commit(kms);
266 unlock_crtcs(kms, crtc_mask);
267 /*
268 * At this point, from drm core's perspective, we
269 * are done with the atomic update, so we can just
270 * go ahead and signal that it is done:
271 */
272 drm_atomic_helper_commit_hw_done(state);
273 drm_atomic_helper_cleanup_planes(dev, state);
274
275 trace_msm_atomic_commit_tail_finish(async, crtc_mask);
276
277 return;
278 }
279
280 /*
281 * If there is any async flush pending on updated crtcs, fold
282 * them into the current flush.
283 */
284 kms->pending_crtc_mask &= ~crtc_mask;
285
286 vblank_get(kms, crtc_mask);
287
288 /*
289 * Flush hardware updates:
290 */
291 trace_msm_atomic_flush_commit(crtc_mask);
292 kms->funcs->flush_commit(kms, crtc_mask);
293 unlock_crtcs(kms, crtc_mask);
294 /*
295 * Wait for flush to complete:
296 */
297 trace_msm_atomic_wait_flush_start(crtc_mask);
298 kms->funcs->wait_flush(kms, crtc_mask);
299 trace_msm_atomic_wait_flush_finish(crtc_mask);
300
301 vblank_put(kms, crtc_mask);
302
303 lock_crtcs(kms, crtc_mask);
304 kms->funcs->complete_commit(kms, crtc_mask);
305 unlock_crtcs(kms, crtc_mask);
306 kms->funcs->disable_commit(kms);
307
308 drm_atomic_helper_commit_hw_done(state);
309 drm_atomic_helper_cleanup_planes(dev, state);
310
311 trace_msm_atomic_commit_tail_finish(async, crtc_mask);
312}