Loading...
1/*
2 * rcar_du_crtc.c -- R-Car Display Unit CRTCs
3 *
4 * Copyright (C) 2013-2015 Renesas Electronics Corporation
5 *
6 * Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
7 *
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
12 */
13
14#include <linux/clk.h>
15#include <linux/mutex.h>
16
17#include <drm/drmP.h>
18#include <drm/drm_atomic.h>
19#include <drm/drm_atomic_helper.h>
20#include <drm/drm_crtc.h>
21#include <drm/drm_crtc_helper.h>
22#include <drm/drm_fb_cma_helper.h>
23#include <drm/drm_gem_cma_helper.h>
24#include <drm/drm_plane_helper.h>
25
26#include "rcar_du_crtc.h"
27#include "rcar_du_drv.h"
28#include "rcar_du_kms.h"
29#include "rcar_du_plane.h"
30#include "rcar_du_regs.h"
31#include "rcar_du_vsp.h"
32
33static u32 rcar_du_crtc_read(struct rcar_du_crtc *rcrtc, u32 reg)
34{
35 struct rcar_du_device *rcdu = rcrtc->group->dev;
36
37 return rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
38}
39
40static void rcar_du_crtc_write(struct rcar_du_crtc *rcrtc, u32 reg, u32 data)
41{
42 struct rcar_du_device *rcdu = rcrtc->group->dev;
43
44 rcar_du_write(rcdu, rcrtc->mmio_offset + reg, data);
45}
46
47static void rcar_du_crtc_clr(struct rcar_du_crtc *rcrtc, u32 reg, u32 clr)
48{
49 struct rcar_du_device *rcdu = rcrtc->group->dev;
50
51 rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
52 rcar_du_read(rcdu, rcrtc->mmio_offset + reg) & ~clr);
53}
54
55static void rcar_du_crtc_set(struct rcar_du_crtc *rcrtc, u32 reg, u32 set)
56{
57 struct rcar_du_device *rcdu = rcrtc->group->dev;
58
59 rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
60 rcar_du_read(rcdu, rcrtc->mmio_offset + reg) | set);
61}
62
63static void rcar_du_crtc_clr_set(struct rcar_du_crtc *rcrtc, u32 reg,
64 u32 clr, u32 set)
65{
66 struct rcar_du_device *rcdu = rcrtc->group->dev;
67 u32 value = rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
68
69 rcar_du_write(rcdu, rcrtc->mmio_offset + reg, (value & ~clr) | set);
70}
71
72static int rcar_du_crtc_get(struct rcar_du_crtc *rcrtc)
73{
74 int ret;
75
76 ret = clk_prepare_enable(rcrtc->clock);
77 if (ret < 0)
78 return ret;
79
80 ret = clk_prepare_enable(rcrtc->extclock);
81 if (ret < 0)
82 goto error_clock;
83
84 ret = rcar_du_group_get(rcrtc->group);
85 if (ret < 0)
86 goto error_group;
87
88 return 0;
89
90error_group:
91 clk_disable_unprepare(rcrtc->extclock);
92error_clock:
93 clk_disable_unprepare(rcrtc->clock);
94 return ret;
95}
96
97static void rcar_du_crtc_put(struct rcar_du_crtc *rcrtc)
98{
99 rcar_du_group_put(rcrtc->group);
100
101 clk_disable_unprepare(rcrtc->extclock);
102 clk_disable_unprepare(rcrtc->clock);
103}
104
105/* -----------------------------------------------------------------------------
106 * Hardware Setup
107 */
108
109static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
110{
111 const struct drm_display_mode *mode = &rcrtc->crtc.state->adjusted_mode;
112 unsigned long mode_clock = mode->clock * 1000;
113 unsigned long clk;
114 u32 value;
115 u32 escr;
116 u32 div;
117
118 /* Compute the clock divisor and select the internal or external dot
119 * clock based on the requested frequency.
120 */
121 clk = clk_get_rate(rcrtc->clock);
122 div = DIV_ROUND_CLOSEST(clk, mode_clock);
123 div = clamp(div, 1U, 64U) - 1;
124 escr = div | ESCR_DCLKSEL_CLKS;
125
126 if (rcrtc->extclock) {
127 unsigned long extclk;
128 unsigned long extrate;
129 unsigned long rate;
130 u32 extdiv;
131
132 extclk = clk_get_rate(rcrtc->extclock);
133 extdiv = DIV_ROUND_CLOSEST(extclk, mode_clock);
134 extdiv = clamp(extdiv, 1U, 64U) - 1;
135
136 rate = clk / (div + 1);
137 extrate = extclk / (extdiv + 1);
138
139 if (abs((long)extrate - (long)mode_clock) <
140 abs((long)rate - (long)mode_clock)) {
141 dev_dbg(rcrtc->group->dev->dev,
142 "crtc%u: using external clock\n", rcrtc->index);
143 escr = extdiv | ESCR_DCLKSEL_DCLKIN;
144 }
145 }
146
147 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? ESCR2 : ESCR,
148 escr);
149 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? OTAR2 : OTAR, 0);
150
151 /* Signal polarities */
152 value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
153 | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
154 | DSMR_DIPM_DISP | DSMR_CSPM;
155 rcar_du_crtc_write(rcrtc, DSMR, value);
156
157 /* Display timings */
158 rcar_du_crtc_write(rcrtc, HDSR, mode->htotal - mode->hsync_start - 19);
159 rcar_du_crtc_write(rcrtc, HDER, mode->htotal - mode->hsync_start +
160 mode->hdisplay - 19);
161 rcar_du_crtc_write(rcrtc, HSWR, mode->hsync_end -
162 mode->hsync_start - 1);
163 rcar_du_crtc_write(rcrtc, HCR, mode->htotal - 1);
164
165 rcar_du_crtc_write(rcrtc, VDSR, mode->crtc_vtotal -
166 mode->crtc_vsync_end - 2);
167 rcar_du_crtc_write(rcrtc, VDER, mode->crtc_vtotal -
168 mode->crtc_vsync_end +
169 mode->crtc_vdisplay - 2);
170 rcar_du_crtc_write(rcrtc, VSPR, mode->crtc_vtotal -
171 mode->crtc_vsync_end +
172 mode->crtc_vsync_start - 1);
173 rcar_du_crtc_write(rcrtc, VCR, mode->crtc_vtotal - 1);
174
175 rcar_du_crtc_write(rcrtc, DESR, mode->htotal - mode->hsync_start);
176 rcar_du_crtc_write(rcrtc, DEWR, mode->hdisplay);
177}
178
179void rcar_du_crtc_route_output(struct drm_crtc *crtc,
180 enum rcar_du_output output)
181{
182 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
183 struct rcar_du_device *rcdu = rcrtc->group->dev;
184
185 /* Store the route from the CRTC output to the DU output. The DU will be
186 * configured when starting the CRTC.
187 */
188 rcrtc->outputs |= BIT(output);
189
190 /* Store RGB routing to DPAD0, the hardware will be configured when
191 * starting the CRTC.
192 */
193 if (output == RCAR_DU_OUTPUT_DPAD0)
194 rcdu->dpad0_source = rcrtc->index;
195}
196
197static unsigned int plane_zpos(struct rcar_du_plane *plane)
198{
199 return to_rcar_plane_state(plane->plane.state)->zpos;
200}
201
202static const struct rcar_du_format_info *
203plane_format(struct rcar_du_plane *plane)
204{
205 return to_rcar_plane_state(plane->plane.state)->format;
206}
207
208static void rcar_du_crtc_update_planes(struct rcar_du_crtc *rcrtc)
209{
210 struct rcar_du_plane *planes[RCAR_DU_NUM_HW_PLANES];
211 struct rcar_du_device *rcdu = rcrtc->group->dev;
212 unsigned int num_planes = 0;
213 unsigned int dptsr_planes;
214 unsigned int hwplanes = 0;
215 unsigned int prio = 0;
216 unsigned int i;
217 u32 dspr = 0;
218
219 for (i = 0; i < rcrtc->group->num_planes; ++i) {
220 struct rcar_du_plane *plane = &rcrtc->group->planes[i];
221 unsigned int j;
222
223 if (plane->plane.state->crtc != &rcrtc->crtc)
224 continue;
225
226 /* Insert the plane in the sorted planes array. */
227 for (j = num_planes++; j > 0; --j) {
228 if (plane_zpos(planes[j-1]) <= plane_zpos(plane))
229 break;
230 planes[j] = planes[j-1];
231 }
232
233 planes[j] = plane;
234 prio += plane_format(plane)->planes * 4;
235 }
236
237 for (i = 0; i < num_planes; ++i) {
238 struct rcar_du_plane *plane = planes[i];
239 struct drm_plane_state *state = plane->plane.state;
240 unsigned int index = to_rcar_plane_state(state)->hwindex;
241
242 prio -= 4;
243 dspr |= (index + 1) << prio;
244 hwplanes |= 1 << index;
245
246 if (plane_format(plane)->planes == 2) {
247 index = (index + 1) % 8;
248
249 prio -= 4;
250 dspr |= (index + 1) << prio;
251 hwplanes |= 1 << index;
252 }
253 }
254
255 /* If VSP+DU integration is enabled the plane assignment is fixed. */
256 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE)) {
257 if (rcdu->info->gen < 3) {
258 dspr = (rcrtc->index % 2) + 1;
259 hwplanes = 1 << (rcrtc->index % 2);
260 } else {
261 dspr = (rcrtc->index % 2) ? 3 : 1;
262 hwplanes = 1 << ((rcrtc->index % 2) ? 2 : 0);
263 }
264 }
265
266 /* Update the planes to display timing and dot clock generator
267 * associations.
268 *
269 * Updating the DPTSR register requires restarting the CRTC group,
270 * resulting in visible flicker. To mitigate the issue only update the
271 * association if needed by enabled planes. Planes being disabled will
272 * keep their current association.
273 */
274 mutex_lock(&rcrtc->group->lock);
275
276 dptsr_planes = rcrtc->index % 2 ? rcrtc->group->dptsr_planes | hwplanes
277 : rcrtc->group->dptsr_planes & ~hwplanes;
278
279 if (dptsr_planes != rcrtc->group->dptsr_planes) {
280 rcar_du_group_write(rcrtc->group, DPTSR,
281 (dptsr_planes << 16) | dptsr_planes);
282 rcrtc->group->dptsr_planes = dptsr_planes;
283
284 if (rcrtc->group->used_crtcs)
285 rcar_du_group_restart(rcrtc->group);
286 }
287
288 /* Restart the group if plane sources have changed. */
289 if (rcrtc->group->need_restart)
290 rcar_du_group_restart(rcrtc->group);
291
292 mutex_unlock(&rcrtc->group->lock);
293
294 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR,
295 dspr);
296}
297
298/* -----------------------------------------------------------------------------
299 * Page Flip
300 */
301
302static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc)
303{
304 struct drm_pending_vblank_event *event;
305 struct drm_device *dev = rcrtc->crtc.dev;
306 unsigned long flags;
307
308 spin_lock_irqsave(&dev->event_lock, flags);
309 event = rcrtc->event;
310 rcrtc->event = NULL;
311 spin_unlock_irqrestore(&dev->event_lock, flags);
312
313 if (event == NULL)
314 return;
315
316 spin_lock_irqsave(&dev->event_lock, flags);
317 drm_send_vblank_event(dev, rcrtc->index, event);
318 wake_up(&rcrtc->flip_wait);
319 spin_unlock_irqrestore(&dev->event_lock, flags);
320
321 drm_crtc_vblank_put(&rcrtc->crtc);
322}
323
324static bool rcar_du_crtc_page_flip_pending(struct rcar_du_crtc *rcrtc)
325{
326 struct drm_device *dev = rcrtc->crtc.dev;
327 unsigned long flags;
328 bool pending;
329
330 spin_lock_irqsave(&dev->event_lock, flags);
331 pending = rcrtc->event != NULL;
332 spin_unlock_irqrestore(&dev->event_lock, flags);
333
334 return pending;
335}
336
337static void rcar_du_crtc_wait_page_flip(struct rcar_du_crtc *rcrtc)
338{
339 struct rcar_du_device *rcdu = rcrtc->group->dev;
340
341 if (wait_event_timeout(rcrtc->flip_wait,
342 !rcar_du_crtc_page_flip_pending(rcrtc),
343 msecs_to_jiffies(50)))
344 return;
345
346 dev_warn(rcdu->dev, "page flip timeout\n");
347
348 rcar_du_crtc_finish_page_flip(rcrtc);
349}
350
351/* -----------------------------------------------------------------------------
352 * Start/Stop and Suspend/Resume
353 */
354
355static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
356{
357 struct drm_crtc *crtc = &rcrtc->crtc;
358 bool interlaced;
359
360 if (rcrtc->started)
361 return;
362
363 /* Set display off and background to black */
364 rcar_du_crtc_write(rcrtc, DOOR, DOOR_RGB(0, 0, 0));
365 rcar_du_crtc_write(rcrtc, BPOR, BPOR_RGB(0, 0, 0));
366
367 /* Configure display timings and output routing */
368 rcar_du_crtc_set_display_timing(rcrtc);
369 rcar_du_group_set_routing(rcrtc->group);
370
371 /* Start with all planes disabled. */
372 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR, 0);
373
374 /* Select master sync mode. This enables display operation in master
375 * sync mode (with the HSYNC and VSYNC signals configured as outputs and
376 * actively driven).
377 */
378 interlaced = rcrtc->crtc.mode.flags & DRM_MODE_FLAG_INTERLACE;
379 rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK | DSYSR_SCM_MASK,
380 (interlaced ? DSYSR_SCM_INT_VIDEO : 0) |
381 DSYSR_TVM_MASTER);
382
383 rcar_du_group_start_stop(rcrtc->group, true);
384
385 /* Enable the VSP compositor. */
386 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
387 rcar_du_vsp_enable(rcrtc);
388
389 /* Turn vertical blanking interrupt reporting back on. */
390 drm_crtc_vblank_on(crtc);
391
392 rcrtc->started = true;
393}
394
395static void rcar_du_crtc_stop(struct rcar_du_crtc *rcrtc)
396{
397 struct drm_crtc *crtc = &rcrtc->crtc;
398
399 if (!rcrtc->started)
400 return;
401
402 /* Disable all planes and wait for the change to take effect. This is
403 * required as the DSnPR registers are updated on vblank, and no vblank
404 * will occur once the CRTC is stopped. Disabling planes when starting
405 * the CRTC thus wouldn't be enough as it would start scanning out
406 * immediately from old frame buffers until the next vblank.
407 *
408 * This increases the CRTC stop delay, especially when multiple CRTCs
409 * are stopped in one operation as we now wait for one vblank per CRTC.
410 * Whether this can be improved needs to be researched.
411 */
412 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR, 0);
413 drm_crtc_wait_one_vblank(crtc);
414
415 /* Disable vertical blanking interrupt reporting. We first need to wait
416 * for page flip completion before stopping the CRTC as userspace
417 * expects page flips to eventually complete.
418 */
419 rcar_du_crtc_wait_page_flip(rcrtc);
420 drm_crtc_vblank_off(crtc);
421
422 /* Disable the VSP compositor. */
423 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
424 rcar_du_vsp_disable(rcrtc);
425
426 /* Select switch sync mode. This stops display operation and configures
427 * the HSYNC and VSYNC signals as inputs.
428 */
429 rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK, DSYSR_TVM_SWITCH);
430
431 rcar_du_group_start_stop(rcrtc->group, false);
432
433 rcrtc->started = false;
434}
435
436void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc)
437{
438 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
439 rcar_du_vsp_disable(rcrtc);
440
441 rcar_du_crtc_stop(rcrtc);
442 rcar_du_crtc_put(rcrtc);
443}
444
445void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc)
446{
447 unsigned int i;
448
449 if (!rcrtc->crtc.state->active)
450 return;
451
452 rcar_du_crtc_get(rcrtc);
453 rcar_du_crtc_start(rcrtc);
454
455 /* Commit the planes state. */
456 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE)) {
457 rcar_du_vsp_enable(rcrtc);
458 } else {
459 for (i = 0; i < rcrtc->group->num_planes; ++i) {
460 struct rcar_du_plane *plane = &rcrtc->group->planes[i];
461
462 if (plane->plane.state->crtc != &rcrtc->crtc)
463 continue;
464
465 rcar_du_plane_setup(plane);
466 }
467 }
468
469 rcar_du_crtc_update_planes(rcrtc);
470}
471
472/* -----------------------------------------------------------------------------
473 * CRTC Functions
474 */
475
476static void rcar_du_crtc_enable(struct drm_crtc *crtc)
477{
478 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
479
480 rcar_du_crtc_get(rcrtc);
481 rcar_du_crtc_start(rcrtc);
482}
483
484static void rcar_du_crtc_disable(struct drm_crtc *crtc)
485{
486 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
487
488 rcar_du_crtc_stop(rcrtc);
489 rcar_du_crtc_put(rcrtc);
490
491 rcrtc->outputs = 0;
492}
493
494static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
495 struct drm_crtc_state *old_crtc_state)
496{
497 struct drm_pending_vblank_event *event = crtc->state->event;
498 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
499 struct drm_device *dev = rcrtc->crtc.dev;
500 unsigned long flags;
501
502 if (event) {
503 WARN_ON(drm_crtc_vblank_get(crtc) != 0);
504
505 spin_lock_irqsave(&dev->event_lock, flags);
506 rcrtc->event = event;
507 spin_unlock_irqrestore(&dev->event_lock, flags);
508 }
509
510 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
511 rcar_du_vsp_atomic_begin(rcrtc);
512}
513
514static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
515 struct drm_crtc_state *old_crtc_state)
516{
517 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
518
519 rcar_du_crtc_update_planes(rcrtc);
520
521 if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE))
522 rcar_du_vsp_atomic_flush(rcrtc);
523}
524
525static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
526 .disable = rcar_du_crtc_disable,
527 .enable = rcar_du_crtc_enable,
528 .atomic_begin = rcar_du_crtc_atomic_begin,
529 .atomic_flush = rcar_du_crtc_atomic_flush,
530};
531
532static const struct drm_crtc_funcs crtc_funcs = {
533 .reset = drm_atomic_helper_crtc_reset,
534 .destroy = drm_crtc_cleanup,
535 .set_config = drm_atomic_helper_set_config,
536 .page_flip = drm_atomic_helper_page_flip,
537 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
538 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
539};
540
541/* -----------------------------------------------------------------------------
542 * Interrupt Handling
543 */
544
545static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
546{
547 struct rcar_du_crtc *rcrtc = arg;
548 irqreturn_t ret = IRQ_NONE;
549 u32 status;
550
551 status = rcar_du_crtc_read(rcrtc, DSSR);
552 rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
553
554 if (status & DSSR_FRM) {
555 drm_handle_vblank(rcrtc->crtc.dev, rcrtc->index);
556 rcar_du_crtc_finish_page_flip(rcrtc);
557 ret = IRQ_HANDLED;
558 }
559
560 return ret;
561}
562
563/* -----------------------------------------------------------------------------
564 * Initialization
565 */
566
567int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index)
568{
569 static const unsigned int mmio_offsets[] = {
570 DU0_REG_OFFSET, DU1_REG_OFFSET, DU2_REG_OFFSET, DU3_REG_OFFSET
571 };
572
573 struct rcar_du_device *rcdu = rgrp->dev;
574 struct platform_device *pdev = to_platform_device(rcdu->dev);
575 struct rcar_du_crtc *rcrtc = &rcdu->crtcs[index];
576 struct drm_crtc *crtc = &rcrtc->crtc;
577 struct drm_plane *primary;
578 unsigned int irqflags;
579 struct clk *clk;
580 char clk_name[9];
581 char *name;
582 int irq;
583 int ret;
584
585 /* Get the CRTC clock and the optional external clock. */
586 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
587 sprintf(clk_name, "du.%u", index);
588 name = clk_name;
589 } else {
590 name = NULL;
591 }
592
593 rcrtc->clock = devm_clk_get(rcdu->dev, name);
594 if (IS_ERR(rcrtc->clock)) {
595 dev_err(rcdu->dev, "no clock for CRTC %u\n", index);
596 return PTR_ERR(rcrtc->clock);
597 }
598
599 sprintf(clk_name, "dclkin.%u", index);
600 clk = devm_clk_get(rcdu->dev, clk_name);
601 if (!IS_ERR(clk)) {
602 rcrtc->extclock = clk;
603 } else if (PTR_ERR(rcrtc->clock) == -EPROBE_DEFER) {
604 dev_info(rcdu->dev, "can't get external clock %u\n", index);
605 return -EPROBE_DEFER;
606 }
607
608 init_waitqueue_head(&rcrtc->flip_wait);
609
610 rcrtc->group = rgrp;
611 rcrtc->mmio_offset = mmio_offsets[index];
612 rcrtc->index = index;
613
614 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE))
615 primary = &rcrtc->vsp->planes[0].plane;
616 else
617 primary = &rgrp->planes[index % 2].plane;
618
619 ret = drm_crtc_init_with_planes(rcdu->ddev, crtc, primary,
620 NULL, &crtc_funcs, NULL);
621 if (ret < 0)
622 return ret;
623
624 drm_crtc_helper_add(crtc, &crtc_helper_funcs);
625
626 /* Start with vertical blanking interrupt reporting disabled. */
627 drm_crtc_vblank_off(crtc);
628
629 /* Register the interrupt handler. */
630 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
631 irq = platform_get_irq(pdev, index);
632 irqflags = 0;
633 } else {
634 irq = platform_get_irq(pdev, 0);
635 irqflags = IRQF_SHARED;
636 }
637
638 if (irq < 0) {
639 dev_err(rcdu->dev, "no IRQ for CRTC %u\n", index);
640 return irq;
641 }
642
643 ret = devm_request_irq(rcdu->dev, irq, rcar_du_crtc_irq, irqflags,
644 dev_name(rcdu->dev), rcrtc);
645 if (ret < 0) {
646 dev_err(rcdu->dev,
647 "failed to register IRQ for CRTC %u\n", index);
648 return ret;
649 }
650
651 return 0;
652}
653
654void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable)
655{
656 if (enable) {
657 rcar_du_crtc_write(rcrtc, DSRCR, DSRCR_VBCL);
658 rcar_du_crtc_set(rcrtc, DIER, DIER_VBE);
659 } else {
660 rcar_du_crtc_clr(rcrtc, DIER, DIER_VBE);
661 }
662}
1/*
2 * rcar_du_crtc.c -- R-Car Display Unit CRTCs
3 *
4 * Copyright (C) 2013 Renesas Corporation
5 *
6 * Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
7 *
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
12 */
13
14#include <linux/clk.h>
15#include <linux/mutex.h>
16
17#include <drm/drmP.h>
18#include <drm/drm_crtc.h>
19#include <drm/drm_crtc_helper.h>
20#include <drm/drm_fb_cma_helper.h>
21#include <drm/drm_gem_cma_helper.h>
22
23#include "rcar_du_crtc.h"
24#include "rcar_du_drv.h"
25#include "rcar_du_kms.h"
26#include "rcar_du_plane.h"
27#include "rcar_du_regs.h"
28
29static u32 rcar_du_crtc_read(struct rcar_du_crtc *rcrtc, u32 reg)
30{
31 struct rcar_du_device *rcdu = rcrtc->group->dev;
32
33 return rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
34}
35
36static void rcar_du_crtc_write(struct rcar_du_crtc *rcrtc, u32 reg, u32 data)
37{
38 struct rcar_du_device *rcdu = rcrtc->group->dev;
39
40 rcar_du_write(rcdu, rcrtc->mmio_offset + reg, data);
41}
42
43static void rcar_du_crtc_clr(struct rcar_du_crtc *rcrtc, u32 reg, u32 clr)
44{
45 struct rcar_du_device *rcdu = rcrtc->group->dev;
46
47 rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
48 rcar_du_read(rcdu, rcrtc->mmio_offset + reg) & ~clr);
49}
50
51static void rcar_du_crtc_set(struct rcar_du_crtc *rcrtc, u32 reg, u32 set)
52{
53 struct rcar_du_device *rcdu = rcrtc->group->dev;
54
55 rcar_du_write(rcdu, rcrtc->mmio_offset + reg,
56 rcar_du_read(rcdu, rcrtc->mmio_offset + reg) | set);
57}
58
59static void rcar_du_crtc_clr_set(struct rcar_du_crtc *rcrtc, u32 reg,
60 u32 clr, u32 set)
61{
62 struct rcar_du_device *rcdu = rcrtc->group->dev;
63 u32 value = rcar_du_read(rcdu, rcrtc->mmio_offset + reg);
64
65 rcar_du_write(rcdu, rcrtc->mmio_offset + reg, (value & ~clr) | set);
66}
67
68static int rcar_du_crtc_get(struct rcar_du_crtc *rcrtc)
69{
70 int ret;
71
72 ret = clk_prepare_enable(rcrtc->clock);
73 if (ret < 0)
74 return ret;
75
76 ret = rcar_du_group_get(rcrtc->group);
77 if (ret < 0)
78 clk_disable_unprepare(rcrtc->clock);
79
80 return ret;
81}
82
83static void rcar_du_crtc_put(struct rcar_du_crtc *rcrtc)
84{
85 rcar_du_group_put(rcrtc->group);
86 clk_disable_unprepare(rcrtc->clock);
87}
88
89static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc)
90{
91 const struct drm_display_mode *mode = &rcrtc->crtc.mode;
92 unsigned long clk;
93 u32 value;
94 u32 div;
95
96 /* Dot clock */
97 clk = clk_get_rate(rcrtc->clock);
98 div = DIV_ROUND_CLOSEST(clk, mode->clock * 1000);
99 div = clamp(div, 1U, 64U) - 1;
100
101 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? ESCR2 : ESCR,
102 ESCR_DCLKSEL_CLKS | div);
103 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? OTAR2 : OTAR, 0);
104
105 /* Signal polarities */
106 value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
107 | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
108 | DSMR_DIPM_DE;
109 rcar_du_crtc_write(rcrtc, DSMR, value);
110
111 /* Display timings */
112 rcar_du_crtc_write(rcrtc, HDSR, mode->htotal - mode->hsync_start - 19);
113 rcar_du_crtc_write(rcrtc, HDER, mode->htotal - mode->hsync_start +
114 mode->hdisplay - 19);
115 rcar_du_crtc_write(rcrtc, HSWR, mode->hsync_end -
116 mode->hsync_start - 1);
117 rcar_du_crtc_write(rcrtc, HCR, mode->htotal - 1);
118
119 rcar_du_crtc_write(rcrtc, VDSR, mode->vtotal - mode->vsync_end - 2);
120 rcar_du_crtc_write(rcrtc, VDER, mode->vtotal - mode->vsync_end +
121 mode->vdisplay - 2);
122 rcar_du_crtc_write(rcrtc, VSPR, mode->vtotal - mode->vsync_end +
123 mode->vsync_start - 1);
124 rcar_du_crtc_write(rcrtc, VCR, mode->vtotal - 1);
125
126 rcar_du_crtc_write(rcrtc, DESR, mode->htotal - mode->hsync_start);
127 rcar_du_crtc_write(rcrtc, DEWR, mode->hdisplay);
128}
129
130void rcar_du_crtc_route_output(struct drm_crtc *crtc,
131 enum rcar_du_output output)
132{
133 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
134 struct rcar_du_device *rcdu = rcrtc->group->dev;
135
136 /* Store the route from the CRTC output to the DU output. The DU will be
137 * configured when starting the CRTC.
138 */
139 rcrtc->outputs |= BIT(output);
140
141 /* Store RGB routing to DPAD0 for R8A7790. */
142 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_DEFR8) &&
143 output == RCAR_DU_OUTPUT_DPAD0)
144 rcdu->dpad0_source = rcrtc->index;
145}
146
147void rcar_du_crtc_update_planes(struct drm_crtc *crtc)
148{
149 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
150 struct rcar_du_plane *planes[RCAR_DU_NUM_HW_PLANES];
151 unsigned int num_planes = 0;
152 unsigned int prio = 0;
153 unsigned int i;
154 u32 dptsr = 0;
155 u32 dspr = 0;
156
157 for (i = 0; i < ARRAY_SIZE(rcrtc->group->planes.planes); ++i) {
158 struct rcar_du_plane *plane = &rcrtc->group->planes.planes[i];
159 unsigned int j;
160
161 if (plane->crtc != &rcrtc->crtc || !plane->enabled)
162 continue;
163
164 /* Insert the plane in the sorted planes array. */
165 for (j = num_planes++; j > 0; --j) {
166 if (planes[j-1]->zpos <= plane->zpos)
167 break;
168 planes[j] = planes[j-1];
169 }
170
171 planes[j] = plane;
172 prio += plane->format->planes * 4;
173 }
174
175 for (i = 0; i < num_planes; ++i) {
176 struct rcar_du_plane *plane = planes[i];
177 unsigned int index = plane->hwindex;
178
179 prio -= 4;
180 dspr |= (index + 1) << prio;
181 dptsr |= DPTSR_PnDK(index) | DPTSR_PnTS(index);
182
183 if (plane->format->planes == 2) {
184 index = (index + 1) % 8;
185
186 prio -= 4;
187 dspr |= (index + 1) << prio;
188 dptsr |= DPTSR_PnDK(index) | DPTSR_PnTS(index);
189 }
190 }
191
192 /* Select display timing and dot clock generator 2 for planes associated
193 * with superposition controller 2.
194 */
195 if (rcrtc->index % 2) {
196 u32 value = rcar_du_group_read(rcrtc->group, DPTSR);
197
198 /* The DPTSR register is updated when the display controller is
199 * stopped. We thus need to restart the DU. Once again, sorry
200 * for the flicker. One way to mitigate the issue would be to
201 * pre-associate planes with CRTCs (either with a fixed 4/4
202 * split, or through a module parameter). Flicker would then
203 * occur only if we need to break the pre-association.
204 */
205 if (value != dptsr) {
206 rcar_du_group_write(rcrtc->group, DPTSR, dptsr);
207 if (rcrtc->group->used_crtcs)
208 rcar_du_group_restart(rcrtc->group);
209 }
210 }
211
212 rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? DS2PR : DS1PR,
213 dspr);
214}
215
216static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
217{
218 struct drm_crtc *crtc = &rcrtc->crtc;
219 unsigned int i;
220
221 if (rcrtc->started)
222 return;
223
224 if (WARN_ON(rcrtc->plane->format == NULL))
225 return;
226
227 /* Set display off and background to black */
228 rcar_du_crtc_write(rcrtc, DOOR, DOOR_RGB(0, 0, 0));
229 rcar_du_crtc_write(rcrtc, BPOR, BPOR_RGB(0, 0, 0));
230
231 /* Configure display timings and output routing */
232 rcar_du_crtc_set_display_timing(rcrtc);
233 rcar_du_group_set_routing(rcrtc->group);
234
235 mutex_lock(&rcrtc->group->planes.lock);
236 rcrtc->plane->enabled = true;
237 rcar_du_crtc_update_planes(crtc);
238 mutex_unlock(&rcrtc->group->planes.lock);
239
240 /* Setup planes. */
241 for (i = 0; i < ARRAY_SIZE(rcrtc->group->planes.planes); ++i) {
242 struct rcar_du_plane *plane = &rcrtc->group->planes.planes[i];
243
244 if (plane->crtc != crtc || !plane->enabled)
245 continue;
246
247 rcar_du_plane_setup(plane);
248 }
249
250 /* Select master sync mode. This enables display operation in master
251 * sync mode (with the HSYNC and VSYNC signals configured as outputs and
252 * actively driven).
253 */
254 rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK, DSYSR_TVM_MASTER);
255
256 rcar_du_group_start_stop(rcrtc->group, true);
257
258 rcrtc->started = true;
259}
260
261static void rcar_du_crtc_stop(struct rcar_du_crtc *rcrtc)
262{
263 struct drm_crtc *crtc = &rcrtc->crtc;
264
265 if (!rcrtc->started)
266 return;
267
268 mutex_lock(&rcrtc->group->planes.lock);
269 rcrtc->plane->enabled = false;
270 rcar_du_crtc_update_planes(crtc);
271 mutex_unlock(&rcrtc->group->planes.lock);
272
273 /* Select switch sync mode. This stops display operation and configures
274 * the HSYNC and VSYNC signals as inputs.
275 */
276 rcar_du_crtc_clr_set(rcrtc, DSYSR, DSYSR_TVM_MASK, DSYSR_TVM_SWITCH);
277
278 rcar_du_group_start_stop(rcrtc->group, false);
279
280 rcrtc->started = false;
281}
282
283void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc)
284{
285 rcar_du_crtc_stop(rcrtc);
286 rcar_du_crtc_put(rcrtc);
287}
288
289void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc)
290{
291 if (rcrtc->dpms != DRM_MODE_DPMS_ON)
292 return;
293
294 rcar_du_crtc_get(rcrtc);
295 rcar_du_crtc_start(rcrtc);
296}
297
298static void rcar_du_crtc_update_base(struct rcar_du_crtc *rcrtc)
299{
300 struct drm_crtc *crtc = &rcrtc->crtc;
301
302 rcar_du_plane_compute_base(rcrtc->plane, crtc->primary->fb);
303 rcar_du_plane_update_base(rcrtc->plane);
304}
305
306static void rcar_du_crtc_dpms(struct drm_crtc *crtc, int mode)
307{
308 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
309
310 if (rcrtc->dpms == mode)
311 return;
312
313 if (mode == DRM_MODE_DPMS_ON) {
314 rcar_du_crtc_get(rcrtc);
315 rcar_du_crtc_start(rcrtc);
316 } else {
317 rcar_du_crtc_stop(rcrtc);
318 rcar_du_crtc_put(rcrtc);
319 }
320
321 rcrtc->dpms = mode;
322}
323
324static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc,
325 const struct drm_display_mode *mode,
326 struct drm_display_mode *adjusted_mode)
327{
328 /* TODO Fixup modes */
329 return true;
330}
331
332static void rcar_du_crtc_mode_prepare(struct drm_crtc *crtc)
333{
334 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
335
336 /* We need to access the hardware during mode set, acquire a reference
337 * to the CRTC.
338 */
339 rcar_du_crtc_get(rcrtc);
340
341 /* Stop the CRTC and release the plane. Force the DPMS mode to off as a
342 * result.
343 */
344 rcar_du_crtc_stop(rcrtc);
345 rcar_du_plane_release(rcrtc->plane);
346
347 rcrtc->dpms = DRM_MODE_DPMS_OFF;
348}
349
350static int rcar_du_crtc_mode_set(struct drm_crtc *crtc,
351 struct drm_display_mode *mode,
352 struct drm_display_mode *adjusted_mode,
353 int x, int y,
354 struct drm_framebuffer *old_fb)
355{
356 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
357 struct rcar_du_device *rcdu = rcrtc->group->dev;
358 const struct rcar_du_format_info *format;
359 int ret;
360
361 format = rcar_du_format_info(crtc->primary->fb->pixel_format);
362 if (format == NULL) {
363 dev_dbg(rcdu->dev, "mode_set: unsupported format %08x\n",
364 crtc->primary->fb->pixel_format);
365 ret = -EINVAL;
366 goto error;
367 }
368
369 ret = rcar_du_plane_reserve(rcrtc->plane, format);
370 if (ret < 0)
371 goto error;
372
373 rcrtc->plane->format = format;
374
375 rcrtc->plane->src_x = x;
376 rcrtc->plane->src_y = y;
377 rcrtc->plane->width = mode->hdisplay;
378 rcrtc->plane->height = mode->vdisplay;
379
380 rcar_du_plane_compute_base(rcrtc->plane, crtc->primary->fb);
381
382 rcrtc->outputs = 0;
383
384 return 0;
385
386error:
387 /* There's no rollback/abort operation to clean up in case of error. We
388 * thus need to release the reference to the CRTC acquired in prepare()
389 * here.
390 */
391 rcar_du_crtc_put(rcrtc);
392 return ret;
393}
394
395static void rcar_du_crtc_mode_commit(struct drm_crtc *crtc)
396{
397 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
398
399 /* We're done, restart the CRTC and set the DPMS mode to on. The
400 * reference to the DU acquired at prepare() time will thus be released
401 * by the DPMS handler (possibly called by the disable() handler).
402 */
403 rcar_du_crtc_start(rcrtc);
404 rcrtc->dpms = DRM_MODE_DPMS_ON;
405}
406
407static int rcar_du_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
408 struct drm_framebuffer *old_fb)
409{
410 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
411
412 rcrtc->plane->src_x = x;
413 rcrtc->plane->src_y = y;
414
415 rcar_du_crtc_update_base(rcrtc);
416
417 return 0;
418}
419
420static void rcar_du_crtc_disable(struct drm_crtc *crtc)
421{
422 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
423
424 rcar_du_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
425 rcar_du_plane_release(rcrtc->plane);
426}
427
428static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
429 .dpms = rcar_du_crtc_dpms,
430 .mode_fixup = rcar_du_crtc_mode_fixup,
431 .prepare = rcar_du_crtc_mode_prepare,
432 .commit = rcar_du_crtc_mode_commit,
433 .mode_set = rcar_du_crtc_mode_set,
434 .mode_set_base = rcar_du_crtc_mode_set_base,
435 .disable = rcar_du_crtc_disable,
436};
437
438void rcar_du_crtc_cancel_page_flip(struct rcar_du_crtc *rcrtc,
439 struct drm_file *file)
440{
441 struct drm_pending_vblank_event *event;
442 struct drm_device *dev = rcrtc->crtc.dev;
443 unsigned long flags;
444
445 /* Destroy the pending vertical blanking event associated with the
446 * pending page flip, if any, and disable vertical blanking interrupts.
447 */
448 spin_lock_irqsave(&dev->event_lock, flags);
449 event = rcrtc->event;
450 if (event && event->base.file_priv == file) {
451 rcrtc->event = NULL;
452 event->base.destroy(&event->base);
453 drm_vblank_put(dev, rcrtc->index);
454 }
455 spin_unlock_irqrestore(&dev->event_lock, flags);
456}
457
458static void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc)
459{
460 struct drm_pending_vblank_event *event;
461 struct drm_device *dev = rcrtc->crtc.dev;
462 unsigned long flags;
463
464 spin_lock_irqsave(&dev->event_lock, flags);
465 event = rcrtc->event;
466 rcrtc->event = NULL;
467 spin_unlock_irqrestore(&dev->event_lock, flags);
468
469 if (event == NULL)
470 return;
471
472 spin_lock_irqsave(&dev->event_lock, flags);
473 drm_send_vblank_event(dev, rcrtc->index, event);
474 spin_unlock_irqrestore(&dev->event_lock, flags);
475
476 drm_vblank_put(dev, rcrtc->index);
477}
478
479static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
480{
481 struct rcar_du_crtc *rcrtc = arg;
482 irqreturn_t ret = IRQ_NONE;
483 u32 status;
484
485 status = rcar_du_crtc_read(rcrtc, DSSR);
486 rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
487
488 if (status & DSSR_VBK) {
489 drm_handle_vblank(rcrtc->crtc.dev, rcrtc->index);
490 rcar_du_crtc_finish_page_flip(rcrtc);
491 ret = IRQ_HANDLED;
492 }
493
494 return ret;
495}
496
497static int rcar_du_crtc_page_flip(struct drm_crtc *crtc,
498 struct drm_framebuffer *fb,
499 struct drm_pending_vblank_event *event,
500 uint32_t page_flip_flags)
501{
502 struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
503 struct drm_device *dev = rcrtc->crtc.dev;
504 unsigned long flags;
505
506 spin_lock_irqsave(&dev->event_lock, flags);
507 if (rcrtc->event != NULL) {
508 spin_unlock_irqrestore(&dev->event_lock, flags);
509 return -EBUSY;
510 }
511 spin_unlock_irqrestore(&dev->event_lock, flags);
512
513 crtc->primary->fb = fb;
514 rcar_du_crtc_update_base(rcrtc);
515
516 if (event) {
517 event->pipe = rcrtc->index;
518 drm_vblank_get(dev, rcrtc->index);
519 spin_lock_irqsave(&dev->event_lock, flags);
520 rcrtc->event = event;
521 spin_unlock_irqrestore(&dev->event_lock, flags);
522 }
523
524 return 0;
525}
526
527static const struct drm_crtc_funcs crtc_funcs = {
528 .destroy = drm_crtc_cleanup,
529 .set_config = drm_crtc_helper_set_config,
530 .page_flip = rcar_du_crtc_page_flip,
531};
532
533int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int index)
534{
535 static const unsigned int mmio_offsets[] = {
536 DU0_REG_OFFSET, DU1_REG_OFFSET, DU2_REG_OFFSET
537 };
538
539 struct rcar_du_device *rcdu = rgrp->dev;
540 struct platform_device *pdev = to_platform_device(rcdu->dev);
541 struct rcar_du_crtc *rcrtc = &rcdu->crtcs[index];
542 struct drm_crtc *crtc = &rcrtc->crtc;
543 unsigned int irqflags;
544 char clk_name[5];
545 char *name;
546 int irq;
547 int ret;
548
549 /* Get the CRTC clock. */
550 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
551 sprintf(clk_name, "du.%u", index);
552 name = clk_name;
553 } else {
554 name = NULL;
555 }
556
557 rcrtc->clock = devm_clk_get(rcdu->dev, name);
558 if (IS_ERR(rcrtc->clock)) {
559 dev_err(rcdu->dev, "no clock for CRTC %u\n", index);
560 return PTR_ERR(rcrtc->clock);
561 }
562
563 rcrtc->group = rgrp;
564 rcrtc->mmio_offset = mmio_offsets[index];
565 rcrtc->index = index;
566 rcrtc->dpms = DRM_MODE_DPMS_OFF;
567 rcrtc->plane = &rgrp->planes.planes[index % 2];
568
569 rcrtc->plane->crtc = crtc;
570
571 ret = drm_crtc_init(rcdu->ddev, crtc, &crtc_funcs);
572 if (ret < 0)
573 return ret;
574
575 drm_crtc_helper_add(crtc, &crtc_helper_funcs);
576
577 /* Register the interrupt handler. */
578 if (rcar_du_has(rcdu, RCAR_DU_FEATURE_CRTC_IRQ_CLOCK)) {
579 irq = platform_get_irq(pdev, index);
580 irqflags = 0;
581 } else {
582 irq = platform_get_irq(pdev, 0);
583 irqflags = IRQF_SHARED;
584 }
585
586 if (irq < 0) {
587 dev_err(rcdu->dev, "no IRQ for CRTC %u\n", index);
588 return ret;
589 }
590
591 ret = devm_request_irq(rcdu->dev, irq, rcar_du_crtc_irq, irqflags,
592 dev_name(rcdu->dev), rcrtc);
593 if (ret < 0) {
594 dev_err(rcdu->dev,
595 "failed to register IRQ for CRTC %u\n", index);
596 return ret;
597 }
598
599 return 0;
600}
601
602void rcar_du_crtc_enable_vblank(struct rcar_du_crtc *rcrtc, bool enable)
603{
604 if (enable) {
605 rcar_du_crtc_write(rcrtc, DSRCR, DSRCR_VBCL);
606 rcar_du_crtc_set(rcrtc, DIER, DIER_VBE);
607 } else {
608 rcar_du_crtc_clr(rcrtc, DIER, DIER_VBE);
609 }
610}