Loading...
1/*
2 * Copyright © 2011 Intel Corporation
3 *
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
10 *
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
13 * Software.
14 *
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21 * SOFTWARE.
22 *
23 * Authors:
24 * Jesse Barnes <jbarnes@virtuousgeek.org>
25 *
26 * New plane/sprite handling.
27 *
28 * The older chips had a separate interface for programming plane related
29 * registers; newer ones are much simpler and we can use the new DRM plane
30 * support.
31 */
32#include "drmP.h"
33#include "drm_crtc.h"
34#include "drm_fourcc.h"
35#include "intel_drv.h"
36#include "i915_drm.h"
37#include "i915_drv.h"
38
39static void
40ivb_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
41 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
42 unsigned int crtc_w, unsigned int crtc_h,
43 uint32_t x, uint32_t y,
44 uint32_t src_w, uint32_t src_h)
45{
46 struct drm_device *dev = plane->dev;
47 struct drm_i915_private *dev_priv = dev->dev_private;
48 struct intel_plane *intel_plane = to_intel_plane(plane);
49 int pipe = intel_plane->pipe;
50 u32 sprctl, sprscale = 0;
51 int pixel_size;
52
53 sprctl = I915_READ(SPRCTL(pipe));
54
55 /* Mask out pixel format bits in case we change it */
56 sprctl &= ~SPRITE_PIXFORMAT_MASK;
57 sprctl &= ~SPRITE_RGB_ORDER_RGBX;
58 sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
59
60 switch (fb->pixel_format) {
61 case DRM_FORMAT_XBGR8888:
62 sprctl |= SPRITE_FORMAT_RGBX888;
63 pixel_size = 4;
64 break;
65 case DRM_FORMAT_XRGB8888:
66 sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
67 pixel_size = 4;
68 break;
69 case DRM_FORMAT_YUYV:
70 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
71 pixel_size = 2;
72 break;
73 case DRM_FORMAT_YVYU:
74 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
75 pixel_size = 2;
76 break;
77 case DRM_FORMAT_UYVY:
78 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
79 pixel_size = 2;
80 break;
81 case DRM_FORMAT_VYUY:
82 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
83 pixel_size = 2;
84 break;
85 default:
86 DRM_DEBUG_DRIVER("bad pixel format, assuming RGBX888\n");
87 sprctl |= DVS_FORMAT_RGBX888;
88 pixel_size = 4;
89 break;
90 }
91
92 if (obj->tiling_mode != I915_TILING_NONE)
93 sprctl |= SPRITE_TILED;
94
95 /* must disable */
96 sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
97 sprctl |= SPRITE_ENABLE;
98
99 /* Sizes are 0 based */
100 src_w--;
101 src_h--;
102 crtc_w--;
103 crtc_h--;
104
105 intel_update_sprite_watermarks(dev, pipe, crtc_w, pixel_size);
106
107 /*
108 * IVB workaround: must disable low power watermarks for at least
109 * one frame before enabling scaling. LP watermarks can be re-enabled
110 * when scaling is disabled.
111 */
112 if (crtc_w != src_w || crtc_h != src_h) {
113 if (!dev_priv->sprite_scaling_enabled) {
114 dev_priv->sprite_scaling_enabled = true;
115 intel_update_watermarks(dev);
116 intel_wait_for_vblank(dev, pipe);
117 }
118 sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;
119 } else {
120 if (dev_priv->sprite_scaling_enabled) {
121 dev_priv->sprite_scaling_enabled = false;
122 /* potentially re-enable LP watermarks */
123 intel_update_watermarks(dev);
124 }
125 }
126
127 I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
128 I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);
129 if (obj->tiling_mode != I915_TILING_NONE) {
130 I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
131 } else {
132 unsigned long offset;
133
134 offset = y * fb->pitches[0] + x * (fb->bits_per_pixel / 8);
135 I915_WRITE(SPRLINOFF(pipe), offset);
136 }
137 I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
138 I915_WRITE(SPRSCALE(pipe), sprscale);
139 I915_WRITE(SPRCTL(pipe), sprctl);
140 I915_MODIFY_DISPBASE(SPRSURF(pipe), obj->gtt_offset);
141 POSTING_READ(SPRSURF(pipe));
142}
143
144static void
145ivb_disable_plane(struct drm_plane *plane)
146{
147 struct drm_device *dev = plane->dev;
148 struct drm_i915_private *dev_priv = dev->dev_private;
149 struct intel_plane *intel_plane = to_intel_plane(plane);
150 int pipe = intel_plane->pipe;
151
152 I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
153 /* Can't leave the scaler enabled... */
154 I915_WRITE(SPRSCALE(pipe), 0);
155 /* Activate double buffered register update */
156 I915_MODIFY_DISPBASE(SPRSURF(pipe), 0);
157 POSTING_READ(SPRSURF(pipe));
158
159 dev_priv->sprite_scaling_enabled = false;
160 intel_update_watermarks(dev);
161}
162
163static int
164ivb_update_colorkey(struct drm_plane *plane,
165 struct drm_intel_sprite_colorkey *key)
166{
167 struct drm_device *dev = plane->dev;
168 struct drm_i915_private *dev_priv = dev->dev_private;
169 struct intel_plane *intel_plane;
170 u32 sprctl;
171 int ret = 0;
172
173 intel_plane = to_intel_plane(plane);
174
175 I915_WRITE(SPRKEYVAL(intel_plane->pipe), key->min_value);
176 I915_WRITE(SPRKEYMAX(intel_plane->pipe), key->max_value);
177 I915_WRITE(SPRKEYMSK(intel_plane->pipe), key->channel_mask);
178
179 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
180 sprctl &= ~(SPRITE_SOURCE_KEY | SPRITE_DEST_KEY);
181 if (key->flags & I915_SET_COLORKEY_DESTINATION)
182 sprctl |= SPRITE_DEST_KEY;
183 else if (key->flags & I915_SET_COLORKEY_SOURCE)
184 sprctl |= SPRITE_SOURCE_KEY;
185 I915_WRITE(SPRCTL(intel_plane->pipe), sprctl);
186
187 POSTING_READ(SPRKEYMSK(intel_plane->pipe));
188
189 return ret;
190}
191
192static void
193ivb_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
194{
195 struct drm_device *dev = plane->dev;
196 struct drm_i915_private *dev_priv = dev->dev_private;
197 struct intel_plane *intel_plane;
198 u32 sprctl;
199
200 intel_plane = to_intel_plane(plane);
201
202 key->min_value = I915_READ(SPRKEYVAL(intel_plane->pipe));
203 key->max_value = I915_READ(SPRKEYMAX(intel_plane->pipe));
204 key->channel_mask = I915_READ(SPRKEYMSK(intel_plane->pipe));
205 key->flags = 0;
206
207 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
208
209 if (sprctl & SPRITE_DEST_KEY)
210 key->flags = I915_SET_COLORKEY_DESTINATION;
211 else if (sprctl & SPRITE_SOURCE_KEY)
212 key->flags = I915_SET_COLORKEY_SOURCE;
213 else
214 key->flags = I915_SET_COLORKEY_NONE;
215}
216
217static void
218ilk_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
219 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
220 unsigned int crtc_w, unsigned int crtc_h,
221 uint32_t x, uint32_t y,
222 uint32_t src_w, uint32_t src_h)
223{
224 struct drm_device *dev = plane->dev;
225 struct drm_i915_private *dev_priv = dev->dev_private;
226 struct intel_plane *intel_plane = to_intel_plane(plane);
227 int pipe = intel_plane->pipe, pixel_size;
228 u32 dvscntr, dvsscale;
229
230 dvscntr = I915_READ(DVSCNTR(pipe));
231
232 /* Mask out pixel format bits in case we change it */
233 dvscntr &= ~DVS_PIXFORMAT_MASK;
234 dvscntr &= ~DVS_RGB_ORDER_XBGR;
235 dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
236
237 switch (fb->pixel_format) {
238 case DRM_FORMAT_XBGR8888:
239 dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
240 pixel_size = 4;
241 break;
242 case DRM_FORMAT_XRGB8888:
243 dvscntr |= DVS_FORMAT_RGBX888;
244 pixel_size = 4;
245 break;
246 case DRM_FORMAT_YUYV:
247 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
248 pixel_size = 2;
249 break;
250 case DRM_FORMAT_YVYU:
251 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
252 pixel_size = 2;
253 break;
254 case DRM_FORMAT_UYVY:
255 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
256 pixel_size = 2;
257 break;
258 case DRM_FORMAT_VYUY:
259 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
260 pixel_size = 2;
261 break;
262 default:
263 DRM_DEBUG_DRIVER("bad pixel format, assuming RGBX888\n");
264 dvscntr |= DVS_FORMAT_RGBX888;
265 pixel_size = 4;
266 break;
267 }
268
269 if (obj->tiling_mode != I915_TILING_NONE)
270 dvscntr |= DVS_TILED;
271
272 if (IS_GEN6(dev))
273 dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
274 dvscntr |= DVS_ENABLE;
275
276 /* Sizes are 0 based */
277 src_w--;
278 src_h--;
279 crtc_w--;
280 crtc_h--;
281
282 intel_update_sprite_watermarks(dev, pipe, crtc_w, pixel_size);
283
284 dvsscale = 0;
285 if (IS_GEN5(dev) || crtc_w != src_w || crtc_h != src_h)
286 dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;
287
288 I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
289 I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);
290 if (obj->tiling_mode != I915_TILING_NONE) {
291 I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
292 } else {
293 unsigned long offset;
294
295 offset = y * fb->pitches[0] + x * (fb->bits_per_pixel / 8);
296 I915_WRITE(DVSLINOFF(pipe), offset);
297 }
298 I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
299 I915_WRITE(DVSSCALE(pipe), dvsscale);
300 I915_WRITE(DVSCNTR(pipe), dvscntr);
301 I915_MODIFY_DISPBASE(DVSSURF(pipe), obj->gtt_offset);
302 POSTING_READ(DVSSURF(pipe));
303}
304
305static void
306ilk_disable_plane(struct drm_plane *plane)
307{
308 struct drm_device *dev = plane->dev;
309 struct drm_i915_private *dev_priv = dev->dev_private;
310 struct intel_plane *intel_plane = to_intel_plane(plane);
311 int pipe = intel_plane->pipe;
312
313 I915_WRITE(DVSCNTR(pipe), I915_READ(DVSCNTR(pipe)) & ~DVS_ENABLE);
314 /* Disable the scaler */
315 I915_WRITE(DVSSCALE(pipe), 0);
316 /* Flush double buffered register updates */
317 I915_MODIFY_DISPBASE(DVSSURF(pipe), 0);
318 POSTING_READ(DVSSURF(pipe));
319}
320
321static void
322intel_enable_primary(struct drm_crtc *crtc)
323{
324 struct drm_device *dev = crtc->dev;
325 struct drm_i915_private *dev_priv = dev->dev_private;
326 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
327 int reg = DSPCNTR(intel_crtc->plane);
328
329 I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
330}
331
332static void
333intel_disable_primary(struct drm_crtc *crtc)
334{
335 struct drm_device *dev = crtc->dev;
336 struct drm_i915_private *dev_priv = dev->dev_private;
337 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
338 int reg = DSPCNTR(intel_crtc->plane);
339
340 I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
341}
342
343static int
344ilk_update_colorkey(struct drm_plane *plane,
345 struct drm_intel_sprite_colorkey *key)
346{
347 struct drm_device *dev = plane->dev;
348 struct drm_i915_private *dev_priv = dev->dev_private;
349 struct intel_plane *intel_plane;
350 u32 dvscntr;
351 int ret = 0;
352
353 intel_plane = to_intel_plane(plane);
354
355 I915_WRITE(DVSKEYVAL(intel_plane->pipe), key->min_value);
356 I915_WRITE(DVSKEYMAX(intel_plane->pipe), key->max_value);
357 I915_WRITE(DVSKEYMSK(intel_plane->pipe), key->channel_mask);
358
359 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
360 dvscntr &= ~(DVS_SOURCE_KEY | DVS_DEST_KEY);
361 if (key->flags & I915_SET_COLORKEY_DESTINATION)
362 dvscntr |= DVS_DEST_KEY;
363 else if (key->flags & I915_SET_COLORKEY_SOURCE)
364 dvscntr |= DVS_SOURCE_KEY;
365 I915_WRITE(DVSCNTR(intel_plane->pipe), dvscntr);
366
367 POSTING_READ(DVSKEYMSK(intel_plane->pipe));
368
369 return ret;
370}
371
372static void
373ilk_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
374{
375 struct drm_device *dev = plane->dev;
376 struct drm_i915_private *dev_priv = dev->dev_private;
377 struct intel_plane *intel_plane;
378 u32 dvscntr;
379
380 intel_plane = to_intel_plane(plane);
381
382 key->min_value = I915_READ(DVSKEYVAL(intel_plane->pipe));
383 key->max_value = I915_READ(DVSKEYMAX(intel_plane->pipe));
384 key->channel_mask = I915_READ(DVSKEYMSK(intel_plane->pipe));
385 key->flags = 0;
386
387 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
388
389 if (dvscntr & DVS_DEST_KEY)
390 key->flags = I915_SET_COLORKEY_DESTINATION;
391 else if (dvscntr & DVS_SOURCE_KEY)
392 key->flags = I915_SET_COLORKEY_SOURCE;
393 else
394 key->flags = I915_SET_COLORKEY_NONE;
395}
396
397static int
398intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
399 struct drm_framebuffer *fb, int crtc_x, int crtc_y,
400 unsigned int crtc_w, unsigned int crtc_h,
401 uint32_t src_x, uint32_t src_y,
402 uint32_t src_w, uint32_t src_h)
403{
404 struct drm_device *dev = plane->dev;
405 struct drm_i915_private *dev_priv = dev->dev_private;
406 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
407 struct intel_plane *intel_plane = to_intel_plane(plane);
408 struct intel_framebuffer *intel_fb;
409 struct drm_i915_gem_object *obj, *old_obj;
410 int pipe = intel_plane->pipe;
411 int ret = 0;
412 int x = src_x >> 16, y = src_y >> 16;
413 int primary_w = crtc->mode.hdisplay, primary_h = crtc->mode.vdisplay;
414 bool disable_primary = false;
415
416 intel_fb = to_intel_framebuffer(fb);
417 obj = intel_fb->obj;
418
419 old_obj = intel_plane->obj;
420
421 src_w = src_w >> 16;
422 src_h = src_h >> 16;
423
424 /* Pipe must be running... */
425 if (!(I915_READ(PIPECONF(pipe)) & PIPECONF_ENABLE))
426 return -EINVAL;
427
428 if (crtc_x >= primary_w || crtc_y >= primary_h)
429 return -EINVAL;
430
431 /* Don't modify another pipe's plane */
432 if (intel_plane->pipe != intel_crtc->pipe)
433 return -EINVAL;
434
435 /*
436 * Clamp the width & height into the visible area. Note we don't
437 * try to scale the source if part of the visible region is offscreen.
438 * The caller must handle that by adjusting source offset and size.
439 */
440 if ((crtc_x < 0) && ((crtc_x + crtc_w) > 0)) {
441 crtc_w += crtc_x;
442 crtc_x = 0;
443 }
444 if ((crtc_x + crtc_w) <= 0) /* Nothing to display */
445 goto out;
446 if ((crtc_x + crtc_w) > primary_w)
447 crtc_w = primary_w - crtc_x;
448
449 if ((crtc_y < 0) && ((crtc_y + crtc_h) > 0)) {
450 crtc_h += crtc_y;
451 crtc_y = 0;
452 }
453 if ((crtc_y + crtc_h) <= 0) /* Nothing to display */
454 goto out;
455 if (crtc_y + crtc_h > primary_h)
456 crtc_h = primary_h - crtc_y;
457
458 if (!crtc_w || !crtc_h) /* Again, nothing to display */
459 goto out;
460
461 /*
462 * We can take a larger source and scale it down, but
463 * only so much... 16x is the max on SNB.
464 */
465 if (((src_w * src_h) / (crtc_w * crtc_h)) > intel_plane->max_downscale)
466 return -EINVAL;
467
468 /*
469 * If the sprite is completely covering the primary plane,
470 * we can disable the primary and save power.
471 */
472 if ((crtc_x == 0) && (crtc_y == 0) &&
473 (crtc_w == primary_w) && (crtc_h == primary_h))
474 disable_primary = true;
475
476 mutex_lock(&dev->struct_mutex);
477
478 ret = intel_pin_and_fence_fb_obj(dev, obj, NULL);
479 if (ret)
480 goto out_unlock;
481
482 intel_plane->obj = obj;
483
484 /*
485 * Be sure to re-enable the primary before the sprite is no longer
486 * covering it fully.
487 */
488 if (!disable_primary && intel_plane->primary_disabled) {
489 intel_enable_primary(crtc);
490 intel_plane->primary_disabled = false;
491 }
492
493 intel_plane->update_plane(plane, fb, obj, crtc_x, crtc_y,
494 crtc_w, crtc_h, x, y, src_w, src_h);
495
496 if (disable_primary) {
497 intel_disable_primary(crtc);
498 intel_plane->primary_disabled = true;
499 }
500
501 /* Unpin old obj after new one is active to avoid ugliness */
502 if (old_obj) {
503 /*
504 * It's fairly common to simply update the position of
505 * an existing object. In that case, we don't need to
506 * wait for vblank to avoid ugliness, we only need to
507 * do the pin & ref bookkeeping.
508 */
509 if (old_obj != obj) {
510 mutex_unlock(&dev->struct_mutex);
511 intel_wait_for_vblank(dev, to_intel_crtc(crtc)->pipe);
512 mutex_lock(&dev->struct_mutex);
513 }
514 intel_unpin_fb_obj(old_obj);
515 }
516
517out_unlock:
518 mutex_unlock(&dev->struct_mutex);
519out:
520 return ret;
521}
522
523static int
524intel_disable_plane(struct drm_plane *plane)
525{
526 struct drm_device *dev = plane->dev;
527 struct intel_plane *intel_plane = to_intel_plane(plane);
528 int ret = 0;
529
530 if (intel_plane->primary_disabled) {
531 intel_enable_primary(plane->crtc);
532 intel_plane->primary_disabled = false;
533 }
534
535 intel_plane->disable_plane(plane);
536
537 if (!intel_plane->obj)
538 goto out;
539
540 mutex_lock(&dev->struct_mutex);
541 intel_unpin_fb_obj(intel_plane->obj);
542 intel_plane->obj = NULL;
543 mutex_unlock(&dev->struct_mutex);
544out:
545
546 return ret;
547}
548
549static void intel_destroy_plane(struct drm_plane *plane)
550{
551 struct intel_plane *intel_plane = to_intel_plane(plane);
552 intel_disable_plane(plane);
553 drm_plane_cleanup(plane);
554 kfree(intel_plane);
555}
556
557int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
558 struct drm_file *file_priv)
559{
560 struct drm_intel_sprite_colorkey *set = data;
561 struct drm_mode_object *obj;
562 struct drm_plane *plane;
563 struct intel_plane *intel_plane;
564 int ret = 0;
565
566 if (!drm_core_check_feature(dev, DRIVER_MODESET))
567 return -ENODEV;
568
569 /* Make sure we don't try to enable both src & dest simultaneously */
570 if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
571 return -EINVAL;
572
573 mutex_lock(&dev->mode_config.mutex);
574
575 obj = drm_mode_object_find(dev, set->plane_id, DRM_MODE_OBJECT_PLANE);
576 if (!obj) {
577 ret = -EINVAL;
578 goto out_unlock;
579 }
580
581 plane = obj_to_plane(obj);
582 intel_plane = to_intel_plane(plane);
583 ret = intel_plane->update_colorkey(plane, set);
584
585out_unlock:
586 mutex_unlock(&dev->mode_config.mutex);
587 return ret;
588}
589
590int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
591 struct drm_file *file_priv)
592{
593 struct drm_intel_sprite_colorkey *get = data;
594 struct drm_mode_object *obj;
595 struct drm_plane *plane;
596 struct intel_plane *intel_plane;
597 int ret = 0;
598
599 if (!drm_core_check_feature(dev, DRIVER_MODESET))
600 return -ENODEV;
601
602 mutex_lock(&dev->mode_config.mutex);
603
604 obj = drm_mode_object_find(dev, get->plane_id, DRM_MODE_OBJECT_PLANE);
605 if (!obj) {
606 ret = -EINVAL;
607 goto out_unlock;
608 }
609
610 plane = obj_to_plane(obj);
611 intel_plane = to_intel_plane(plane);
612 intel_plane->get_colorkey(plane, get);
613
614out_unlock:
615 mutex_unlock(&dev->mode_config.mutex);
616 return ret;
617}
618
619static const struct drm_plane_funcs intel_plane_funcs = {
620 .update_plane = intel_update_plane,
621 .disable_plane = intel_disable_plane,
622 .destroy = intel_destroy_plane,
623};
624
625static uint32_t ilk_plane_formats[] = {
626 DRM_FORMAT_XRGB8888,
627 DRM_FORMAT_YUYV,
628 DRM_FORMAT_YVYU,
629 DRM_FORMAT_UYVY,
630 DRM_FORMAT_VYUY,
631};
632
633static uint32_t snb_plane_formats[] = {
634 DRM_FORMAT_XBGR8888,
635 DRM_FORMAT_XRGB8888,
636 DRM_FORMAT_YUYV,
637 DRM_FORMAT_YVYU,
638 DRM_FORMAT_UYVY,
639 DRM_FORMAT_VYUY,
640};
641
642int
643intel_plane_init(struct drm_device *dev, enum pipe pipe)
644{
645 struct intel_plane *intel_plane;
646 unsigned long possible_crtcs;
647 const uint32_t *plane_formats;
648 int num_plane_formats;
649 int ret;
650
651 if (INTEL_INFO(dev)->gen < 5)
652 return -ENODEV;
653
654 intel_plane = kzalloc(sizeof(struct intel_plane), GFP_KERNEL);
655 if (!intel_plane)
656 return -ENOMEM;
657
658 switch (INTEL_INFO(dev)->gen) {
659 case 5:
660 case 6:
661 intel_plane->max_downscale = 16;
662 intel_plane->update_plane = ilk_update_plane;
663 intel_plane->disable_plane = ilk_disable_plane;
664 intel_plane->update_colorkey = ilk_update_colorkey;
665 intel_plane->get_colorkey = ilk_get_colorkey;
666
667 if (IS_GEN6(dev)) {
668 plane_formats = snb_plane_formats;
669 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
670 } else {
671 plane_formats = ilk_plane_formats;
672 num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
673 }
674 break;
675
676 case 7:
677 intel_plane->max_downscale = 2;
678 intel_plane->update_plane = ivb_update_plane;
679 intel_plane->disable_plane = ivb_disable_plane;
680 intel_plane->update_colorkey = ivb_update_colorkey;
681 intel_plane->get_colorkey = ivb_get_colorkey;
682
683 plane_formats = snb_plane_formats;
684 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
685 break;
686
687 default:
688 return -ENODEV;
689 }
690
691 intel_plane->pipe = pipe;
692 possible_crtcs = (1 << pipe);
693 ret = drm_plane_init(dev, &intel_plane->base, possible_crtcs,
694 &intel_plane_funcs,
695 plane_formats, num_plane_formats,
696 false);
697 if (ret)
698 kfree(intel_plane);
699
700 return ret;
701}
702
1/*
2 * Copyright © 2011 Intel Corporation
3 *
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
10 *
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
13 * Software.
14 *
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21 * SOFTWARE.
22 *
23 * Authors:
24 * Jesse Barnes <jbarnes@virtuousgeek.org>
25 *
26 * New plane/sprite handling.
27 *
28 * The older chips had a separate interface for programming plane related
29 * registers; newer ones are much simpler and we can use the new DRM plane
30 * support.
31 */
32#include <drm/drmP.h>
33#include <drm/drm_crtc.h>
34#include <drm/drm_fourcc.h>
35#include <drm/drm_rect.h>
36#include "intel_drv.h"
37#include <drm/i915_drm.h>
38#include "i915_drv.h"
39
40static void
41vlv_update_plane(struct drm_plane *dplane, struct drm_crtc *crtc,
42 struct drm_framebuffer *fb,
43 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
44 unsigned int crtc_w, unsigned int crtc_h,
45 uint32_t x, uint32_t y,
46 uint32_t src_w, uint32_t src_h)
47{
48 struct drm_device *dev = dplane->dev;
49 struct drm_i915_private *dev_priv = dev->dev_private;
50 struct intel_plane *intel_plane = to_intel_plane(dplane);
51 int pipe = intel_plane->pipe;
52 int plane = intel_plane->plane;
53 u32 sprctl;
54 unsigned long sprsurf_offset, linear_offset;
55 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
56
57 sprctl = I915_READ(SPCNTR(pipe, plane));
58
59 /* Mask out pixel format bits in case we change it */
60 sprctl &= ~SP_PIXFORMAT_MASK;
61 sprctl &= ~SP_YUV_BYTE_ORDER_MASK;
62 sprctl &= ~SP_TILED;
63
64 switch (fb->pixel_format) {
65 case DRM_FORMAT_YUYV:
66 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
67 break;
68 case DRM_FORMAT_YVYU:
69 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
70 break;
71 case DRM_FORMAT_UYVY:
72 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
73 break;
74 case DRM_FORMAT_VYUY:
75 sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
76 break;
77 case DRM_FORMAT_RGB565:
78 sprctl |= SP_FORMAT_BGR565;
79 break;
80 case DRM_FORMAT_XRGB8888:
81 sprctl |= SP_FORMAT_BGRX8888;
82 break;
83 case DRM_FORMAT_ARGB8888:
84 sprctl |= SP_FORMAT_BGRA8888;
85 break;
86 case DRM_FORMAT_XBGR2101010:
87 sprctl |= SP_FORMAT_RGBX1010102;
88 break;
89 case DRM_FORMAT_ABGR2101010:
90 sprctl |= SP_FORMAT_RGBA1010102;
91 break;
92 case DRM_FORMAT_XBGR8888:
93 sprctl |= SP_FORMAT_RGBX8888;
94 break;
95 case DRM_FORMAT_ABGR8888:
96 sprctl |= SP_FORMAT_RGBA8888;
97 break;
98 default:
99 /*
100 * If we get here one of the upper layers failed to filter
101 * out the unsupported plane formats
102 */
103 BUG();
104 break;
105 }
106
107 /*
108 * Enable gamma to match primary/cursor plane behaviour.
109 * FIXME should be user controllable via propertiesa.
110 */
111 sprctl |= SP_GAMMA_ENABLE;
112
113 if (obj->tiling_mode != I915_TILING_NONE)
114 sprctl |= SP_TILED;
115
116 sprctl |= SP_ENABLE;
117
118 intel_update_sprite_watermarks(dplane, crtc, src_w, pixel_size, true,
119 src_w != crtc_w || src_h != crtc_h);
120
121 /* Sizes are 0 based */
122 src_w--;
123 src_h--;
124 crtc_w--;
125 crtc_h--;
126
127 linear_offset = y * fb->pitches[0] + x * pixel_size;
128 sprsurf_offset = intel_gen4_compute_page_offset(&x, &y,
129 obj->tiling_mode,
130 pixel_size,
131 fb->pitches[0]);
132 linear_offset -= sprsurf_offset;
133
134 I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
135 I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);
136
137 if (obj->tiling_mode != I915_TILING_NONE)
138 I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
139 else
140 I915_WRITE(SPLINOFF(pipe, plane), linear_offset);
141
142 I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
143 I915_WRITE(SPCNTR(pipe, plane), sprctl);
144 I915_WRITE(SPSURF(pipe, plane), i915_gem_obj_ggtt_offset(obj) +
145 sprsurf_offset);
146 POSTING_READ(SPSURF(pipe, plane));
147}
148
149static void
150vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
151{
152 struct drm_device *dev = dplane->dev;
153 struct drm_i915_private *dev_priv = dev->dev_private;
154 struct intel_plane *intel_plane = to_intel_plane(dplane);
155 int pipe = intel_plane->pipe;
156 int plane = intel_plane->plane;
157
158 I915_WRITE(SPCNTR(pipe, plane), I915_READ(SPCNTR(pipe, plane)) &
159 ~SP_ENABLE);
160 /* Activate double buffered register update */
161 I915_WRITE(SPSURF(pipe, plane), 0);
162 POSTING_READ(SPSURF(pipe, plane));
163
164 intel_update_sprite_watermarks(dplane, crtc, 0, 0, false, false);
165}
166
167static int
168vlv_update_colorkey(struct drm_plane *dplane,
169 struct drm_intel_sprite_colorkey *key)
170{
171 struct drm_device *dev = dplane->dev;
172 struct drm_i915_private *dev_priv = dev->dev_private;
173 struct intel_plane *intel_plane = to_intel_plane(dplane);
174 int pipe = intel_plane->pipe;
175 int plane = intel_plane->plane;
176 u32 sprctl;
177
178 if (key->flags & I915_SET_COLORKEY_DESTINATION)
179 return -EINVAL;
180
181 I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
182 I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
183 I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);
184
185 sprctl = I915_READ(SPCNTR(pipe, plane));
186 sprctl &= ~SP_SOURCE_KEY;
187 if (key->flags & I915_SET_COLORKEY_SOURCE)
188 sprctl |= SP_SOURCE_KEY;
189 I915_WRITE(SPCNTR(pipe, plane), sprctl);
190
191 POSTING_READ(SPKEYMSK(pipe, plane));
192
193 return 0;
194}
195
196static void
197vlv_get_colorkey(struct drm_plane *dplane,
198 struct drm_intel_sprite_colorkey *key)
199{
200 struct drm_device *dev = dplane->dev;
201 struct drm_i915_private *dev_priv = dev->dev_private;
202 struct intel_plane *intel_plane = to_intel_plane(dplane);
203 int pipe = intel_plane->pipe;
204 int plane = intel_plane->plane;
205 u32 sprctl;
206
207 key->min_value = I915_READ(SPKEYMINVAL(pipe, plane));
208 key->max_value = I915_READ(SPKEYMAXVAL(pipe, plane));
209 key->channel_mask = I915_READ(SPKEYMSK(pipe, plane));
210
211 sprctl = I915_READ(SPCNTR(pipe, plane));
212 if (sprctl & SP_SOURCE_KEY)
213 key->flags = I915_SET_COLORKEY_SOURCE;
214 else
215 key->flags = I915_SET_COLORKEY_NONE;
216}
217
218static void
219ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
220 struct drm_framebuffer *fb,
221 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
222 unsigned int crtc_w, unsigned int crtc_h,
223 uint32_t x, uint32_t y,
224 uint32_t src_w, uint32_t src_h)
225{
226 struct drm_device *dev = plane->dev;
227 struct drm_i915_private *dev_priv = dev->dev_private;
228 struct intel_plane *intel_plane = to_intel_plane(plane);
229 int pipe = intel_plane->pipe;
230 u32 sprctl, sprscale = 0;
231 unsigned long sprsurf_offset, linear_offset;
232 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
233
234 sprctl = I915_READ(SPRCTL(pipe));
235
236 /* Mask out pixel format bits in case we change it */
237 sprctl &= ~SPRITE_PIXFORMAT_MASK;
238 sprctl &= ~SPRITE_RGB_ORDER_RGBX;
239 sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
240 sprctl &= ~SPRITE_TILED;
241
242 switch (fb->pixel_format) {
243 case DRM_FORMAT_XBGR8888:
244 sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
245 break;
246 case DRM_FORMAT_XRGB8888:
247 sprctl |= SPRITE_FORMAT_RGBX888;
248 break;
249 case DRM_FORMAT_YUYV:
250 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
251 break;
252 case DRM_FORMAT_YVYU:
253 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
254 break;
255 case DRM_FORMAT_UYVY:
256 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
257 break;
258 case DRM_FORMAT_VYUY:
259 sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
260 break;
261 default:
262 BUG();
263 }
264
265 /*
266 * Enable gamma to match primary/cursor plane behaviour.
267 * FIXME should be user controllable via propertiesa.
268 */
269 sprctl |= SPRITE_GAMMA_ENABLE;
270
271 if (obj->tiling_mode != I915_TILING_NONE)
272 sprctl |= SPRITE_TILED;
273
274 if (IS_HASWELL(dev) || IS_BROADWELL(dev))
275 sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
276 else
277 sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
278
279 sprctl |= SPRITE_ENABLE;
280
281 if (IS_HASWELL(dev) || IS_BROADWELL(dev))
282 sprctl |= SPRITE_PIPE_CSC_ENABLE;
283
284 intel_update_sprite_watermarks(plane, crtc, src_w, pixel_size, true,
285 src_w != crtc_w || src_h != crtc_h);
286
287 /* Sizes are 0 based */
288 src_w--;
289 src_h--;
290 crtc_w--;
291 crtc_h--;
292
293 if (crtc_w != src_w || crtc_h != src_h)
294 sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;
295
296 linear_offset = y * fb->pitches[0] + x * pixel_size;
297 sprsurf_offset =
298 intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
299 pixel_size, fb->pitches[0]);
300 linear_offset -= sprsurf_offset;
301
302 I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
303 I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);
304
305 /* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
306 * register */
307 if (IS_HASWELL(dev) || IS_BROADWELL(dev))
308 I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
309 else if (obj->tiling_mode != I915_TILING_NONE)
310 I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
311 else
312 I915_WRITE(SPRLINOFF(pipe), linear_offset);
313
314 I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
315 if (intel_plane->can_scale)
316 I915_WRITE(SPRSCALE(pipe), sprscale);
317 I915_WRITE(SPRCTL(pipe), sprctl);
318 I915_WRITE(SPRSURF(pipe),
319 i915_gem_obj_ggtt_offset(obj) + sprsurf_offset);
320 POSTING_READ(SPRSURF(pipe));
321}
322
323static void
324ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
325{
326 struct drm_device *dev = plane->dev;
327 struct drm_i915_private *dev_priv = dev->dev_private;
328 struct intel_plane *intel_plane = to_intel_plane(plane);
329 int pipe = intel_plane->pipe;
330
331 I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
332 /* Can't leave the scaler enabled... */
333 if (intel_plane->can_scale)
334 I915_WRITE(SPRSCALE(pipe), 0);
335 /* Activate double buffered register update */
336 I915_WRITE(SPRSURF(pipe), 0);
337 POSTING_READ(SPRSURF(pipe));
338
339 /*
340 * Avoid underruns when disabling the sprite.
341 * FIXME remove once watermark updates are done properly.
342 */
343 intel_wait_for_vblank(dev, pipe);
344
345 intel_update_sprite_watermarks(plane, crtc, 0, 0, false, false);
346}
347
348static int
349ivb_update_colorkey(struct drm_plane *plane,
350 struct drm_intel_sprite_colorkey *key)
351{
352 struct drm_device *dev = plane->dev;
353 struct drm_i915_private *dev_priv = dev->dev_private;
354 struct intel_plane *intel_plane;
355 u32 sprctl;
356 int ret = 0;
357
358 intel_plane = to_intel_plane(plane);
359
360 I915_WRITE(SPRKEYVAL(intel_plane->pipe), key->min_value);
361 I915_WRITE(SPRKEYMAX(intel_plane->pipe), key->max_value);
362 I915_WRITE(SPRKEYMSK(intel_plane->pipe), key->channel_mask);
363
364 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
365 sprctl &= ~(SPRITE_SOURCE_KEY | SPRITE_DEST_KEY);
366 if (key->flags & I915_SET_COLORKEY_DESTINATION)
367 sprctl |= SPRITE_DEST_KEY;
368 else if (key->flags & I915_SET_COLORKEY_SOURCE)
369 sprctl |= SPRITE_SOURCE_KEY;
370 I915_WRITE(SPRCTL(intel_plane->pipe), sprctl);
371
372 POSTING_READ(SPRKEYMSK(intel_plane->pipe));
373
374 return ret;
375}
376
377static void
378ivb_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
379{
380 struct drm_device *dev = plane->dev;
381 struct drm_i915_private *dev_priv = dev->dev_private;
382 struct intel_plane *intel_plane;
383 u32 sprctl;
384
385 intel_plane = to_intel_plane(plane);
386
387 key->min_value = I915_READ(SPRKEYVAL(intel_plane->pipe));
388 key->max_value = I915_READ(SPRKEYMAX(intel_plane->pipe));
389 key->channel_mask = I915_READ(SPRKEYMSK(intel_plane->pipe));
390 key->flags = 0;
391
392 sprctl = I915_READ(SPRCTL(intel_plane->pipe));
393
394 if (sprctl & SPRITE_DEST_KEY)
395 key->flags = I915_SET_COLORKEY_DESTINATION;
396 else if (sprctl & SPRITE_SOURCE_KEY)
397 key->flags = I915_SET_COLORKEY_SOURCE;
398 else
399 key->flags = I915_SET_COLORKEY_NONE;
400}
401
402static void
403ilk_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
404 struct drm_framebuffer *fb,
405 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
406 unsigned int crtc_w, unsigned int crtc_h,
407 uint32_t x, uint32_t y,
408 uint32_t src_w, uint32_t src_h)
409{
410 struct drm_device *dev = plane->dev;
411 struct drm_i915_private *dev_priv = dev->dev_private;
412 struct intel_plane *intel_plane = to_intel_plane(plane);
413 int pipe = intel_plane->pipe;
414 unsigned long dvssurf_offset, linear_offset;
415 u32 dvscntr, dvsscale;
416 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
417
418 dvscntr = I915_READ(DVSCNTR(pipe));
419
420 /* Mask out pixel format bits in case we change it */
421 dvscntr &= ~DVS_PIXFORMAT_MASK;
422 dvscntr &= ~DVS_RGB_ORDER_XBGR;
423 dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
424 dvscntr &= ~DVS_TILED;
425
426 switch (fb->pixel_format) {
427 case DRM_FORMAT_XBGR8888:
428 dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
429 break;
430 case DRM_FORMAT_XRGB8888:
431 dvscntr |= DVS_FORMAT_RGBX888;
432 break;
433 case DRM_FORMAT_YUYV:
434 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
435 break;
436 case DRM_FORMAT_YVYU:
437 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
438 break;
439 case DRM_FORMAT_UYVY:
440 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
441 break;
442 case DRM_FORMAT_VYUY:
443 dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
444 break;
445 default:
446 BUG();
447 }
448
449 /*
450 * Enable gamma to match primary/cursor plane behaviour.
451 * FIXME should be user controllable via propertiesa.
452 */
453 dvscntr |= DVS_GAMMA_ENABLE;
454
455 if (obj->tiling_mode != I915_TILING_NONE)
456 dvscntr |= DVS_TILED;
457
458 if (IS_GEN6(dev))
459 dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
460 dvscntr |= DVS_ENABLE;
461
462 intel_update_sprite_watermarks(plane, crtc, src_w, pixel_size, true,
463 src_w != crtc_w || src_h != crtc_h);
464
465 /* Sizes are 0 based */
466 src_w--;
467 src_h--;
468 crtc_w--;
469 crtc_h--;
470
471 dvsscale = 0;
472 if (crtc_w != src_w || crtc_h != src_h)
473 dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;
474
475 linear_offset = y * fb->pitches[0] + x * pixel_size;
476 dvssurf_offset =
477 intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
478 pixel_size, fb->pitches[0]);
479 linear_offset -= dvssurf_offset;
480
481 I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
482 I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);
483
484 if (obj->tiling_mode != I915_TILING_NONE)
485 I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
486 else
487 I915_WRITE(DVSLINOFF(pipe), linear_offset);
488
489 I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
490 I915_WRITE(DVSSCALE(pipe), dvsscale);
491 I915_WRITE(DVSCNTR(pipe), dvscntr);
492 I915_WRITE(DVSSURF(pipe),
493 i915_gem_obj_ggtt_offset(obj) + dvssurf_offset);
494 POSTING_READ(DVSSURF(pipe));
495}
496
497static void
498ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
499{
500 struct drm_device *dev = plane->dev;
501 struct drm_i915_private *dev_priv = dev->dev_private;
502 struct intel_plane *intel_plane = to_intel_plane(plane);
503 int pipe = intel_plane->pipe;
504
505 I915_WRITE(DVSCNTR(pipe), I915_READ(DVSCNTR(pipe)) & ~DVS_ENABLE);
506 /* Disable the scaler */
507 I915_WRITE(DVSSCALE(pipe), 0);
508 /* Flush double buffered register updates */
509 I915_WRITE(DVSSURF(pipe), 0);
510 POSTING_READ(DVSSURF(pipe));
511
512 /*
513 * Avoid underruns when disabling the sprite.
514 * FIXME remove once watermark updates are done properly.
515 */
516 intel_wait_for_vblank(dev, pipe);
517
518 intel_update_sprite_watermarks(plane, crtc, 0, 0, false, false);
519}
520
521static void
522intel_enable_primary(struct drm_crtc *crtc)
523{
524 struct drm_device *dev = crtc->dev;
525 struct drm_i915_private *dev_priv = dev->dev_private;
526 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
527 int reg = DSPCNTR(intel_crtc->plane);
528
529 if (intel_crtc->primary_enabled)
530 return;
531
532 intel_crtc->primary_enabled = true;
533
534 I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
535 intel_flush_primary_plane(dev_priv, intel_crtc->plane);
536
537 /*
538 * FIXME IPS should be fine as long as one plane is
539 * enabled, but in practice it seems to have problems
540 * when going from primary only to sprite only and vice
541 * versa.
542 */
543 if (intel_crtc->config.ips_enabled) {
544 intel_wait_for_vblank(dev, intel_crtc->pipe);
545 hsw_enable_ips(intel_crtc);
546 }
547
548 mutex_lock(&dev->struct_mutex);
549 intel_update_fbc(dev);
550 mutex_unlock(&dev->struct_mutex);
551}
552
553static void
554intel_disable_primary(struct drm_crtc *crtc)
555{
556 struct drm_device *dev = crtc->dev;
557 struct drm_i915_private *dev_priv = dev->dev_private;
558 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
559 int reg = DSPCNTR(intel_crtc->plane);
560
561 if (!intel_crtc->primary_enabled)
562 return;
563
564 intel_crtc->primary_enabled = false;
565
566 mutex_lock(&dev->struct_mutex);
567 if (dev_priv->fbc.plane == intel_crtc->plane)
568 intel_disable_fbc(dev);
569 mutex_unlock(&dev->struct_mutex);
570
571 /*
572 * FIXME IPS should be fine as long as one plane is
573 * enabled, but in practice it seems to have problems
574 * when going from primary only to sprite only and vice
575 * versa.
576 */
577 hsw_disable_ips(intel_crtc);
578
579 I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
580 intel_flush_primary_plane(dev_priv, intel_crtc->plane);
581}
582
583static int
584ilk_update_colorkey(struct drm_plane *plane,
585 struct drm_intel_sprite_colorkey *key)
586{
587 struct drm_device *dev = plane->dev;
588 struct drm_i915_private *dev_priv = dev->dev_private;
589 struct intel_plane *intel_plane;
590 u32 dvscntr;
591 int ret = 0;
592
593 intel_plane = to_intel_plane(plane);
594
595 I915_WRITE(DVSKEYVAL(intel_plane->pipe), key->min_value);
596 I915_WRITE(DVSKEYMAX(intel_plane->pipe), key->max_value);
597 I915_WRITE(DVSKEYMSK(intel_plane->pipe), key->channel_mask);
598
599 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
600 dvscntr &= ~(DVS_SOURCE_KEY | DVS_DEST_KEY);
601 if (key->flags & I915_SET_COLORKEY_DESTINATION)
602 dvscntr |= DVS_DEST_KEY;
603 else if (key->flags & I915_SET_COLORKEY_SOURCE)
604 dvscntr |= DVS_SOURCE_KEY;
605 I915_WRITE(DVSCNTR(intel_plane->pipe), dvscntr);
606
607 POSTING_READ(DVSKEYMSK(intel_plane->pipe));
608
609 return ret;
610}
611
612static void
613ilk_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
614{
615 struct drm_device *dev = plane->dev;
616 struct drm_i915_private *dev_priv = dev->dev_private;
617 struct intel_plane *intel_plane;
618 u32 dvscntr;
619
620 intel_plane = to_intel_plane(plane);
621
622 key->min_value = I915_READ(DVSKEYVAL(intel_plane->pipe));
623 key->max_value = I915_READ(DVSKEYMAX(intel_plane->pipe));
624 key->channel_mask = I915_READ(DVSKEYMSK(intel_plane->pipe));
625 key->flags = 0;
626
627 dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
628
629 if (dvscntr & DVS_DEST_KEY)
630 key->flags = I915_SET_COLORKEY_DESTINATION;
631 else if (dvscntr & DVS_SOURCE_KEY)
632 key->flags = I915_SET_COLORKEY_SOURCE;
633 else
634 key->flags = I915_SET_COLORKEY_NONE;
635}
636
637static bool
638format_is_yuv(uint32_t format)
639{
640 switch (format) {
641 case DRM_FORMAT_YUYV:
642 case DRM_FORMAT_UYVY:
643 case DRM_FORMAT_VYUY:
644 case DRM_FORMAT_YVYU:
645 return true;
646 default:
647 return false;
648 }
649}
650
651static bool colorkey_enabled(struct intel_plane *intel_plane)
652{
653 struct drm_intel_sprite_colorkey key;
654
655 intel_plane->get_colorkey(&intel_plane->base, &key);
656
657 return key.flags != I915_SET_COLORKEY_NONE;
658}
659
660static int
661intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
662 struct drm_framebuffer *fb, int crtc_x, int crtc_y,
663 unsigned int crtc_w, unsigned int crtc_h,
664 uint32_t src_x, uint32_t src_y,
665 uint32_t src_w, uint32_t src_h)
666{
667 struct drm_device *dev = plane->dev;
668 struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
669 struct intel_plane *intel_plane = to_intel_plane(plane);
670 struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
671 struct drm_i915_gem_object *obj = intel_fb->obj;
672 struct drm_i915_gem_object *old_obj = intel_plane->obj;
673 int ret;
674 bool disable_primary = false;
675 bool visible;
676 int hscale, vscale;
677 int max_scale, min_scale;
678 int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
679 struct drm_rect src = {
680 /* sample coordinates in 16.16 fixed point */
681 .x1 = src_x,
682 .x2 = src_x + src_w,
683 .y1 = src_y,
684 .y2 = src_y + src_h,
685 };
686 struct drm_rect dst = {
687 /* integer pixels */
688 .x1 = crtc_x,
689 .x2 = crtc_x + crtc_w,
690 .y1 = crtc_y,
691 .y2 = crtc_y + crtc_h,
692 };
693 const struct drm_rect clip = {
694 .x2 = intel_crtc->active ? intel_crtc->config.pipe_src_w : 0,
695 .y2 = intel_crtc->active ? intel_crtc->config.pipe_src_h : 0,
696 };
697 const struct {
698 int crtc_x, crtc_y;
699 unsigned int crtc_w, crtc_h;
700 uint32_t src_x, src_y, src_w, src_h;
701 } orig = {
702 .crtc_x = crtc_x,
703 .crtc_y = crtc_y,
704 .crtc_w = crtc_w,
705 .crtc_h = crtc_h,
706 .src_x = src_x,
707 .src_y = src_y,
708 .src_w = src_w,
709 .src_h = src_h,
710 };
711
712 /* Don't modify another pipe's plane */
713 if (intel_plane->pipe != intel_crtc->pipe) {
714 DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
715 return -EINVAL;
716 }
717
718 /* FIXME check all gen limits */
719 if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
720 DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
721 return -EINVAL;
722 }
723
724 /* Sprite planes can be linear or x-tiled surfaces */
725 switch (obj->tiling_mode) {
726 case I915_TILING_NONE:
727 case I915_TILING_X:
728 break;
729 default:
730 DRM_DEBUG_KMS("Unsupported tiling mode\n");
731 return -EINVAL;
732 }
733
734 /*
735 * FIXME the following code does a bunch of fuzzy adjustments to the
736 * coordinates and sizes. We probably need some way to decide whether
737 * more strict checking should be done instead.
738 */
739 max_scale = intel_plane->max_downscale << 16;
740 min_scale = intel_plane->can_scale ? 1 : (1 << 16);
741
742 hscale = drm_rect_calc_hscale_relaxed(&src, &dst, min_scale, max_scale);
743 BUG_ON(hscale < 0);
744
745 vscale = drm_rect_calc_vscale_relaxed(&src, &dst, min_scale, max_scale);
746 BUG_ON(vscale < 0);
747
748 visible = drm_rect_clip_scaled(&src, &dst, &clip, hscale, vscale);
749
750 crtc_x = dst.x1;
751 crtc_y = dst.y1;
752 crtc_w = drm_rect_width(&dst);
753 crtc_h = drm_rect_height(&dst);
754
755 if (visible) {
756 /* check again in case clipping clamped the results */
757 hscale = drm_rect_calc_hscale(&src, &dst, min_scale, max_scale);
758 if (hscale < 0) {
759 DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
760 drm_rect_debug_print(&src, true);
761 drm_rect_debug_print(&dst, false);
762
763 return hscale;
764 }
765
766 vscale = drm_rect_calc_vscale(&src, &dst, min_scale, max_scale);
767 if (vscale < 0) {
768 DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
769 drm_rect_debug_print(&src, true);
770 drm_rect_debug_print(&dst, false);
771
772 return vscale;
773 }
774
775 /* Make the source viewport size an exact multiple of the scaling factors. */
776 drm_rect_adjust_size(&src,
777 drm_rect_width(&dst) * hscale - drm_rect_width(&src),
778 drm_rect_height(&dst) * vscale - drm_rect_height(&src));
779
780 /* sanity check to make sure the src viewport wasn't enlarged */
781 WARN_ON(src.x1 < (int) src_x ||
782 src.y1 < (int) src_y ||
783 src.x2 > (int) (src_x + src_w) ||
784 src.y2 > (int) (src_y + src_h));
785
786 /*
787 * Hardware doesn't handle subpixel coordinates.
788 * Adjust to (macro)pixel boundary, but be careful not to
789 * increase the source viewport size, because that could
790 * push the downscaling factor out of bounds.
791 */
792 src_x = src.x1 >> 16;
793 src_w = drm_rect_width(&src) >> 16;
794 src_y = src.y1 >> 16;
795 src_h = drm_rect_height(&src) >> 16;
796
797 if (format_is_yuv(fb->pixel_format)) {
798 src_x &= ~1;
799 src_w &= ~1;
800
801 /*
802 * Must keep src and dst the
803 * same if we can't scale.
804 */
805 if (!intel_plane->can_scale)
806 crtc_w &= ~1;
807
808 if (crtc_w == 0)
809 visible = false;
810 }
811 }
812
813 /* Check size restrictions when scaling */
814 if (visible && (src_w != crtc_w || src_h != crtc_h)) {
815 unsigned int width_bytes;
816
817 WARN_ON(!intel_plane->can_scale);
818
819 /* FIXME interlacing min height is 6 */
820
821 if (crtc_w < 3 || crtc_h < 3)
822 visible = false;
823
824 if (src_w < 3 || src_h < 3)
825 visible = false;
826
827 width_bytes = ((src_x * pixel_size) & 63) + src_w * pixel_size;
828
829 if (src_w > 2048 || src_h > 2048 ||
830 width_bytes > 4096 || fb->pitches[0] > 4096) {
831 DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
832 return -EINVAL;
833 }
834 }
835
836 dst.x1 = crtc_x;
837 dst.x2 = crtc_x + crtc_w;
838 dst.y1 = crtc_y;
839 dst.y2 = crtc_y + crtc_h;
840
841 /*
842 * If the sprite is completely covering the primary plane,
843 * we can disable the primary and save power.
844 */
845 disable_primary = drm_rect_equals(&dst, &clip) && !colorkey_enabled(intel_plane);
846 WARN_ON(disable_primary && !visible && intel_crtc->active);
847
848 mutex_lock(&dev->struct_mutex);
849
850 /* Note that this will apply the VT-d workaround for scanouts,
851 * which is more restrictive than required for sprites. (The
852 * primary plane requires 256KiB alignment with 64 PTE padding,
853 * the sprite planes only require 128KiB alignment and 32 PTE padding.
854 */
855 ret = intel_pin_and_fence_fb_obj(dev, obj, NULL);
856
857 mutex_unlock(&dev->struct_mutex);
858
859 if (ret)
860 return ret;
861
862 intel_plane->crtc_x = orig.crtc_x;
863 intel_plane->crtc_y = orig.crtc_y;
864 intel_plane->crtc_w = orig.crtc_w;
865 intel_plane->crtc_h = orig.crtc_h;
866 intel_plane->src_x = orig.src_x;
867 intel_plane->src_y = orig.src_y;
868 intel_plane->src_w = orig.src_w;
869 intel_plane->src_h = orig.src_h;
870 intel_plane->obj = obj;
871
872 if (intel_crtc->active) {
873 /*
874 * Be sure to re-enable the primary before the sprite is no longer
875 * covering it fully.
876 */
877 if (!disable_primary)
878 intel_enable_primary(crtc);
879
880 if (visible)
881 intel_plane->update_plane(plane, crtc, fb, obj,
882 crtc_x, crtc_y, crtc_w, crtc_h,
883 src_x, src_y, src_w, src_h);
884 else
885 intel_plane->disable_plane(plane, crtc);
886
887 if (disable_primary)
888 intel_disable_primary(crtc);
889 }
890
891 /* Unpin old obj after new one is active to avoid ugliness */
892 if (old_obj) {
893 /*
894 * It's fairly common to simply update the position of
895 * an existing object. In that case, we don't need to
896 * wait for vblank to avoid ugliness, we only need to
897 * do the pin & ref bookkeeping.
898 */
899 if (old_obj != obj && intel_crtc->active)
900 intel_wait_for_vblank(dev, intel_crtc->pipe);
901
902 mutex_lock(&dev->struct_mutex);
903 intel_unpin_fb_obj(old_obj);
904 mutex_unlock(&dev->struct_mutex);
905 }
906
907 return 0;
908}
909
910static int
911intel_disable_plane(struct drm_plane *plane)
912{
913 struct drm_device *dev = plane->dev;
914 struct intel_plane *intel_plane = to_intel_plane(plane);
915 struct intel_crtc *intel_crtc;
916
917 if (!plane->fb)
918 return 0;
919
920 if (WARN_ON(!plane->crtc))
921 return -EINVAL;
922
923 intel_crtc = to_intel_crtc(plane->crtc);
924
925 if (intel_crtc->active) {
926 intel_enable_primary(plane->crtc);
927 intel_plane->disable_plane(plane, plane->crtc);
928 }
929
930 if (intel_plane->obj) {
931 if (intel_crtc->active)
932 intel_wait_for_vblank(dev, intel_plane->pipe);
933
934 mutex_lock(&dev->struct_mutex);
935 intel_unpin_fb_obj(intel_plane->obj);
936 mutex_unlock(&dev->struct_mutex);
937
938 intel_plane->obj = NULL;
939 }
940
941 return 0;
942}
943
944static void intel_destroy_plane(struct drm_plane *plane)
945{
946 struct intel_plane *intel_plane = to_intel_plane(plane);
947 intel_disable_plane(plane);
948 drm_plane_cleanup(plane);
949 kfree(intel_plane);
950}
951
952int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
953 struct drm_file *file_priv)
954{
955 struct drm_intel_sprite_colorkey *set = data;
956 struct drm_mode_object *obj;
957 struct drm_plane *plane;
958 struct intel_plane *intel_plane;
959 int ret = 0;
960
961 if (!drm_core_check_feature(dev, DRIVER_MODESET))
962 return -ENODEV;
963
964 /* Make sure we don't try to enable both src & dest simultaneously */
965 if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
966 return -EINVAL;
967
968 drm_modeset_lock_all(dev);
969
970 obj = drm_mode_object_find(dev, set->plane_id, DRM_MODE_OBJECT_PLANE);
971 if (!obj) {
972 ret = -ENOENT;
973 goto out_unlock;
974 }
975
976 plane = obj_to_plane(obj);
977 intel_plane = to_intel_plane(plane);
978 ret = intel_plane->update_colorkey(plane, set);
979
980out_unlock:
981 drm_modeset_unlock_all(dev);
982 return ret;
983}
984
985int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
986 struct drm_file *file_priv)
987{
988 struct drm_intel_sprite_colorkey *get = data;
989 struct drm_mode_object *obj;
990 struct drm_plane *plane;
991 struct intel_plane *intel_plane;
992 int ret = 0;
993
994 if (!drm_core_check_feature(dev, DRIVER_MODESET))
995 return -ENODEV;
996
997 drm_modeset_lock_all(dev);
998
999 obj = drm_mode_object_find(dev, get->plane_id, DRM_MODE_OBJECT_PLANE);
1000 if (!obj) {
1001 ret = -ENOENT;
1002 goto out_unlock;
1003 }
1004
1005 plane = obj_to_plane(obj);
1006 intel_plane = to_intel_plane(plane);
1007 intel_plane->get_colorkey(plane, get);
1008
1009out_unlock:
1010 drm_modeset_unlock_all(dev);
1011 return ret;
1012}
1013
1014void intel_plane_restore(struct drm_plane *plane)
1015{
1016 struct intel_plane *intel_plane = to_intel_plane(plane);
1017
1018 if (!plane->crtc || !plane->fb)
1019 return;
1020
1021 intel_update_plane(plane, plane->crtc, plane->fb,
1022 intel_plane->crtc_x, intel_plane->crtc_y,
1023 intel_plane->crtc_w, intel_plane->crtc_h,
1024 intel_plane->src_x, intel_plane->src_y,
1025 intel_plane->src_w, intel_plane->src_h);
1026}
1027
1028void intel_plane_disable(struct drm_plane *plane)
1029{
1030 if (!plane->crtc || !plane->fb)
1031 return;
1032
1033 intel_disable_plane(plane);
1034}
1035
1036static const struct drm_plane_funcs intel_plane_funcs = {
1037 .update_plane = intel_update_plane,
1038 .disable_plane = intel_disable_plane,
1039 .destroy = intel_destroy_plane,
1040};
1041
1042static uint32_t ilk_plane_formats[] = {
1043 DRM_FORMAT_XRGB8888,
1044 DRM_FORMAT_YUYV,
1045 DRM_FORMAT_YVYU,
1046 DRM_FORMAT_UYVY,
1047 DRM_FORMAT_VYUY,
1048};
1049
1050static uint32_t snb_plane_formats[] = {
1051 DRM_FORMAT_XBGR8888,
1052 DRM_FORMAT_XRGB8888,
1053 DRM_FORMAT_YUYV,
1054 DRM_FORMAT_YVYU,
1055 DRM_FORMAT_UYVY,
1056 DRM_FORMAT_VYUY,
1057};
1058
1059static uint32_t vlv_plane_formats[] = {
1060 DRM_FORMAT_RGB565,
1061 DRM_FORMAT_ABGR8888,
1062 DRM_FORMAT_ARGB8888,
1063 DRM_FORMAT_XBGR8888,
1064 DRM_FORMAT_XRGB8888,
1065 DRM_FORMAT_XBGR2101010,
1066 DRM_FORMAT_ABGR2101010,
1067 DRM_FORMAT_YUYV,
1068 DRM_FORMAT_YVYU,
1069 DRM_FORMAT_UYVY,
1070 DRM_FORMAT_VYUY,
1071};
1072
1073int
1074intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
1075{
1076 struct intel_plane *intel_plane;
1077 unsigned long possible_crtcs;
1078 const uint32_t *plane_formats;
1079 int num_plane_formats;
1080 int ret;
1081
1082 if (INTEL_INFO(dev)->gen < 5)
1083 return -ENODEV;
1084
1085 intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
1086 if (!intel_plane)
1087 return -ENOMEM;
1088
1089 switch (INTEL_INFO(dev)->gen) {
1090 case 5:
1091 case 6:
1092 intel_plane->can_scale = true;
1093 intel_plane->max_downscale = 16;
1094 intel_plane->update_plane = ilk_update_plane;
1095 intel_plane->disable_plane = ilk_disable_plane;
1096 intel_plane->update_colorkey = ilk_update_colorkey;
1097 intel_plane->get_colorkey = ilk_get_colorkey;
1098
1099 if (IS_GEN6(dev)) {
1100 plane_formats = snb_plane_formats;
1101 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
1102 } else {
1103 plane_formats = ilk_plane_formats;
1104 num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
1105 }
1106 break;
1107
1108 case 7:
1109 case 8:
1110 if (IS_IVYBRIDGE(dev)) {
1111 intel_plane->can_scale = true;
1112 intel_plane->max_downscale = 2;
1113 } else {
1114 intel_plane->can_scale = false;
1115 intel_plane->max_downscale = 1;
1116 }
1117
1118 if (IS_VALLEYVIEW(dev)) {
1119 intel_plane->update_plane = vlv_update_plane;
1120 intel_plane->disable_plane = vlv_disable_plane;
1121 intel_plane->update_colorkey = vlv_update_colorkey;
1122 intel_plane->get_colorkey = vlv_get_colorkey;
1123
1124 plane_formats = vlv_plane_formats;
1125 num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
1126 } else {
1127 intel_plane->update_plane = ivb_update_plane;
1128 intel_plane->disable_plane = ivb_disable_plane;
1129 intel_plane->update_colorkey = ivb_update_colorkey;
1130 intel_plane->get_colorkey = ivb_get_colorkey;
1131
1132 plane_formats = snb_plane_formats;
1133 num_plane_formats = ARRAY_SIZE(snb_plane_formats);
1134 }
1135 break;
1136
1137 default:
1138 kfree(intel_plane);
1139 return -ENODEV;
1140 }
1141
1142 intel_plane->pipe = pipe;
1143 intel_plane->plane = plane;
1144 possible_crtcs = (1 << pipe);
1145 ret = drm_plane_init(dev, &intel_plane->base, possible_crtcs,
1146 &intel_plane_funcs,
1147 plane_formats, num_plane_formats,
1148 false);
1149 if (ret)
1150 kfree(intel_plane);
1151
1152 return ret;
1153}