Linux Audio

Check our new training course

Loading...
v3.15
 
  1/*
  2 * AppArmor security module
  3 *
  4 * This file contains AppArmor functions for unpacking policy loaded from
  5 * userspace.
  6 *
  7 * Copyright (C) 1998-2008 Novell/SUSE
  8 * Copyright 2009-2010 Canonical Ltd.
  9 *
 10 * This program is free software; you can redistribute it and/or
 11 * modify it under the terms of the GNU General Public License as
 12 * published by the Free Software Foundation, version 2 of the
 13 * License.
 14 *
 15 * AppArmor uses a serialized binary format for loading policy. To find
 16 * policy format documentation look in Documentation/security/apparmor.txt
 17 * All policy is validated before it is used.
 18 */
 19
 20#include <asm/unaligned.h>
 
 21#include <linux/ctype.h>
 22#include <linux/errno.h>
 
 23
 24#include "include/apparmor.h"
 25#include "include/audit.h"
 26#include "include/context.h"
 27#include "include/crypto.h"
 
 28#include "include/match.h"
 
 29#include "include/policy.h"
 30#include "include/policy_unpack.h"
 31
 32/*
 33 * The AppArmor interface treats data as a type byte followed by the
 34 * actual data.  The interface has the notion of a a named entry
 35 * which has a name (AA_NAME typecode followed by name string) followed by
 36 * the entries typecode and data.  Named types allow for optional
 37 * elements and extensions to be added and tested for without breaking
 38 * backwards compatibility.
 39 */
 40
 41enum aa_code {
 42	AA_U8,
 43	AA_U16,
 44	AA_U32,
 45	AA_U64,
 46	AA_NAME,		/* same as string except it is items name */
 47	AA_STRING,
 48	AA_BLOB,
 49	AA_STRUCT,
 50	AA_STRUCTEND,
 51	AA_LIST,
 52	AA_LISTEND,
 53	AA_ARRAY,
 54	AA_ARRAYEND,
 55};
 56
 57/*
 58 * aa_ext is the read of the buffer containing the serialized profile.  The
 59 * data is copied into a kernel buffer in apparmorfs and then handed off to
 60 * the unpack routines.
 61 */
 62struct aa_ext {
 63	void *start;
 64	void *end;
 65	void *pos;		/* pointer to current position in the buffer */
 66	u32 version;
 67};
 68
 69/* audit callback for unpack fields */
 70static void audit_cb(struct audit_buffer *ab, void *va)
 71{
 72	struct common_audit_data *sa = va;
 73	if (sa->aad->iface.target) {
 74		struct aa_profile *name = sa->aad->iface.target;
 
 
 
 
 
 75		audit_log_format(ab, " name=");
 76		audit_log_untrustedstring(ab, name->base.hname);
 77	}
 78	if (sa->aad->iface.pos)
 79		audit_log_format(ab, " offset=%ld", sa->aad->iface.pos);
 80}
 81
 82/**
 83 * audit_iface - do audit message for policy unpacking/load/replace/remove
 84 * @new: profile if it has been allocated (MAYBE NULL)
 
 85 * @name: name of the profile being manipulated (MAYBE NULL)
 86 * @info: any extra info about the failure (MAYBE NULL)
 87 * @e: buffer position info
 88 * @error: error code
 89 *
 90 * Returns: %0 or error
 91 */
 92static int audit_iface(struct aa_profile *new, const char *name,
 93		       const char *info, struct aa_ext *e, int error)
 
 94{
 95	struct aa_profile *profile = __aa_current_profile();
 96	struct common_audit_data sa;
 97	struct apparmor_audit_data aad = {0,};
 98	sa.type = LSM_AUDIT_DATA_NONE;
 99	sa.aad = &aad;
100	if (e)
101		aad.iface.pos = e->pos - e->start;
102	aad.iface.target = new;
103	aad.name = name;
104	aad.info = info;
105	aad.error = error;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
106
107	return aa_audit(AUDIT_APPARMOR_STATUS, profile, GFP_KERNEL, &sa,
108			audit_cb);
 
 
 
 
 
 
 
 
 
 
 
 
 
 
109}
110
111/* test if read will be in packed data bounds */
112static bool inbounds(struct aa_ext *e, size_t size)
113{
114	return (size <= e->end - e->pos);
115}
 
116
117/**
118 * aa_u16_chunck - test and do bounds checking for a u16 size based chunk
119 * @e: serialized data read head (NOT NULL)
120 * @chunk: start address for chunk of data (NOT NULL)
121 *
122 * Returns: the size of chunk found with the read head at the end of the chunk.
123 */
124static size_t unpack_u16_chunk(struct aa_ext *e, char **chunk)
125{
126	size_t size = 0;
 
127
128	if (!inbounds(e, sizeof(u16)))
129		return 0;
130	size = le16_to_cpu(get_unaligned((u16 *) e->pos));
131	e->pos += sizeof(u16);
132	if (!inbounds(e, size))
133		return 0;
134	*chunk = e->pos;
135	e->pos += size;
136	return size;
 
 
 
 
137}
 
138
139/* unpack control byte */
140static bool unpack_X(struct aa_ext *e, enum aa_code code)
141{
142	if (!inbounds(e, 1))
143		return 0;
144	if (*(u8 *) e->pos != code)
145		return 0;
146	e->pos++;
147	return 1;
148}
 
149
150/**
151 * unpack_nameX - check is the next element is of type X with a name of @name
152 * @e: serialized data extent information  (NOT NULL)
153 * @code: type code
154 * @name: name to match to the serialized element.  (MAYBE NULL)
155 *
156 * check that the next serialized data element is of type X and has a tag
157 * name @name.  If @name is specified then there must be a matching
158 * name element in the stream.  If @name is NULL any name element will be
159 * skipped and only the typecode will be tested.
160 *
161 * Returns 1 on success (both type code and name tests match) and the read
162 * head is advanced past the headers
163 *
164 * Returns: 0 if either match fails, the read head does not move
165 */
166static bool unpack_nameX(struct aa_ext *e, enum aa_code code, const char *name)
167{
168	/*
169	 * May need to reset pos if name or type doesn't match
170	 */
171	void *pos = e->pos;
172	/*
173	 * Check for presence of a tagname, and if present name size
174	 * AA_NAME tag value is a u16.
175	 */
176	if (unpack_X(e, AA_NAME)) {
177		char *tag = NULL;
178		size_t size = unpack_u16_chunk(e, &tag);
179		/* if a name is specified it must match. otherwise skip tag */
180		if (name && (!size || strcmp(name, tag)))
181			goto fail;
182	} else if (name) {
183		/* if a name is specified and there is no name tag fail */
184		goto fail;
185	}
186
187	/* now check if type code matches */
188	if (unpack_X(e, code))
189		return 1;
190
191fail:
192	e->pos = pos;
193	return 0;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
194}
195
196static bool unpack_u32(struct aa_ext *e, u32 *data, const char *name)
197{
198	if (unpack_nameX(e, AA_U32, name)) {
199		if (!inbounds(e, sizeof(u32)))
200			return 0;
 
 
201		if (data)
202			*data = le32_to_cpu(get_unaligned((u32 *) e->pos));
203		e->pos += sizeof(u32);
204		return 1;
205	}
206	return 0;
 
 
 
207}
 
208
209static bool unpack_u64(struct aa_ext *e, u64 *data, const char *name)
210{
211	if (unpack_nameX(e, AA_U64, name)) {
212		if (!inbounds(e, sizeof(u64)))
213			return 0;
 
 
214		if (data)
215			*data = le64_to_cpu(get_unaligned((u64 *) e->pos));
216		e->pos += sizeof(u64);
217		return 1;
218	}
219	return 0;
 
 
 
220}
 
221
222static size_t unpack_array(struct aa_ext *e, const char *name)
223{
224	if (unpack_nameX(e, AA_ARRAY, name)) {
225		int size;
226		if (!inbounds(e, sizeof(u16)))
227			return 0;
228		size = (int)le16_to_cpu(get_unaligned((u16 *) e->pos));
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
229		e->pos += sizeof(u16);
230		return size;
231	}
232	return 0;
 
 
 
233}
 
234
235static size_t unpack_blob(struct aa_ext *e, char **blob, const char *name)
236{
237	if (unpack_nameX(e, AA_BLOB, name)) {
 
 
238		u32 size;
239		if (!inbounds(e, sizeof(u32)))
240			return 0;
241		size = le32_to_cpu(get_unaligned((u32 *) e->pos));
242		e->pos += sizeof(u32);
243		if (inbounds(e, (size_t) size)) {
244			*blob = e->pos;
245			e->pos += size;
246			return size;
247		}
248	}
 
 
 
249	return 0;
250}
 
251
252static int unpack_str(struct aa_ext *e, const char **string, const char *name)
253{
254	char *src_str;
255	size_t size = 0;
256	void *pos = e->pos;
257	*string = NULL;
258	if (unpack_nameX(e, AA_STRING, name)) {
259		size = unpack_u16_chunk(e, &src_str);
260		if (size) {
261			/* strings are null terminated, length is size - 1 */
262			if (src_str[size - 1] != 0)
263				goto fail;
264			*string = src_str;
 
 
265		}
266	}
267	return size;
268
269fail:
270	e->pos = pos;
271	return 0;
272}
 
273
274static int unpack_strdup(struct aa_ext *e, char **string, const char *name)
275{
276	const char *tmp;
277	void *pos = e->pos;
278	int res = unpack_str(e, &tmp, name);
279	*string = NULL;
280
281	if (!res)
282		return 0;
283
284	*string = kmemdup(tmp, res, GFP_KERNEL);
285	if (!*string) {
286		e->pos = pos;
287		return 0;
288	}
289
290	return res;
291}
 
292
293#define DFA_VALID_PERM_MASK		0xffffffff
294#define DFA_VALID_PERM2_MASK		0xffffffff
295
296/**
297 * verify_accept - verify the accept tables of a dfa
298 * @dfa: dfa to verify accept tables of (NOT NULL)
299 * @flags: flags governing dfa
300 *
301 * Returns: 1 if valid accept tables else 0 if error
302 */
303static bool verify_accept(struct aa_dfa *dfa, int flags)
304{
305	int i;
306
307	/* verify accept permissions */
308	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
309		int mode = ACCEPT_TABLE(dfa)[i];
310
311		if (mode & ~DFA_VALID_PERM_MASK)
312			return 0;
313
314		if (ACCEPT_TABLE2(dfa)[i] & ~DFA_VALID_PERM2_MASK)
315			return 0;
316	}
317	return 1;
318}
319
320/**
321 * unpack_dfa - unpack a file rule dfa
322 * @e: serialized data extent information (NOT NULL)
 
323 *
324 * returns dfa or ERR_PTR or NULL if no dfa
325 */
326static struct aa_dfa *unpack_dfa(struct aa_ext *e)
327{
328	char *blob = NULL;
329	size_t size;
330	struct aa_dfa *dfa = NULL;
331
332	size = unpack_blob(e, &blob, "aadfa");
333	if (size) {
334		/*
335		 * The dfa is aligned with in the blob to 8 bytes
336		 * from the beginning of the stream.
337		 * alignment adjust needed by dfa unpack
338		 */
339		size_t sz = blob - (char *) e->start -
340			((e->pos - e->start) & 7);
341		size_t pad = ALIGN(sz, 8) - sz;
342		int flags = TO_ACCEPT1_FLAG(YYTD_DATA32) |
343			TO_ACCEPT2_FLAG(YYTD_DATA32);
344
345
346		if (aa_g_paranoid_load)
347			flags |= DFA_FLAG_VERIFY_STATES;
348
349		dfa = aa_dfa_unpack(blob + pad, size - pad, flags);
350
351		if (IS_ERR(dfa))
352			return dfa;
353
354		if (!verify_accept(dfa, flags))
355			goto fail;
356	}
357
358	return dfa;
359
360fail:
361	aa_put_dfa(dfa);
362	return ERR_PTR(-EPROTO);
363}
364
365/**
366 * unpack_trans_table - unpack a profile transition table
367 * @e: serialized data extent information  (NOT NULL)
368 * @profile: profile to add the accept table to (NOT NULL)
369 *
370 * Returns: 1 if table successfully unpacked
371 */
372static bool unpack_trans_table(struct aa_ext *e, struct aa_profile *profile)
373{
374	void *pos = e->pos;
 
375
376	/* exec table is optional */
377	if (unpack_nameX(e, AA_STRUCT, "xtable")) {
378		int i, size;
379
380		size = unpack_array(e, NULL);
381		/* currently 4 exec bits and entries 0-3 are reserved iupcx */
382		if (size > 16 - 4)
 
 
 
 
 
383			goto fail;
384		profile->file.trans.table = kzalloc(sizeof(char *) * size,
385						    GFP_KERNEL);
386		if (!profile->file.trans.table)
387			goto fail;
388
389		profile->file.trans.size = size;
 
390		for (i = 0; i < size; i++) {
391			char *str;
392			int c, j, size2 = unpack_strdup(e, &str, NULL);
393			/* unpack_strdup verifies that the last character is
394			 * null termination byte.
395			 */
396			if (!size2)
397				goto fail;
398			profile->file.trans.table[i] = str;
399			/* verify that name doesn't start with space */
400			if (isspace(*str))
401				goto fail;
402
403			/* count internal #  of internal \0 */
404			for (c = j = 0; j < size2 - 2; j++) {
405				if (!str[j])
 
406					c++;
 
407			}
408			if (*str == ':') {
 
 
 
409				/* beginning with : requires an embedded \0,
410				 * verify that exactly 1 internal \0 exists
411				 * trailing \0 already verified by unpack_strdup
 
 
412				 */
413				if (c != 1)
414					goto fail;
415				/* first character after : must be valid */
416				if (!str[1])
417					goto fail;
418			} else if (c)
419				/* fail - all other cases with embedded \0 */
420				goto fail;
421		}
422		if (!unpack_nameX(e, AA_ARRAYEND, NULL))
423			goto fail;
424		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
425			goto fail;
426	}
427	return 1;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
428
429fail:
430	aa_free_domain_entries(&profile->file.trans);
431	e->pos = pos;
432	return 0;
433}
434
435static bool unpack_rlimits(struct aa_ext *e, struct aa_profile *profile)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
436{
437	void *pos = e->pos;
438
439	/* rlimits are optional */
440	if (unpack_nameX(e, AA_STRUCT, "rlimits")) {
441		int i, size;
 
442		u32 tmp = 0;
443		if (!unpack_u32(e, &tmp, NULL))
444			goto fail;
445		profile->rlimits.mask = tmp;
446
447		size = unpack_array(e, NULL);
448		if (size > RLIM_NLIMITS)
449			goto fail;
450		for (i = 0; i < size; i++) {
451			u64 tmp2 = 0;
452			int a = aa_map_resource(i);
453			if (!unpack_u64(e, &tmp2, NULL))
454				goto fail;
455			profile->rlimits.limits[a].rlim_max = tmp2;
456		}
457		if (!unpack_nameX(e, AA_ARRAYEND, NULL))
458			goto fail;
459		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
460			goto fail;
461	}
462	return 1;
463
464fail:
465	e->pos = pos;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
466	return 0;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
467}
468
469/**
470 * unpack_profile - unpack a serialized profile
471 * @e: serialized data extent information (NOT NULL)
 
472 *
473 * NOTE: unpack profile sets audit struct if there is a failure
474 */
475static struct aa_profile *unpack_profile(struct aa_ext *e)
476{
 
477	struct aa_profile *profile = NULL;
478	const char *name = NULL;
479	int i, error = -EPROTO;
 
 
 
 
 
480	kernel_cap_t tmpcap;
481	u32 tmp;
482
 
 
483	/* check that we have the right struct being passed */
484	if (!unpack_nameX(e, AA_STRUCT, "profile"))
 
 
485		goto fail;
486	if (!unpack_str(e, &name, NULL))
487		goto fail;
488
489	profile = aa_alloc_profile(name);
490	if (!profile)
491		return ERR_PTR(-ENOMEM);
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
492
493	/* profile renaming is optional */
494	(void) unpack_str(e, &profile->rename, "rename");
495
496	/* attachment string is optional */
497	(void) unpack_str(e, &profile->attach, "attach");
498
499	/* xmatch is optional and may be NULL */
500	profile->xmatch = unpack_dfa(e);
501	if (IS_ERR(profile->xmatch)) {
502		error = PTR_ERR(profile->xmatch);
503		profile->xmatch = NULL;
504		goto fail;
505	}
506	/* xmatch_len is not optional if xmatch is set */
507	if (profile->xmatch) {
508		if (!unpack_u32(e, &tmp, NULL))
 
 
509			goto fail;
510		profile->xmatch_len = tmp;
 
 
 
 
 
 
 
 
 
511	}
512
 
 
 
 
513	/* per profile debug flags (complain, audit) */
514	if (!unpack_nameX(e, AA_STRUCT, "flags"))
 
515		goto fail;
516	if (!unpack_u32(e, &tmp, NULL))
 
 
517		goto fail;
518	if (tmp & PACKED_FLAG_HAT)
519		profile->flags |= PFLAG_HAT;
520	if (!unpack_u32(e, &tmp, NULL))
 
 
 
 
521		goto fail;
522	if (tmp == PACKED_MODE_COMPLAIN)
523		profile->mode = APPARMOR_COMPLAIN;
524	else if (tmp == PACKED_MODE_KILL)
 
 
525		profile->mode = APPARMOR_KILL;
526	else if (tmp == PACKED_MODE_UNCONFINED)
527		profile->mode = APPARMOR_UNCONFINED;
528	if (!unpack_u32(e, &tmp, NULL))
 
 
 
 
 
 
529		goto fail;
530	if (tmp)
531		profile->audit = AUDIT_ALL;
532
533	if (!unpack_nameX(e, AA_STRUCTEND, NULL))
534		goto fail;
535
536	/* path_flags is optional */
537	if (unpack_u32(e, &profile->path_flags, "path_flags"))
538		profile->path_flags |= profile->flags & PFLAG_MEDIATE_DELETED;
 
539	else
540		/* set a default value if path_flags field is not present */
541		profile->path_flags = PFLAG_MEDIATE_DELETED;
542
543	if (!unpack_u32(e, &(profile->caps.allow.cap[0]), NULL))
 
544		goto fail;
545	if (!unpack_u32(e, &(profile->caps.audit.cap[0]), NULL))
546		goto fail;
547	if (!unpack_u32(e, &(profile->caps.quiet.cap[0]), NULL))
548		goto fail;
549	if (!unpack_u32(e, &tmpcap.cap[0], NULL))
550		goto fail;
551
552	if (unpack_nameX(e, AA_STRUCT, "caps64")) {
 
553		/* optional upper half of 64 bit caps */
554		if (!unpack_u32(e, &(profile->caps.allow.cap[1]), NULL))
555			goto fail;
556		if (!unpack_u32(e, &(profile->caps.audit.cap[1]), NULL))
557			goto fail;
558		if (!unpack_u32(e, &(profile->caps.quiet.cap[1]), NULL))
559			goto fail;
560		if (!unpack_u32(e, &(tmpcap.cap[1]), NULL))
561			goto fail;
562		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
563			goto fail;
564	}
565
566	if (unpack_nameX(e, AA_STRUCT, "capsx")) {
 
567		/* optional extended caps mediation mask */
568		if (!unpack_u32(e, &(profile->caps.extended.cap[0]), NULL))
569			goto fail;
570		if (!unpack_u32(e, &(profile->caps.extended.cap[1]), NULL))
571			goto fail;
572		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
573			goto fail;
574	}
575
576	if (!unpack_rlimits(e, profile))
 
577		goto fail;
 
578
579	if (unpack_nameX(e, AA_STRUCT, "policydb")) {
 
 
 
 
 
 
 
 
 
 
580		/* generic policy dfa - optional and may be NULL */
581		profile->policy.dfa = unpack_dfa(e);
582		if (IS_ERR(profile->policy.dfa)) {
583			error = PTR_ERR(profile->policy.dfa);
584			profile->policy.dfa = NULL;
585			goto fail;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
586		}
587		if (!unpack_u32(e, &profile->policy.start[0], "start"))
588			/* default start state */
589			profile->policy.start[0] = DFA_START;
590		/* setup class index */
591		for (i = AA_CLASS_FILE; i <= AA_CLASS_LAST; i++) {
592			profile->policy.start[i] =
593				aa_dfa_next(profile->policy.dfa,
594					    profile->policy.start[0],
595					    i);
596		}
597		if (!unpack_nameX(e, AA_STRUCTEND, NULL))
598			goto fail;
599	}
600
601	/* get file rules */
602	profile->file.dfa = unpack_dfa(e);
603	if (IS_ERR(profile->file.dfa)) {
604		error = PTR_ERR(profile->file.dfa);
605		profile->file.dfa = NULL;
606		goto fail;
607	}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
608
609	if (!unpack_u32(e, &profile->file.start, "dfa_start"))
610		/* default start state */
611		profile->file.start = DFA_START;
 
 
 
 
612
613	if (!unpack_trans_table(e, profile))
614		goto fail;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
615
616	if (!unpack_nameX(e, AA_STRUCTEND, NULL))
 
 
 
 
 
 
 
617		goto fail;
 
618
619	return profile;
620
621fail:
 
 
 
 
 
 
 
622	if (profile)
623		name = NULL;
624	else if (!name)
625		name = "unknown";
626	audit_iface(profile, name, "failed to unpack profile", e, error);
627	aa_free_profile(profile);
628
629	return ERR_PTR(error);
630}
631
632/**
633 * verify_head - unpack serialized stream header
634 * @e: serialized data read head (NOT NULL)
635 * @required: whether the header is required or optional
636 * @ns: Returns - namespace if one is specified else NULL (NOT NULL)
637 *
638 * Returns: error or 0 if header is good
639 */
640static int verify_header(struct aa_ext *e, int required, const char **ns)
641{
642	int error = -EPROTONOSUPPORT;
643	const char *name = NULL;
644	*ns = NULL;
645
646	/* get the interface version */
647	if (!unpack_u32(e, &e->version, "version")) {
648		if (required) {
649			audit_iface(NULL, NULL, "invalid profile format", e,
650				    error);
651			return error;
652		}
653
654		/* check that the interface version is currently supported */
655		if (e->version != 5) {
656			audit_iface(NULL, NULL, "unsupported interface version",
657				    e, error);
658			return error;
659		}
660	}
661
 
 
 
 
 
 
 
 
 
662
663	/* read the namespace if present */
664	if (unpack_str(e, &name, "namespace")) {
665		if (*ns && strcmp(*ns, name))
666			audit_iface(NULL, NULL, "invalid ns change", e, error);
667		else if (!*ns)
668			*ns = name;
 
 
 
 
 
 
 
 
 
669	}
670
671	return 0;
672}
673
674static bool verify_xindex(int xindex, int table_size)
 
 
 
 
 
675{
676	int index, xtype;
677	xtype = xindex & AA_X_TYPE_MASK;
678	index = xindex & AA_X_INDEX_MASK;
679	if (xtype == AA_X_TABLE && index > table_size)
680		return 0;
681	return 1;
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
682}
683
684/* verify dfa xindexes are in range of transition tables */
685static bool verify_dfa_xindex(struct aa_dfa *dfa, int table_size)
686{
687	int i;
688	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
689		if (!verify_xindex(dfa_user_xindex(dfa, i), table_size))
690			return 0;
691		if (!verify_xindex(dfa_other_xindex(dfa, i), table_size))
692			return 0;
 
 
 
 
 
 
 
 
693	}
694	return 1;
 
695}
696
697/**
698 * verify_profile - Do post unpack analysis to verify profile consistency
699 * @profile: profile to verify (NOT NULL)
700 *
701 * Returns: 0 if passes verification else error
 
 
702 */
703static int verify_profile(struct aa_profile *profile)
704{
705	if (aa_g_paranoid_load) {
706		if (profile->file.dfa &&
707		    !verify_dfa_xindex(profile->file.dfa,
708				       profile->file.trans.size)) {
709			audit_iface(profile, NULL, "Invalid named transition",
710				    NULL, -EPROTO);
711			return -EPROTO;
712		}
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
713	}
714
715	return 0;
716}
717
718void aa_load_ent_free(struct aa_load_ent *ent)
719{
720	if (ent) {
721		aa_put_profile(ent->rename);
722		aa_put_profile(ent->old);
723		aa_put_profile(ent->new);
724		kzfree(ent);
 
725	}
726}
727
728struct aa_load_ent *aa_load_ent_alloc(void)
729{
730	struct aa_load_ent *ent = kzalloc(sizeof(*ent), GFP_KERNEL);
731	if (ent)
732		INIT_LIST_HEAD(&ent->list);
733	return ent;
734}
735
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
736/**
737 * aa_unpack - unpack packed binary profile(s) data loaded from user space
738 * @udata: user data copied to kmem  (NOT NULL)
739 * @size: the size of the user data
740 * @lh: list to place unpacked profiles in a aa_repl_ws
741 * @ns: Returns namespace profile is in if specified else NULL (NOT NULL)
742 *
743 * Unpack user data and return refcounted allocated profile(s) stored in
744 * @lh in order of discovery, with the list chain stored in base.list
745 * or error
746 *
747 * Returns: profile(s) on @lh else error pointer if fails to unpack
748 */
749int aa_unpack(void *udata, size_t size, struct list_head *lh, const char **ns)
 
750{
751	struct aa_load_ent *tmp, *ent;
752	struct aa_profile *profile = NULL;
 
753	int error;
754	struct aa_ext e = {
755		.start = udata,
756		.end = udata + size,
757		.pos = udata,
758	};
759
760	*ns = NULL;
761	while (e.pos < e.end) {
762		void *start;
763		error = verify_header(&e, e.pos == e.start, ns);
764		if (error)
765			goto fail;
766
767		start = e.pos;
768		profile = unpack_profile(&e);
769		if (IS_ERR(profile)) {
770			error = PTR_ERR(profile);
771			goto fail;
772		}
773
774		error = verify_profile(profile);
775		if (error)
776			goto fail_profile;
777
778		error = aa_calc_profile_hash(profile, e.version, start,
779					     e.pos - start);
 
780		if (error)
781			goto fail_profile;
782
783		ent = aa_load_ent_alloc();
784		if (!ent) {
785			error = -ENOMEM;
786			goto fail_profile;
787		}
788
789		ent->new = profile;
 
 
790		list_add_tail(&ent->list, lh);
791	}
 
 
 
 
 
 
 
 
 
792
 
 
 
 
 
793	return 0;
794
795fail_profile:
 
796	aa_put_profile(profile);
797
798fail:
799	list_for_each_entry_safe(ent, tmp, lh, list) {
800		list_del_init(&ent->list);
801		aa_load_ent_free(ent);
802	}
803
804	return error;
805}
v6.13.7
   1// SPDX-License-Identifier: GPL-2.0-only
   2/*
   3 * AppArmor security module
   4 *
   5 * This file contains AppArmor functions for unpacking policy loaded from
   6 * userspace.
   7 *
   8 * Copyright (C) 1998-2008 Novell/SUSE
   9 * Copyright 2009-2010 Canonical Ltd.
  10 *
 
 
 
 
 
  11 * AppArmor uses a serialized binary format for loading policy. To find
  12 * policy format documentation see Documentation/admin-guide/LSM/apparmor.rst
  13 * All policy is validated before it is used.
  14 */
  15
  16#include <linux/unaligned.h>
  17#include <kunit/visibility.h>
  18#include <linux/ctype.h>
  19#include <linux/errno.h>
  20#include <linux/zstd.h>
  21
  22#include "include/apparmor.h"
  23#include "include/audit.h"
  24#include "include/cred.h"
  25#include "include/crypto.h"
  26#include "include/file.h"
  27#include "include/match.h"
  28#include "include/path.h"
  29#include "include/policy.h"
  30#include "include/policy_unpack.h"
  31#include "include/policy_compat.h"
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
  32
  33/* audit callback for unpack fields */
  34static void audit_cb(struct audit_buffer *ab, void *va)
  35{
  36	struct common_audit_data *sa = va;
  37	struct apparmor_audit_data *ad = aad(sa);
  38
  39	if (ad->iface.ns) {
  40		audit_log_format(ab, " ns=");
  41		audit_log_untrustedstring(ab, ad->iface.ns);
  42	}
  43	if (ad->name) {
  44		audit_log_format(ab, " name=");
  45		audit_log_untrustedstring(ab, ad->name);
  46	}
  47	if (ad->iface.pos)
  48		audit_log_format(ab, " offset=%ld", ad->iface.pos);
  49}
  50
  51/**
  52 * audit_iface - do audit message for policy unpacking/load/replace/remove
  53 * @new: profile if it has been allocated (MAYBE NULL)
  54 * @ns_name: name of the ns the profile is to be loaded to (MAY BE NULL)
  55 * @name: name of the profile being manipulated (MAYBE NULL)
  56 * @info: any extra info about the failure (MAYBE NULL)
  57 * @e: buffer position info
  58 * @error: error code
  59 *
  60 * Returns: %0 or error
  61 */
  62static int audit_iface(struct aa_profile *new, const char *ns_name,
  63		       const char *name, const char *info, struct aa_ext *e,
  64		       int error)
  65{
  66	struct aa_profile *profile = labels_profile(aa_current_raw_label());
  67	DEFINE_AUDIT_DATA(ad, LSM_AUDIT_DATA_NONE, AA_CLASS_NONE, NULL);
 
 
 
  68	if (e)
  69		ad.iface.pos = e->pos - e->start;
  70	ad.iface.ns = ns_name;
  71	if (new)
  72		ad.name = new->base.hname;
  73	else
  74		ad.name = name;
  75	ad.info = info;
  76	ad.error = error;
  77
  78	return aa_audit(AUDIT_APPARMOR_STATUS, profile, &ad, audit_cb);
  79}
  80
  81void __aa_loaddata_update(struct aa_loaddata *data, long revision)
  82{
  83	AA_BUG(!data);
  84	AA_BUG(!data->ns);
  85	AA_BUG(!mutex_is_locked(&data->ns->lock));
  86	AA_BUG(data->revision > revision);
  87
  88	data->revision = revision;
  89	if ((data->dents[AAFS_LOADDATA_REVISION])) {
  90		struct inode *inode;
  91
  92		inode = d_inode(data->dents[AAFS_LOADDATA_DIR]);
  93		inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
  94
  95		inode = d_inode(data->dents[AAFS_LOADDATA_REVISION]);
  96		inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
  97	}
  98}
  99
 100bool aa_rawdata_eq(struct aa_loaddata *l, struct aa_loaddata *r)
 101{
 102	if (l->size != r->size)
 103		return false;
 104	if (l->compressed_size != r->compressed_size)
 105		return false;
 106	if (aa_g_hash_policy && memcmp(l->hash, r->hash, aa_hash_size()) != 0)
 107		return false;
 108	return memcmp(l->data, r->data, r->compressed_size ?: r->size) == 0;
 109}
 110
 111/*
 112 * need to take the ns mutex lock which is NOT safe most places that
 113 * put_loaddata is called, so we have to delay freeing it
 114 */
 115static void do_loaddata_free(struct work_struct *work)
 116{
 117	struct aa_loaddata *d = container_of(work, struct aa_loaddata, work);
 118	struct aa_ns *ns = aa_get_ns(d->ns);
 119
 120	if (ns) {
 121		mutex_lock_nested(&ns->lock, ns->level);
 122		__aa_fs_remove_rawdata(d);
 123		mutex_unlock(&ns->lock);
 124		aa_put_ns(ns);
 125	}
 126
 127	kfree_sensitive(d->hash);
 128	kfree_sensitive(d->name);
 129	kvfree(d->data);
 130	kfree_sensitive(d);
 131}
 132
 133void aa_loaddata_kref(struct kref *kref)
 134{
 135	struct aa_loaddata *d = container_of(kref, struct aa_loaddata, count);
 136
 137	if (d) {
 138		INIT_WORK(&d->work, do_loaddata_free);
 139		schedule_work(&d->work);
 140	}
 141}
 142
 143struct aa_loaddata *aa_loaddata_alloc(size_t size)
 144{
 145	struct aa_loaddata *d;
 146
 147	d = kzalloc(sizeof(*d), GFP_KERNEL);
 148	if (d == NULL)
 149		return ERR_PTR(-ENOMEM);
 150	d->data = kvzalloc(size, GFP_KERNEL);
 151	if (!d->data) {
 152		kfree(d);
 153		return ERR_PTR(-ENOMEM);
 154	}
 155	kref_init(&d->count);
 156	INIT_LIST_HEAD(&d->list);
 157
 158	return d;
 159}
 160
 161/* test if read will be in packed data bounds */
 162VISIBLE_IF_KUNIT bool aa_inbounds(struct aa_ext *e, size_t size)
 163{
 164	return (size <= e->end - e->pos);
 165}
 166EXPORT_SYMBOL_IF_KUNIT(aa_inbounds);
 167
 168/**
 169 * aa_unpack_u16_chunk - test and do bounds checking for a u16 size based chunk
 170 * @e: serialized data read head (NOT NULL)
 171 * @chunk: start address for chunk of data (NOT NULL)
 172 *
 173 * Returns: the size of chunk found with the read head at the end of the chunk.
 174 */
 175VISIBLE_IF_KUNIT size_t aa_unpack_u16_chunk(struct aa_ext *e, char **chunk)
 176{
 177	size_t size = 0;
 178	void *pos = e->pos;
 179
 180	if (!aa_inbounds(e, sizeof(u16)))
 181		goto fail;
 182	size = le16_to_cpu(get_unaligned((__le16 *) e->pos));
 183	e->pos += sizeof(__le16);
 184	if (!aa_inbounds(e, size))
 185		goto fail;
 186	*chunk = e->pos;
 187	e->pos += size;
 188	return size;
 189
 190fail:
 191	e->pos = pos;
 192	return 0;
 193}
 194EXPORT_SYMBOL_IF_KUNIT(aa_unpack_u16_chunk);
 195
 196/* unpack control byte */
 197VISIBLE_IF_KUNIT bool aa_unpack_X(struct aa_ext *e, enum aa_code code)
 198{
 199	if (!aa_inbounds(e, 1))
 200		return false;
 201	if (*(u8 *) e->pos != code)
 202		return false;
 203	e->pos++;
 204	return true;
 205}
 206EXPORT_SYMBOL_IF_KUNIT(aa_unpack_X);
 207
 208/**
 209 * aa_unpack_nameX - check is the next element is of type X with a name of @name
 210 * @e: serialized data extent information  (NOT NULL)
 211 * @code: type code
 212 * @name: name to match to the serialized element.  (MAYBE NULL)
 213 *
 214 * check that the next serialized data element is of type X and has a tag
 215 * name @name.  If @name is specified then there must be a matching
 216 * name element in the stream.  If @name is NULL any name element will be
 217 * skipped and only the typecode will be tested.
 218 *
 219 * Returns true on success (both type code and name tests match) and the read
 220 * head is advanced past the headers
 221 *
 222 * Returns: false if either match fails, the read head does not move
 223 */
 224VISIBLE_IF_KUNIT bool aa_unpack_nameX(struct aa_ext *e, enum aa_code code, const char *name)
 225{
 226	/*
 227	 * May need to reset pos if name or type doesn't match
 228	 */
 229	void *pos = e->pos;
 230	/*
 231	 * Check for presence of a tagname, and if present name size
 232	 * AA_NAME tag value is a u16.
 233	 */
 234	if (aa_unpack_X(e, AA_NAME)) {
 235		char *tag = NULL;
 236		size_t size = aa_unpack_u16_chunk(e, &tag);
 237		/* if a name is specified it must match. otherwise skip tag */
 238		if (name && (!size || tag[size-1] != '\0' || strcmp(name, tag)))
 239			goto fail;
 240	} else if (name) {
 241		/* if a name is specified and there is no name tag fail */
 242		goto fail;
 243	}
 244
 245	/* now check if type code matches */
 246	if (aa_unpack_X(e, code))
 247		return true;
 248
 249fail:
 250	e->pos = pos;
 251	return false;
 252}
 253EXPORT_SYMBOL_IF_KUNIT(aa_unpack_nameX);
 254
 255static bool unpack_u8(struct aa_ext *e, u8 *data, const char *name)
 256{
 257	void *pos = e->pos;
 258
 259	if (aa_unpack_nameX(e, AA_U8, name)) {
 260		if (!aa_inbounds(e, sizeof(u8)))
 261			goto fail;
 262		if (data)
 263			*data = *((u8 *)e->pos);
 264		e->pos += sizeof(u8);
 265		return true;
 266	}
 267
 268fail:
 269	e->pos = pos;
 270	return false;
 271}
 272
 273VISIBLE_IF_KUNIT bool aa_unpack_u32(struct aa_ext *e, u32 *data, const char *name)
 274{
 275	void *pos = e->pos;
 276
 277	if (aa_unpack_nameX(e, AA_U32, name)) {
 278		if (!aa_inbounds(e, sizeof(u32)))
 279			goto fail;
 280		if (data)
 281			*data = le32_to_cpu(get_unaligned((__le32 *) e->pos));
 282		e->pos += sizeof(u32);
 283		return true;
 284	}
 285
 286fail:
 287	e->pos = pos;
 288	return false;
 289}
 290EXPORT_SYMBOL_IF_KUNIT(aa_unpack_u32);
 291
 292VISIBLE_IF_KUNIT bool aa_unpack_u64(struct aa_ext *e, u64 *data, const char *name)
 293{
 294	void *pos = e->pos;
 295
 296	if (aa_unpack_nameX(e, AA_U64, name)) {
 297		if (!aa_inbounds(e, sizeof(u64)))
 298			goto fail;
 299		if (data)
 300			*data = le64_to_cpu(get_unaligned((__le64 *) e->pos));
 301		e->pos += sizeof(u64);
 302		return true;
 303	}
 304
 305fail:
 306	e->pos = pos;
 307	return false;
 308}
 309EXPORT_SYMBOL_IF_KUNIT(aa_unpack_u64);
 310
 311static bool aa_unpack_cap_low(struct aa_ext *e, kernel_cap_t *data, const char *name)
 312{
 313	u32 val;
 314
 315	if (!aa_unpack_u32(e, &val, name))
 316		return false;
 317	data->val = val;
 318	return true;
 319}
 320
 321static bool aa_unpack_cap_high(struct aa_ext *e, kernel_cap_t *data, const char *name)
 322{
 323	u32 val;
 324
 325	if (!aa_unpack_u32(e, &val, name))
 326		return false;
 327	data->val = (u32)data->val | ((u64)val << 32);
 328	return true;
 329}
 330
 331VISIBLE_IF_KUNIT bool aa_unpack_array(struct aa_ext *e, const char *name, u16 *size)
 332{
 333	void *pos = e->pos;
 334
 335	if (aa_unpack_nameX(e, AA_ARRAY, name)) {
 336		if (!aa_inbounds(e, sizeof(u16)))
 337			goto fail;
 338		*size = le16_to_cpu(get_unaligned((__le16 *) e->pos));
 339		e->pos += sizeof(u16);
 340		return true;
 341	}
 342
 343fail:
 344	e->pos = pos;
 345	return false;
 346}
 347EXPORT_SYMBOL_IF_KUNIT(aa_unpack_array);
 348
 349VISIBLE_IF_KUNIT size_t aa_unpack_blob(struct aa_ext *e, char **blob, const char *name)
 350{
 351	void *pos = e->pos;
 352
 353	if (aa_unpack_nameX(e, AA_BLOB, name)) {
 354		u32 size;
 355		if (!aa_inbounds(e, sizeof(u32)))
 356			goto fail;
 357		size = le32_to_cpu(get_unaligned((__le32 *) e->pos));
 358		e->pos += sizeof(u32);
 359		if (aa_inbounds(e, (size_t) size)) {
 360			*blob = e->pos;
 361			e->pos += size;
 362			return size;
 363		}
 364	}
 365
 366fail:
 367	e->pos = pos;
 368	return 0;
 369}
 370EXPORT_SYMBOL_IF_KUNIT(aa_unpack_blob);
 371
 372VISIBLE_IF_KUNIT int aa_unpack_str(struct aa_ext *e, const char **string, const char *name)
 373{
 374	char *src_str;
 375	size_t size = 0;
 376	void *pos = e->pos;
 377	*string = NULL;
 378	if (aa_unpack_nameX(e, AA_STRING, name)) {
 379		size = aa_unpack_u16_chunk(e, &src_str);
 380		if (size) {
 381			/* strings are null terminated, length is size - 1 */
 382			if (src_str[size - 1] != 0)
 383				goto fail;
 384			*string = src_str;
 385
 386			return size;
 387		}
 388	}
 
 389
 390fail:
 391	e->pos = pos;
 392	return 0;
 393}
 394EXPORT_SYMBOL_IF_KUNIT(aa_unpack_str);
 395
 396VISIBLE_IF_KUNIT int aa_unpack_strdup(struct aa_ext *e, char **string, const char *name)
 397{
 398	const char *tmp;
 399	void *pos = e->pos;
 400	int res = aa_unpack_str(e, &tmp, name);
 401	*string = NULL;
 402
 403	if (!res)
 404		return 0;
 405
 406	*string = kmemdup(tmp, res, GFP_KERNEL);
 407	if (!*string) {
 408		e->pos = pos;
 409		return 0;
 410	}
 411
 412	return res;
 413}
 414EXPORT_SYMBOL_IF_KUNIT(aa_unpack_strdup);
 415
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 416
 417/**
 418 * unpack_dfa - unpack a file rule dfa
 419 * @e: serialized data extent information (NOT NULL)
 420 * @flags: dfa flags to check
 421 *
 422 * returns dfa or ERR_PTR or NULL if no dfa
 423 */
 424static struct aa_dfa *unpack_dfa(struct aa_ext *e, int flags)
 425{
 426	char *blob = NULL;
 427	size_t size;
 428	struct aa_dfa *dfa = NULL;
 429
 430	size = aa_unpack_blob(e, &blob, "aadfa");
 431	if (size) {
 432		/*
 433		 * The dfa is aligned with in the blob to 8 bytes
 434		 * from the beginning of the stream.
 435		 * alignment adjust needed by dfa unpack
 436		 */
 437		size_t sz = blob - (char *) e->start -
 438			((e->pos - e->start) & 7);
 439		size_t pad = ALIGN(sz, 8) - sz;
 
 
 
 
 440		if (aa_g_paranoid_load)
 441			flags |= DFA_FLAG_VERIFY_STATES;
 
 442		dfa = aa_dfa_unpack(blob + pad, size - pad, flags);
 443
 444		if (IS_ERR(dfa))
 445			return dfa;
 446
 
 
 447	}
 448
 449	return dfa;
 
 
 
 
 450}
 451
 452/**
 453 * unpack_trans_table - unpack a profile transition table
 454 * @e: serialized data extent information  (NOT NULL)
 455 * @strs: str table to unpack to (NOT NULL)
 456 *
 457 * Returns: true if table successfully unpacked or not present
 458 */
 459static bool unpack_trans_table(struct aa_ext *e, struct aa_str_table *strs)
 460{
 461	void *saved_pos = e->pos;
 462	char **table = NULL;
 463
 464	/* exec table is optional */
 465	if (aa_unpack_nameX(e, AA_STRUCT, "xtable")) {
 466		u16 size;
 467		int i;
 468
 469		if (!aa_unpack_array(e, NULL, &size))
 470			/*
 471			 * Note: index into trans table array is a max
 472			 * of 2^24, but unpack array can only unpack
 473			 * an array of 2^16 in size atm so no need
 474			 * for size check here
 475			 */
 476			goto fail;
 477		table = kcalloc(size, sizeof(char *), GFP_KERNEL);
 478		if (!table)
 
 479			goto fail;
 480
 481		strs->table = table;
 482		strs->size = size;
 483		for (i = 0; i < size; i++) {
 484			char *str;
 485			int c, j, pos, size2 = aa_unpack_strdup(e, &str, NULL);
 486			/* aa_unpack_strdup verifies that the last character is
 487			 * null termination byte.
 488			 */
 489			if (!size2)
 490				goto fail;
 491			table[i] = str;
 492			/* verify that name doesn't start with space */
 493			if (isspace(*str))
 494				goto fail;
 495
 496			/* count internal #  of internal \0 */
 497			for (c = j = 0; j < size2 - 1; j++) {
 498				if (!str[j]) {
 499					pos = j;
 500					c++;
 501				}
 502			}
 503			if (*str == ':') {
 504				/* first character after : must be valid */
 505				if (!str[1])
 506					goto fail;
 507				/* beginning with : requires an embedded \0,
 508				 * verify that exactly 1 internal \0 exists
 509				 * trailing \0 already verified by aa_unpack_strdup
 510				 *
 511				 * convert \0 back to : for label_parse
 512				 */
 513				if (c == 1)
 514					str[pos] = ':';
 515				else if (c > 1)
 
 516					goto fail;
 517			} else if (c)
 518				/* fail - all other cases with embedded \0 */
 519				goto fail;
 520		}
 521		if (!aa_unpack_nameX(e, AA_ARRAYEND, NULL))
 522			goto fail;
 523		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 524			goto fail;
 525	}
 526	return true;
 527
 528fail:
 529	aa_free_str_table(strs);
 530	e->pos = saved_pos;
 531	return false;
 532}
 533
 534static bool unpack_xattrs(struct aa_ext *e, struct aa_profile *profile)
 535{
 536	void *pos = e->pos;
 537
 538	if (aa_unpack_nameX(e, AA_STRUCT, "xattrs")) {
 539		u16 size;
 540		int i;
 541
 542		if (!aa_unpack_array(e, NULL, &size))
 543			goto fail;
 544		profile->attach.xattr_count = size;
 545		profile->attach.xattrs = kcalloc(size, sizeof(char *), GFP_KERNEL);
 546		if (!profile->attach.xattrs)
 547			goto fail;
 548		for (i = 0; i < size; i++) {
 549			if (!aa_unpack_strdup(e, &profile->attach.xattrs[i], NULL))
 550				goto fail;
 551		}
 552		if (!aa_unpack_nameX(e, AA_ARRAYEND, NULL))
 553			goto fail;
 554		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 555			goto fail;
 556	}
 557
 558	return true;
 559
 560fail:
 
 561	e->pos = pos;
 562	return false;
 563}
 564
 565static bool unpack_secmark(struct aa_ext *e, struct aa_ruleset *rules)
 566{
 567	void *pos = e->pos;
 568	u16 size;
 569	int i;
 570
 571	if (aa_unpack_nameX(e, AA_STRUCT, "secmark")) {
 572		if (!aa_unpack_array(e, NULL, &size))
 573			goto fail;
 574
 575		rules->secmark = kcalloc(size, sizeof(struct aa_secmark),
 576					   GFP_KERNEL);
 577		if (!rules->secmark)
 578			goto fail;
 579
 580		rules->secmark_count = size;
 581
 582		for (i = 0; i < size; i++) {
 583			if (!unpack_u8(e, &rules->secmark[i].audit, NULL))
 584				goto fail;
 585			if (!unpack_u8(e, &rules->secmark[i].deny, NULL))
 586				goto fail;
 587			if (!aa_unpack_strdup(e, &rules->secmark[i].label, NULL))
 588				goto fail;
 589		}
 590		if (!aa_unpack_nameX(e, AA_ARRAYEND, NULL))
 591			goto fail;
 592		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 593			goto fail;
 594	}
 595
 596	return true;
 597
 598fail:
 599	if (rules->secmark) {
 600		for (i = 0; i < size; i++)
 601			kfree(rules->secmark[i].label);
 602		kfree(rules->secmark);
 603		rules->secmark_count = 0;
 604		rules->secmark = NULL;
 605	}
 606
 607	e->pos = pos;
 608	return false;
 609}
 610
 611static bool unpack_rlimits(struct aa_ext *e, struct aa_ruleset *rules)
 612{
 613	void *pos = e->pos;
 614
 615	/* rlimits are optional */
 616	if (aa_unpack_nameX(e, AA_STRUCT, "rlimits")) {
 617		u16 size;
 618		int i;
 619		u32 tmp = 0;
 620		if (!aa_unpack_u32(e, &tmp, NULL))
 621			goto fail;
 622		rules->rlimits.mask = tmp;
 623
 624		if (!aa_unpack_array(e, NULL, &size) ||
 625		    size > RLIM_NLIMITS)
 626			goto fail;
 627		for (i = 0; i < size; i++) {
 628			u64 tmp2 = 0;
 629			int a = aa_map_resource(i);
 630			if (!aa_unpack_u64(e, &tmp2, NULL))
 631				goto fail;
 632			rules->rlimits.limits[a].rlim_max = tmp2;
 633		}
 634		if (!aa_unpack_nameX(e, AA_ARRAYEND, NULL))
 635			goto fail;
 636		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 637			goto fail;
 638	}
 639	return true;
 640
 641fail:
 642	e->pos = pos;
 643	return false;
 644}
 645
 646static bool unpack_perm(struct aa_ext *e, u32 version, struct aa_perms *perm)
 647{
 648	u32 reserved;
 649
 650	if (version != 1)
 651		return false;
 652
 653	/* reserved entry is for later expansion, discard for now */
 654	return	aa_unpack_u32(e, &reserved, NULL) &&
 655		aa_unpack_u32(e, &perm->allow, NULL) &&
 656		aa_unpack_u32(e, &perm->deny, NULL) &&
 657		aa_unpack_u32(e, &perm->subtree, NULL) &&
 658		aa_unpack_u32(e, &perm->cond, NULL) &&
 659		aa_unpack_u32(e, &perm->kill, NULL) &&
 660		aa_unpack_u32(e, &perm->complain, NULL) &&
 661		aa_unpack_u32(e, &perm->prompt, NULL) &&
 662		aa_unpack_u32(e, &perm->audit, NULL) &&
 663		aa_unpack_u32(e, &perm->quiet, NULL) &&
 664		aa_unpack_u32(e, &perm->hide, NULL) &&
 665		aa_unpack_u32(e, &perm->xindex, NULL) &&
 666		aa_unpack_u32(e, &perm->tag, NULL) &&
 667		aa_unpack_u32(e, &perm->label, NULL);
 668}
 669
 670static ssize_t unpack_perms_table(struct aa_ext *e, struct aa_perms **perms)
 671{
 672	void *pos = e->pos;
 673	u16 size = 0;
 674
 675	AA_BUG(!perms);
 676	/*
 677	 * policy perms are optional, in which case perms are embedded
 678	 * in the dfa accept table
 679	 */
 680	if (aa_unpack_nameX(e, AA_STRUCT, "perms")) {
 681		int i;
 682		u32 version;
 683
 684		if (!aa_unpack_u32(e, &version, "version"))
 685			goto fail_reset;
 686		if (!aa_unpack_array(e, NULL, &size))
 687			goto fail_reset;
 688		*perms = kcalloc(size, sizeof(struct aa_perms), GFP_KERNEL);
 689		if (!*perms)
 690			goto fail_reset;
 691		for (i = 0; i < size; i++) {
 692			if (!unpack_perm(e, version, &(*perms)[i]))
 693				goto fail;
 694		}
 695		if (!aa_unpack_nameX(e, AA_ARRAYEND, NULL))
 696			goto fail;
 697		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 698			goto fail;
 699	} else
 700		*perms = NULL;
 701
 702	return size;
 703
 704fail:
 705	kfree(*perms);
 706fail_reset:
 707	e->pos = pos;
 708	return -EPROTO;
 709}
 710
 711static int unpack_pdb(struct aa_ext *e, struct aa_policydb **policy,
 712		      bool required_dfa, bool required_trans,
 713		      const char **info)
 714{
 715	struct aa_policydb *pdb;
 716	void *pos = e->pos;
 717	int i, flags, error = -EPROTO;
 718	ssize_t size;
 719
 720	pdb = aa_alloc_pdb(GFP_KERNEL);
 721	if (!pdb)
 722		return -ENOMEM;
 723
 724	size = unpack_perms_table(e, &pdb->perms);
 725	if (size < 0) {
 726		error = size;
 727		pdb->perms = NULL;
 728		*info = "failed to unpack - perms";
 729		goto fail;
 730	}
 731	pdb->size = size;
 732
 733	if (pdb->perms) {
 734		/* perms table present accept is index */
 735		flags = TO_ACCEPT1_FLAG(YYTD_DATA32);
 736	} else {
 737		/* packed perms in accept1 and accept2 */
 738		flags = TO_ACCEPT1_FLAG(YYTD_DATA32) |
 739			TO_ACCEPT2_FLAG(YYTD_DATA32);
 740	}
 741
 742	pdb->dfa = unpack_dfa(e, flags);
 743	if (IS_ERR(pdb->dfa)) {
 744		error = PTR_ERR(pdb->dfa);
 745		pdb->dfa = NULL;
 746		*info = "failed to unpack - dfa";
 747		goto fail;
 748	} else if (!pdb->dfa) {
 749		if (required_dfa) {
 750			*info = "missing required dfa";
 751			goto fail;
 752		}
 753	} else {
 754		/*
 755		 * only unpack the following if a dfa is present
 756		 *
 757		 * sadly start was given different names for file and policydb
 758		 * but since it is optional we can try both
 759		 */
 760		if (!aa_unpack_u32(e, &pdb->start[0], "start"))
 761			/* default start state */
 762			pdb->start[0] = DFA_START;
 763		if (!aa_unpack_u32(e, &pdb->start[AA_CLASS_FILE], "dfa_start")) {
 764			/* default start state for xmatch and file dfa */
 765			pdb->start[AA_CLASS_FILE] = DFA_START;
 766		}	/* setup class index */
 767		for (i = AA_CLASS_FILE + 1; i <= AA_CLASS_LAST; i++) {
 768			pdb->start[i] = aa_dfa_next(pdb->dfa, pdb->start[0],
 769						    i);
 770		}
 771	}
 772
 773	/*
 774	 * Unfortunately due to a bug in earlier userspaces, a
 775	 * transition table may be present even when the dfa is
 776	 * not. For compatibility reasons unpack and discard.
 777	 */
 778	if (!unpack_trans_table(e, &pdb->trans) && required_trans) {
 779		*info = "failed to unpack profile transition table";
 780		goto fail;
 781	}
 782
 783	if (!pdb->dfa && pdb->trans.table)
 784		aa_free_str_table(&pdb->trans);
 785
 786	/* TODO: move compat mapping here, requires dfa merging first */
 787	/* TODO: move verify here, it has to be done after compat mappings */
 788
 789	*policy = pdb;
 790	return 0;
 791
 792fail:
 793	aa_put_pdb(pdb);
 794	e->pos = pos;
 795	return error;
 796}
 797
 798static u32 strhash(const void *data, u32 len, u32 seed)
 799{
 800	const char * const *key = data;
 801
 802	return jhash(*key, strlen(*key), seed);
 803}
 804
 805static int datacmp(struct rhashtable_compare_arg *arg, const void *obj)
 806{
 807	const struct aa_data *data = obj;
 808	const char * const *key = arg->key;
 809
 810	return strcmp(data->key, *key);
 811}
 812
 813/**
 814 * unpack_profile - unpack a serialized profile
 815 * @e: serialized data extent information (NOT NULL)
 816 * @ns_name: pointer of newly allocated copy of %NULL in case of error
 817 *
 818 * NOTE: unpack profile sets audit struct if there is a failure
 819 */
 820static struct aa_profile *unpack_profile(struct aa_ext *e, char **ns_name)
 821{
 822	struct aa_ruleset *rules;
 823	struct aa_profile *profile = NULL;
 824	const char *tmpname, *tmpns = NULL, *name = NULL;
 825	const char *info = "failed to unpack profile";
 826	size_t ns_len;
 827	struct rhashtable_params params = { 0 };
 828	char *key = NULL, *disconnected = NULL;
 829	struct aa_data *data;
 830	int error = -EPROTO;
 831	kernel_cap_t tmpcap;
 832	u32 tmp;
 833
 834	*ns_name = NULL;
 835
 836	/* check that we have the right struct being passed */
 837	if (!aa_unpack_nameX(e, AA_STRUCT, "profile"))
 838		goto fail;
 839	if (!aa_unpack_str(e, &name, NULL))
 840		goto fail;
 841	if (*name == '\0')
 842		goto fail;
 843
 844	tmpname = aa_splitn_fqname(name, strlen(name), &tmpns, &ns_len);
 845	if (tmpns) {
 846		if (!tmpname) {
 847			info = "empty profile name";
 848			goto fail;
 849		}
 850		*ns_name = kstrndup(tmpns, ns_len, GFP_KERNEL);
 851		if (!*ns_name) {
 852			info = "out of memory";
 853			error = -ENOMEM;
 854			goto fail;
 855		}
 856		name = tmpname;
 857	}
 858
 859	profile = aa_alloc_profile(name, NULL, GFP_KERNEL);
 860	if (!profile) {
 861		info = "out of memory";
 862		error = -ENOMEM;
 863		goto fail;
 864	}
 865	rules = list_first_entry(&profile->rules, typeof(*rules), list);
 866
 867	/* profile renaming is optional */
 868	(void) aa_unpack_str(e, &profile->rename, "rename");
 869
 870	/* attachment string is optional */
 871	(void) aa_unpack_str(e, &profile->attach.xmatch_str, "attach");
 872
 873	/* xmatch is optional and may be NULL */
 874	error = unpack_pdb(e, &profile->attach.xmatch, false, false, &info);
 875	if (error) {
 876		info = "bad xmatch";
 
 877		goto fail;
 878	}
 879
 880	/* neither xmatch_len not xmatch_perms are optional if xmatch is set */
 881	if (profile->attach.xmatch->dfa) {
 882		if (!aa_unpack_u32(e, &tmp, NULL)) {
 883			info = "missing xmatch len";
 884			goto fail;
 885		}
 886		profile->attach.xmatch_len = tmp;
 887		profile->attach.xmatch->start[AA_CLASS_XMATCH] = DFA_START;
 888		if (!profile->attach.xmatch->perms) {
 889			error = aa_compat_map_xmatch(profile->attach.xmatch);
 890			if (error) {
 891				info = "failed to convert xmatch permission table";
 892				goto fail;
 893			}
 894		}
 895	}
 896
 897	/* disconnected attachment string is optional */
 898	(void) aa_unpack_strdup(e, &disconnected, "disconnected");
 899	profile->disconnected = disconnected;
 900
 901	/* per profile debug flags (complain, audit) */
 902	if (!aa_unpack_nameX(e, AA_STRUCT, "flags")) {
 903		info = "profile missing flags";
 904		goto fail;
 905	}
 906	info = "failed to unpack profile flags";
 907	if (!aa_unpack_u32(e, &tmp, NULL))
 908		goto fail;
 909	if (tmp & PACKED_FLAG_HAT)
 910		profile->label.flags |= FLAG_HAT;
 911	if (tmp & PACKED_FLAG_DEBUG1)
 912		profile->label.flags |= FLAG_DEBUG1;
 913	if (tmp & PACKED_FLAG_DEBUG2)
 914		profile->label.flags |= FLAG_DEBUG2;
 915	if (!aa_unpack_u32(e, &tmp, NULL))
 916		goto fail;
 917	if (tmp == PACKED_MODE_COMPLAIN || (e->version & FORCE_COMPLAIN_FLAG)) {
 918		profile->mode = APPARMOR_COMPLAIN;
 919	} else if (tmp == PACKED_MODE_ENFORCE) {
 920		profile->mode = APPARMOR_ENFORCE;
 921	} else if (tmp == PACKED_MODE_KILL) {
 922		profile->mode = APPARMOR_KILL;
 923	} else if (tmp == PACKED_MODE_UNCONFINED) {
 924		profile->mode = APPARMOR_UNCONFINED;
 925		profile->label.flags |= FLAG_UNCONFINED;
 926	} else if (tmp == PACKED_MODE_USER) {
 927		profile->mode = APPARMOR_USER;
 928	} else {
 929		goto fail;
 930	}
 931	if (!aa_unpack_u32(e, &tmp, NULL))
 932		goto fail;
 933	if (tmp)
 934		profile->audit = AUDIT_ALL;
 935
 936	if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 937		goto fail;
 938
 939	/* path_flags is optional */
 940	if (aa_unpack_u32(e, &profile->path_flags, "path_flags"))
 941		profile->path_flags |= profile->label.flags &
 942			PATH_MEDIATE_DELETED;
 943	else
 944		/* set a default value if path_flags field is not present */
 945		profile->path_flags = PATH_MEDIATE_DELETED;
 946
 947	info = "failed to unpack profile capabilities";
 948	if (!aa_unpack_cap_low(e, &rules->caps.allow, NULL))
 949		goto fail;
 950	if (!aa_unpack_cap_low(e, &rules->caps.audit, NULL))
 951		goto fail;
 952	if (!aa_unpack_cap_low(e, &rules->caps.quiet, NULL))
 953		goto fail;
 954	if (!aa_unpack_cap_low(e, &tmpcap, NULL))
 955		goto fail;
 956
 957	info = "failed to unpack upper profile capabilities";
 958	if (aa_unpack_nameX(e, AA_STRUCT, "caps64")) {
 959		/* optional upper half of 64 bit caps */
 960		if (!aa_unpack_cap_high(e, &rules->caps.allow, NULL))
 961			goto fail;
 962		if (!aa_unpack_cap_high(e, &rules->caps.audit, NULL))
 963			goto fail;
 964		if (!aa_unpack_cap_high(e, &rules->caps.quiet, NULL))
 965			goto fail;
 966		if (!aa_unpack_cap_high(e, &tmpcap, NULL))
 967			goto fail;
 968		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 969			goto fail;
 970	}
 971
 972	info = "failed to unpack extended profile capabilities";
 973	if (aa_unpack_nameX(e, AA_STRUCT, "capsx")) {
 974		/* optional extended caps mediation mask */
 975		if (!aa_unpack_cap_low(e, &rules->caps.extended, NULL))
 976			goto fail;
 977		if (!aa_unpack_cap_high(e, &rules->caps.extended, NULL))
 978			goto fail;
 979		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
 980			goto fail;
 981	}
 982
 983	if (!unpack_xattrs(e, profile)) {
 984		info = "failed to unpack profile xattrs";
 985		goto fail;
 986	}
 987
 988	if (!unpack_rlimits(e, rules)) {
 989		info = "failed to unpack profile rlimits";
 990		goto fail;
 991	}
 992
 993	if (!unpack_secmark(e, rules)) {
 994		info = "failed to unpack profile secmark rules";
 995		goto fail;
 996	}
 997
 998	if (aa_unpack_nameX(e, AA_STRUCT, "policydb")) {
 999		/* generic policy dfa - optional and may be NULL */
1000		info = "failed to unpack policydb";
1001		error = unpack_pdb(e, &rules->policy, true, false,
1002				   &info);
1003		if (error)
1004			goto fail;
1005		/* Fixup: drop when we get rid of start array */
1006		if (aa_dfa_next(rules->policy->dfa, rules->policy->start[0],
1007				AA_CLASS_FILE))
1008			rules->policy->start[AA_CLASS_FILE] =
1009			  aa_dfa_next(rules->policy->dfa,
1010				      rules->policy->start[0],
1011				      AA_CLASS_FILE);
1012		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL))
1013			goto fail;
1014		if (!rules->policy->perms) {
1015			error = aa_compat_map_policy(rules->policy,
1016						     e->version);
1017			if (error) {
1018				info = "failed to remap policydb permission table";
1019				goto fail;
1020			}
1021		}
1022	} else {
1023		rules->policy = aa_get_pdb(nullpdb);
 
 
 
 
 
 
 
 
 
 
1024	}
 
1025	/* get file rules */
1026	error = unpack_pdb(e, &rules->file, false, true, &info);
1027	if (error) {
 
 
1028		goto fail;
1029	} else if (rules->file->dfa) {
1030		if (!rules->file->perms) {
1031			error = aa_compat_map_file(rules->file);
1032			if (error) {
1033				info = "failed to remap file permission table";
1034				goto fail;
1035			}
1036		}
1037	} else if (rules->policy->dfa &&
1038		   rules->policy->start[AA_CLASS_FILE]) {
1039		aa_put_pdb(rules->file);
1040		rules->file = aa_get_pdb(rules->policy);
1041	} else {
1042		aa_put_pdb(rules->file);
1043		rules->file = aa_get_pdb(nullpdb);
1044	}
1045	error = -EPROTO;
1046	if (aa_unpack_nameX(e, AA_STRUCT, "data")) {
1047		info = "out of memory";
1048		profile->data = kzalloc(sizeof(*profile->data), GFP_KERNEL);
1049		if (!profile->data) {
1050			error = -ENOMEM;
1051			goto fail;
1052		}
1053		params.nelem_hint = 3;
1054		params.key_len = sizeof(void *);
1055		params.key_offset = offsetof(struct aa_data, key);
1056		params.head_offset = offsetof(struct aa_data, head);
1057		params.hashfn = strhash;
1058		params.obj_cmpfn = datacmp;
1059
1060		if (rhashtable_init(profile->data, &params)) {
1061			info = "failed to init key, value hash table";
1062			goto fail;
1063		}
1064
1065		while (aa_unpack_strdup(e, &key, NULL)) {
1066			data = kzalloc(sizeof(*data), GFP_KERNEL);
1067			if (!data) {
1068				kfree_sensitive(key);
1069				error = -ENOMEM;
1070				goto fail;
1071			}
1072
1073			data->key = key;
1074			data->size = aa_unpack_blob(e, &data->data, NULL);
1075			data->data = kvmemdup(data->data, data->size, GFP_KERNEL);
1076			if (data->size && !data->data) {
1077				kfree_sensitive(data->key);
1078				kfree_sensitive(data);
1079				error = -ENOMEM;
1080				goto fail;
1081			}
1082
1083			if (rhashtable_insert_fast(profile->data, &data->head,
1084						   profile->data->p)) {
1085				kvfree_sensitive(data->data, data->size);
1086				kfree_sensitive(data->key);
1087				kfree_sensitive(data);
1088				info = "failed to insert data to table";
1089				goto fail;
1090			}
1091		}
1092
1093		if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL)) {
1094			info = "failed to unpack end of key, value data table";
1095			goto fail;
1096		}
1097	}
1098
1099	if (!aa_unpack_nameX(e, AA_STRUCTEND, NULL)) {
1100		info = "failed to unpack end of profile";
1101		goto fail;
1102	}
1103
1104	return profile;
1105
1106fail:
1107	if (error == 0)
1108		/* default error covers most cases */
1109		error = -EPROTO;
1110	if (*ns_name) {
1111		kfree(*ns_name);
1112		*ns_name = NULL;
1113	}
1114	if (profile)
1115		name = NULL;
1116	else if (!name)
1117		name = "unknown";
1118	audit_iface(profile, NULL, name, info, e, error);
1119	aa_free_profile(profile);
1120
1121	return ERR_PTR(error);
1122}
1123
1124/**
1125 * verify_header - unpack serialized stream header
1126 * @e: serialized data read head (NOT NULL)
1127 * @required: whether the header is required or optional
1128 * @ns: Returns - namespace if one is specified else NULL (NOT NULL)
1129 *
1130 * Returns: error or 0 if header is good
1131 */
1132static int verify_header(struct aa_ext *e, int required, const char **ns)
1133{
1134	int error = -EPROTONOSUPPORT;
1135	const char *name = NULL;
1136	*ns = NULL;
1137
1138	/* get the interface version */
1139	if (!aa_unpack_u32(e, &e->version, "version")) {
1140		if (required) {
1141			audit_iface(NULL, NULL, NULL, "invalid profile format",
 
 
 
 
 
 
 
1142				    e, error);
1143			return error;
1144		}
1145	}
1146
1147	/* Check that the interface version is currently supported.
1148	 * if not specified use previous version
1149	 * Mask off everything that is not kernel abi version
1150	 */
1151	if (VERSION_LT(e->version, v5) || VERSION_GT(e->version, v9)) {
1152		audit_iface(NULL, NULL, NULL, "unsupported interface version",
1153			    e, error);
1154		return error;
1155	}
1156
1157	/* read the namespace if present */
1158	if (aa_unpack_str(e, &name, "namespace")) {
1159		if (*name == '\0') {
1160			audit_iface(NULL, NULL, NULL, "invalid namespace name",
1161				    e, error);
1162			return error;
1163		}
1164		if (*ns && strcmp(*ns, name)) {
1165			audit_iface(NULL, NULL, NULL, "invalid ns change", e,
1166				    error);
1167		} else if (!*ns) {
1168			*ns = kstrdup(name, GFP_KERNEL);
1169			if (!*ns)
1170				return -ENOMEM;
1171		}
1172	}
1173
1174	return 0;
1175}
1176
1177/**
1178 * verify_dfa_accept_index - verify accept indexes are in range of perms table
1179 * @dfa: the dfa to check accept indexes are in range
1180 * @table_size: the permission table size the indexes should be within
1181 */
1182static bool verify_dfa_accept_index(struct aa_dfa *dfa, int table_size)
1183{
1184	int i;
1185	for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) {
1186		if (ACCEPT_TABLE(dfa)[i] >= table_size)
1187			return false;
1188	}
1189	return true;
1190}
1191
1192static bool verify_perm(struct aa_perms *perm)
1193{
1194	/* TODO: allow option to just force the perms into a valid state */
1195	if (perm->allow & perm->deny)
1196		return false;
1197	if (perm->subtree & ~perm->allow)
1198		return false;
1199	if (perm->cond & (perm->allow | perm->deny))
1200		return false;
1201	if (perm->kill & perm->allow)
1202		return false;
1203	if (perm->complain & (perm->allow | perm->deny))
1204		return false;
1205	if (perm->prompt & (perm->allow | perm->deny))
1206		return false;
1207	if (perm->complain & perm->prompt)
1208		return false;
1209	if (perm->hide & perm->allow)
1210		return false;
1211
1212	return true;
1213}
1214
1215static bool verify_perms(struct aa_policydb *pdb)
 
1216{
1217	int i;
1218
1219	for (i = 0; i < pdb->size; i++) {
1220		if (!verify_perm(&pdb->perms[i]))
1221			return false;
1222		/* verify indexes into str table */
1223		if ((pdb->perms[i].xindex & AA_X_TYPE_MASK) == AA_X_TABLE &&
1224		    (pdb->perms[i].xindex & AA_X_INDEX_MASK) >= pdb->trans.size)
1225			return false;
1226		if (pdb->perms[i].tag && pdb->perms[i].tag >= pdb->trans.size)
1227			return false;
1228		if (pdb->perms[i].label &&
1229		    pdb->perms[i].label >= pdb->trans.size)
1230			return false;
1231	}
1232
1233	return true;
1234}
1235
1236/**
1237 * verify_profile - Do post unpack analysis to verify profile consistency
1238 * @profile: profile to verify (NOT NULL)
1239 *
1240 * Returns: 0 if passes verification else error
1241 *
1242 * This verification is post any unpack mapping or changes
1243 */
1244static int verify_profile(struct aa_profile *profile)
1245{
1246	struct aa_ruleset *rules = list_first_entry(&profile->rules,
1247						    typeof(*rules), list);
1248	if (!rules)
1249		return 0;
1250
1251	if (rules->file->dfa && !verify_dfa_accept_index(rules->file->dfa,
1252							rules->file->size)) {
1253		audit_iface(profile, NULL, NULL,
1254			    "Unpack: file Invalid named transition", NULL,
1255			    -EPROTO);
1256		return -EPROTO;
1257	}
1258	if (rules->policy->dfa &&
1259	    !verify_dfa_accept_index(rules->policy->dfa, rules->policy->size)) {
1260		audit_iface(profile, NULL, NULL,
1261			    "Unpack: policy Invalid named transition", NULL,
1262			    -EPROTO);
1263		return -EPROTO;
1264	}
1265
1266	if (!verify_perms(rules->file)) {
1267		audit_iface(profile, NULL, NULL,
1268			    "Unpack: Invalid perm index", NULL, -EPROTO);
1269		return -EPROTO;
1270	}
1271	if (!verify_perms(rules->policy)) {
1272		audit_iface(profile, NULL, NULL,
1273			    "Unpack: Invalid perm index", NULL, -EPROTO);
1274		return -EPROTO;
1275	}
1276	if (!verify_perms(profile->attach.xmatch)) {
1277		audit_iface(profile, NULL, NULL,
1278			    "Unpack: Invalid perm index", NULL, -EPROTO);
1279		return -EPROTO;
1280	}
1281
1282	return 0;
1283}
1284
1285void aa_load_ent_free(struct aa_load_ent *ent)
1286{
1287	if (ent) {
1288		aa_put_profile(ent->rename);
1289		aa_put_profile(ent->old);
1290		aa_put_profile(ent->new);
1291		kfree(ent->ns_name);
1292		kfree_sensitive(ent);
1293	}
1294}
1295
1296struct aa_load_ent *aa_load_ent_alloc(void)
1297{
1298	struct aa_load_ent *ent = kzalloc(sizeof(*ent), GFP_KERNEL);
1299	if (ent)
1300		INIT_LIST_HEAD(&ent->list);
1301	return ent;
1302}
1303
1304static int compress_zstd(const char *src, size_t slen, char **dst, size_t *dlen)
1305{
1306#ifdef CONFIG_SECURITY_APPARMOR_EXPORT_BINARY
1307	const zstd_parameters params =
1308		zstd_get_params(aa_g_rawdata_compression_level, slen);
1309	const size_t wksp_len = zstd_cctx_workspace_bound(&params.cParams);
1310	void *wksp = NULL;
1311	zstd_cctx *ctx = NULL;
1312	size_t out_len = zstd_compress_bound(slen);
1313	void *out = NULL;
1314	int ret = 0;
1315
1316	out = kvzalloc(out_len, GFP_KERNEL);
1317	if (!out) {
1318		ret = -ENOMEM;
1319		goto cleanup;
1320	}
1321
1322	wksp = kvzalloc(wksp_len, GFP_KERNEL);
1323	if (!wksp) {
1324		ret = -ENOMEM;
1325		goto cleanup;
1326	}
1327
1328	ctx = zstd_init_cctx(wksp, wksp_len);
1329	if (!ctx) {
1330		ret = -EINVAL;
1331		goto cleanup;
1332	}
1333
1334	out_len = zstd_compress_cctx(ctx, out, out_len, src, slen, &params);
1335	if (zstd_is_error(out_len) || out_len >= slen) {
1336		ret = -EINVAL;
1337		goto cleanup;
1338	}
1339
1340	if (is_vmalloc_addr(out)) {
1341		*dst = kvzalloc(out_len, GFP_KERNEL);
1342		if (*dst) {
1343			memcpy(*dst, out, out_len);
1344			kvfree(out);
1345			out = NULL;
1346		}
1347	} else {
1348		/*
1349		 * If the staging buffer was kmalloc'd, then using krealloc is
1350		 * probably going to be faster. The destination buffer will
1351		 * always be smaller, so it's just shrunk, avoiding a memcpy
1352		 */
1353		*dst = krealloc(out, out_len, GFP_KERNEL);
1354	}
1355
1356	if (!*dst) {
1357		ret = -ENOMEM;
1358		goto cleanup;
1359	}
1360
1361	*dlen = out_len;
1362
1363cleanup:
1364	if (ret) {
1365		kvfree(out);
1366		*dst = NULL;
1367	}
1368
1369	kvfree(wksp);
1370	return ret;
1371#else
1372	*dlen = slen;
1373	return 0;
1374#endif
1375}
1376
1377static int compress_loaddata(struct aa_loaddata *data)
1378{
1379	AA_BUG(data->compressed_size > 0);
1380
1381	/*
1382	 * Shortcut the no compression case, else we increase the amount of
1383	 * storage required by a small amount
1384	 */
1385	if (aa_g_rawdata_compression_level != 0) {
1386		void *udata = data->data;
1387		int error = compress_zstd(udata, data->size, &data->data,
1388					  &data->compressed_size);
1389		if (error) {
1390			data->compressed_size = data->size;
1391			return error;
1392		}
1393		if (udata != data->data)
1394			kvfree(udata);
1395	} else
1396		data->compressed_size = data->size;
1397
1398	return 0;
1399}
1400
1401/**
1402 * aa_unpack - unpack packed binary profile(s) data loaded from user space
1403 * @udata: user data copied to kmem  (NOT NULL)
 
1404 * @lh: list to place unpacked profiles in a aa_repl_ws
1405 * @ns: Returns namespace profile is in if specified else NULL (NOT NULL)
1406 *
1407 * Unpack user data and return refcounted allocated profile(s) stored in
1408 * @lh in order of discovery, with the list chain stored in base.list
1409 * or error
1410 *
1411 * Returns: profile(s) on @lh else error pointer if fails to unpack
1412 */
1413int aa_unpack(struct aa_loaddata *udata, struct list_head *lh,
1414	      const char **ns)
1415{
1416	struct aa_load_ent *tmp, *ent;
1417	struct aa_profile *profile = NULL;
1418	char *ns_name = NULL;
1419	int error;
1420	struct aa_ext e = {
1421		.start = udata->data,
1422		.end = udata->data + udata->size,
1423		.pos = udata->data,
1424	};
1425
1426	*ns = NULL;
1427	while (e.pos < e.end) {
1428		void *start;
1429		error = verify_header(&e, e.pos == e.start, ns);
1430		if (error)
1431			goto fail;
1432
1433		start = e.pos;
1434		profile = unpack_profile(&e, &ns_name);
1435		if (IS_ERR(profile)) {
1436			error = PTR_ERR(profile);
1437			goto fail;
1438		}
1439
1440		error = verify_profile(profile);
1441		if (error)
1442			goto fail_profile;
1443
1444		if (aa_g_hash_policy)
1445			error = aa_calc_profile_hash(profile, e.version, start,
1446						     e.pos - start);
1447		if (error)
1448			goto fail_profile;
1449
1450		ent = aa_load_ent_alloc();
1451		if (!ent) {
1452			error = -ENOMEM;
1453			goto fail_profile;
1454		}
1455
1456		ent->new = profile;
1457		ent->ns_name = ns_name;
1458		ns_name = NULL;
1459		list_add_tail(&ent->list, lh);
1460	}
1461	udata->abi = e.version & K_ABI_MASK;
1462	if (aa_g_hash_policy) {
1463		udata->hash = aa_calc_hash(udata->data, udata->size);
1464		if (IS_ERR(udata->hash)) {
1465			error = PTR_ERR(udata->hash);
1466			udata->hash = NULL;
1467			goto fail;
1468		}
1469	}
1470
1471	if (aa_g_export_binary) {
1472		error = compress_loaddata(udata);
1473		if (error)
1474			goto fail;
1475	}
1476	return 0;
1477
1478fail_profile:
1479	kfree(ns_name);
1480	aa_put_profile(profile);
1481
1482fail:
1483	list_for_each_entry_safe(ent, tmp, lh, list) {
1484		list_del_init(&ent->list);
1485		aa_load_ent_free(ent);
1486	}
1487
1488	return error;
1489}