Loading...
1/*
2 * GPIO interface for Intel Poulsbo SCH
3 *
4 * Copyright (c) 2010 CompuLab Ltd
5 * Author: Denis Turischev <denis@compulab.co.il>
6 *
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License 2 as published
9 * by the Free Software Foundation.
10 *
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
15 *
16 * You should have received a copy of the GNU General Public License
17 * along with this program; see the file COPYING. If not, write to
18 * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
19 */
20
21#include <linux/init.h>
22#include <linux/kernel.h>
23#include <linux/module.h>
24#include <linux/io.h>
25#include <linux/errno.h>
26#include <linux/acpi.h>
27#include <linux/platform_device.h>
28#include <linux/pci_ids.h>
29
30#include <linux/gpio.h>
31
32static DEFINE_SPINLOCK(gpio_lock);
33
34#define CGEN (0x00)
35#define CGIO (0x04)
36#define CGLV (0x08)
37
38#define RGEN (0x20)
39#define RGIO (0x24)
40#define RGLV (0x28)
41
42static unsigned short gpio_ba;
43
44static int sch_gpio_core_direction_in(struct gpio_chip *gc, unsigned gpio_num)
45{
46 u8 curr_dirs;
47 unsigned short offset, bit;
48
49 spin_lock(&gpio_lock);
50
51 offset = CGIO + gpio_num / 8;
52 bit = gpio_num % 8;
53
54 curr_dirs = inb(gpio_ba + offset);
55
56 if (!(curr_dirs & (1 << bit)))
57 outb(curr_dirs | (1 << bit), gpio_ba + offset);
58
59 spin_unlock(&gpio_lock);
60 return 0;
61}
62
63static int sch_gpio_core_get(struct gpio_chip *gc, unsigned gpio_num)
64{
65 int res;
66 unsigned short offset, bit;
67
68 offset = CGLV + gpio_num / 8;
69 bit = gpio_num % 8;
70
71 res = !!(inb(gpio_ba + offset) & (1 << bit));
72 return res;
73}
74
75static void sch_gpio_core_set(struct gpio_chip *gc, unsigned gpio_num, int val)
76{
77 u8 curr_vals;
78 unsigned short offset, bit;
79
80 spin_lock(&gpio_lock);
81
82 offset = CGLV + gpio_num / 8;
83 bit = gpio_num % 8;
84
85 curr_vals = inb(gpio_ba + offset);
86
87 if (val)
88 outb(curr_vals | (1 << bit), gpio_ba + offset);
89 else
90 outb((curr_vals & ~(1 << bit)), gpio_ba + offset);
91 spin_unlock(&gpio_lock);
92}
93
94static int sch_gpio_core_direction_out(struct gpio_chip *gc,
95 unsigned gpio_num, int val)
96{
97 u8 curr_dirs;
98 unsigned short offset, bit;
99
100 sch_gpio_core_set(gc, gpio_num, val);
101
102 spin_lock(&gpio_lock);
103
104 offset = CGIO + gpio_num / 8;
105 bit = gpio_num % 8;
106
107 curr_dirs = inb(gpio_ba + offset);
108 if (curr_dirs & (1 << bit))
109 outb(curr_dirs & ~(1 << bit), gpio_ba + offset);
110
111 spin_unlock(&gpio_lock);
112 return 0;
113}
114
115static struct gpio_chip sch_gpio_core = {
116 .label = "sch_gpio_core",
117 .owner = THIS_MODULE,
118 .direction_input = sch_gpio_core_direction_in,
119 .get = sch_gpio_core_get,
120 .direction_output = sch_gpio_core_direction_out,
121 .set = sch_gpio_core_set,
122};
123
124static int sch_gpio_resume_direction_in(struct gpio_chip *gc,
125 unsigned gpio_num)
126{
127 u8 curr_dirs;
128 unsigned short offset, bit;
129
130 spin_lock(&gpio_lock);
131
132 offset = RGIO + gpio_num / 8;
133 bit = gpio_num % 8;
134
135 curr_dirs = inb(gpio_ba + offset);
136
137 if (!(curr_dirs & (1 << bit)))
138 outb(curr_dirs | (1 << bit), gpio_ba + offset);
139
140 spin_unlock(&gpio_lock);
141 return 0;
142}
143
144static int sch_gpio_resume_get(struct gpio_chip *gc, unsigned gpio_num)
145{
146 unsigned short offset, bit;
147
148 offset = RGLV + gpio_num / 8;
149 bit = gpio_num % 8;
150
151 return !!(inb(gpio_ba + offset) & (1 << bit));
152}
153
154static void sch_gpio_resume_set(struct gpio_chip *gc,
155 unsigned gpio_num, int val)
156{
157 u8 curr_vals;
158 unsigned short offset, bit;
159
160 spin_lock(&gpio_lock);
161
162 offset = RGLV + gpio_num / 8;
163 bit = gpio_num % 8;
164
165 curr_vals = inb(gpio_ba + offset);
166
167 if (val)
168 outb(curr_vals | (1 << bit), gpio_ba + offset);
169 else
170 outb((curr_vals & ~(1 << bit)), gpio_ba + offset);
171
172 spin_unlock(&gpio_lock);
173}
174
175static int sch_gpio_resume_direction_out(struct gpio_chip *gc,
176 unsigned gpio_num, int val)
177{
178 u8 curr_dirs;
179 unsigned short offset, bit;
180
181 sch_gpio_resume_set(gc, gpio_num, val);
182
183 offset = RGIO + gpio_num / 8;
184 bit = gpio_num % 8;
185
186 spin_lock(&gpio_lock);
187
188 curr_dirs = inb(gpio_ba + offset);
189 if (curr_dirs & (1 << bit))
190 outb(curr_dirs & ~(1 << bit), gpio_ba + offset);
191
192 spin_unlock(&gpio_lock);
193 return 0;
194}
195
196static struct gpio_chip sch_gpio_resume = {
197 .label = "sch_gpio_resume",
198 .owner = THIS_MODULE,
199 .direction_input = sch_gpio_resume_direction_in,
200 .get = sch_gpio_resume_get,
201 .direction_output = sch_gpio_resume_direction_out,
202 .set = sch_gpio_resume_set,
203};
204
205static int sch_gpio_probe(struct platform_device *pdev)
206{
207 struct resource *res;
208 int err, id;
209
210 id = pdev->id;
211 if (!id)
212 return -ENODEV;
213
214 res = platform_get_resource(pdev, IORESOURCE_IO, 0);
215 if (!res)
216 return -EBUSY;
217
218 if (!request_region(res->start, resource_size(res), pdev->name))
219 return -EBUSY;
220
221 gpio_ba = res->start;
222
223 switch (id) {
224 case PCI_DEVICE_ID_INTEL_SCH_LPC:
225 sch_gpio_core.base = 0;
226 sch_gpio_core.ngpio = 10;
227 sch_gpio_resume.base = 10;
228 sch_gpio_resume.ngpio = 4;
229 /*
230 * GPIO[6:0] enabled by default
231 * GPIO7 is configured by the CMC as SLPIOVR
232 * Enable GPIO[9:8] core powered gpios explicitly
233 */
234 outb(0x3, gpio_ba + CGEN + 1);
235 /*
236 * SUS_GPIO[2:0] enabled by default
237 * Enable SUS_GPIO3 resume powered gpio explicitly
238 */
239 outb(0x8, gpio_ba + RGEN);
240 break;
241
242 case PCI_DEVICE_ID_INTEL_ITC_LPC:
243 sch_gpio_core.base = 0;
244 sch_gpio_core.ngpio = 5;
245 sch_gpio_resume.base = 5;
246 sch_gpio_resume.ngpio = 9;
247 break;
248
249 case PCI_DEVICE_ID_INTEL_CENTERTON_ILB:
250 sch_gpio_core.base = 0;
251 sch_gpio_core.ngpio = 21;
252 sch_gpio_resume.base = 21;
253 sch_gpio_resume.ngpio = 9;
254 break;
255
256 default:
257 err = -ENODEV;
258 goto err_sch_gpio_core;
259 }
260
261 sch_gpio_core.dev = &pdev->dev;
262 sch_gpio_resume.dev = &pdev->dev;
263
264 err = gpiochip_add(&sch_gpio_core);
265 if (err < 0)
266 goto err_sch_gpio_core;
267
268 err = gpiochip_add(&sch_gpio_resume);
269 if (err < 0)
270 goto err_sch_gpio_resume;
271
272 return 0;
273
274err_sch_gpio_resume:
275 if (gpiochip_remove(&sch_gpio_core))
276 dev_err(&pdev->dev, "%s gpiochip_remove failed\n", __func__);
277
278err_sch_gpio_core:
279 release_region(res->start, resource_size(res));
280 gpio_ba = 0;
281
282 return err;
283}
284
285static int sch_gpio_remove(struct platform_device *pdev)
286{
287 struct resource *res;
288 if (gpio_ba) {
289 int err;
290
291 err = gpiochip_remove(&sch_gpio_core);
292 if (err)
293 dev_err(&pdev->dev, "%s failed, %d\n",
294 "gpiochip_remove()", err);
295 err = gpiochip_remove(&sch_gpio_resume);
296 if (err)
297 dev_err(&pdev->dev, "%s failed, %d\n",
298 "gpiochip_remove()", err);
299
300 res = platform_get_resource(pdev, IORESOURCE_IO, 0);
301
302 release_region(res->start, resource_size(res));
303 gpio_ba = 0;
304
305 return err;
306 }
307
308 return 0;
309}
310
311static struct platform_driver sch_gpio_driver = {
312 .driver = {
313 .name = "sch_gpio",
314 .owner = THIS_MODULE,
315 },
316 .probe = sch_gpio_probe,
317 .remove = sch_gpio_remove,
318};
319
320module_platform_driver(sch_gpio_driver);
321
322MODULE_AUTHOR("Denis Turischev <denis@compulab.co.il>");
323MODULE_DESCRIPTION("GPIO interface for Intel Poulsbo SCH");
324MODULE_LICENSE("GPL");
325MODULE_ALIAS("platform:sch_gpio");
1// SPDX-License-Identifier: GPL-2.0
2/*
3 * GPIO interface for Intel Poulsbo SCH
4 *
5 * Copyright (c) 2010 CompuLab Ltd
6 * Author: Denis Turischev <denis@compulab.co.il>
7 */
8
9#include <linux/acpi.h>
10#include <linux/bitops.h>
11#include <linux/errno.h>
12#include <linux/gpio/driver.h>
13#include <linux/io.h>
14#include <linux/irq.h>
15#include <linux/kernel.h>
16#include <linux/module.h>
17#include <linux/pci_ids.h>
18#include <linux/platform_device.h>
19#include <linux/types.h>
20
21#define GEN 0x00
22#define GIO 0x04
23#define GLV 0x08
24#define GTPE 0x0c
25#define GTNE 0x10
26#define GGPE 0x14
27#define GSMI 0x18
28#define GTS 0x1c
29
30#define CORE_BANK_OFFSET 0x00
31#define RESUME_BANK_OFFSET 0x20
32
33/*
34 * iLB datasheet describes GPE0BLK registers, in particular GPE0E.GPIO bit.
35 * Document Number: 328195-001
36 */
37#define GPE0E_GPIO 14
38
39struct sch_gpio {
40 struct gpio_chip chip;
41 struct irq_chip irqchip;
42 spinlock_t lock;
43 unsigned short iobase;
44 unsigned short resume_base;
45
46 /* GPE handling */
47 u32 gpe;
48 acpi_gpe_handler gpe_handler;
49};
50
51static unsigned int sch_gpio_offset(struct sch_gpio *sch, unsigned int gpio,
52 unsigned int reg)
53{
54 unsigned int base = CORE_BANK_OFFSET;
55
56 if (gpio >= sch->resume_base) {
57 gpio -= sch->resume_base;
58 base = RESUME_BANK_OFFSET;
59 }
60
61 return base + reg + gpio / 8;
62}
63
64static unsigned int sch_gpio_bit(struct sch_gpio *sch, unsigned int gpio)
65{
66 if (gpio >= sch->resume_base)
67 gpio -= sch->resume_base;
68 return gpio % 8;
69}
70
71static int sch_gpio_reg_get(struct sch_gpio *sch, unsigned int gpio, unsigned int reg)
72{
73 unsigned short offset, bit;
74 u8 reg_val;
75
76 offset = sch_gpio_offset(sch, gpio, reg);
77 bit = sch_gpio_bit(sch, gpio);
78
79 reg_val = !!(inb(sch->iobase + offset) & BIT(bit));
80
81 return reg_val;
82}
83
84static void sch_gpio_reg_set(struct sch_gpio *sch, unsigned int gpio, unsigned int reg,
85 int val)
86{
87 unsigned short offset, bit;
88 u8 reg_val;
89
90 offset = sch_gpio_offset(sch, gpio, reg);
91 bit = sch_gpio_bit(sch, gpio);
92
93 reg_val = inb(sch->iobase + offset);
94
95 if (val)
96 outb(reg_val | BIT(bit), sch->iobase + offset);
97 else
98 outb((reg_val & ~BIT(bit)), sch->iobase + offset);
99}
100
101static int sch_gpio_direction_in(struct gpio_chip *gc, unsigned int gpio_num)
102{
103 struct sch_gpio *sch = gpiochip_get_data(gc);
104 unsigned long flags;
105
106 spin_lock_irqsave(&sch->lock, flags);
107 sch_gpio_reg_set(sch, gpio_num, GIO, 1);
108 spin_unlock_irqrestore(&sch->lock, flags);
109 return 0;
110}
111
112static int sch_gpio_get(struct gpio_chip *gc, unsigned int gpio_num)
113{
114 struct sch_gpio *sch = gpiochip_get_data(gc);
115
116 return sch_gpio_reg_get(sch, gpio_num, GLV);
117}
118
119static void sch_gpio_set(struct gpio_chip *gc, unsigned int gpio_num, int val)
120{
121 struct sch_gpio *sch = gpiochip_get_data(gc);
122 unsigned long flags;
123
124 spin_lock_irqsave(&sch->lock, flags);
125 sch_gpio_reg_set(sch, gpio_num, GLV, val);
126 spin_unlock_irqrestore(&sch->lock, flags);
127}
128
129static int sch_gpio_direction_out(struct gpio_chip *gc, unsigned int gpio_num,
130 int val)
131{
132 struct sch_gpio *sch = gpiochip_get_data(gc);
133 unsigned long flags;
134
135 spin_lock_irqsave(&sch->lock, flags);
136 sch_gpio_reg_set(sch, gpio_num, GIO, 0);
137 spin_unlock_irqrestore(&sch->lock, flags);
138
139 /*
140 * according to the datasheet, writing to the level register has no
141 * effect when GPIO is programmed as input.
142 * Actually the the level register is read-only when configured as input.
143 * Thus presetting the output level before switching to output is _NOT_ possible.
144 * Hence we set the level after configuring the GPIO as output.
145 * But we cannot prevent a short low pulse if direction is set to high
146 * and an external pull-up is connected.
147 */
148 sch_gpio_set(gc, gpio_num, val);
149 return 0;
150}
151
152static int sch_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio_num)
153{
154 struct sch_gpio *sch = gpiochip_get_data(gc);
155
156 if (sch_gpio_reg_get(sch, gpio_num, GIO))
157 return GPIO_LINE_DIRECTION_IN;
158
159 return GPIO_LINE_DIRECTION_OUT;
160}
161
162static const struct gpio_chip sch_gpio_chip = {
163 .label = "sch_gpio",
164 .owner = THIS_MODULE,
165 .direction_input = sch_gpio_direction_in,
166 .get = sch_gpio_get,
167 .direction_output = sch_gpio_direction_out,
168 .set = sch_gpio_set,
169 .get_direction = sch_gpio_get_direction,
170};
171
172static int sch_irq_type(struct irq_data *d, unsigned int type)
173{
174 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
175 struct sch_gpio *sch = gpiochip_get_data(gc);
176 irq_hw_number_t gpio_num = irqd_to_hwirq(d);
177 unsigned long flags;
178 int rising, falling;
179
180 switch (type & IRQ_TYPE_SENSE_MASK) {
181 case IRQ_TYPE_EDGE_RISING:
182 rising = 1;
183 falling = 0;
184 break;
185 case IRQ_TYPE_EDGE_FALLING:
186 rising = 0;
187 falling = 1;
188 break;
189 case IRQ_TYPE_EDGE_BOTH:
190 rising = 1;
191 falling = 1;
192 break;
193 default:
194 return -EINVAL;
195 }
196
197 spin_lock_irqsave(&sch->lock, flags);
198
199 sch_gpio_reg_set(sch, gpio_num, GTPE, rising);
200 sch_gpio_reg_set(sch, gpio_num, GTNE, falling);
201
202 irq_set_handler_locked(d, handle_edge_irq);
203
204 spin_unlock_irqrestore(&sch->lock, flags);
205
206 return 0;
207}
208
209static void sch_irq_ack(struct irq_data *d)
210{
211 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
212 struct sch_gpio *sch = gpiochip_get_data(gc);
213 irq_hw_number_t gpio_num = irqd_to_hwirq(d);
214 unsigned long flags;
215
216 spin_lock_irqsave(&sch->lock, flags);
217 sch_gpio_reg_set(sch, gpio_num, GTS, 1);
218 spin_unlock_irqrestore(&sch->lock, flags);
219}
220
221static void sch_irq_mask_unmask(struct irq_data *d, int val)
222{
223 struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
224 struct sch_gpio *sch = gpiochip_get_data(gc);
225 irq_hw_number_t gpio_num = irqd_to_hwirq(d);
226 unsigned long flags;
227
228 spin_lock_irqsave(&sch->lock, flags);
229 sch_gpio_reg_set(sch, gpio_num, GGPE, val);
230 spin_unlock_irqrestore(&sch->lock, flags);
231}
232
233static void sch_irq_mask(struct irq_data *d)
234{
235 sch_irq_mask_unmask(d, 0);
236}
237
238static void sch_irq_unmask(struct irq_data *d)
239{
240 sch_irq_mask_unmask(d, 1);
241}
242
243static u32 sch_gpio_gpe_handler(acpi_handle gpe_device, u32 gpe, void *context)
244{
245 struct sch_gpio *sch = context;
246 struct gpio_chip *gc = &sch->chip;
247 unsigned long core_status, resume_status;
248 unsigned long pending;
249 unsigned long flags;
250 int offset;
251 u32 ret;
252
253 spin_lock_irqsave(&sch->lock, flags);
254
255 core_status = inl(sch->iobase + CORE_BANK_OFFSET + GTS);
256 resume_status = inl(sch->iobase + RESUME_BANK_OFFSET + GTS);
257
258 spin_unlock_irqrestore(&sch->lock, flags);
259
260 pending = (resume_status << sch->resume_base) | core_status;
261 for_each_set_bit(offset, &pending, sch->chip.ngpio)
262 generic_handle_irq(irq_find_mapping(gc->irq.domain, offset));
263
264 /* Set returning value depending on whether we handled an interrupt */
265 ret = pending ? ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
266
267 /* Acknowledge GPE to ACPICA */
268 ret |= ACPI_REENABLE_GPE;
269
270 return ret;
271}
272
273static void sch_gpio_remove_gpe_handler(void *data)
274{
275 struct sch_gpio *sch = data;
276
277 acpi_disable_gpe(NULL, sch->gpe);
278 acpi_remove_gpe_handler(NULL, sch->gpe, sch->gpe_handler);
279}
280
281static int sch_gpio_install_gpe_handler(struct sch_gpio *sch)
282{
283 struct device *dev = sch->chip.parent;
284 acpi_status status;
285
286 status = acpi_install_gpe_handler(NULL, sch->gpe, ACPI_GPE_LEVEL_TRIGGERED,
287 sch->gpe_handler, sch);
288 if (ACPI_FAILURE(status)) {
289 dev_err(dev, "Failed to install GPE handler for %u: %s\n",
290 sch->gpe, acpi_format_exception(status));
291 return -ENODEV;
292 }
293
294 status = acpi_enable_gpe(NULL, sch->gpe);
295 if (ACPI_FAILURE(status)) {
296 dev_err(dev, "Failed to enable GPE handler for %u: %s\n",
297 sch->gpe, acpi_format_exception(status));
298 acpi_remove_gpe_handler(NULL, sch->gpe, sch->gpe_handler);
299 return -ENODEV;
300 }
301
302 return devm_add_action_or_reset(dev, sch_gpio_remove_gpe_handler, sch);
303}
304
305static int sch_gpio_probe(struct platform_device *pdev)
306{
307 struct gpio_irq_chip *girq;
308 struct sch_gpio *sch;
309 struct resource *res;
310 int ret;
311
312 sch = devm_kzalloc(&pdev->dev, sizeof(*sch), GFP_KERNEL);
313 if (!sch)
314 return -ENOMEM;
315
316 res = platform_get_resource(pdev, IORESOURCE_IO, 0);
317 if (!res)
318 return -EBUSY;
319
320 if (!devm_request_region(&pdev->dev, res->start, resource_size(res),
321 pdev->name))
322 return -EBUSY;
323
324 spin_lock_init(&sch->lock);
325 sch->iobase = res->start;
326 sch->chip = sch_gpio_chip;
327 sch->chip.label = dev_name(&pdev->dev);
328 sch->chip.parent = &pdev->dev;
329
330 switch (pdev->id) {
331 case PCI_DEVICE_ID_INTEL_SCH_LPC:
332 sch->resume_base = 10;
333 sch->chip.ngpio = 14;
334
335 /*
336 * GPIO[6:0] enabled by default
337 * GPIO7 is configured by the CMC as SLPIOVR
338 * Enable GPIO[9:8] core powered gpios explicitly
339 */
340 sch_gpio_reg_set(sch, 8, GEN, 1);
341 sch_gpio_reg_set(sch, 9, GEN, 1);
342 /*
343 * SUS_GPIO[2:0] enabled by default
344 * Enable SUS_GPIO3 resume powered gpio explicitly
345 */
346 sch_gpio_reg_set(sch, 13, GEN, 1);
347 break;
348
349 case PCI_DEVICE_ID_INTEL_ITC_LPC:
350 sch->resume_base = 5;
351 sch->chip.ngpio = 14;
352 break;
353
354 case PCI_DEVICE_ID_INTEL_CENTERTON_ILB:
355 sch->resume_base = 21;
356 sch->chip.ngpio = 30;
357 break;
358
359 case PCI_DEVICE_ID_INTEL_QUARK_X1000_ILB:
360 sch->resume_base = 2;
361 sch->chip.ngpio = 8;
362 break;
363
364 default:
365 return -ENODEV;
366 }
367
368 platform_set_drvdata(pdev, sch);
369
370 sch->irqchip.name = "sch_gpio";
371 sch->irqchip.irq_ack = sch_irq_ack;
372 sch->irqchip.irq_mask = sch_irq_mask;
373 sch->irqchip.irq_unmask = sch_irq_unmask;
374 sch->irqchip.irq_set_type = sch_irq_type;
375
376 girq = &sch->chip.irq;
377 girq->chip = &sch->irqchip;
378 girq->num_parents = 0;
379 girq->parents = NULL;
380 girq->parent_handler = NULL;
381 girq->default_type = IRQ_TYPE_NONE;
382 girq->handler = handle_bad_irq;
383
384 /* GPE setup is optional */
385 sch->gpe = GPE0E_GPIO;
386 sch->gpe_handler = sch_gpio_gpe_handler;
387
388 ret = sch_gpio_install_gpe_handler(sch);
389 if (ret)
390 dev_warn(&pdev->dev, "Can't setup GPE, no IRQ support\n");
391
392 return devm_gpiochip_add_data(&pdev->dev, &sch->chip, sch);
393}
394
395static struct platform_driver sch_gpio_driver = {
396 .driver = {
397 .name = "sch_gpio",
398 },
399 .probe = sch_gpio_probe,
400};
401
402module_platform_driver(sch_gpio_driver);
403
404MODULE_AUTHOR("Denis Turischev <denis@compulab.co.il>");
405MODULE_DESCRIPTION("GPIO interface for Intel Poulsbo SCH");
406MODULE_LICENSE("GPL v2");
407MODULE_ALIAS("platform:sch_gpio");